[PATCH] staging:vt6655 Add extern variable in head file

2015-01-13 Thread sun wang
Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes. Signed-off-by: Sun Wang --- drivers/staging/vt6655/ioctl.c | 1 - drivers/staging/vt6655/ioctl.h | 5 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/v

[PATCH] Staging: dgnc: fixed depreciated EXTRA_CFLAGS in MakeFile

2015-01-13 Thread Joshua James
Replaced depreciated EXTRA_CFLAGS with ccflags-y as identified by checkpatch: WARNING: Use of EXTRA_CFLAGS is deprecated, please use `ccflags-y instead. +EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" Signed-off-by: Joshua James --- drivers/staging/dgnc/Makefile | 2 +- 1 fil

Re: [PATCH v4 0/2] lprocfs_write_frac_u64_helper cleanup

2015-01-13 Thread Dan Carpenter
Since no one had any responses to the original thread, Greg is going to see that first and apply it and this one will not apply. It's not worth resending patches for trivial stuff like this anyway... regards, dan carpenter ___ devel mailing list de...@

Re: [PATCH] Staging: dgnc: fixed depreciated EXTRA_CFLAGS in MakeFile

2015-01-13 Thread Dan Carpenter
Can't you just get rid of this stuff entirely? (Hint, yes, but compile test it. The define in dgap.h should be sufficient for DG_NAME and DG_PART isn't used). regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.

Re: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Dan Carpenter
On Tue, Jan 13, 2015 at 12:18:40PM +0530, Sudip Mukherjee wrote: > On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote: > > On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote: > > > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote: > > > > > > > > any reason why thi

[PATCH] staging: ft1000: fix else style error

2015-01-13 Thread Bilel DRIRA
This patch fix the checkpatch.pl error: ERROR: else should follow close brace '}' Signed-off-by: Bilel DRIRA --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/f

Re: [PATCH 00/37] staging: comedi: tidy up legacy DMA drivers

2015-01-13 Thread Ian Abbott
On 12/01/15 17:55, H Hartley Sweeten wrote: This series removes all the VIRT_TO_BUS dependancies from the legacy comedi drivers. It also tidies up the allocation and freeing of the DMA and the buffers used for DMA. H Hartley Sweeten (37): staging: comedi: adl_pci9118: remove VIRT_TO_BUS depen

Re: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure

2015-01-13 Thread Vitaly Kuznetsov
Dexuan Cui writes: > In the case the user-space daemon crashes, hangs or is killed, we > need to down the semaphore, otherwise, after the daemon starts next > time, the obsolete data in fcopy_transaction.message or > fcopy_transaction.fcopy_msg will be used immediately. It seems this patch got l

RE: [PATCH 00/37] staging: comedi: tidy up legacy DMA drivers

2015-01-13 Thread Hartley Sweeten
On Tuesday, January 13, 2015 5:54 AM, Ian Abbott wrote: > On 12/01/15 17:55, H Hartley Sweeten wrote: >> This series removes all the VIRT_TO_BUS dependancies from the legacy comedi >> drivers. It also tidies up the allocation and freeing of the DMA and the >> buffers used for DMA. > > Reviewed-by:

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread One Thousand Gnomes
On Mon, 12 Jan 2015 11:06:08 -0700 Jason Gunthorpe wrote: > On Sun, Jan 11, 2015 at 10:29:00AM -0600, atull wrote: > > the FPGA image. If someone wants there to be only one FPGA image on > > the FGPA forever, they will probably not be using this framework; their > > FPGA will probably be loaded

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread One Thousand Gnomes
On Mon, 12 Jan 2015 14:43:14 -0700 Jason Gunthorpe wrote: > On Mon, Jan 12, 2015 at 09:01:34PM +, One Thousand Gnomes wrote: > > There are plenty of people today who treat the FPGA as an entirely > > dynamic resource. It's not like flashing a controller, its near > > immediate. > > But this

Re: [PATCH] staging: ft1000: fix else style error

2015-01-13 Thread Joe Perches
On Tue, 2015-01-13 at 12:57 +0100, Bilel DRIRA wrote: > ERROR: else should follow close brace '}' [] > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c > b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c [] > @@ -572,8 +572,7 @@ static void ft1000_hbchk(u_long data) >

[PATCH] Staging: vt6656: Code cleanup: remove unreachable return

2015-01-13 Thread Emrys Bayliss
This patch removes an unnecessary return statement that cannot be reached. Signed-off-by: Emrys Bayliss --- drivers/staging/vt6656/rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index ea5140a..0cce140 100644 --- a/drivers

[PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:558: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss --- The else statement was replaced with a block to avoid the following compiler error: "warning: ISO C90 forbids mixed declarations and code"

Re: [PATCH] staging:vt6655 Add extern variable in head file

2015-01-13 Thread Greg KH
On Tue, Jan 13, 2015 at 04:31:14PM +0800, sun wang wrote: > Extern variable must be declared in head file. Compiler can catch the > inconsistency when variable changes. > > Signed-off-by: Sun Wang > --- > drivers/staging/vt6655/ioctl.c | 1 - > drivers/staging/vt6655/ioctl.h | 5 + > 2 fil

Re: [PATCH] Staging: vt6656: Code cleanup: remove unreachable return

2015-01-13 Thread Greg KH
On Wed, Jan 14, 2015 at 04:07:40AM +1100, Emrys Bayliss wrote: > This patch removes an unnecessary return statement that cannot be reached. > > Signed-off-by: Emrys Bayliss > --- > drivers/staging/vt6656/rxtx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vt6656/rxt

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Greg KH
On Wed, Jan 14, 2015 at 04:03:24AM +1100, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement was replaced with a block to avoid the follo

[PATCH v3] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Emrys Bayliss
This patch fixes the following checkpatch.pl error: rxtx.c:558: WARNING: else is not generally useful after a break or return Signed-off-by: Emrys Bayliss --- The else statement was replaced with a block to avoid the following compiler error: "warning: ISO C90 forbids mixed declarations and code"

Re: [PATCH 00/37] staging: comedi: tidy up legacy DMA drivers

2015-01-13 Thread gre...@linuxfoundation.org
On Tue, Jan 13, 2015 at 04:08:29PM +, Hartley Sweeten wrote: > On Tuesday, January 13, 2015 5:54 AM, Ian Abbott wrote: > > On 12/01/15 17:55, H Hartley Sweeten wrote: > >> This series removes all the VIRT_TO_BUS dependancies from the legacy comedi > >> drivers. It also tidies up the allocation

Re: [PATCH] Staging: dgnc: fixed depreciated EXTRA_CFLAGS in MakeFile

2015-01-13 Thread Greg KH
On Tue, Jan 13, 2015 at 06:54:38PM +0900, Joshua James wrote: > Replaced depreciated EXTRA_CFLAGS with ccflags-y as identified by checkpatch: > WARNING: Use of EXTRA_CFLAGS is deprecated, please use `ccflags-y instead. > +EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" > > Signe

[PATCH 07/25] staging: comedi: das1800: pass dma descriptor to das1800_flush_dma_channel()

2015-01-13 Thread H Hartley Sweeten
Instead of passing the dma descriptor 'chan' and 'virt_addr' just pass the dma descriptor. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/

[PATCH 11/25] staging: comedi: das16: move dma transfer 'size' to dma descriptor

2015-01-13 Thread H Hartley Sweeten
For asethetics, move the variable that holds the dma transfer 'size' into the dma descriptor. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/driv

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Emrys Bayliss
This was supposed to be a v3 patch. Resent. On 01/14/2015 04:03 AM, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement was replaced with

[PATCH 10/25] staging: comedi: das1800: introduce das1800_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to disable and the ISA DMA controller and return the residue as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 40 ++-- 1 f

[PATCH 13/25] staging: comedi: das16: introduce das16_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to disable and the ISA DMA controller and return the residue as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 33 - 1 fi

[PATCH 21/25] staging: comedi: ni_labpc_isadma: tidy up labpc_drain_dma()

2015-01-13 Thread H Hartley Sweeten
Tidy up the code that determines the number of samples to read for the current DMA transfer and how many samples are needed for the next DMA, Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_isadma.c | 48 ---

[PATCH 00/25] staging: comedi: tidy up ISA DMA programming

2015-01-13 Thread H Hartley Sweeten
Tidy up the ISA DMA programming in all the comedi legacy drivers to follow the programming sequence described in Documentation/DMA-ISA-LPC.txt. This series applies after: "[PATCH 00/37] staging: comedi: tidy up legacy DMA drivers" H Hartley Sweeten (25): staging: comedi: pcl818: introduce pcl81

[PATCH 18/25] staging: comedi: ni_labpc_isadma: remove hard coded samples size

2015-01-13 Thread H Hartley Sweeten
Use the comedi_bytes_per_sample() helper and remove the hard coded sample size. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_isadma.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/st

[PATCH 17/25] staging: comedi: ni_at_a2150: introduce a2150_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to disable and the ISA DMA controller and return the residue as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 42 +++- 1 f

[PATCH 22/25] staging: comedi: ni_labpc_isadma: move dma programming out of labpc_drain_dma()

2015-01-13 Thread H Hartley Sweeten
The external caller of labpc_drain_dma() does not enable the DMA transfer. Only the call from handle_isa_dma() results in the programmed DMA operation getting enabled. For aesthetics, move the dma programming to handle_isa_dma(). Make sure the DMA operation would actually do something (dma->size !

[PATCH 24/25] staging: comedi: das1800: remove hard coded 'sample_size'

2015-01-13 Thread H Hartley Sweeten
Use the comedi_bytes_per_sample() helper to remove the hard coded sample_size in suggest_transfer_size(). The helper function needs to comedi_subdevice pointer. Change the parameters passed to suggest_transfer_size() and setup_dma() so that this pointer is available. Rename these functions so they

[PATCH 05/25] staging: comedi: dt282x: introduce dt282x_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 36 - 1 file ch

[PATCH 04/25] staging: comedi: pcl816: introduce pcl816_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
According to Documentation/DMA-ISA-LPC.txt, the DMA lock needs to be claimed before using any of the ISA DMA routines. Introduce a helper function to disable the ISA DMA controller and add the necessary locking calls. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 25/25] staging: comedi: das1800: tidy up das1800_ai_transfer_size()

2015-01-13 Thread H Hartley Sweeten
For aesthetics, pass the fill time 'ns' as a parameter to this function. Refactor this function to calculate the transfer size in 'samples' instead of 'bytes'. This removes the need to constantly multiply the values by the 'sample_size'. It also helps avoid any possible integer overflow issues. U

[PATCH 03/25] staging: comedi: pcl816: introduce pcl816_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 33 ++--- 1 file ch

[PATCH 23/25] staging: comedi: ni_labpc_isadma: introduce labpc_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_isadma.c | 37 1 file ch

[PATCH 14/25] staging: comedi: pcl812: introduce pcl812_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 49 + 1 file ch

[PATCH 16/25] staging: comedi: ni_at_a2150: introduce a2150_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 36 1 file ch

[PATCH 01/25] staging: comedi: pcl818: introduce pcl818_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 33 ++--- 1 file ch

[PATCH 15/25] staging: comedi: pcl812: introduce pcl812_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
According to Documentation/DMA-ISA-LPC.txt, the DMA lock needs to be claimed before using any of the ISA DMA routines. Introduce a helper function to disable the ISA DMA controller and add the necessary locking calls. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 12/25] staging: comedi: das16: introduce das16_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 35 ++ 1 file ch

[PATCH 19/25] staging: comedi: ni_labpc_isadma: convert 'dma_buffer_size' to a define

2015-01-13 Thread H Hartley Sweeten
For aesthetics, convert this statis const global variable to a define. Cleanup the maximum 'size' calc in labpc_suggest_transfer_size(). The modulo operation will always result in '0'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni

[PATCH 02/25] staging: comedi: pcl818: introduce pcl818_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
According to Documentation/DMA-ISA-LPC.txt, the DMA lock needs to be claimed before using any of the ISA DMA routines. Introduce a helper function to disable the ISA DMA controller and add the necessary locking calls. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

[PATCH 09/25] staging: comedi: das1800: introduce das1800_isadma_program()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to program the ISA DMA controller. Program the ISA DMA as described in Documentation/DMA-ISA-LPC.txt. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 48 ++-- 1 file ch

[PATCH 20/25] staging: comedi: ni_labpc_isadma: introduce labpc_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
Introduce a helper function to disable and the ISA DMA controller and return the residue as described in Documentation/DMA-ISA-LPC.txt. The DMA will always be disabled when labpc_setup_dma() is called. Remove the unnecessary disable in that function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbo

[PATCH 08/25] staging: comedi: das1800: move dma transfer 'size' to dma descriptor

2015-01-13 Thread H Hartley Sweeten
For asethetics, move the variable that holds the dma transfer 'size' into the dma descriptor. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[PATCH 06/25] staging: comedi: dt282x: introduce dt282x_isadma_disable()

2015-01-13 Thread H Hartley Sweeten
According to Documentation/DMA-ISA-LPC.txt, the DMA lock needs to be claimed before using any of the ISA DMA routines. Introduce a helper function to disable the ISA DMA controller and add the necessary locking calls. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- d

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread Pantelis Antoniou
Hi Alan, > On Jan 13, 2015, at 18:28 , One Thousand Gnomes > wrote: > > On Mon, 12 Jan 2015 14:43:14 -0700 > Jason Gunthorpe wrote: > >> On Mon, Jan 12, 2015 at 09:01:34PM +, One Thousand Gnomes wrote: >>> There are plenty of people today who treat the FPGA as an entirely >>> dynamic reso

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread atull
On Tue, 13 Jan 2015, Pavel Machek wrote: > On Tue 2015-01-13 09:40:18, Pantelis Antoniou wrote: > > Hi Pavel, > > > > > On Jan 13, 2015, at 09:28 , Pavel Machek wrote: > > > > > > Hi! > > > > > >> +What: /sys/class/fpga_manager//firmware > > >> +Date: Octobe

Re: [PATCH] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-13 Thread Joe Perches
On Wed, 2015-01-14 at 04:03 +1100, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return "not generally" does not mean always. It's OK to ignore these messages too. _

Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members.

2015-01-13 Thread Krzysztof Adamski
On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote: On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote: This patch fixes checkpatch.pl warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) current_net_addr and permanen

Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members.

2015-01-13 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 07:42:28PM +0100, Krzysztof Adamski wrote: > On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote: > >On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote: > >>This patch fixes checkpatch.pl warning: > >>WARNING: Prefer ether_addr_copy() over memcp

Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members.

2015-01-13 Thread Krzysztof Adamski
On Tue, Jan 13, 2015 at 10:52:00AM -0800, Greg Kroah-Hartman wrote: On Tue, Jan 13, 2015 at 07:42:28PM +0100, Krzysztof Adamski wrote: On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote: >On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote: >>This patch fixes checkp

Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members.

2015-01-13 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 07:59:18PM +0100, Krzysztof Adamski wrote: > On Tue, Jan 13, 2015 at 10:52:00AM -0800, Greg Kroah-Hartman wrote: > >On Tue, Jan 13, 2015 at 07:42:28PM +0100, Krzysztof Adamski wrote: > >>On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote: > >>>On Mon, Dec 22,

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread atull
On Tue, 13 Jan 2015, Pantelis Antoniou wrote: > Hi Alan, > > > On Jan 13, 2015, at 18:28 , One Thousand Gnomes > > wrote: > > > > On Mon, 12 Jan 2015 14:43:14 -0700 > > Jason Gunthorpe wrote: > > > >> On Mon, Jan 12, 2015 at 09:01:34PM +, One Thousand Gnomes wrote: > >>> There are plenty

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread Jason Gunthorpe
On Tue, Jan 13, 2015 at 04:28:47PM +, One Thousand Gnomes wrote: > There is a lot of code overlap in things like loading the bitstreams, > there is also some overlap because you want to be able to assign FPGA > resources. For example if you have four FPGAs and you want to use one for > OS stuf

Re: [PATCH] staging: ft1000: fix else style error

2015-01-13 Thread bill
On Tue, Jan 13, 2015 at 08:01:39AM -0800, Joe Perches wrote: > On Tue, 2015-01-13 at 12:57 +0100, Bilel DRIRA wrote: > > ERROR: else should follow close brace '}' > [] > > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c > > b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c > []

[PATCH v2 ] staging: ft1000: fix else style error

2015-01-13 Thread Bilel DRIRA
This patch fix the checkpatch.pl error: ERROR: else should follow close brace '}' Signed-off-by: Bilel DRIRA --- v2: remove braces instead of just putting else after close brace. (suggested by Joe Perches). drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 29 --

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread atull
On Tue, 13 Jan 2015, Jason Gunthorpe wrote: > On Tue, Jan 13, 2015 at 04:28:47PM +, One Thousand Gnomes wrote: > > > There is a lot of code overlap in things like loading the bitstreams, > > there is also some overlap because you want to be able to assign FPGA > > resources. For example if yo

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-13 Thread Jason Gunthorpe
On Tue, Jan 13, 2015 at 03:37:14PM -0600, atull wrote: > > I do agree with this, and I think this is where this patch set goes so > > wrong. > > > > Just exposing all sorts of controls to userspace and having a way for > > the kernel to load/unload a bitstream compleletely misses the point that >

[PATCH 1/2] staging/lustre: remove unused function

2015-01-13 Thread Luca Ceresoli
Signed-off-by: Luca Ceresoli Cc: Peng Tao Cc: hpdd-disc...@lists.01.org Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org --- drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linu

[PATCH 2/2] staging: lustre: declare internal symbols as static

2015-01-13 Thread Luca Ceresoli
Fixes dozens of sparse warnings like: warning: symbol 'cfs_tracefile_sem' was not declared. Should it be static? Signed-off-by: Luca Ceresoli Cc: Peng Tao Cc: Jinshan Xiong Cc: Srikrishan Malik Cc: hpdd-disc...@lists.01.org Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org ---

RE: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure

2015-01-13 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, January 13, 2015 21:52 PM > To: Dexuan Cui; KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com

RE: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure

2015-01-13 Thread Jason Wang
On Wed, Jan 14, 2015 at 9:43 AM, Dexuan Cui wrote: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Tuesday, January 13, 2015 21:52 PM To: Dexuan Cui; KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- de...@linuxd

[PATCH 1/3] memstick: rtsx: dump register using compact format

2015-01-13 Thread micky_ching
From: Micky Ching Using more compact format for dump register when error occurs, this is useful to read debug log and reduce log length. Signed-off-by: Micky Ching --- drivers/memstick/host/rtsx_pci_ms.c | 37 - 1 file changed, 20 insertions(+), 17 deletions

[PATCH 3/3] memstick: rtsx: move suspend/resume to pm ops

2015-01-13 Thread micky_ching
From: Micky Ching Move suspend/resume function to pm ops, make it consistence with rtsx_usb_ms.c driver. Signed-off-by: Micky Ching --- drivers/memstick/host/rtsx_pci_ms.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/memstick/host/rtsx

[PATCH 2/3] memstick: rtsx: finish request if no card exist

2015-01-13 Thread micky_ching
From: Micky Ching Check card exist before start request, this method can make card remove faster. If we found the card is not exist, just return error-code, not sending request can save much time. Signed-off-by: Micky Ching --- drivers/memstick/host/rtsx_pci_ms.c | 27 ++---

[PATCH 0/3] memstick: rtsx: finish request faster if no card exist

2015-01-13 Thread micky_ching
From: Micky Ching This pathset include some misc coding update. - dump register using compact format. This prevent dump a lot of lines register dump when some error occurs. - finish request if no card exist check card exist before sending any request, When card removed, request can returne

[PATCH 0/2] mmc: rtsx: add check before sending request

2015-01-13 Thread micky_ching
From: Micky Ching Add check before sending request can make request return faster. - finish request if no card exist This can make request finish faster, especial for some sdio card, when card removed, there still a lot of command pending, if we check card exist and stop request, the card w

[PATCH 1/2] mmc: rtsx: finish request if no card exist

2015-01-13 Thread micky_ching
From: Micky Ching Return error-code directly if no card exist, this can make card remove faster. Signed-off-by: Micky Ching --- drivers/mmc/host/rtsx_pci_sdmmc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/r

[PATCH 2/2] mmc: rtsx: check sg_count before long data xfer

2015-01-13 Thread micky_ching
From: Micky Ching Check sg_count before sending long data xfer. Because dma_map_sg() return int, and sg_count may be negative, so using int instead of unsigned. Signed-off-by: Micky Ching --- drivers/mmc/host/rtsx_pci_sdmmc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) d

RE: [PATCH v3] hv: hv_fcopy: drop the obsolete message on transfer failure

2015-01-13 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Tuesday, January 13, 2015 5:44 PM > To: Vitaly Kuznetsov; KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; Hai

[PATCH] Fixed else statement following a return statement in if block in hfa384x_usb.c

2015-01-13 Thread Asheesh Ranjan
This fixes a else after if block containing return statement warning as found by checkpatch.pl Signed-off-by: Asheesh Ranjan --- drivers/staging/wlan-ng/hfa384x_usb.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers

[PATCH] Replacing simple_strtoul with kstrtoul

2015-01-13 Thread Asheesh Ranjan
Added code to move pointer till end of parsed string as being done by simple_strtoul. Not checking return value of kstrtoul Signed-off-by: Asheesh Ranjan --- drivers/staging/speakup/varhandlers.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/sta