RE: [PATCH net] hyperv: Fix the error processing in netvsc_send()

2015-02-01 Thread Jason Wang
On Fri, Jan 30, 2015 at 11:05 PM, Haiyang Zhang wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Friday, January 30, 2015 5:25 AM > + if (ret != 0) { > + if (section_index != NETVSC_INVALID_INDEX) > + netvsc_free_send_slot(

[PATCH v2 3/3] hv: vmbus_open(): reset the channel state on ENOMEM

2015-02-01 Thread Dexuan Cui
Without this patch, the state is put to CHANNEL_OPENING_STATE, and when the driver is loaded next time, vmbus_open() will fail immediately due to newchannel->state != CHANNEL_OPEN_STATE. CC: "K. Y. Srinivasan" Signed-off-by: Dexuan Cui --- v2: this is a RESEND. drivers/hv/channel.c | 8 +-

[PATCH v2 2/3] hv: vmbus_post_msg: retry the hypercall on some transient errors

2015-02-01 Thread Dexuan Cui
I got HV_STATUS_INVALID_CONNECTION_ID on Hyper-V 2008 R2 when keeping running "rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe hv_utils" in a Linux guest. Looks the host has some kind of throttling mechanism if some kinds of hypercalls are sent too frequently. Without the patch, the d

[PATCH v2 1/3] hv: hv_util: move vmbus_open() to a later place

2015-02-01 Thread Dexuan Cui
Before the line vmbus_open() returns, srv->util_cb can be already running and the variables, like util_fw_version, are needed by the srv->util_cb. So we have to make sure the variables are initialized before the vmbus_open(). CC: "K. Y. Srinivasan" Reviewed-by: Vitaly Kuznetsov Signed-off-by: D

[PATCH 10/20] staging/lustre/obdclass: Proper swabbing of llog_rec_tail.

2015-02-01 Thread green
From: Henri Doreau A variable-length structure preceeds llog_rec_tail within an llog block. Thus cr_tail shouldn't be accessed directly as a structure member but its actual location should be computed dynamically. Signed-off-by: Henri Doreau Reviewed-on: http://review.whamcloud.com/11937 Intel-

[PATCH 17/20] staging/lustre/llite: Add exception entry check after radix_tree

2015-02-01 Thread green
From: Yang Sheng We need to check for an exception entry after radix_tree lookup. Signed-off-by: Yang Sheng Signed-off-by: Oleg Drokin Reviewed-on: http://review.whamcloud.com/10709 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5162 Reviewed-by: Bob Glossman Reviewed-by: James Simmons

[PATCH 16/20] staging/lustre/libcfs: protect kkuc_groups from write access

2015-02-01 Thread green
From: Frank Zago Since reg->kr_fp can be changed inside the foreach loop, kkuc_groups must be write protected, and not just read protected. This should fix the following oops, which could happen if two different threads simultaneously execute the function, and EPIPE is returned. PID: 24385 TAS

[PATCH 15/20] staging/lustre/fld: refer to MDT0 for fld lookup in some cases

2015-02-01 Thread green
From: wang di It is possible that when fld client is trying to lookup seq on one of MDT, but the connection between the client and the MDT is not being initialized yet, especially during striped dir creation, because client will only send create req to the master MDT, then master MDT will distrib

[PATCH 09/20] staging/lustre/llite: remove llite proc root on init failure

2015-02-01 Thread green
From: "John L. Hammond" In init_lustre_lite() ensure that /proc/fs/lustre/llite is removed in case of failure. Generally rework the cleanup code in this function. Signed-off-by: John L. Hammond Reviewed-on: http://review.whamcloud.com/6420 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-333

[PATCH 18/20] staging/lustre/llite: don't add to page cache upon failure

2015-02-01 Thread green
From: Lai Siyao Reading directory pages may fail on MDS, in this case client should not cache a non-up-to-date directory page, because it will cause a later read on the same page fail. Signed-off-by: Lai Siyao Signed-off-by: Oleg Drokin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5461

[PATCH 13/20] staging/lustre/ptlrpc: hold rq_lock when modify rq_flags

2015-02-01 Thread green
From: Niu Yawei In after_reply(), take the rq_lock for changing the rq_resend. Signed-off-by: Niu Yawei Reviewed-on: http://review.whamcloud.com/11957 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5633 Reviewed-by: Fan Yong Reviewed-by: Johann Lombardi Signed-off-by: Oleg Drokin --- d

[PATCH 14/20] staging/lustre/llite: Solve a race to access lli_has_smd in read case

2015-02-01 Thread green
From: Jinshan Xiong In vvp_io_read_lock(), it used to decide if to add read lock by checking lli_has_smd. Accessing lli_has_smd is racy when an empty file is turned into raid0, therefore, it may result in read requests are issued without corresponding lock. Signed-off-by: Jinshan Xiong Reviewed

[PATCH 04/20] staging/lustre/libcfs: fix illegal page access of tracefiled()

2015-02-01 Thread green
From: Li Xi After failure happens and put_pages_back() returns the pages, tracefiled() should not go on itering on the page list. Otherwise, some pages might be accessed illegally. Signed-off-by: Li Xi Signed-off-by: Jian Yu Reviewed-on: http://review.whamcloud.com/11454 Intel-bug-id: https://

[PATCH 08/20] staging/lustre/llite: to configure max_cached_mb correctly

2015-02-01 Thread green
From: Jinshan Xiong If there exists MGS conf_param to reduce the memory cache max_cached_mb it will fail because dt_exp is not initialized yet. It should just go ahead and configure it because certainly it have enough free LRU slot to deduct ccc_lru_left. Signed-off-by: Jinshan Xiong Reviewed-

[PATCH 02/20] staging/lustre/osc: split different type of IO

2015-02-01 Thread green
From: Alexander Boyko Do not allow different type of pages at the same rpc. Signed-off-by: Alexander Boyko Signed-off-by: Vitaly Fertman Xyratex-bug-id: MRP-859 Reviewed-on: http://review.whamcloud.com/10930 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3192 Reviewed-by: Jinshan Xiong R

[PATCH 03/20] staging/lustre/ldlm: high load because of negative timeout

2015-02-01 Thread green
From: Li Xi When the time of LRU resizing exceeds waiting period of recalculation, the ldlm daemon will keep on resizing without any interval of rest. That will cause high CPU load. This patch fixes the problem by setting the recalculation timestamp after LRU resizing finishes rather than before

[PATCH 19/20] staging/lustre/clio: Do not allow group locks with gid 0

2015-02-01 Thread green
From: Patrick Farrell When a group lock with GID=0 is released (put_grouplock is called), an assertion in cl_put_grouplock is hit. We should not allow group lock requests with GID=0, instead we should return -EINVAL. Signed-off-by: Patrick Farrell Reviewed-on: http://review.whamcloud.com/12459

[PATCH 00/20] Lustre fixes

2015-02-01 Thread green
From: Oleg Drokin These 20 patches represent various lustre fixes mostly taken from development lustre tree. It also unbreaks lustre flock functionality accdentally broken in the staging tree by a cleanup. Please consider. Alexander Boyko (1): staging/lustre/osc: split different type of IO D

[PATCH 20/20] staging/lustre/mdc: Initialize req in mdc_enqueue for !it case

2015-02-01 Thread green
From: Oleg Drokin Commit ab909585b813 ("staging: lustre: Cleanup variable declarations in mdc_enqueue()") broke Lustre flock handling introducing access to uninitialized req variable, leading to bizzare crash in a later call to __req_capsule_offset with invalid pill value. Set req to NULL just f

[PATCH 01/20] staging/lustre/ptlrpc: avoid list scan in ptlrpcd_check

2015-02-01 Thread green
From: Liang Zhen ptlrpcd_check() always scan all requests on ptlrpc_request_set and try to finish completed requests, this is low efficiency. Even worse, l_wait_event() always checks condition for twice before sleeping and one more time after waking up, which means it will call ptlrpcd_check() fo

[PATCH 06/20] staging/lustre: fix comparison between signed and unsigned

2015-02-01 Thread green
From: Dmitry Eremin Expression if (size != (ssize_t)size) is always false. Therefore no bounds check errors detected. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/11376 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5417 Reviewed-by: John L. Hammond Reviewed-by: F

[PATCH 12/20] staging/lustre/obd: change type of cl_conn_count to size_t

2015-02-01 Thread green
From: Dmitry Eremin Change type of cl_conn_count to size_t. Signed-off-by: Dmitry Eremin Reviewed-on: http://review.whamcloud.com/13125 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5577 Reviewed-by: James Simmons Reviewed-by: John L. Hammond Signed-off-by: Oleg Drokin --- drivers/sta

[PATCH 05/20] staging/lustre/obdclass: fix a race in recovery

2015-02-01 Thread green
From: Hongchao Zhang in "class_export_recovery_cleanup", the check of the flag "exp->exp_req_replay_needed" should be protected by "exp_lock". Signed-off-by: Hongchao Zhang Reviewed-on: http://review.whamcloud.com/10849 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5128 Reviewed-by: Fan Y

[PATCH 07/20] staging/lustre/lnet: peer aliveness status and NI status

2015-02-01 Thread green
From: Liang Zhen A couple of changes to improve aliveness detection: - When LNet received a message, it can determine peer of this message is alive - When LNet received a message from remote network, it can determine router is alive and NI status on router is UP. Signed-off-by: Liang Zhen

[PATCH 11/20] staging/lustre/lnet: portal spreading rotor should be unsigned

2015-02-01 Thread green
From: Liang Zhen Portal spreading rotor should be unsigned, otherwise lnet may get negative CPT number and access invalid addresses. Signed-off-by: Liang Zhen Reviewed-on: http://review.whamcloud.com/11936 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5639 Reviewed-by: Amir Shehata Revie

[Patch v2 01/23] ACPICA: Resources: Provide common part for struct acpi_resource_address structures.

2015-02-01 Thread Jiang Liu
From: Lv Zheng struct acpi_resource_address and struct acpi_resource_extended_address64 share substracts just at different offsets. To unify the parsing functions, OSPMs like Linux need a new ACPI_ADDRESS64_ATTRIBUTE as their substructs, so they can extract the shared data. This patch also sync

RE: [PATCH 3/3] hv: vmbus_open(): reset the channel state on ENOMEM

2015-02-01 Thread Dexuan Cui
> -Original Message- > From: KY Srinivasan > Sent: Monday, February 2, 2015 3:42 AM > To: Dexuan Cui; Vitaly Kuznetsov > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; Haiyan

Re: [RESEND PATCH v2 7/9] mfd: rtsx: add support for rts524A

2015-02-01 Thread 敬锐
Hi Lee, do you have reviewed this patchset? regards. micky. On 01/22/2015 03:30 PM, micky_ch...@realsil.com.cn wrote: > From: Micky Ching > > add support for new chip rts524A. > > Signed-off-by: Micky Ching > --- > drivers/mfd/rts5249.c| 186 >

Re: [PATCH] staging: rtl8723au: hal: usb_ops_linux: Removed variables that is never used

2015-02-01 Thread Jes Sorensen
Julian Calaby writes: > Hi Rickard, > > On Mon, Feb 2, 2015 at 10:17 AM, Rickard Strandqvist > wrote: >> 2015-02-02 0:01 GMT+01:00 Jes Sorensen : >>> Rickard Strandqvist writes: Variable was assigned a value that was never used. I have also removed all the code that thereby serves no p

Re: [PATCH] staging: rtl8723au: hal: usb_ops_linux: Removed variables that is never used

2015-02-01 Thread Julian Calaby
Hi Rickard, On Mon, Feb 2, 2015 at 10:17 AM, Rickard Strandqvist wrote: > 2015-02-02 0:01 GMT+01:00 Jes Sorensen : >> Rickard Strandqvist writes: >>> Variable was assigned a value that was never used. >>> I have also removed all the code that thereby serves no purpose. >>> >>> This was found usi

Re: [PATCH] staging: rtl8723au: core: rtw_mlme: Removed variables that is never used

2015-02-01 Thread Rickard Strandqvist
2015-02-02 0:02 GMT+01:00 Jes Sorensen : > Rickard Strandqvist writes: >> Variable was assigned a value that was never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard St

Re: [PATCH] staging: rtl8723au: hal: HalDMOutSrc8723A_CE: Removed variables that is never used

2015-02-01 Thread Rickard Strandqvist
2015-02-02 0:00 GMT+01:00 Jes Sorensen : > Rickard Strandqvist writes: >> Variable was assigned a value that was never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard St

Re: [PATCH] staging: rtl8723au: hal: usb_ops_linux: Removed variables that is never used

2015-02-01 Thread Rickard Strandqvist
2015-02-02 0:01 GMT+01:00 Jes Sorensen : > Rickard Strandqvist writes: >> Variable was assigned a value that was never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard St

Re: [PATCH] staging: rtl8723au: core: rtw_mlme_ext: Removed variables that is never used

2015-02-01 Thread Rickard Strandqvist
2015-02-01 23:58 GMT+01:00 Jes Sorensen : > Rickard Strandqvist writes: >> Variable was assigned a value that was never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard S

Re: [PATCH] staging: rtl8723au: core: rtw_mlme: Removed variables that is never used

2015-02-01 Thread Jes Sorensen
Rickard Strandqvist writes: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8723au/cor

Re: [PATCH] staging: rtl8723au: hal: usb_ops_linux: Removed variables that is never used

2015-02-01 Thread Jes Sorensen
Rickard Strandqvist writes: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8723au/hal

Re: [PATCH] staging: rtl8723au: hal: HalDMOutSrc8723A_CE: Removed variables that is never used

2015-02-01 Thread Jes Sorensen
Rickard Strandqvist writes: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8723au/hal

Re: [PATCH] staging: rtl8723au: core: rtw_mlme_ext: Removed variables that is never used

2015-02-01 Thread Jes Sorensen
Rickard Strandqvist writes: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8723au/cor

RE: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-02-01 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Saturday, January 31, 2015 7:38 PM > To: Vitaly Kuznetsov > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; Ha

RE: [PATCH 3/3] hv: vmbus_open(): reset the channel state on ENOMEM

2015-02-01 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Thursday, January 29, 2015 9:03 PM > To: Vitaly Kuznetsov > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY Srinivasan; Ha

[PATCH 2/2] [media] mn88472: One function call less in mn88472_init() after error detection

2015-02-01 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 1 Feb 2015 19:34:37 +0100 The release_firmware() function was called in three cases by the mn88472_init() function during error handling even if the passed variable "fw" contained still a null pointer. This implementation detail could be improved by the introducti

[PATCH 1/2] [media] mn88472: Deletion of an unnecessary check before the function call "release_firmware"

2015-02-01 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 1 Feb 2015 19:12:56 +0100 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- d

[PATCH 0/2] [media] mn88472: Delete an unnecessary check

2015-02-01 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 1 Feb 2015 20:00:17 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Deletion of an unnecessary check before the function call "release_firmware" One function call less in mn

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-02-01 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Thursday, January 29, 2015 8:21 PM > To: Jason Wang > Cc: Vitaly Kuznetsov; KY Srinivasan; de...@linuxdriverproject.org; Haiyang > Zhang; linux-ker...@vger.kernel.org; Radim Krčmář; Dan Carpenter > Subject: RE: [PATCH v3 3/3] Drivers: hv: vm

RE: [PATCH v3 3/3] Drivers: hv: vmbus: serialize Offer and Rescind offer

2015-02-01 Thread KY Srinivasan
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, January 29, 2015 2:07 AM > To: Dexuan Cui > Cc: Vitaly Kuznetsov; KY Srinivasan; de...@linuxdriverproject.org; Haiyang > Zhang; linux-ker...@vger.kernel.org; Radim Krčmář; Dan Carpenter > Subject: RE: [

Re: [PATCH] staging: gdm72xx: Deletion of an unnecessary check before the function call "kfree"

2015-02-01 Thread Greg Kroah-Hartman
On Sun, Feb 01, 2015 at 06:42:53PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 1 Feb 2015 18:28:33 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by

[PATCH] staging: gdm72xx: Deletion of an unnecessary check before the function call "kfree"

2015-02-01 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 1 Feb 2015 18:28:33 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/stag

[PATCH] staging: xgifb: fix colours on big-endian machines other than powerpc

2015-02-01 Thread Aaro Koskinen
XGI framebuffer supports big-endian machines, but it's currently enabled based on __powerpc__ define (which is wrong, as powerpc can be also little-endian now). Use __BIG_ENDIAN instead. This will fix wrong colours on such machines. Tested on parisc with XGI Z7. Signed-off-by: Aaro Koskinen ---

[PATCH 5/6] staging: vt6656: vnt_fill_cts_head remove unneeded NULL check.

2015-02-01 Thread Malcolm Priestley
union vnt_tx_data_head is nolonger detached from main vnt_tx_buffer structure so this check is unnecessary. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/rxtx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index

[PATCH 4/6] staging: vt6655: vnt_rx_data add track rsr and new_rsr errors

2015-02-01 Thread Malcolm Priestley
If not rsr & RSR_CRCOK report RX_FLAG_FAILED_FCS_CRC If not rsr & (RSR_IVLDTYP | RSR_IVLDLEN) drop packet If not NEWRSR_DECRYPTOK on new_rsr drop packet. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6655/dpc.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --

[PATCH 2/6] staging: vt6655: parse bb vga code out of device_intr.

2015-02-01 Thread Malcolm Priestley
Reordering the code and reversing the priv->byBBVGANew verses priv->byBBVGACurrent check and using dev_dbg for pr_debug. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6655/device_main.c | 93 +--- 1 file changed, 54 insertions(+), 39 deletions(-) diff --

[PATCH 1/6] staging: vt6655: move setting of PSTxDesc->buff_addr to vnt_tx_packet

2015-02-01 Thread Malcolm Priestley
Keep setting of this part of the structure with the others. Only pTDInfo needs carried in the buffer structure. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6655/device_main.c | 2 ++ drivers/staging/vt6655/rxtx.c| 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH 3/6] staging: vt6655: Fix TD_FLAGS_NETIF_SKB only on TYPE_AC0DMA

2015-02-01 Thread Malcolm Priestley
Allow only TD_FLAGS_NETIF_SKB on ring buffer TYPE_AC0DMA for data only transfers for correct reporting of tx rates. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6655/device_main.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/device_m

[PATCH 6/6] staging: vt6656: parse cts fall back out of vnt_fill_cts_head

2015-02-01 Thread Malcolm Priestley
Creating new function vnt_fill_cts_fb_head for the fall back rates. The check for fb_option is now done in vnt_rxtx_cts. This fixes checkpatch warning WARNING: else is not generally useful after a break or return 559: FILE: drivers/staging/vt6656/rxtx.c:559: Signed-off-by: Malcolm Priest

[PATCH] staging: lustre: lnet: fix space prohibited before that '++'

2015-02-01 Thread Asaf Vertz
Fixed a coding style error, space prohibited before that '++' Signed-off-by: Asaf Vertz --- drivers/staging/lustre/lnet/selftest/console.c | 28 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/s

[PATCH] staging: lustre: osc: fix space prohibited after that '!'

2015-02-01 Thread Asaf Vertz
Fixed a coding style error, space prohibited after that '!' Signed-off-by: Asaf Vertz --- drivers/staging/lustre/lustre/osc/osc_lock.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c b/drivers/staging/lustre/lustre

Re: [PATCH V2 2/2] iio: meter: ade7759: add error handling in _reset and _stop_device

2015-02-01 Thread Jonathan Cameron
On 02/01/15 09:02, Devendra Naga wrote: > This patch adds the error handling for the value returned from > ade7759_spi_read_reg_16. With this patch, the following randconfig > warnings get fixed automatically. > > drivers/staging/iio/meter/ade7759.c:224:6: warning: ‘val’ may be > used uninitialize

Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-02-01 Thread Jonathan Cameron
On 05/01/15 05:57, sanjeev sharma wrote: > On Fri, Jan 2, 2015 at 2:32 PM, Devendra Naga wrote: >> This patch adds the error handling for the value returned from >> ade7754_spi_read_reg_8. With this patch, the following randconfig >> warnings get fixed automatically. >> >> drivers/staging/iio/mete

Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-02-01 Thread Jonathan Cameron
On 05/01/15 06:12, devendra.aaru wrote: > On Sun, Jan 4, 2015 at 6:06 AM, Jonathan Cameron wrote: >> On 02/01/15 09:02, Devendra Naga wrote: >>> This patch adds the error handling for the value returned from >>> ade7754_spi_read_reg_8. With this patch, the following randconfig >>> warnings get fix

[PATCH] hv: channel_mgmt: match var type to return type of wait_for_completion

2015-02-01 Thread Nicholas Mc Guire
From: Nicholas Mc Guire return type of wait_for_completion_timeout is unsigned long not int, this patch changes the type of t from int to unsigned long. Signed-off-by: Nicholas Mc Guire --- The return type of wait_for_completion_timeout is unsigned long not int. This patch resolves the type mi

[PATCH] hv: vmbus_drv: match var type to return type of wait_for_completion

2015-02-01 Thread Nicholas Mc Guire
From: Nicholas Mc Guire return type of wait_for_completion_timeout is unsigned long not int, this patch changes the type of t from int to unsigned long. Signed-off-by: Nicholas Mc Guire --- The return type of wait_for_completion_timeout is unsigned long not int. This patch resolves the type mi

[PATCH] hv: channel: match var type to return type of wait_for_completion

2015-02-01 Thread Nicholas Mc Guire
From: Nicholas Mc Guire return type of wait_for_completion_timeout is unsigned long not int, this patch changes the type of t from int to unsigned long. Signed-off-by: Nicholas Mc Guire --- The return type of wait_for_completion_timeout is unsigned long not int. This patch resolves the type mi

[PATCH] hv: hv_balloon: match var type to return type of wait_for_completion

2015-02-01 Thread Nicholas Mc Guire
From: Nicholas Mc Guire return type of wait_for_completion_timeout is unsigned long not int, this patch changes the type of t from int to unsigned long. Signed-off-by: Nicholas Mc Guire --- The return type of wait_for_completion_timeout is unsigned long not int. This patch resolves the type mi