On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote:
This patch fix the checkpatch.pl WARNING:
[]
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
[]
@@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, February 4, 2015 1:01 AM
To: KY Srinivasan; de...@linuxdriverproject.org
Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang
Subject: [PATCH 3/4] Drivers: hv: vmbus: protect
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, February 4, 2015 1:01 AM
To: KY Srinivasan; de...@linuxdriverproject.org
Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang
Subject: [PATCH 2/4] Drivers: hv: vmbus: do not
-Original Message-
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Sent: Wednesday, February 4, 2015 1:01 AM
To: KY Srinivasan; de...@linuxdriverproject.org
Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang
Subject: [PATCH 4/4] hyperv: netvsc: improve
On Tue, Feb 3, 2015 at 11:46 PM, Haiyang Zhang haiya...@microsoft.com
wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Monday, February 2, 2015 1:49 AM
btw, I find during netvsc_start_xmit(), ret was change to
-ENOSPC
when
for x86_64_defconfig + CONFIG_STAGING=y
CONFIG_R8723AU=m, CONFIG_8723AU_BT_COEXIST=y
Patch is against 3.0.19-rc7 (localversoin = -next-20150203)
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 60
+++-
1 file changed, 8 insertions(+), 52 deletions(-)
Why make it simple
From: Dexuan Cui [mailto:de...@microsoft.com]
I got HV_STATUS_INVALID_CONNECTION_ID on Hyper-V 2008 R2 when keeping running
rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe hv_utils
in a Linux guest. Looks the host has some kind of throttling mechanism if
some kinds of hypercalls are
From: Nicholas Mc Guire der.h...@hofr.at
return type of wait_for_completion_timeout is unsigned long not int, this
patch changes the type of t from int to unsigned long.
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
From: Dexuan Cui [mailto:de...@microsoft.com]
Before the line vmbus_open() returns, srv-util_cb can be already running
and the variables, like util_fw_version, are needed by the srv-util_cb.
So we have to make sure the variables are initialized before the vmbus_open().
CC: K. Y. Srinivasan
From: Nicholas Mc Guire der.h...@hofr.at
return type of wait_for_completion_timeout is unsigned long not int, this
patch changes the type of t from int to unsigned long.
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/hv/channel.c
From: Nicholas Mc Guire der.h...@hofr.at
return type of wait_for_completion_timeout is unsigned long not int, this
patch changes the type of t from int to unsigned long.
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
From: Dexuan Cui [mailto:de...@microsoft.com]
Without this patch, the state is put to CHANNEL_OPENING_STATE, and when
the driver is loaded next time, vmbus_open() will fail immediately due to
newchannel-state != CHANNEL_OPEN_STATE.
CC: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Dexuan
INTERNATIONAL FUNDS TRANSFER / AUDIT UNIT UNITED NATIONS
(World Bank Assisted Programme) Directorate of International Payment and
Transfers UN Plaza,
DC2-2060, New York, 10017.
Attention:-The Beneficiary,
My Names are Mr. Lou Yost, I'm the 2nd vice chairman of the united nations/
international
NetworkDirect is a service that supports guest RDMA. Define the GUID for this
service.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/hv/channel_mgmt.c |2 ++
include/linux/hyperv.h| 10 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git
Correctly rollback state if the failure occurs after we have handed over
the ownership of the buffer to the host.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Cc: sta...@vger.kernel.org
---
drivers/hv/channel.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git
Hi,
Continuing with the checkpatch cleanup, this series will just fix the CamelCase.
Two different patches are made just to make review easier.
Now there is only one checkpatch warning pending about __setup, which will be
fixed
in one of the upcoming patch where I will introduce the use of
INTERNATIONAL FUNDS TRANSFER / AUDIT UNIT UNITED NATIONS
(World Bank Assisted Programme) Directorate of International Payment and
Transfers UN Plaza,
DC2-2060, New York, 10017.
Attention:-The Beneficiary,
My Names are Mr. Lou Yost, I'm the 2nd vice chairman of the united nations/
international
INTERNATIONAL FUNDS TRANSFER / AUDIT UNIT UNITED NATIONS
(World Bank Assisted Programme) Directorate of International Payment and
Transfers UN Plaza,
DC2-2060, New York, 10017.
Attention:-The Beneficiary,
My Names are Mr. Lou Yost, I'm the 2nd vice chairman of the united nations/
international
This patch removes the sparse warnings present in the lproc_lmv.c
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lproc_lmv.c
is potentially record breaking
!
Patch was compile tested for x86_64_defconfig + CONFIG_STAGING=y
CONFIG_R8723AU=m, CONFIG_8723AU_BT_COEXIST=y
Patch is against 3.0.19-rc7 (localversoin = -next-20150203)
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 60
+++-
1 file
of this driver.
Also not sure about the retained comment string if that is still valid now.
Patch was only compile tested for x86_64_defconfig + CONFIG_STAGING=y
CONFIG_COMEDI=m, COMEDI_ISA_DRIVERS=y, CONFIG_COMEDI_DT282X=m
Patch is against 3.0.19-rc7 (localversion = -next-20150203)
drivers/staging
This patch adds a static keyword to lprocfs_lmv_init_vars and
lprocfs_lmv_module_vars to suppress the sparse warnings about
static declaration
Signed-off-by: Mohammad Jamal md.jamalmohiud...@gmail.com
---
drivers/staging/lustre/lustre/lmv/lproc_lmv.c |4 ++--
1 file changed, 2 insertions(+),
On Feb 02 Peter Hurley wrote:
On 01/28/2015 03:07 PM, Clemens Ladisch wrote:
The driver was using the vendor ID 0xd00d1e from the FireWire core.
However, this ID was not registered, and invalid.
Instead, use the vendor/version IDs that now are officially assigned to
firewire-serial:
This symbol is never used anywhere else besides sm7xxfb.c
Signed-off-by: Max Perepelitsyn mperepelit...@gmail.com
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index
On 02/03/2015 03:44 AM, Stefan Richter wrote:
On Feb 02 Peter Hurley wrote:
On 01/28/2015 03:07 PM, Clemens Ladisch wrote:
The driver was using the vendor ID 0xd00d1e from the FireWire core.
However, this ID was not registered, and invalid.
Instead, use the vendor/version IDs that now are
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
This symbol is never used anywhere else besides sm7xxfb.c
Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?
regards
sudip
Signed-off-by: Max Perepelitsyn mperepelit...@gmail.com
---
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Monday, February 2, 2015 1:49 AM
btw, I find during netvsc_start_xmit(), ret was change to -ENOSPC
when
queue_sends[q_idx] 1. But non of the caller check -ENOSPC in fact?
In this case, we don't request
In case we hit a failure condition in vmbus_process_offer() and a rescind offer
was pending for the channel we just do free_channel() so
CHANNELMSG_RELID_RELEASED
will never be send to the host. We have to follow vmbus_process_rescind_offer()
path anyway.
To support the change we need to protect
free_channel() function frees the channel unconditionally so we need to make
sure nobody has any link to it. This is not trivial and there are several
examples of races we have:
1) In vmbus_onoffer_rescind() we check for channel existence with
relid2channel() and then use it. This can go wrong
list_for_each_safe() we have in vmbus_get_outgoing_channel() works, however, we
are not protected against the channel being removed (e.g. after receiving
rescind
offer). Users of this function (storvsc_do_io() is the only one at this moment)
can get a link to an already freed channel. Make
The check added in commit c3582a2c4d0b (hyperv: Add support for vNIC hot
removal) is incomplete as there is no synchronization between
vmbus_onoffer_rescind() and netvsc_send(). In case we get the offer after we
checked out_channel-rescind and before netvsc_send() finishes its job we can
get a
This series is a continuation of the Drivers: hv: vmbus: serialize Offer and
Rescind offer. I'm trying to address a number of theoretically possible issues
with rescind offer handling. All these complications come from the fact that
a rescind offer results in vmbus channel being freed and we must
string if that is still valid now.
Patch was only compile tested for x86_64_defconfig + CONFIG_STAGING=y
CONFIG_COMEDI=m, COMEDI_ISA_DRIVERS=y, CONFIG_COMEDI_DT282X=m
Patch is against 3.0.19-rc7 (localversion = -next-20150203)
drivers/staging/comedi/drivers/dt282x.c | 10 ++
1 file
This is a resend of the patches from Dexuan and Nicholas
Dexuan Cui (3):
hv: hv_util: move vmbus_open() to a later place
hv: vmbus_post_msg: retry the hypercall on some transient errors
hv: vmbus_open(): reset the channel state on ENOMEM
Nicholas Mc Guire (3):
hv: channel: match var type
, CONFIG_8723AU_BT_COEXIST=y
Patch is against 3.0.19-rc7 (localversoin = -next-20150203)
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 60 +++-
1 file changed, 8 insertions(+), 52 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b/drivers/staging
On Tue, Feb 03, 2015 at 08:54:45PM +0530, Mohammad Jamal wrote:
This patch adds a static keyword to lprocfs_lmv_init_vars and
lprocfs_lmv_module_vars to suppress the sparse warnings about
static declaration
have you build tested your patch?
After your patch:
On Tue, Feb 03, 2015 at 02:44:28PM +0600, Max Perepelitsyn wrote:
This symbol is never used anywhere else besides sm7xxfb.c
Signed-off-by: Max Perepelitsyn mperepelit...@gmail.com
Tested-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
1 file
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Tuesday, February 3, 2015 11:04 AM
To: KY Srinivasan; Haiyang Zhang
Cc: de...@linuxdriverproject.org; net...@vger.kernel.org
Subject: [PATCH] hyper-v: allow access to vmbus from userspace driver
Brocade is submitting a hyper-v driver for DPDK d...@dpdk.org
but this driver needs a hook in the hyper-v bus layer
to allow the additional hv_uio driver to access the shared vmbus
pages. The hv_uio driver lives in DPDK (like igb_uio) and provides
userspace access to raw network packets.
This patch fix the checkpatch.pl WARNING:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Bilel DRIRA bilel...@gmail.com
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 78 +-
1 file changed, 31 insertions(+), 47 deletions(-)
diff
3.0.19-rc7 (localversion = -next-20150203)
drivers/staging/comedi/drivers/dt282x.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt282x.c
b/drivers/staging/comedi/drivers/dt282x.c
index 051dfb2..22c59e5 100644
--- a/drivers
This small patchset fixes all the style problems reported by checkpatch.pl on
ft1000-pcmcia/ft1000_hw.c
* Patch 1/2 fixes all trivial issues not requiring code refactoring
* Patch 2/2 fixes all remaining line over 80 characters warnings by means of
some code refactoring. Specifically, the
On Tue, Feb 03, 2015 at 07:31:36AM -0800, K. Y. Srinivasan wrote:
This is a resend of the patches from Dexuan and Nicholas
What do you mean by resend? Did you send them to be before? I can't
see them in my inbox anywhere.
confused,
greg k-h
___
Fix all the trivial style issues (as reported by checkpatch.pl) not requiring
code refactoring. A following patch is expected to fix the remaining issues by
performing some code refactoring.
Signed-off-by: Daniele Alessandrelli daniele.alessandre...@gmail.com
---
Add new function ft1000_read_dsp_timer() replacing recurring code block for
reading DSP timer. Such code refactoring solves all remaining line over 80
characters warnings reported by checkpatch.pl.
Signed-off-by: Daniele Alessandrelli daniele.alessandre...@gmail.com
---
On Wed, Jan 28, 2015 at 04:49:20PM -0800, K. Y. Srinivasan wrote:
Windows hosts starting with Ws2012 R2 permit re-establishing the vmbus
connection from the guest. This patch-set includes patches from Vitaly
to cleanup the VMBUS unload path so we can potentially reload the driver.
This set
On Tue, 2015-02-03 at 21:05 +0100, bill wrote:
Ok,thank you, I will do that and resend the patch again.
I wouldn't.
It's probably better as a separate patch anyway.
btw: please don't top post.
cheers, Joe
On Tue, Feb 03, 2015 at 11:05:08AM -0800, Joe Perches wrote:
On Tue, 2015-02-03 at
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, February 3, 2015 3:47 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
t...@linutronix.de
Subject: Re:
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, February 3, 2015 4:01 PM
To: KY Srinivasan
Cc: a...@canonical.com; de...@linuxdriverproject.org; o...@aepfle.de;
linux-ker...@vger.kernel.org
Subject: Re: [PATCH RESEND 0/6] Drivers: hv: vmbus:
On Tue, Feb 03, 2015 at 11:51:53PM +, KY Srinivasan wrote:
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, February 3, 2015 3:45 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
o...@aepfle.de;
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, February 3, 2015 3:45 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com
Subject: Re: [PATCH RESEND 0/6]
On Tue, Feb 03, 2015 at 11:57:18PM +, KY Srinivasan wrote:
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, February 3, 2015 3:47 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
o...@aepfle.de;
-Original Message-
From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
Behalf Of KY Srinivasan
Sent: Tuesday, February 3, 2015 11:24 AM
To: Stephen Hemminger; Haiyang Zhang
Cc: de...@linuxdriverproject.org; net...@vger.kernel.org
Subject: RE: [PATCH] hyper-v:
On Feb 03 Peter Hurley wrote:
On 02/03/2015 03:44 AM, Stefan Richter wrote:
On Feb 02 Peter Hurley wrote:
[...]
The problem is a host with the old OUIs will not recognize a remote
unit with the new OUIs, and vice versa.
Even though the new ids could be added to the unit driver's
Windows hosts starting with Ws2012 R2 permit re-establishing the vmbus
connection from the guest. This patch-set includes patches from Vitaly
to cleanup the VMBUS unload path so we can potentially reload the driver.
This set also includes a patch from Jake to correctly extract MMIO
From: Jake Oshins [mailto:ja...@microsoft.com]
This set of changes finds the _CRS object in the ACPI namespace
that contains memory address space descriptors, intended to convey
to VMBus which ranges of memory-mapped I/O space are available for
child devices, and then builds a resource list that
From: Nicholas Mc Guire der.h...@hofr.at
return type of wait_for_completion_timeout is unsigned long not int, this
patch changes the type of t from int to unsigned long.
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/hv/channel.c
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
We need to destroy hv_vmbus_con on module shutdown, otherwise the following
crash is sometimes observed:
[ 76.569845] hv_vmbus: Hyper-V Host Build:9600-6.3-17-0.17039; Vmbus
version:3.0
[ 82.598859] BUG: unable to handle kernel paging
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
It looks like clockevents_unbind is being exported by mistake as:
- it is static;
- it is not listed in include/linux/clockchips.h;
- EXPORT_SYMBOL_GPL(clockevents_unbind) follows clockevents_unbind_device()
implementation.
I think
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
SynIC has to be switched off when we unload the module, otherwise registered
memory pages can get corrupted after (as Hyper-V host still writes there) and
we see the following crashes for random processes:
[ 89.116774] BUG: Bad page map in
From: Dexuan Cui [mailto:de...@microsoft.com]
I got HV_STATUS_INVALID_CONNECTION_ID on Hyper-V 2008 R2 when keeping running
rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe hv_utils
in a Linux guest. Looks the host has some kind of throttling mechanism if
some kinds of hypercalls are
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
On driver shutdown device_obj is being freed twice:
1) In vmbus_free_channels()
2) vmbus_device_release() (which is being triggered by device_unregister() in
vmbus_device_unregister().
This double kfree leads to the following sporadic crash
From: Vitaly Kuznetsov vkuzn...@redhat.com
When an SMP Hyper-V guest is running on top of 2012R2 Server and secondary
cpus are sent offline (with echo 0 /sys/devices/system/cpu/cpu$cpu/online)
the system freeze is observed. This happens due to the fact that on newer
hypervisors (Win8, WS2012R2,
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
All channel work queues are named 'hv_vmbus_ctl', this makes them
indistinguishable in ps output and makes it hard to link to the corresponding
vmbus device. Rename them to hv_vmbus_ctl/N and make vmbus device names match,
e.g. now vmbus_1
From: Dexuan Cui [mailto:de...@microsoft.com]
Before the line vmbus_open() returns, srv-util_cb can be already running
and the variables, like util_fw_version, are needed by the srv-util_cb.
So we have to make sure the variables are initialized before the vmbus_open().
CC: K. Y. Srinivasan
NetworkDirect is a service that supports guest RDMA.
Define the GUID for this service.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/hv/channel_mgmt.c |2 ++
include/linux/hyperv.h| 10 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git
From: Dexuan Cui [mailto:de...@microsoft.com]
Without this patch, the state is put to CHANNEL_OPENING_STATE, and when
the driver is loaded next time, vmbus_open() will fail immediately due to
newchannel-state != CHANNEL_OPEN_STATE.
CC: K. Y. Srinivasan k...@microsoft.com
Signed-off-by: Dexuan
From: Nicholas Mc Guire der.h...@hofr.at
return type of wait_for_completion_timeout is unsigned long not int, this
patch changes the type of t from int to unsigned long.
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
Newly introduced clockevent devices made it impossible to unload hv_vmbus
module as clockevents_config_and_register() takes additional reverence to
the module. To make it possible again we do the following:
- avoid setting dev-owner for
Correctly rollback state if the failure occurs after we have handed over
the ownership of the buffer to the host.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Cc: sta...@vger.kernel.org
---
drivers/hv/channel.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git
From: Nicholas Mc Guire der.h...@hofr.at
return type of wait_for_completion_timeout is unsigned long not int, this
patch changes the type of t from int to unsigned long.
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
71 matches
Mail list logo
