Re: [PATCHv2 0/3] Lustre: get rid of deprecated cpumask calls

2015-03-07 Thread Greg Kroah-Hartman
On Wed, Mar 04, 2015 at 01:07:50AM -0500, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > A recent crash report with CONFIG_CPUMASK_OFFSTACK enabled > set off a chain of emails through which I learned that cpus_* functions > are deprecated and should not be really used to operate on cpumasks.

Re: [PATCH v2] staging: dgnc: Warn on macro with flow control statements

2015-03-07 Thread Greg KH
On Fri, Feb 27, 2015 at 11:50:01AM +0100, Salah Triki wrote: > This fixes the following checkpatch.pl warnings: > WARNING: Macros with flow control statements should be avoided. > > Signed-off-by: Salah Triki > --- > drivers/staging/dgnc/dgnc_sysfs.c | 38 -- >

Re: [PATCH] staging: dgnc: use min_t instead of min

2015-03-07 Thread Greg KH
On Sun, Feb 22, 2015 at 11:47:01PM +0100, Salah Triki wrote: > This fixes the following checkpatch.pl warnings: > WARNING: min() should probably be min_t() > --- > drivers/staging/dgnc/dgnc_neo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You sent 3 copies of this patch, some differe

Re: [PATCH] staging: wlan-ng: Use setup_timer

2015-03-07 Thread Greg Kroah-Hartman
On Sun, Feb 08, 2015 at 12:50:45PM +0530, Vaishali Thakkar wrote: > This patch introduces the use of function setup_timer. > > This is done using Coccinelle and semantic patch used is > as follows: > > @@ > expression x,y,z; > @@ > > - init_timer (&x); > + setup_timer (&x, y, z); > - x.function

Re: [PATCH] Staging: vt6655: replace C99 style comments

2015-03-07 Thread Greg KH
On Fri, Feb 27, 2015 at 07:18:17PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the following error: > ERROR: do not use C99 // comments > > Signed-off-by: Matteo Semenzato > --- > drivers/staging/vt6655/key.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 1/2] staging: sm750fb: add sm750 to staging

2015-03-07 Thread Greg Kroah-Hartman
On Tue, Mar 03, 2015 at 04:21:06PM +0530, Sudip Mukherjee wrote: > sm750 of Silicon Motion is pci-e display controller device and has > features like dual display and 2D acceleration. This patch adds the > driver to staging. > > Signed-off-by: Sudip Mukherjee > --- > > this patch has lots of che

Re: [PATCH] Staging: vt6655: remove C99 style comments.

2015-03-07 Thread Greg KH
On Fri, Feb 27, 2015 at 07:13:10PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the following error: > ERROR: do not use C99 // comments > > Signed-off-by: Matteo Semenzato > --- > drivers/staging/vt6655/device_main.c | 35 ++- >

Re: [PATCHv3 1/2] ft1000-pcmcia: ft1000_hw.c: fix style issues not requiring code refactoring

2015-03-07 Thread Greg Kroah-Hartman
On Wed, Feb 11, 2015 at 11:06:03PM +0100, Daniele Alessandrelli wrote: > Fix all the trivial style issues (as reported by checkpatch.pl) not requiring > code refactoring. A following patch is expected to fix the remaining issues by > performing some code refactoring. > > Signed-off-by: Daniele Ale

Re: [PATCH] staging/sm7xxfb: Make 'struct vgamode' static

2015-03-07 Thread Greg KH
On Mon, Feb 23, 2015 at 12:16:16PM +0100, Peter Senna Tschudin wrote: > sparse was complaining that symbol 'vgamode' was not declared. > > Declaring vgamode as static. > > Signed-off-by: Peter Senna Tschudin > --- > Tested by compilation only > > drivers/staging/sm7xxfb/sm7xx.h | 2 +- > 1 fil

Re: [PATCH v2 1/7] staging: ft1000: ft1000-pcmcia: removed unnecessary braces

2015-03-07 Thread Greg KH
On Mon, Feb 09, 2015 at 12:41:58PM +0530, Pushpendra Singh wrote: > Remove checkpatch.pl warning > WARNING: braces {} are not necessary for any arm of this statement > + if (tempword & 0x1f) { > [...] > + } else { > [...] > > Signed-off-b

Re: [PATCH] staging: media: lirc: Separate authors into own MODULE_AUTHOR

2015-03-07 Thread Greg KH
On Sat, Feb 21, 2015 at 07:59:06PM +, Boran Car wrote: > Fixes quoted string split accross lines checkpatch.pl warning. > > Signed-off-by: Boran Car > --- > drivers/staging/media/lirc/lirc_zilog.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Please use scripts/get_mai

Re: [PATCH 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings

2015-03-07 Thread Greg KH
On Wed, Mar 04, 2015 at 11:11:12AM +, Cláudio Maia wrote: > Fixed two warnings occurring in lines that are over 80 characters > and which are not comments. > > Signed-off-by: Cláudio Maia > --- > drivers/staging/fbtft/fb_pcd8544.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions

Re: [PATCH V2] Staging: fbtft: fix space prohibition

2015-03-07 Thread Greg KH
On Mon, Mar 02, 2015 at 02:28:31PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the following warnings: > space prohibited before that close parenthesis ')' > space prohibited after that open parenthesis '(' > > V2: The patch should apply now. The "V2" should be

Re: [PATCH 1/5] Staging: gdm724x: code style improvements

2015-03-07 Thread Greg Kroah-Hartman
On Fri, Feb 13, 2015 at 09:32:20PM -0800, Tolga Ceylan wrote: > Corrections based on checkpatch.pl with --strict. > Added missing spaces between operators. > > Signed-off-by: Tolga Ceylan 5 patches all with the same subject: line :( I can't take these, please fix them up to be unique. And also

Re: [PATCH] Staging: rtl8192u: r8190_rtl8256: coding style and format string type connections

2015-03-07 Thread Greg Kroah-Hartman
On Sun, Feb 08, 2015 at 08:46:28PM -0800, Tolga Ceylan wrote: > Lines over 80 were corrected > RT_TRACE format strings should specify unsigned instead of signed int I don't understand, why did you do 2 different things in a single patch? Please split this up. Also: > case RF90_PAT

Re: [PATCH] staging: rtl8192u: r8192U_wx.h is now checkpatch-conform

2015-03-07 Thread Greg Kroah-Hartman
On Mon, Feb 16, 2015 at 11:22:37PM +0100, Patrick Boettcher wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to > line-length and comments in r8192I_wx.h. > > Signed-off-by: Patrick Boettcher > --- > drivers/staging/rtl8192u/r8192U_wx.h | 32

Re: [PATCH 1/2] staging: rtl8192e: remove unnecessary spaces

2015-03-07 Thread Greg KH
On Mon, Feb 16, 2015 at 03:12:24PM +0530, Pushpendra Singh wrote: > Removed checkpatch.pl error > ERROR: space prohibited before that ',' (ctx:WxE) > +433, 433, 477} } , > > Signed-off-by: Pushpendra Singh > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- > drivers/staging/rtl8

Re: [PATCH 3/3] Staging: rtl8192u: ieee80211: rtl819x_TS: replaced C99 comments with C89

2015-03-07 Thread Greg Kroah-Hartman
On Fri, Feb 20, 2015 at 06:14:25PM -0800, Tolga Ceylan wrote: > Replaced C99 comments with C89 while maintaining less than 80 char lines. > Removed commented out struct member: DLRecord. > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 15 ---

Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma

2015-03-07 Thread Greg Kroah-Hartman
On Thu, Feb 19, 2015 at 09:54:11PM -0800, Tolga Ceylan wrote: > Resolved space required after that ',' errors reported by checkpatch. > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/rtl8192u/r819xU_firmware.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) Thi

Re: [PATCH] Staging: emxx_udc: fix warnings

2015-03-07 Thread Greg KH
On Wed, Feb 25, 2015 at 02:54:32PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the following warning: > __aligned(size) is preferred over __attribute__((aligned(size))) That's a coding style warning, not a build warning. Please be explicit when sending a patch.

Re: [PATCH 1/3] Staging: rtl8192u: ieee80211: ieee80211_crypt: removed commented out include

2015-03-07 Thread Greg Kroah-Hartman
On Fri, Feb 20, 2015 at 06:14:23PM -0800, Tolga Ceylan wrote: > Removed a commented out header include > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 1 - > 1 file changed, 1 deletion(-) Doesn't apply to my tree :(

Re: [PATCH 1/1] Staging: rtl8192u: r8192U_wx: removed unnecessary comments

2015-03-07 Thread Greg Kroah-Hartman
On Fri, Feb 27, 2015 at 08:36:59PM -0800, Tolga Ceylan wrote: > 1) Removed commented out include header statement > 2) Removed unnecessary author/date comment > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/rtl8192u/r8192U_wx.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) D

Re: [PATCH 1/2] staging: sm750fb: add sm750 to staging

2015-03-07 Thread Sudip Mukherjee
On Fri, Mar 06, 2015 at 04:38:34PM -0800, Greg Kroah-Hartman wrote: > On Tue, Mar 03, 2015 at 04:21:06PM +0530, Sudip Mukherjee wrote: > > --- > > > > this patch has lots of checkpatch warnings including some trailing > > whitespaces. > > And it has build warnings as well. Please send me patche

[PATCH] staging/lustre: Make lstcon_console_{init,fini} static

2015-03-07 Thread Peter Senna Tschudin
sparse was complaining that the symbols 'lstcon_console_init' and 'lstcon_console_fini' were not declared. Declaring both as static. Signed-off-by: Peter Senna Tschudin --- drivers/staging/lustre/lnet/selftest/console.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/d

Re: [PATCH] staging: rtl8192u: r8192U_wx.h is now checkpatch-conform

2015-03-07 Thread Patrick Boettcher
On Fri, 6 Mar 2015 16:52:48 -0800 Greg Kroah-Hartman wrote: > > [..] > > Just remove the line please. Already done and integration one week ago. I won't ever make it. I'm too slow :) Thanks for you feedback though. -- Patrick. ___ devel mailing list

Re: [PATCH 16/17] staging: rtl8723au: odm.c: Further reduce the use of ODM_SetBBReg()

2015-03-07 Thread Greg KH
On Thu, Mar 05, 2015 at 02:24:49PM -0500, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > drivers/staging/rtl8723au/hal/odm.c | 168 > +--- > 1 file changed, 119 insertions(+), 49 deletions(-) More trailing whitespace

Re: [PATCH 15/17] staging: rtl8723au: Eliminate ODM_GetBBReg()

2015-03-07 Thread Greg KH
On Thu, Mar 05, 2015 at 02:24:48PM -0500, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > drivers/staging/rtl8723au/hal/odm.c | 28 > ++- > drivers/staging/rtl8723au/hal/odm_interface.c | 11 - > drivers/

Re: [PATCH 17/17] staging: rtl8723au: Eliminate ODM_SetBBReg()

2015-03-07 Thread Greg KH
On Thu, Mar 05, 2015 at 02:24:50PM -0500, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > drivers/staging/rtl8723au/hal/odm.c | 33 > ++- > drivers/staging/rtl8723au/hal/odm_interface.c | 12 - > drivers/

Re: [PATCH v9 1/3] staging: fsl-mc: Added Freescale Management Complex APIs

2015-03-07 Thread Greg KH
On Thu, Mar 05, 2015 at 07:29:09PM -0600, J. German Rivera wrote: > APIs to access the Management Complex (MC) hardware > module of Freescale LS2 SoCs. This patch includes > APIs to check the MC firmware version and to manipulate > DPRC objects in the MC. > > Signed-off-by: J. German Rivera > Sig

Re: [PATCH v3] Staging: dgnc: Remove sysfs file

2015-03-07 Thread Greg KH
On Sat, Mar 07, 2015 at 01:36:54AM +0100, Salah Triki wrote: > This sysfs file is not useful for anything. What is "this"? Same goes for the subject. Why is it not useful? How did you determine this? You need to provide a lot more info here. ___ dev

Re: [PATCH 1/1] dgnc: Cleanup coding style

2015-03-07 Thread Greg KH
On Tue, Feb 17, 2015 at 10:53:32PM +0100, Salah Triki wrote: > This fixes the following checkpatch.pl warnings: > WARNING: printk() should include KERN_ facility level > > Signed-off-by: Salah Triki Please make your subject say what you are doing specifically, not just a vague statement like it

Re: [PATCH] staging/lustre: Make lstcon_console_{init,fini} static

2015-03-07 Thread Sudip Mukherjee
On Sat, Mar 07, 2015 at 12:41:06PM +0100, Peter Senna Tschudin wrote: > sparse was complaining that the symbols 'lstcon_console_init' > and 'lstcon_console_fini' were not declared. > > Declaring both as static. you have not even build tested your patch. WARNING: "lstcon_console_init" [drivers/s

Re: [PATCH 17/17] staging: rtl8723au: Eliminate ODM_SetBBReg()

2015-03-07 Thread Jes Sorensen
Greg KH writes: > On Thu, Mar 05, 2015 at 02:24:50PM -0500, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> --- >> drivers/staging/rtl8723au/hal/odm.c | 33 ++- >> drivers/staging/rtl8723au/hal/odm_interface.c | 12 - >>

[PATCH 2/2] Staging: rtl8188eu: fix double unlock

2015-03-07 Thread Matteo Semenzato
From: Matteo Semenzato The rtw_cmd_thread semaphore was being unlocked twice. Signed-off-by: Matteo Semenzato --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/c

[PATCH RESEND] Staging: rtl8188eu: fix double unlock

2015-03-07 Thread Matteo Semenzato
From: Matteo Semenzato The rtw_cmd_thread semaphore was being unlocked twice. Signed-off-by: Matteo Semenzato --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/c

[PATCH RESEND 1/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings

2015-03-07 Thread Cláudio Maia
Fixed one warning about lines that are over 80 characters and which are not comments. Signed-off-by: Cláudio Maia --- drivers/staging/fbtft/fb_pcd8544.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544

[PATCH RESEND 2/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings

2015-03-07 Thread Cláudio Maia
This patch fixes the following errors by refactoring the comments' style: WARNING: line over 80 characters ERROR: code indent should use tabs where possible Signed-off-by: Cláudio Maia --- drivers/staging/fbtft/fb_pcd8544.c | 107 1 file changed, 59 inserti

Re: [PATCH RESEND] Staging: rtl8188eu: fix double unlock

2015-03-07 Thread Larry Finger
On 03/07/2015 09:33 AM, Matteo Semenzato wrote: From: Matteo Semenzato The rtw_cmd_thread semaphore was being unlocked twice. Signed-off-by: Matteo Semenzato --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl

Re: [PATCHv2 0/3] Lustre: get rid of deprecated cpumask calls

2015-03-07 Thread Oleg Drokin
Hello! On Mar 6, 2015, at 7:06 PM, Greg Kroah-Hartman wrote: >> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 4 +- >> .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 102 >> +++-- >> drivers/staging/lustre/lustre/ptlrpc/ptlrpcd.c | 8 +- >> drivers/staging/lustre

[PATCH 4/4] staging/lustre: Don't call blocking funcitons when !RUNNABLE

2015-03-07 Thread green
From: Oleg Drokin Move setting of TASK_INTERRUPTIBLE just around schedule call in libcfs_sock_accept. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-tcpip.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lu

[PATCH 1/4] staging/lustre/libcfs: replace deprecated cpus_ calls with cpumask_

2015-03-07 Thread green
From: Oleg Drokin This patch continues to further remove deprecated functions, such as any_online_cpu, for_each_cpu_mask and also cleaning up usage of NR_CPUS in a few places Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/libcfs/linux/linux-cpu.c | 32 -- 1 file c

[PATCH 2/4] staging/lustre/o2iblnd: Don't use cpus_weight

2015-03-07 Thread green
From: Oleg Drokin cpus_weight and for_each_cpu_mask are deprecated, so replace them with cpumask_weight and for_each_cpu respectively. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH 3/4] staging/lustre/llite: avoid nonatomic memory alloc under spinlock

2015-03-07 Thread green
From: Lai Siyao ll_intent_drop_lock() may sleep in memory allocation, which should not be called inside spinlock. Signed-off-by: Lai Siyao Signed-off-by: Jian Yu Reviewed-on: http://review.whamcloud.com/10674 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2272 Signed-off-by: Oleg Drokin

[PATCH 0/4] Lustre fixes

2015-03-07 Thread green
From: Oleg Drokin The first two patches are a follow on for the previous patch series on not using deprecated cpumask-related code. And two blocking while atomic/not running fixes. Please consider. Lai Siyao (1): staging/lustre/llite: avoid nonatomic memory alloc under spinlock Oleg Drokin

[PATCH] staging: fbtft: Use kmemdup rather than duplicating its implementation

2015-03-07 Thread Madhusudhanan Ravindran
The semantic patch that makes this change is available in scriptcoccinelle/api/memdup.cocci. Signed-off-by: Madhusudhanan Ravindran --- drivers/staging/fbtft/fbtft-sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging