[PATCH] staging: sm750fb: Fixed no space warnings

2015-03-13 Thread Ragavendra Nagraj
This patch fixes the no spaces warning identified by the checkpath.pl script for the entire ddk750_chip.c file by using appropriate tab spaces instead. Signed-off-by: Ragavendra Nagraj --- drivers/staging/sm750fb/ddk750_chip.c | 364 - 1 file changed, 182 inserti

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-13 Thread Giedrius Statkevičius
Hi Ragavendra, On 2015.03.14 03:04, Ragavendra Nagraj wrote: > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the > code give no > warnings by the checpath.pl. Please accept. The "Please accept."

[PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-13 Thread Ragavendra Nagraj
This patch removes the braces for the single line if statement. It fixes the indent positions correctly. It fixes the spaces appropriately making the code give no warnings by the checpath.pl. Please accept. Signed-off-by: Ragavendra Nagraj --- drivers/staging/sm750fb/ddk750_chip.c | 22 ++

[PATCH v2] staging: panel: change struct bits to a bit array

2015-03-13 Thread Isaac Lleida
This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage. Signed-off-by: Isaac Lleida >= 1; @@ -814,7 +826,7 @@ static void lcd_backlight(int on) /* The backlight i

[PATCH] staging: vt6656: don't return zero on failure path in vt6656_probe()

2015-03-13 Thread Alexey Khoroshilov
If ieee80211_alloc_hw() fails in vt6656_probe(), it breaks off initialization, but returns zero. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/staging/vt6656/main_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/sta

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-13 Thread Mark Hounschell
On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote: On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't save dgnc_boards which failed to initialize. Assign the result of kzalloc() to brd in dgnc_found_board()

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-13 Thread Giedrius Statkevičius
Hi Greg, On 2015.03.12 12:08, Greg KH wrote: > On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: >> Remove BOARD_FAILED and don't save dgnc_boards which failed to >> initialize. >> >> Assign the result of kzalloc() to brd in dgnc_found_board() and only put >> it in the dgnc_Bo

[PATCH] staging: panel: change struct bits to a bit array

2015-03-13 Thread Isaac Lleida
From: isaky This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage. Signed-off-by: Isaac Lleida --- drivers/staging/panel/panel.c | 86 -

[PATCH v2 5/7] dgnc: remove old 2.4-2.6 compat kernel defines

2015-03-13 Thread Giedrius Statkevičius
dgnc_kcompat.h contains some old legacy defines in case the kernel doesn't have __user defined but for current kernel versions these defines don't make sense and are useless so remove them. Move the TTY_FLIPBUF_SIZE define to digi.h because it's used in the code. Signed-off-by: Giedrius Statkeviči

[PATCH v2 4/7] dgnc: use linux/types.h instead of dgnc_types.h

2015-03-13 Thread Giedrius Statkevičius
Dgnc_types.h unnecesarily defines TRUE as 1 and FALSE as 0 because we already have a widely used linux/types.h so convert all TRUE to true, FALSE to false and edit the dgnc_board struct to make sure it uses "bool". Signed-off-by: Giedrius Statkevičius --- I'm still not sure whether it's safe to c

[PATCH v2 6/7] dgnc: remove unused stuff from dgnc_cls.h

2015-03-13 Thread Giedrius Statkevičius
Remove unused defines from dgnc_cls.h Signed-off-by: Giedrius Statkevičius --- v2: No change drivers/staging/dgnc/dgnc_cls.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h index 85042bd..2597e36 100644 --- a/dr

[PATCH v2 3/7] dgnc: get rid of dpacompat.h, move remaining stuff to digi.h

2015-03-13 Thread Giedrius Statkevičius
Dpacompat.h contained a lot of unused #defines and only few things are used from it so since we've trimmed down digi.h, now we can delete dpacompat.h and move remaining stuff into digi.h. Signed-off-by: Giedrius Statkevičius --- v2: No change drivers/staging/dgnc/dgnc_driver.c | 1 - drivers/

[PATCH v2 7/7] dgnc: Clean up dgnc_sysfs.h

2015-03-13 Thread Giedrius Statkevičius
Remove redundant blank lines, move absolute include after relative include. Signed-off-by: Giedrius Statkevičius --- v2: no change drivers/staging/dgnc/dgnc_sysfs.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_sysfs.h b/drivers/staging/dgnc/

[PATCH v2 2/7] dgnc: clean up digi.h

2015-03-13 Thread Giedrius Statkevičius
Remove a lot of unused structs and defines from digi.h. We still have to be careful with TIOCM_LE and TIOCMSET/TIOCMBIC because termios.h and ioctls.h respectfully redefine them. Signed-off-by: Giedrius Statkevičius --- v2: Updated commit msg and remove some more unused stuff drivers/staging/dg

[PATCH v2 1/7] dgnc: remove unused dgnc_ioctl_name() command

2015-03-13 Thread Giedrius Statkevičius
dgnc_ioctl_name() is never used anywhere so remove it Signed-off-by: Giedrius Statkevičius --- v2: Forgot to include this patch in the first version. Without this some of the other patches in this set will fail. drivers/staging/dgnc/dgnc_utils.c | 52 --- dri

[PATCH] staging: netlogic: allocate right size in devm_kzalloc

2015-03-13 Thread Ravindran, Madhusudhanan (M.)
sizeof when applied to a pointer typed expression gives the size of the pointer. The semantic patch that makes this change is available in scripts/coccinelle/misc/noderef.cocci. Signed-off-by: Madhusudhanan Ravindran --- drivers/staging/netlogic/xlr_net.c |2 +- 1 file changed, 1 insertion(

[PATCH] staging: fbtft: Use kmemdup rather than duplicating its implementation

2015-03-13 Thread Abdul Hussain S
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci Signed-off-by: Abdul Hussain S --- drivers/staging/fbtft/fbtft-sysfs.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbt

Re: [PATCH] staging: fbtft: Use kmemdup rather than duplicating its implementation

2015-03-13 Thread Dan Carpenter
On Fri, Mar 13, 2015 at 04:01:32PM +0530, Abdul Hussain S wrote: > Change-Id: I3ae055f5efe63acc3a71e52c1eb677ebd16e538b What is this? Anyway, don't include it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev

[PATCH] staging: fbtft: Use kmemdup rather than duplicating its implementation

2015-03-13 Thread Abdul Hussain S
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci Change-Id: I3ae055f5efe63acc3a71e52c1eb677ebd16e538b Signed-off-by: Abdul Hussain S --- drivers/staging/fbtft/fbtft-sysfs.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drive

Re: [PATCH 00/56] staging: comedi: introduce comedi_pci.h header

2015-03-13 Thread Ian Abbott
On 12/03/15 10:29, Ian Abbott wrote: On 10/03/15 16:25, Joe Perches wrote: On Tue, 2015-03-10 at 16:10 +, Ian Abbott wrote: "comedidev.h" includes PCI-specific stuff that gets included by all comedi drivers including non-PCI ones. Separate it out into its own header "comedi_pci.h". Make t

[PATCH] Staging: lustre: fix space issue in workitem.c

2015-03-13 Thread Greg Kroah-Hartman
This patch fixes a space issue in the workitem.c file Signed-off-by: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/libcfs/workitem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c b/drivers/staging/lustre/lustre/libcfs/

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-13 Thread Dan Carpenter
On Thu, Mar 12, 2015 at 11:11:27PM -0700, Ragavendra BN wrote: > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the > code give no > warnings by the checpath.pl script check. Please accept.