This patch removes the unnecessary spinlock helper function and instead
calls spin_lock and spin_unlock directly.
This does *not* resolve sparse warnings about context imbalances but these are
spurious.
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
drivers/staging/sm750fb/sm750.c | 53
This patch removes the unused hw712_fillrect function. This patch fixes
the following sparse warning:-
drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes lstoa...@gmail.com
---
This patch annotates pointers as referring to I/O mapped memory where they ought
to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O
mapped memory by using iowrite16 instead, and updates the pointer arithmetic
accordingly to take into account that the pointers are now
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1
(different address spaces)
drivers/staging/sm750fb/sm750.c:490:17: warning:
This patch declares externally unavailable functions static. This fixes
the following sparse warnings:-
drivers/staging/sm750fb/ddk750_swi2c.c:223:6: warning: symbol 'swI2CStart' was
not declared. Should it be static?
drivers/staging/sm750fb/ddk750_swi2c.c:234:6: warning: symbol 'swI2CStop' was
This patch fixes following sparse warning
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol
'ieee80211_check_auth_response' was not declared. Should it be static?
Signed-off-by: Vibi Sreenivasan vibisreeniva...@linuxmail.org
---
On Wed, Mar 18, 2015 at 01:17:17PM +0300, Dan Carpenter wrote:
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote:
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse
On Wed, Mar 18, 2015 at 10:46:52AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:17, Dan Carpenter dan.carpen...@oracle.com wrote:
Why is there a RESEND in the subject.
To avoid confusion (and Sudip explicitly mentioned there might be
some), and in addition I had to update my patch
On 18 March 2015 at 10:59, Dan Carpenter dan.carpen...@oracle.com wrote:
Btw, sorry for coming down hard on you. You're a newbie and expected to
make these mistakes. Your patches are good and appreciated.
Thanks and no problem, I expect to receive robust criticism given the
high standards in
Hello,
My name is Lina duc Kien,the daughter of Nguyen Duc Kien.I look very good
before writing you and I am sorry i do not write english good.I want to know
if there is chance or project i can make with you in your country.why i am
asking was that my father who co-founded the Asia Commercial
Hello,
My name is Lina duc Kien,the daughter of Nguyen Duc Kien.I look very good
before writing you and I am sorry i do not write english good.I want to know
if there is chance or project i can make with you in your country.why i am
asking was that my father who co-founded the Asia Commercial
Lorenzo Stoakes lstoa...@gmail.com writes:
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1
(different address spaces)
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
ERROR is reported by scripts/checkpatch.pl (spaces are missing after
','). This coding style problem was there before your patch but I don't
think it makes sense to preserve it.
[snip]
WARNING: please, no spaces at the
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
ERROR is reported by scripts/checkpatch.pl (spaces are missing after
','). This coding style problem was there before your patch but I don't
think it makes
On Tue, Mar 10, 2015 at 12:02:05PM -0300, Mario J. Rugiero wrote:
Replace __attribute__(packed) by __packed as suggested by checkpatch.
Signed-off-by: Mario J. Rugiero mrugi...@gmail.com
---
.../include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
On 18 March 2015 at 07:52, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
your series is not applying anymore to linux-next.
looks like some patches came from the Outreachy and were already
applied.
please redo it against staging-testing.
Will do that now! I think at this point it'll be
On 18 March 2015 at 10:52, Dan Carpenter dan.carpen...@oracle.com wrote:
I often say don't resend because something is minor and I don't want
to slow you down but since you were resending it anyway then please fix
it. Also changelogs are really easy to fix. In mutt, you can do it
without
The semantic patch that makes this change is available
in scripts/coccinelle/api/kstrdup.cocci
Signed-off-by: Abdul Hussain S hussain.ab...@outlook.com
---
drivers/staging/i2o/memory.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/i2o/memory.c
Hello,
My name is Lina duc Kien,the daughter of Nguyen Duc Kien.I look very good
before writing you and I am sorry i do not write english good.I want to know
if there is chance or project i can make with you in your country.why i am
asking was that my father who co-founded the Asia Commercial
This patch fixes the no spaces and indent warnings identified by the
checkpath.pl script for the entire ddk750_chip.c file by using
appropriate tab spaces and indents accordingly.
Signed-off-by: Ragavendra Nagraj ragavendra...@gmail.com
---
Changes in v5:
- Created patch for latest staging-next
Why is there a RESEND in the subject.
On Wed, Mar 18, 2015 at 08:57:22AM +, Lorenzo Stoakes wrote:
This patch uses memset_io instead of memset when using memset on __iomem
qualified pointers. This fixes the following sparse warnings:-
drivers/staging/sm750fb/sm750.c:489:17: warning:
On Tue, Mar 10, 2015 at 12:02:04PM -0300, Mario J. Rugiero wrote:
Replace uses of __attribute__(aligned(size)) by __aligned(size), as suggested
by checkpatch.
Signed-off-by: Mario J. Rugiero mrugi...@gmail.com
---
drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
1
On 18 March 2015 at 10:17, Dan Carpenter dan.carpen...@oracle.com wrote:
Why is there a RESEND in the subject.
To avoid confusion (and Sudip explicitly mentioned there might be
some), and in addition I had to update my patch series to take into
account that it no longer applied due to another
On 18 March 2015 at 10:18, Dan Carpenter dan.carpen...@oracle.com wrote:
This changelog still sucks. It doesn't describe the effect of this
behavior change for the user. It doesn't even make it clear that you
are aware that this is a behavior change.
It doesn't say to me that you have
On Wed, Mar 18, 2015 at 10:44:53AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:18, Dan Carpenter dan.carpen...@oracle.com wrote:
This changelog still sucks. It doesn't describe the effect of this
behavior change for the user. It doesn't even make it clear that you
are aware
On Wed, Mar 18, 2015 at 04:23:39PM +0300, Dan Carpenter wrote:
https://lkml.org/lkml/2015/3/10/685
You were making random white space changes and not on the same line. It
was hard to review because you had to count how many u32 arguments there
were (a million) and really look at it to
On Wed, Mar 18, 2015 at 02:43:01PM +0100, Quentin Lambert wrote:
On 18/03/2015 14:36, Dan Carpenter wrote:
This changelog still doesn't make sense so I took a look at the code.
tty_ldisc_deref() is an unlock function. So this is a lock ordering
bug. What makes you think the original
On Wed, Mar 18, 2015 at 02:25:09PM +0300, Dan Carpenter wrote:
On Wed, Mar 18, 2015 at 11:12:20AM +, Lorenzo Stoakes wrote:
On 18 March 2015 at 10:50, Vitaly Kuznetsov vkuzn...@redhat.com wrote:
If it's a white space thing on the same line then it's generally ok to
fix it. The one thing
On 18/03/2015 14:36, Dan Carpenter wrote:
This changelog still doesn't make sense so I took a look at the code.
tty_ldisc_deref() is an unlock function. So this is a lock ordering
bug. What makes you think the original ordering was correct? Who
reported this bug? What are the effects of
On Wed, Mar 18, 2015 at 09:30:24AM -0300, Mario J. Rugiero wrote:
I didn't expect that. Maybe I used the wrong linux-next?
Just to make sure, what should I be making the patches against? I made them
against the latest next branch I was able to find on Linus tree, is that
right?
linux-next is
This patch has no changelog. What's the bug?
On Wed, Mar 18, 2015 at 01:51:52PM +0100, Quentin Lambert wrote:
Fixes: c84a083b995b (Staging: dgnc: Use goto for spinlock release before
return)
Don't put a blank line here.
Signed-off-by: Quentin Lambert lambert.quen...@gmail.com
regards,
Prezado usuário
Seu e-mail excedeu 2 GB criado pelo webmaster, você está atualmente
rodando a 2,30 GB, que não pode enviar ou receber mensagem nova dentro o
próximo 24 horas até que você verificar que a conta de e-mail.
Por favor, digite seus dados abaixo para verificar a sua conta:
(1)
I didn't expect that. Maybe I used the wrong linux-next?
Just to make sure, what should I be making the patches against? I made
them against the latest next branch I was able to find on Linus tree, is
that right?
___
devel mailing list
The refactoring intrduced in
c84a083b995b (Staging: dgnc: Use goto for spinlock release before return)
inverts the order in which the lock is released and ld is tested for nullity.
This patch restores the execution flow.
Fixes: c84a083b995b (Staging: dgnc: Use goto for spinlock release before
On Wed, Mar 18, 2015 at 02:21:08PM +0100, Quentin Lambert wrote:
The refactoring intrduced in
c84a083b995b (Staging: dgnc: Use goto for spinlock release before return)
inverts the order in which the lock is released and ld is tested for nullity.
This patch restores the execution flow.
Fixes: c84a083b995b (Staging: dgnc: Use goto for spinlock release before
return)
Signed-off-by: Quentin Lambert lambert.quen...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c
OK, I'll do that, thanks.
Mario.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 18/03/2015 14:54, Dan Carpenter wrote:
On Wed, Mar 18, 2015 at 02:43:01PM +0100, Quentin Lambert wrote:
On 18/03/2015 14:36, Dan Carpenter wrote:
This changelog still doesn't make sense so I took a look at the code.
tty_ldisc_deref() is an unlock function. So this is a lock ordering
On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote:
This file contained a warning of a line being over 80 characters and
so the file has been edited to remove that warning.
Signed-off-by: Amitoj Kaur Chawla amitoj1...@gmail.com
Why did you put the driver name within the
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Wednesday, March 18, 2015 12:27 AM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; Nick Meier
Subject: Re: [PATCH
This file contained a warning of a line being over 80 characters and
so the file has been edited to remove that warning.
Signed-off-by: Amitoj Kaur Chawla amitoj1...@gmail.com
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Mon, Feb 16, 2015 at 12:14:09AM +0700, Tan Nguyen wrote:
Added one line after variable declaration.
Signed-off-by: Tan Nguyen tan@gmail.com
---
drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 +
1 file changed, 1 insertion(+)
Patch does not apply to my tree, someone
I don't know anyone with this hardware who can test a patch. If you
find someone then you should send a patch to reorder the other original
unlock and deref.
Otherwise, I would just leave it alone for now.
regards,
dan carpenter
___
devel mailing
This file contained a lot of warnings of line of over 80 characters
and that the code needs to be refactored due to nested if else
conditions.
The file was accordingly edited to remove some of the warnings.
Signed-off-by: Amitoj Kaur Chawla amitoj1...@gmail.com
---
Hi,
On Wed, Mar 18, 2015 at 08:12:32PM +0530, Amitoj Kaur Chawla wrote:
This file contained a warning of a line being over 80 characters and
so the file has been edited to remove that warning.
Signed-off-by: Amitoj Kaur Chawla amitoj1...@gmail.com
---
This patch is a continuation of the rescind handling cleanup work. We cannot
block in the global message handling work context especially if we are blocking
waiting for the host to wake us up. I would like to thank
Dexuan Cui de...@microsoft.com for observing this problem.
The current char-next
Export the vmbus_sendpacket_pagebuffer_ctl() interface. This export will be
used by the netvsc driver.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/hv/channel.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
From: Dan Carpenter dan.carpen...@oracle.com
The indenting makes it clear that there were curly braces intended here.
Fixes: 2dd37cb81580 ('Drivers: hv: vmbus: Handle both rescind and offer
messages in the same context')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: K. Y.
From: Dexuan Cui de...@microsoft.com
Without this patch, hv_fcopy_daemon's hv_copy_data() - pwrite()
will fail for 2GB file offset.
The current char-next branch is broken and this patch fixes
the bug.
Signed-off-by: Alex Ng ale...@microsoft.com
Signed-off-by: Dexuan Cui de...@microsoft.com
Cc:
From: Vaughan Cao vaughan@oracle.com
If freeze fails, vss_operate will re-enter itself to thaw. But it forgets
to call endmntent() before it recalls setmntent() again.
Signed-off-by: Vaughan Cao vaughan@oracle.com
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
From: Vitaly Kuznetsov vkuzn...@redhat.com
Memory blocks can be onlined in random order. When this order is not natural
some memory pages are not onlined because of the redundant check in
hv_online_page().
Here is a real world scenario:
1) Host tries to hot-add the following (process_hot_add):
From: Nick Meier nme...@microsoft.com
HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context,
the value may be truncated. This patch is in response from the following
email from Wu Fengguang fengguang...@intel.com:
From: Wu Fengguang fengguang...@intel.com
Subject:
From: Roberto Medina robertox...@gmail.com
Coding style fixes due to exported symbols and comment style.
Signed-off-by: Roberto Medina robertox...@gmail.com
---
.../lustre/lustre/libcfs/linux/linux-prim.c| 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
From: Vitaly Kuznetsov vkuzn...@redhat.com
When add_memory() fails the following BUG is observed:
[ 743.646107] hv_balloon: hot_add memory failed error is -17
[ 743.679973]
[ 743.680930] =
[ 743.680930] [ BUG: bad unlock balance detected! ]
[ 743.680930]
Handle the case when the write to the ringbuffer fails. In this case,
unconditionally signal the host. Since we may have deferred signalling
the host based on the kick_q parameter, signalling the host
unconditionally in this case deals with the issue.
Signed-off-by: K. Y. Srinivasan
When a channel has been rescinded, the close operation is a noop.
Restructure the code so we deal with the rescind condition after
we properly cleanup the channel. I would like to thank
Dexuan Cui de...@microsoft.com for observing this problem.
The current code leaks memory when the channel is
Some miscellaneous fixes to the vmbus driver and the balloon driver.
Currently the char-next tree is broken and some of the patches in this
set fix the issue.
In this version of the set, Nick has addressed review comments from Greg
on the patch:
This patch takes into account that cursor-vstart, crtc-vScreen and
share-pvMem are pointers to memory-mapped I/O and thus we should use memset_io
to make this explicit. In addition, some architectures require special treatment
of memory-mapped I/O so the previous code could actually break without
On 18 March 2015 at 11:25, Dan Carpenter dan.carpen...@oracle.com wrote:
Could you read your patches again and find other similar white space
issues.
Done.
Best,
--
Lorenzo Stoakes
https:/ljs.io
___
devel mailing list
de...@linuxdriverproject.org
On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote:
From: Nick Meier nme...@microsoft.com
HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context,
the value may be truncated. This patch is in response from the following
email from Intel:
Subject should
On Tue, Mar 17, 2015 at 05:41:56PM -0700, K. Y. Srinivasan wrote:
From: Nick Meier nme...@microsoft.com
HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context,
the value may be truncated. This patch is in response from the following
email from Intel:
from Intel: is
On Mon, Mar 16, 2015 at 10:16:09PM -0700, Ragavendra Nagraj wrote:
This patch fixes the no spaces and indent warnings identified by the
checkpath.pl script for the entire ddk750_chip.c file by using
appropriate tab spaces and indents accordingly.
your patch is no longer applying to linux-next.
On Wed, Mar 11, 2015 at 03:03:39PM +, Lorenzo Stoakes wrote:
On 11 March 2015 at 14:58, Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
I am more than happy to resend the whole series as necessary if that
makes it easier for Greg or anyone else :) I have previously
resubmitted an
Minor changes to remove extra parenthesis
Signed-off-by: Janakarajan Natarajan janakaraj...@gmail.com
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +-
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wed, 18 Mar 2015, Patrick Farrell wrote:
Uck, my reply made the formatting even worse. I'm trying to say it should
look like this:
+rc = ll_intent_file_open(file-f_path.dentry,
+NULL, 0, it);
Not like this:
+rc
This patch annotates pointers as referring to I/O mapped memory where they ought
to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O
mapped memory by using iowrite16 instead, and updates the pointer arithmetic
accordingly to take into account that the pointers are now
This patch fixes these sparse warnings:
drivers/staging/fbtft/fbtft-sysfs.c:23:5: warning: symbol
'fbtft_gamma_parse_str' was not declared. Should it be static?
drivers/staging/fbtft/fbtft-sysfs.c:153:6: warning: symbol
'fbtft_expand_debug_value' was not declared. Should it be static?
All other non ASCII names in this file are also UTF-8 encoded.
Signed-off-by: Baruch Siach bar...@tkos.co.il
---
I'm pretty sure this patch as it goes through the mail system will fail to
apply using 'git am', because the email encoding is not well defined, but the
intention is clear.
---
Hi,
On Wed, Mar 18, 2015 at 10:18:29PM +0530, Amitoj Kaur Chawla wrote:
This file contained a lot of warnings of line of over 80 characters
and that the code needs to be refactored due to nested if else
conditions.
The file was accordingly edited to remove some of the warnings.
Perhaps this is just a formatting error in my email client, but
shouldn't NULL be one more space over to line up with the '(' above?
On 03/18/2015 02:08 PM, p...@amd48-systeme.lip6.fr wrote:
+ rc = ll_intent_file_open(file-f_path.dentry,
+
Uck, my reply made the formatting even worse. I'm trying to say it
should look like this:
+rc = ll_intent_file_open(file-f_path.dentry,
+NULL, 0, it);
Not like this:
+rc = ll_intent_file_open(file-f_path.dentry,
+
On 18 March 2015 at 10:59, Dan Carpenter dan.carpen...@oracle.com wrote:
Call it a v2 patch. Put a note under the --- cut off line:
v2: updated to apply to latest linux-next
http://kernelnewbies.org/PatchTipsAndTricks
Since each changed patch in the resend already incorporates changes to
Several warnings and errors of coding style rules corrected.
Compile tested.
Signed-off-by: Pierre-Yves Péneau pierre-yves.pen...@gmx.com
---
drivers/staging/lustre/lustre/llite/file.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Fix your email client From header to use your full name.
The subject is very vague.
On Wed, Mar 18, 2015 at 08:08:48PM +0100, p...@amd48-systeme.lip6.fr wrote:
Several warnings and errors of coding style rules corrected.
Which?
Compile tested.
Put this under the --- cut off.
regards,
dan
Errors and warnings of coding style rules corrected.
Signed-off-by: Guillaume Turchini guillaume.turch...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
If the hypervisor supports MSR based access to the APIC registers
(EOI, TPR and ICR), implement the MSR based access.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
Changes from V1: Addressed comments from Ingo Molnar
mingo.kernel@gmail.com
arch/x86/kernel/cpu/mshyperv.c | 62
Minor change to convert if-else to if statement
Signed-off-by: Janakarajan Natarajan janakaraj...@gmail.com
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
Merges variable declaration and definition.
Signed-off-by: Janakarajan Natarajan janakaraj...@gmail.com
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
Minor change to remove {} for single line if statements
Signed-off-by: Janakarajan Natarajan janakaraj...@gmail.com
---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
Minor changes to fix ft1000 driver checkpatch.pl warnings
Janakarajan Natarajan (5):
Drivers: Staging: ft1000: Single line if-statement changes
Drivers: Staging: ft1000: Fix extra parenthesis warnings
Drivers: Staging: ft1000: Refactoring if-else statement
Drivers: Staging: ft1000: Fix
Replaces asm/io.h and asm/bitops.h with linux/io.h and linux/bitops.h
Signed-off-by: Janakarajan Natarajan janakaraj...@gmail.com
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Wed, Mar 18, 2015 at 09:11:22PM +0100, Guillaume Turchini wrote:
Errors and warnings of coding style rules corrected.
You need to be a bit more specific and say what exact errors and
warnings were fixed. And please only fix one type of error or warning
per patch you send out. This patch
On Wed, Mar 18, 2015 at 07:22:49PM +0100, Roberto Medina wrote:
From: Roberto Medina robertox...@gmail.com
Coding style fixes due to exported symbols and comment style.
Signed-off-by: Roberto Medina robertox...@gmail.com
As we spoke in person, it's best to do only one logical thing per
83 matches
Mail list logo
