This is supposed to be -rates_ex[] instead of -rates[]. I found this
because static checkers complain than -rates is too small so we're
reading beyond the end of the array. It has 12 elements instead of 15.
This bug was apparently copy and pasted from ipw2x00. I fixed it before
in that driver
On 30/03/15 17:47, Hartley Sweeten wrote:
On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote:
`comedi_event()` is called from low-level drivers to handle comedi
asynchronous command event flags. As a safety check, it checks the
subdevice's run flags to make sure an asynchronous command is
On Wed, Apr 01, 2015 at 09:09:26AM +0530, Sudip Mukherjee wrote:
On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning:
On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning:
symbol 'ieee80211_check_auth_response' was not declared. Should it be
On Tuesday, March 31, 2015 2:43 AM, Ian Abbott wrote:
On 30/03/15 17:47, Hartley Sweeten wrote:
On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote:
`comedi_event()` is called from low-level drivers to handle comedi
asynchronous command event flags. As a safety check, it checks the
From: Vitaly Kuznetsov vkuzn...@redhat.com
'Drivers: hv: hv_balloon: refuse to balloon below the floor' fix does not
correctly handle the case when val.freeram num_pages as val.freeram is
__kernel_ulong_t and the 'val.freeram - num_pages' value will be a huge
positive value instead of being
From: Vitaly Kuznetsov vkuzn...@redhat.com
balloon_wrk.num_pages is __u32 and it comes from host in struct dm_balloon
where it is also __u32. We, however, use 'int' in balloon_up() and in case
we happen to receive num_pagesINT_MAX request we'll end up allocating zero
pages as 'num_pages
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Mar 26, 2015 at 08:16:14PM -0700, Janakarajan Natarajan wrote:
I resent v2 because I didn't know if my previous patchset had been accepted or
not.
Then it's really not a 'v2' patch series,
PATCH 1/2 addresses a real issue introduced by the 'Drivers: hv: hv_balloon:
refuse to balloon below the floor' fix,
PATCH 2/2 addresses a currently impossible issue (as Hyper-V host never asks
to balloon more than INT_MAX pages) and is rather a cleanup. The patch is
supposed to be applied on
On Tue, Mar 31, 2015 at 10:14:54AM +0300, Dan Carpenter wrote:
On Mon, Mar 30, 2015 at 05:05:36PM -0600, Eddie Kovsky wrote:
Change function definition to static, move the function further up in
the file, and delete the function prototype.
This fixes the following warning generated by
From: K. Y. Srinivasan k...@microsoft.com
Date: Sun, 29 Mar 2015 21:07:58 -0700
The network protocol used to communicate with the host is the remote ndis
(rndis)
protocol. We need to decorate each outgoing packet with a rndis header and
additional rndis state (rndis per-packet state). To
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol
'ieee80211_check_auth_response' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky e...@edkovsky.org
---
Fix checkpatch warnings 'else is not generally useful after a break or return'
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 72 +++---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 10 +-
Fix 'braces {} are not necessary for single statement blocks'
checkpatch.pl warning
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Fix 'void function return statements are not generally useful'
checkpatch.pl warnings
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 --
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 8
Fix 'do {} while (0) macros should not be semicolon terminated'
checkpatch.pl warning
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Move authentication response processing to rtllib_rx_auth_resp() function.
No logic is affected.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_softmac.c | 112 --
1 file changed, 58 insertions(+), 54 deletions(-)
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_softmac.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
b/drivers/staging/rtl8192e/rtllib_softmac.c
Return from rtllib_rx_auth_resp() if auth_parse() fails.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_softmac.c | 89 ---
1 file changed, 45 insertions(+), 44 deletions(-)
diff --git
Remove commented-out code
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c| 3 +--
drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 7 ---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 5 +
On Mar 31, 2015, at 11:57 AM, gre...@linuxfoundation.org wrote:
On Tue, Mar 31, 2015 at 05:15:23PM +0200, Julia Lawall wrote:
On Tue, 31 Mar 2015, Dhere, Chaitanya (C.) wrote:
This patch replaces kzalloc and copy_from_user with memdup_user call
This change was detected with coccinelle tool
Fix 'Avoid unnecessary line continuations' checkpatch.pl warning
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
22 matches
Mail list logo
