Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c

2015-04-20 Thread Gbenga Adalumo
The patch fixes a trailing whitespace and code indenting coding style errors as reported by checkpatch.pl tool. Details of the lines where the fixed errors were reported are as follows: drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace

[PATCH] staging: gdm72xx: enclose complex define statement

2015-04-20 Thread Jaime Arrocha
This patch fixes the warning found by checkpatch.pl: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Jaime Arrocha j...@kerneldev.net --- drivers/staging/gdm72xx/usb_ids.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

our email marketing

2015-04-20 Thread Louis
Hope you are doing well! We specialize in providing email marketing services to a number of businesses. We would like to be your marketing partners and help your business reach the next level. We can increase your business sales 2-4 times than before. Please contact us if you would require more

our email marketing

2015-04-20 Thread Louis
Hope you are doing well! We specialize in providing email marketing services to a number of businesses. We would like to be your marketing partners and help your business reach the next level. We can increase your business sales 2-4 times than before. Please contact us if you would require more

Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences.

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 11:58:53PM +0200, Yorick Rommers wrote: Hello Joe, Thank you once again for the feedback. I've changed my patch accordingly, see below. -- The patch is nice except for this chunk. And also you should be putting version numbers

Re: gcc doesn't warn about uninitialized variable use in switch/case with -O (was: Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences)

2015-04-20 Thread Joe Perches
On Mon, 2015-04-20 at 03:42 -0700, Joe Perches wrote: On Mon, 2015-04-20 at 11:33 +0300, Dan Carpenter wrote: You would hope that GCC would warn about the uninitialized variable but it doesn't. That's odd. So I filed this new gcc bugzilla:

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 05:43:51PM -0300, Gaston Gonzalez wrote: Silence the following sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:184:16: warning: cast to restricted __le16 We have a tkip_mixing_phase2() function in net/mac80211/tkip.c. That's probably the

[PATCH] Staging: dgnc: Using a temporary value for repeated dereferences.

2015-04-20 Thread Yorick Rommers
Sorry, it has been changed in the patch below. --- A patch for a line being too long (80) in dgnc_mgmt.c, fixed by making a temporary value for dgnc_Board[brd], replacing all instanced of dgnc_Board[brd] with temporary value, and removing unnecessary

Re: [PATCH 5/5] Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state

2015-04-20 Thread Vitaly Kuznetsov
Vitaly Kuznetsov vkuzn...@redhat.com writes: K. Y. Srinivasan k...@microsoft.com writes: Implement the protocol for tearing down the monitor state established with the host. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Unfortunatelly this patch leads to the following crash:

Re: [PATCH 2/2] Staging: dgnc: fixed code style issues, mainly line width issues.

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 02:04:39AM +0200, Yorick Rommers wrote: A patch for dgnc_mgmt.c and dgnc_neo.c to fix some code style issues. Signed-off-by: Yorick Rommers yorick-romm...@hotmail.com --- drivers/staging/dgnc/dgnc_mgmt.c | 4 +- drivers/staging/dgnc/dgnc_neo.c | 210

gcc doesn't warn about uninitialized variable use in switch/case with -O (was: Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences)

2015-04-20 Thread Joe Perches
On Mon, 2015-04-20 at 11:33 +0300, Dan Carpenter wrote: You would hope that GCC would warn about the uninitialized variable but it doesn't. That's odd. So I filed this new gcc bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65812) gcc 4.9.1 doesn't warn about uninitialized variable use

Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c

2015-04-20 Thread Alan Cox
On Sat, 2015-04-18 at 22:12 +0200, Yorick Rommers wrote: From: Yorick yorick-romm...@hotmail.com This is a patch that fixes errors regarding whitespaces and split strings. Wouldn't worry. The i2o layer is in staging because it is about to be dropped from the kernel unless someone steps up to

Re: [PATCH] Staging: dgnc: fixed code style issue

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 09:18:23PM +0200, Yorick Rommers wrote: A patch for a line being too long (80) in dgnc_mgmt.c, fixed by making a temporary value for dgnc_Board[brd], and removing an unnecessary typecast. Signed-off-by: Yorick Rommers yorick-romm...@hotmail.com ---

Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences.

2015-04-20 Thread Dan Carpenter
On Sun, Apr 19, 2015 at 05:54:19PM -0700, Joe Perches wrote: diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index b13318a..0437117 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -131,6 +131,7 @@ long

Re: [PATCH] Staging: i2o: fixed various code style issues in i2o_block.c

2015-04-20 Thread Dan Carpenter
On Sat, Apr 18, 2015 at 10:12:14PM +0200, Yorick Rommers wrote: From: Yorick yorick-romm...@hotmail.com Don't include a From: unless you are sending a patch someone else wrote. Otherwise we prefer to get it from your email From. Also you forgot your last name. @@ -488,8 +488,8 @@ static int

Re: [PATCH 5/5] Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state

2015-04-20 Thread Vitaly Kuznetsov
K. Y. Srinivasan k...@microsoft.com writes: Implement the protocol for tearing down the monitor state established with the host. Signed-off-by: K. Y. Srinivasan k...@microsoft.com Unfortunatelly this patch leads to the following crash: pre-udev:/# modprobe hv_vmbus modprobe hv_vmbus [

RE: [PATCH 5/5] Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state

2015-04-20 Thread KY Srinivasan
-Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Monday, April 20, 2015 2:40 AM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com

Re: [PATCH 5/5] Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state

2015-04-20 Thread Vitaly Kuznetsov
KY Srinivasan k...@microsoft.com writes: -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Monday, April 20, 2015 2:40 AM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;

RE: [PATCH 5/5] Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state

2015-04-20 Thread KY Srinivasan
-Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Monday, April 20, 2015 7:17 AM To: KY Srinivasan Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com

Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c

2015-04-20 Thread Greg KH
On Sun, Apr 19, 2015 at 07:59:31PM -0700, Gbenga Adalumo wrote: Fix coding style errors found by checkpatch.pl tool What errors? Be specific. ___ devel mailing list de...@linuxdriverproject.org

[PATCH 2/3] staging: comedi: ni_nio_common: don't write non-existing caldac's

2015-04-20 Thread H Hartley Sweeten
ni_write_caldac() checks the boardinfo 'caldac' array to determine what caldac is used for a given 'addr'. It then calculates the 'bitstring' and number of 'bits' used to write a value to that caldac address. After checking the caldac array, if the number of bits is 0 there is no caldac

[PATCH 3/3] staging: comedi: serial2002: fix Coverity Explicit null dereference

2015-04-20 Thread H Hartley Sweeten
serial2002_setup_subdevices() initializes each subdevice based on the config read from the attached serial device. Part of this initialization is to setup the subdevice range_table_list for the non digital subdevices. The range_table_list is allocated only when a 'range' is passed to the

[PATCH 1/3] staging: comedi: comedi_bond: fix 'b_mask' calc in bonding_dio_insn_bits()

2015-04-20 Thread H Hartley Sweeten
'b_chans' may be a valud up to 32. 'b_mask' is an unsigned int and a left shift of more than 31 bits has undefined behavior. Fix the calc so it works correctly with a 'b_chans' of 32.. Reported-by: coverity (CID 1192244) Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian

[PATCH 0/3] staging: comedi: Coverity fixes

2015-04-20 Thread H Hartley Sweeten
Fix a couple issues reported by Coverity. H Hartley Sweeten (3): staging: comedi: comedi_bond: fix 'b_mask' calc in bonding_dio_insn_bits() staging: comedi: ni_nio_common: don't write non-existing caldac's staging: comedi: serial2002: fix Coverity Explicit null dereference

[PATCH 3/5] hv: vmbus_free_channels(): remove the redundant free_channel()

2015-04-20 Thread K. Y. Srinivasan
From: Dexuan Cui de...@microsoft.com free_channel() has been invoked in vmbus_remove() - hv_process_channel_removal(), or vmbus_remove() - ... - vmbus_close_internal() - hv_process_channel_removal(). We also change to use list_for_each_entry_safe(), because the entry is removed in

[PATCH 1/5] Drivers: hv: vmbus: introduce vmbus_acpi_remove

2015-04-20 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov vkuzn...@redhat.com In case we do request_resource() in vmbus_acpi_add() we need to tear it down to be able to load the driver again. Otherwise the following crash in observed when hv_vmbus unload/load sequence is performed on a Generation2 instance: [ 38.165701] BUG:

[PATCH 0/5] Drivers: hv: vmbus: Cleanup the vmbus unload path

2015-04-20 Thread K. Y. Srinivasan
This patch-set have several fixes to enable the clean unload of the vmbus. Typically, vmbus will not be unloadable when Linux is hosted on Hyper-V since the driver managing the root device needs the vmbus driver. Dexuan Cui (1): hv: vmbus_free_channels(): remove the redundant free_channel() K.

[PATCH 2/5] Drivers: hv: vmbus: unregister panic notifier on module unload

2015-04-20 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov vkuzn...@redhat.com Commit 96c1d0581d00f7abe033350edb021a9d947d8d81 (Drivers: hv: vmbus: Add support for VMBus panic notifier handler) introduced atomic_notifier_chain_register() call on module load. We also need to call atomic_notifier_chain_unregister() on module unload

[PATCH 5/5] Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state

2015-04-20 Thread K. Y. Srinivasan
Implement the protocol for tearing down the monitor state established with the host. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/hv/channel_mgmt.c | 25 + drivers/hv/connection.c |5 + drivers/hv/hyperv_vmbus.h |2 ++

[PATCH 4/5] drivers: hv: vmbus: Get rid of some unused definitions

2015-04-20 Thread K. Y. Srinivasan
Get rid of some unused definitions. Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- include/linux/hyperv.h | 19 --- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 1744148..e29ccdd 100644 ---