[PATCH] staging: gsc_hdpi: Remove dead code

2015-04-23 Thread Gujulan Elango, Hari Prasath (H.)
This patch removes commented code from this driver. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/comedi/drivers/gsc_hpdi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.c b/drivers/staging/comedi/drivers/gsc_hpdi.c index 3cb6

Re: [PATCH v2] Staging: rtl8712: Removed unused return variable

2015-04-23 Thread Sudip Mukherjee
On Thu, Apr 23, 2015 at 03:00:14PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > This patch removes unused return variable in this file. > > Signed-off-by: Gnanachandran Dhanapal > --- your From: name and Signed-off-by: name is not matching. regards sudip

Re: [PATCH 1/2] vfs: export symbol 'getname' and 'putname'

2015-04-23 Thread Drokin, Oleg
On Apr 22, 2015, at 3:34 AM, Christoph Hellwig wrote: > On Wed, Apr 22, 2015 at 06:49:08AM +, Drokin, Oleg wrote: >> I know this is not going to be a popular opinion with you, but sometimes >> opening a file >> is just too expensive. 1 RPC roudntrip to open a file and then another one >> to

[PATCH] staging: sm750fb: cleanup white space and indent

2015-04-23 Thread Charles Rose
This patch fixes "space prohibited" errors reported by checkpatch.pl and related indentation. The module builds without error. Signed-off-by: Charles Rose --- drivers/staging/sm750fb/ddk750_chip.c | 12 ++-- drivers/staging/sm750fb/ddk750_mode.c | 26 +- drivers

[PATCH 2/2] staging: emxx_udc: Remove dead code

2015-04-23 Thread Gujulan Elango, Hari Prasath (H.)
This patch removes few lines of commented code. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/emxx_udc/emxx_udc.c | 33 - 1 file changed, 33 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c inde

[PATCH 1/2] staging: emxx_udc : remove stray semicolon

2015-04-23 Thread Gujulan Elango, Hari Prasath (H.)
This patch removes a stray semicolon around closing brace of an if code block. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/em

Re: [PATCH v2] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Greg Kroah-Hartman
On Thu, Apr 23, 2015 at 08:47:15PM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `fbtft_framebuffer_alloc': > (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' > > As DMA support is already optional, make it depend on HAS_DMA. > > If !HA

[PATCH] staging: comedi: Remove unwanted lines of code

2015-04-23 Thread Gujulan Elango, Hari Prasath (H.)
This patch removes a few lines of code & retains the same functionality Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/comedi/drivers/cb_pcimdda.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c b/drivers/stagi

[PATCH v2] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `fbtft_framebuffer_alloc': (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' As DMA support is already optional, make it depend on HAS_DMA. If !HAS_DMA, "dma" will always be false, and the compiler will optimize away the call to d

Re: [PATCH] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Geert Uytterhoeven
On Thu, Apr 23, 2015 at 8:27 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 23, 2015 at 08:06:52PM +0200, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> drivers/built-in.o: In function `fbtft_framebuffer_alloc': >> (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' >> >> As DMA s

Re: [PATCH] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Greg Kroah-Hartman
On Thu, Apr 23, 2015 at 08:06:52PM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `fbtft_framebuffer_alloc': > (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' > > As DMA support is already optional, make it depend on HAS_DMA. > > Signed

[PATCH] staging: fbtft: Disable DMA support if DMA is not available

2015-04-23 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `fbtft_framebuffer_alloc': (.text+0xb53cae): undefined reference to `dmam_alloc_coherent' As DMA support is already optional, make it depend on HAS_DMA. Signed-off-by: Geert Uytterhoeven --- drivers/staging/fbtft/fbtft-core.c | 4 1 fil

Re: [PATCH v2] Staging: rtl8712: Removed unused return variable

2015-04-23 Thread Dan Carpenter
This patch is a coccinelle thing, the reasoning behind it is that literals are more clear than variables. return status; <-- Ambiguous. This could be returning anything, you have to look at the context. return 0; <-- Clear. regards, dan carpenter ___

Re: [PATCH v2] Staging: rtl8712: Removed unused return variable

2015-04-23 Thread Larry Finger
On 04/23/2015 10:00 AM, DHANAPAL, GNANACHANDRAN (G.) wrote: This patch removes unused return variable in this file. You should hold off with V2 to give others a chance to comment. Your commit message does not exactly describe what is happening. The return variable is not unused. More accurate

答复: 答复: [PATCH] staging: sm750: Fix the Makefile option error

2015-04-23 Thread Teddy Wang 王力强
Hi Huacai, Both SM750 driver can support boot logo. The boot logo display is not related to the display driver. Best Regards, Teddy Wang -邮件原件- 发件人: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] 发送时间: 2015年4月23日 21:16 收件人: 陈华才 抄送: Teddy Wang 王力强; Binbin Zhou; Greg Kroah-Hartman

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-04-23 Thread Alan Cox
On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.) wrote: > This patch removes unwanted semicolon around close braces of code blocks The i2o driver moved into staging ready to be deleted unless someone steps up with hardware willing to maintain it (which is rather unlikely). No

[PATCH v2] Staging: rtl8712: Removed unused return variable

2015-04-23 Thread DHANAPAL, GNANACHANDRAN (G.)
This patch removes unused return variable in this file. Signed-off-by: Gnanachandran Dhanapal --- drivers/staging/rtl8712/os_intfs.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 6e776e5

RE: [PATCH] Staging: rtl8712: Removed unused variable

2015-04-23 Thread DHANAPAL, GNANACHANDRAN (G.)
Thanks for the feedback, Greg. I have sent patch set version 2 for the same changes. -Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: 23 April 2015 19:51 To: DHANAPAL, GNANACHANDRAN (G.) Cc: larry.fin...@lwfinger.net; florian.c.schilha...@goog

[PATCH] Staging: rtl8712: Removed unused variable

2015-04-23 Thread DHANAPAL, GNANACHANDRAN (G.)
This patch removes unused variable in this file. Signed-off-by: Gnanachandran Dhanapal Change-Id: I59cc869773d145239d62c3185018b275239fe812 --- drivers/staging/rtl8712/os_intfs.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/d

Re: [PATCH] Staging: rtl8712: Removed unused variable

2015-04-23 Thread gre...@linuxfoundation.org
On Thu, Apr 23, 2015 at 02:12:44PM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > This patch removes unused variable in this file. > > Signed-off-by: Gnanachandran Dhanapal > > Change-Id: I59cc869773d145239d62c3185018b275239fe812 The only thing I can do with a patch that has this line in it is de

[PATCH] staging: i2o: Remove unwanted semicolon

2015-04-23 Thread Gujulan Elango, Hari Prasath (H.)
This patch removes unwanted semicolon around close braces of code blocks Signed-off-by: Hari Prasath --- drivers/staging/i2o/iop.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/i2o/iop.c b/drivers/staging/i2o/io

[PATCH 1/2] staging: sm7xxfb: use framebuffer_alloc and release

2015-04-23 Thread Sudip Mukherjee
use the standard framebuffer_alloc() and framebuffer_release() instead of custom defined function. for making that change we had to change a member of the private structure from a variable to pointer and had to touch almost all places of the file. since fb was changed into a pointer so all instance

[PATCH 2/2] staging: sm7xxfb: remove unused functions

2015-04-23 Thread Sudip Mukherjee
removed the smtc_alloc_fb_info() and smtc_free_fb_info() functions which were not used anymore. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 32 1 file changed, 32 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/s

Re: 答复: [PATCH] staging: sm750: Fix the Makefile option error

2015-04-23 Thread Sudip Mukherjee
On Thu, Apr 23, 2015 at 10:29:48AM +0530, Sudip Mukherjee wrote: > On Thu, Apr 23, 2015 at 12:43:40PM +0800, 陈华才 wrote: > > Hi, Teddy, > > > > In the code It seems that only SM718/SM750 is supported in Sudip's driver. > > Hi Huacai, > > The driver that Teddy gave me originally was a mix driver o

[PATCH] staging: fsl-mc: Remove redundant initalization of the .owner field

2015-04-23 Thread Gujulan Elango, Hari Prasath (H.)
This patch removes the redundant static initialization of the .owner field from this driver as it is being overidden by the call from the platform driver register Signed-off-by: Hari Prasath --- drivers/staging/fsl-mc/bus/mc-bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/stagi