Re: [PATCH] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Gujulan Elango, Hari Prasath (H.)
On Thu, Apr 30, 2015 at 02:09:13PM -0500, Larry Finger wrote: On 04/30/2015 12:50 PM, Gujulan Elango, Hari Prasath (H.) wrote: From: Larry Finger larry.fin...@gmail.com on behalf of Larry Finger larry.fin...@lwfinger.net Sent: Thursday, April 30, 2015 11:03 PM To: Gujulan Elango, Hari

Re: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's

2015-05-04 Thread Dan Carpenter
On Thu, Apr 09, 2015 at 06:10:04PM -0700, Mitchel Humpherys wrote: We're currently using %lu and %ld to print some variables of type dma_addr_t, which results in the following warning when dma_addr_t is 64-bits wide: drivers/staging/android/ion/ion_chunk_heap.c: In function

Re: [PATCH] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Dan Carpenter
On Mon, May 04, 2015 at 07:21:52AM +, Gujulan Elango, Hari Prasath (H.) wrote: Please exuse me for the replies being screwed up. I just figured out how to reply to e-mails from Mutt.Hope you would be getting cleaner replies from now on. No problem. Please put line breaks at 72

Re: [PATCH] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Gujulan Elango, Hari Prasath (H.)
On Fri, May 01, 2015 at 10:46:53AM +0300, Dan Carpenter wrote: The subject says fix but this does not fix a run time bug, it just silences a warning. It's still the correct thing according to Larry so that's good. On Thu, Apr 30, 2015 at 12:06:28PM +, Gujulan Elango, Hari Prasath (H.)

[PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Gujulan Elango, Hari Prasath (H.)
This patch addresses a spatch warning on assigning a negative value to a unsigned integer.Similar patch has been submitted by Larry Finger earlier to silence the same spatch warning in another file. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- v2: Address Dan

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Dan Carpenter
On Mon, May 04, 2015 at 09:29:05AM +, Gujulan Elango, Hari Prasath (H.) wrote: This patch addresses a spatch warning on assigning a negative value to a unsigned integer.Similar patch has been submitted by Larry Finger earlier to silence the same spatch warning in another file. Or, more

[PATCH V5] staging: goldfish: Fix pointer cast for 32 bits

2015-05-04 Thread Peter Senna Tschudin
As the first argument of gf_write64() was of type unsigned long, and as some calls to gf_write64() were casting the first argument from void * to u64 the compiler and/or sparse were printing warnings for casts of wrong sizes when compiling for i386. This patch changes the type of the first

Re: [PATCH V5] staging: goldfish: Fix pointer cast for 32 bits

2015-05-04 Thread Dan Carpenter
Looks good. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-04 Thread Simmons, James A.
When is soon? How about, if I don't see some real work happening from you all in the next 2 months (i.e. before 4.1-final), I drop lustre from the tree in 4.2-rc1. Given that you all have had over 2 years to get your act together, and nothing has happened, I think I've been waiting

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-04 Thread Dan Carpenter
Email chopped up and responded to out of order. If this is acceptable to you it can be started right away. No one is going to approve your patches until you send them. Start and then we'll see. Send them in as they are ready so you don't get too far along and we ask you to redo everything.

Re: [PATCH] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Larry Finger
On 05/04/2015 02:21 AM, Gujulan Elango, Hari Prasath (H.) wrote: On Thu, Apr 30, 2015 at 02:09:13PM -0500, Larry Finger wrote: Please fix your mailer. The most recent material to which you were replying was not indented any levels, but the new material was 3 levels deep. It is extremely

[PATCH] staging/lustre: Always try kmalloc first for OBD_ALLOC_LARGE

2015-05-04 Thread green
From: Oleg Drokin gr...@linuxhacker.ru Create libcfs_kvzalloc and libcfs_kvzalloc_cpt that are designed to replace OBD_ALLOC_LARGE and OBD_CPT_ALLOC_LARGE. Not a drop-in replacement as they also take gfp flags armument for more flexibility. Signed-off-by: Oleg Drokin gr...@linuxhacker.ru ---

[PATCH] hv_netvsc: remove unused variable in netvsc_send()

2015-05-04 Thread Jerry Snitselaar
With commit b56fc3c53654 (hv_netvsc: Fix a bug in netvsc_start_xmit()), skb variable is no longer used in netvsc_send. Remove variable and dead code that depended on it. Cc: Haiyang Zhang haiya...@microsoft.com Cc: K. Y. Srinivasan k...@microsoft.com Signed-off-by: Jerry Snitselaar

[PATCH] staging: unisys: Disable driver for UML

2015-05-04 Thread Richard Weinberger
UML has no io memory nor cpuid. Let's disable this driver for UML. Fixes: drivers/staging/unisys/common-spar/include/iovmcall_gnuc.h: In function ‘__unisys_vmcall_gnuc’: drivers/staging/unisys/common-spar/include/iovmcall_gnuc.h:24:2: error: implicit declaration of function ‘cpuid’

[PATCH v4] staging: sm750fb: use arch_phys_wc_add() and ioremap_wc()

2015-05-04 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com The same area used for ioremap() is used for the MTRR area. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take

Re: [PATCH v3] staging: sm750fb: use arch_phys_wc_add() and ioremap_wc()

2015-05-04 Thread Luis R. Rodriguez
On Sun, May 03, 2015 at 09:24:59PM +0200, Greg KH wrote: On Tue, Apr 21, 2015 at 01:12:03PM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com The same area used for ioremap() is used for the MTRR area. Convert the driver from using the x86 specific MTRR code to

RE: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

2015-05-04 Thread Jose Rivera
Dan, Thanks for your comments. My replies inline. Thanks, German -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Thursday, April 30, 2015 6:50 AM To: Rivera Jose-B46482 Cc: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org;

RE: [PATCH 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC fw 7.0.0

2015-05-04 Thread Jose Rivera
-Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Thursday, April 30, 2015 7:13 AM To: Rivera Jose-B46482 Cc: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Yoder Stuart- B08248; Sharma

Re: [PATCHv2] staging: rtl8192e: fix wrong assignment

2015-05-04 Thread Mateusz Kulikowski
Hi, On 04.05.2015 11:29, Gujulan Elango, Hari Prasath (H.) wrote: This patch addresses a spatch warning on assigning a negative value to a unsigned integer.Similar patch has been submitted by Larry Finger earlier to silence the same spatch warning in another file. Signed-off-by: Hari

Re: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's

2015-05-04 Thread Colin Cross
On Mon, May 4, 2015 at 1:22 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Apr 09, 2015 at 06:10:04PM -0700, Mitchel Humpherys wrote: We're currently using %lu and %ld to print some variables of type dma_addr_t, which results in the following warning when dma_addr_t is 64-bits wide:

RE: [PATCH] hv_netvsc: remove unused variable in netvsc_send()

2015-05-04 Thread Haiyang Zhang
-Original Message- From: Jerry Snitselaar [mailto:jsnit...@redhat.com] Sent: Monday, May 4, 2015 10:57 AM To: linux-ker...@vger.kernel.org Cc: net...@vger.kernel.org; de...@linuxdriverproject.org; Haiyang Zhang; KY Srinivasan Subject: [PATCH] hv_netvsc: remove unused variable in