On Sat, 2015-05-09 at 23:18 +0200, Mateusz Kulikowski wrote:
> Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
> structures. Use ETH_ALEN as array length in places where it was hardcoded to
> 6.
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> b/driv
On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote:
> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
> Replace printk() with netdev_* if possible, pr_* in other cases.
> All pr_* use __func__ to easily trace message back to rtllib
It's more common to use %s: and not %s():
but i
On Sat, May 09, 2015 at 10:27:16PM +0200, Arno Tiemersma wrote:
> Since the function auth_parse returns a u16, and
> struct rtllib_authentication.status is defined as an __le16, it seems
> that
>
> return cpu_to_le16(a->status);
>
> should be
>
> return le16_to_cpu(a->status);
>
> T
Replace :? with min_t for readability. Remove check that is always false.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 8 +---
drivers/staging/rtl8192e/rtllib_wx.c | 3 +--
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/
WOL capability was reported in an awkward way - print it nicely.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_pm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pm.c
b/drivers/staging/rtl8192e/rtl81
Warninig is printed if precision is lost - it can't happen at moment as
all get_key implementations return either -1 or small buffers.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_wx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/stagin
This messages are not needed, as failure is reported earlier in code.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 1 -
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8192e
Reindent lines to make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 83 +++---
drivers/staging/rtl8192e/rtllib_rx.c | 18 ---
2 files changed, 65 insertions(+), 36 deletions(-)
diff --git a/drivers/staging
Use netdev_dbg() instead, remove duplicated logs.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 101 ---
drivers/staging/rtl8192e/rtllib_wx.c | 12 +++--
3 files changed, 54 insertions(+
- Use netdev_* with log level depending on how serious error is
- Rework some messages to be more readable
- Pass net_device where needed for pretty prints
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 24 +++--
drivers/staging/rtl8192e/rtl8192e/r819
Use print_hex_dump_bytes() if VERBOSE_DEBUG is enabled.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 20
drivers/staging/rtl8192e/rtl819x_HTProc.c | 7 +--
drivers/staging/rtl8192e/rtllib.h | 11 ---
drivers/staging/r
Take out MIFE_TYPE_HT_CAP processing into separate function -
rtllib_parse_mfie_ht_cap()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 49 +---
1 file changed, 29 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8192e/
Remove the following private variables:
- force_mic_error - changes force_mic_error that is not used
- radio - changes sw_radio_on that is not used
- adhoc_peer_list - unimplemented
- firm_ver - unimplemented
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1
Improve readability and make checkpatch happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtllib_rx.c
index 2b337c4..5a08935 100644
Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
Replace printk() with netdev_* if possible, pr_* in other cases.
All pr_* use __func__ to easily trace message back to rtllib
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 2 +-
drivers/staging/rtl8
This function never supported checking of MAC block.
Instead of printing several warnings - print it once and exit.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/stagin
This header is not used - remove it to make driver code smaller.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h | 382 -
1 file changed, 382 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/rtl8192e/rtl_crypto.h
diff --git a
Fix most of simple LONG_LINE warnings. None of the changes should affect
behaviour of code, so several modifications are included in this patch:
- Code is reindented where needed
- Local variable names are compacted (priv -> p)
- Unnecessary casts are removed
- Nested ifs are replaced with logical
Remove rest of rtllib "debug" system - it is no longer used -
proper netdev_* functions are used in most cases.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 45 --
drivers/staging/rtl8192e/rtllib_module.c | 55 --
- Use netdev_dbg() instead of RTLLIB_DEBUG_MGMT()
- Remove RTLLIB_DEBUG_MGMT()
- Pass net_device to auth_parse(), auth_rq_parse() and assoc_rq_parse()
- Remove duplicated messages
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h | 2 -
drivers/staging/rtl8192e/rtl
- Use netdev_dbg or netdev_vdbg instead of RTLLIB_DEBUG()
- Reformat some messages for better readability
- Remove RTLLIB_DEBUG messages that make no sense
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 35 +
drivers/staging/rtl8192e/rtl819x
Remove alloc failed messages where not needed to make checkpatch.pl happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c
b/drivers/staging/rtl8
Assert macro printed warning message (and was used once).
Remove it, and add netdev_warn() in place where it was called.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 +++--
drivers/staging/rtl8192e/rtllib_debug.h | 8
2 files changed, 3 ins
- Pass extra argument (rtllib_device) to rtllib_parse_qos_info_param_IE()
and update_network()
- Replace RTLLIB_DEBUG_QOS() with netdev_dbg()
- Remove RTLLIB_DEBUG_QOS()
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_rx.c | 26
Use pr_* where needed (rtllib init code).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 2 --
drivers/staging/rtl8192e/rtllib_module.c | 8 +++-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/stag
Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
for errors that really should be reported to user.
Use netdev_warn() for the rest.
Rephrase some of the messages to make them more readable/compact.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl819x_BAProc.c
- Extract frame_ctl once and use it as variable.
- Drop endian conversion in is_beacon() function
(used in simplified function only)
- Simplify debug messages
- Invert STYPE checks in debug messages - it is valid
as only BEACON and PROBE_RESP are allowed
Signed-off-by: Mateusz Kulikowski
---
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 364 +--
Use netdev_dbg() instead.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 6
drivers/staging/rtl8192e/rtllib_rx.c | 58
drivers/staging/rtl8192e/rtllib_tx.c | 5 ++--
3 files changed, 35 insertions(+), 34 deletions(-)
diff
Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
structures. Use ETH_ALEN as array length in places where it was hardcoded to 6.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 ++-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
Use pr_debug() instead.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_module.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
inde
Use netdev_dbg() instead of RTLLIB_DEBUG_WX().
Rewrite some messages to be more readable.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib.h| 1 -
drivers/staging/rtl8192e/rtllib_wx.c | 33 -
2 files changed, 16 insertions(+), 18 deletion
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential "Fix" to ether_addr_copy().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
di
Use dedicated macro to compare ethernet addresses in probe_rq_parse().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
b/drivers/staging/rtl8192e/rtlli
It is neither compiled nor used in rtl8192e.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_crypt.c | 254
drivers/staging/rtl8192e/rtllib_crypt.h | 34 -
2 files changed, 288 deletions(-)
delete mode 100644 drivers/staging/rtl8192e/r
Replace memcpy() with ether_addr_copy() where possible to make
checkpatch.pl happy.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl819x_BAProc.c | 13 +++---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 19 --
This series applies some of review comments by Dan (thanks!) as well as does
further cleanups.
Further series will probably focus more on changing driver architecture into
something that may get accepted into -wireless.
This series should apply cleanly to staging-testing(7192a5dd5)
branches.
One
Since the function auth_parse returns a u16, and
struct rtllib_authentication.status is defined as an __le16, it seems
that
return cpu_to_le16(a->status);
should be
return le16_to_cpu(a->status);
This change silences the following sparse warnings:
drivers/staging/rtl8192e/rtllib
Since the function auth_parse returns a u16, and
struct rtllib_authentication.status is defined as an __le16, it seems
that
return cpu_to_le16(a->status);
should be
return le16_to_cpu(a->status);
This change silences the following sparse warnings:
drivers/staging/rtl8192e/rtllib
On Fri, May 01, 2015 at 02:58:25PM -0700, H Hartley Sweeten wrote:
> The ni_stc.h header contains the DAQ-STC and board specific register
> information used by ni_mio_common.c to provide the "guts" for the
> National Instruments MIO drivers ni_atmio, ni_mio_cs, and ni_pcimio.
> Those drivers all cu
On Sat, 09 May 2015 05:59:40 -0500 Dan Carpenter
wrote
> On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> > >From TODO list: remove test for host endian
> > Included header to gather information about host endianness.
> > Please let me know if the code additio
On Mon, May 04, 2015 at 03:11:18PM +0200, Peter Senna Tschudin wrote:
> As the first argument of gf_write64() was of type unsigned long, and as
> some calls to gf_write64() were casting the first argument from void *
> to u64 the compiler and/or sparse were printing warnings for casts of
> wrong si
dgap_sindex() is being only called from dgap_getword() which searches
for either ' ' or '\t' or '\n'. this part of the code with '^' at the
beginning is never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 21 -
1 file changed, 4 insertions(+), 17 dele
On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> >From TODO list: remove test for host endian
> Included header to gather information about host endianness.
> Please let me know if the code addition requires corrections
> to meet standards.
>
No. This isn't really an improvement.
On Sat, May 09, 2015 at 12:19:28PM +0300, Dan Carpenter wrote:
> On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote:
> > >
> > > This function leaks hdr_info on later error paths.
> >
> > Never mind. I'm wrong. Sorry for the noise.
> >
>
> To be honest, I think I was right original
On Fri, May 08, 2015 at 04:07:03PM +0300, Dan Carpenter wrote:
> >
> > This function leaks hdr_info on later error paths.
>
> Never mind. I'm wrong. Sorry for the noise.
>
To be honest, I think I was right originally, but the code is such a
twisty call path that it's hard to tell.
Of course,
You should send your git tree to Fengguang Wu so he can add it to
kbuild. It would have found the compile warnings and most of the static
checker issues.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxd
Also:
drivers/staging/unisys/visorbus/visorchipset.c
2239 rc = queue_delayed_work(periodic_controlvm_workqueue,
2240 &periodic_controlvm_work, poll_jiffies);
2241 if (rc < 0) {
2242 POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC,
On Sat, May 09, 2015 at 12:05:19PM +0300, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote:
> > On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote:
> > > From: Don Zickus
> > >
> > > cleanup:
> > > - bus_epilog(bus_no, CONTROLVM_BUS_CREATE, &inmsg
On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote:
> On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote:
> > From: Don Zickus
> >
> > cleanup:
> > - bus_epilog(bus_no, CONTROLVM_BUS_CREATE, &inmsg->hdr,
> > + bus_epilog(bus_info, CONTROLVM_BUS_CREATE, &inmsg->hdr,
>
Also:
drivers/staging/unisys/visorbus/periodic_work.c:122 visor_periodic_work_start()
warn: bool is not less than zero.
drivers/staging/unisys/visorbus/periodic_work.c
107 bool visor_periodic_work_start(struct periodic_work *pw)
108 {
109 bool rc = false;
110
111
On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote:
> From: Don Zickus
>
> cleanup:
> - bus_epilog(bus_no, CONTROLVM_BUS_CREATE, &inmsg->hdr,
> + bus_epilog(bus_info, CONTROLVM_BUS_CREATE, &inmsg->hdr,
> rc, inmsg->hdr.flags.response_expected == 1);
> }
On
On Tue, May 05, 2015 at 06:36:00PM -0400, Benjamin Romer wrote:
> +/** This is called automatically upon adding a visor_device (device_add), or
> + * adding a visor_driver (visorbus_register_visor_driver), but only after
> + * visorbus_match has returned 1 to indicate a successful match between
>
On Tue, May 05, 2015 at 06:36:07PM -0400, Benjamin Romer wrote:
> -void
> -devmajorminor_remove_file(struct visor_device *dev, int slot)
> -{
> - int maxdevnodes = ARRAY_SIZE(dev->devnodes) / sizeof(dev->devnodes[0]);
> - struct devmajorminor_attribute *myattr = NULL;
> -
> - if (slot <
On Tue, Sep 30, 2014 at 12:07:46PM -0400, Benjamin Romer wrote:
> -BOOL visor_periodic_work_nextperiod(PERIODIC_WORK *periodic_work)
> +BOOL visor_periodic_work_nextperiod(struct periodic_work *pw)
> {
> BOOL rc = FALSE;
>
> - write_lock(&periodic_work->lock);
> - if (periodic_work
55 matches
Mail list logo
