On Tue, May 12, 2015 at 06:57:46PM -0700, Tolga Ceylan wrote:
> To fix sparse warning of incorrect type when calling vfree()
> (different address space), added annotation __force.
Garret Kelly posted a similar patch before, please see the discussion
about that patch at https://lkml.org/lkml/2015/4
In ni_ai_cmd() bitwise or construction of ai_trig in case of TRIG_NOW
is faulty. Register address is accidentally in the expression,
but this has no effect. This is an accidental left-over code
that used to call a function with register address as one of
the arguments.
Signed-off-by: Tolga Ceylan
On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 09:49, Sudip Mukherjee wrote:
> > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>
> You're running checkpatch --strict right?
>
> > 1) multiple blank lines
> > 2) Blank lines aren't necessary
Error code returned from auth_parse() should in cpu byte order.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/staging/rtl
Error code returned from auth_parse() should in cpu byte order. Issue
caught by sparse warning: cast from restricted __le16.
Signed-off-by: Tolga Ceylan
---
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtll
From: "K. Y. Srinivasan"
Date: Mon, 11 May 2015 15:39:46 -0700
> Based on the information given to this driver (via the xmit_more skb flag),
> we can defer signaling the host if more packets are on the way. This will help
> make the host more efficient since it can potentially process a larger ba
To fix sparse warning of incorrect type when calling vfree()
(different address space), added annotation __force.
Signed-off-by: Tolga Ceylan
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/s
Hello!
On May 12, 2015, at 6:43 PM, George G. Davis wrote:
> Greetings,
>
> Resending this using the correct version of get_maintainers.pl.
>
> As recommended in the thread "SPDX-License-Identifier” [1], I would like to
> followup with the
> maintainers of the file
> drivers/staging/lustre/lu
Hi Gaston,
A couple of minor style comments:
On Wed, May 13, 2015 at 8:23 AM, Gaston Gonzalez wrote:
> On 08/05/15 08:03, Dan Carpenter wrote:
>> To be honest, I'm a little bit a newbie myself when it comes to
>> linux-wireless so keep that in mind. ;) Changing the parameters seems
>> simple e
Greetings,
Resending this using the correct version of get_maintainers.pl.
As recommended in the thread "SPDX-License-Identifier” [1], I would like to
followup with the
maintainers of the file
drivers/staging/lustre/lustre/include/lustre_dlm_flags.h regarding the GPLv3
license statement contain
Hello Greg,
On Tue, May 12, 2015 at 03:31:17PM -0700, Greg Kroah-Hartman wrote:
> On Tue, May 12, 2015 at 06:05:24PM -0400, George G. Davis wrote:
> > Greetings,
> >
> > As recommended in the thread "SPDX-License-Identifier” [1], I would like to
> > followup with the
> > maintainers of the file
On Tue, May 12, 2015 at 06:05:24PM -0400, George G. Davis wrote:
> Greetings,
>
> As recommended in the thread "SPDX-License-Identifier” [1], I would like to
> followup with the
> maintainers of the file
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h regarding the GPLv3
> license sta
On 08/05/15 08:03, Dan Carpenter wrote:
> To be honest, I'm a little bit a newbie myself when it comes to
> linux-wireless so keep that in mind. ;) Changing the parameters seems
> simple enough. But it needs to an EXPORT_SYMBOL() and to be declared in
> a header file and I'm not sure what else.
Greetings,
As recommended in the thread "SPDX-License-Identifier” [1], I would like to
followup with the
maintainers of the file
drivers/staging/lustre/lustre/include/lustre_dlm_flags.h regarding the GPLv3
license statement contained in that file [2]. Is there an GPLv3 exception
clause which ca
From: Simon Xiao
Current code does not lock anything when calculating the TX and RX stats.
As a result, the RX and TX data reported by ifconfig are not accuracy in a
system with high network throughput and multiple CPUs (in my test,
RX/TX = 83% between 2 HyperV VM nodes which have 8 vCPUs and 40G
On Tue, May 12, 2015 at 09:52:01PM +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 15:19, Greg KH wrote:
> > On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote:
> >> Replace memcpy() with ether_addr_copy() where possible to make
> >> checkpatch.pl happy.
> >
> > I need proof that
On Tue, May 12, 2015 at 11:03:52PM +0200, Adrian Remonda wrote:
> This patch remove a register from an '|' expression.
> It is wrong since after in the code, the variable ai_trig gets
> written back to that register.
>
>
> modified: drivers/staging/comedi/drivers/ni_mio_common.c
What do
On Tue, 2015-05-12 at 21:44 +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 00:29, Joe Perches wrote:
> > On Sat, 2015-05-09 at 23:18 +0200, Mateusz Kulikowski wrote:
> >> Add __aligned(2) into ethernet addresses allocated on stack or in
> >> non-packed
> >> structures. Use ETH_ALEN as array leng
This patch remove a register from an '|' expression.
It is wrong since after in the code, the variable ai_trig gets
written back to that register.
modified: drivers/staging/comedi/drivers/ni_mio_common.c
Signed-off-by: Adrian Remonda
---
drivers/staging/comedi/drivers/ni_mio_common.
On 10.05.2015 09:49, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
>> Code was not altered significantly, therefore in some places it generates
>> LONG_LINE checkpatch.pl warnin
On 11.05.2015 15:48, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> +if (info_element->len >= 4 &&
>> +info_element->data[0] == 0x00 && info_element->data[1] == 0x50 &&
>> +info_element->data[2] == 0xf2 && info_element->data[3] == 0
On 10.05.2015 09:53, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote:
>> Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
>> for errors that really should be reported to user.
>> Use netdev_warn() for the rest.
>> Rephrase some of the me
On 10.05.2015 00:37, Joe Perches wrote:
> On Sat, 2015-05-09 at 23:19 +0200, Mateusz Kulikowski wrote:
>> Fix most of remaining PREFER_PR_LEVEL warnings in rtllib.
>> Replace printk() with netdev_* if possible, pr_* in other cases.
>> All pr_* use __func__ to easily trace message back to rtllib
>
On 11.05.2015 15:22, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote:
(...)
>> len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv);
>> -erq->length = (len >= 0 ? len : 0);
>> +if (len > U16_MAX)
>> +netdev_err(ieee->de
On 10.05.2015 15:20, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
>> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
>> checkpatch.pl warning.
>> It will prevent accidential "Fix" to ether_addr_copy().
>
> What do you mean by this? Why will t
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
>> */
>> skb_pull(sub_skb, SNAP_SIZE);
>> -memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
>> ETH_ALEN);
>> -memcpy(skb_push(sub_skb, ET
On 10.05.2015 15:19, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:50PM +0200, Mateusz Kulikowski wrote:
>> Replace memcpy() with ether_addr_copy() where possible to make
>> checkpatch.pl happy.
>
> I need proof that this is ok to do, please provide that in the changelog
> entry.
What kind of pr
On 10.05.2015 00:29, Joe Perches wrote:
> On Sat, 2015-05-09 at 23:18 +0200, Mateusz Kulikowski wrote:
>> Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
>> structures. Use ETH_ALEN as array length in places where it was hardcoded to
>> 6.
> []
>> diff --git a/drivers/
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Tuesday, April 21, 2015 9:22 AM
>> To: KY Srinivasan
>> Cc: Haiyang Zhang; de...@linuxdriverproject.org; linux-
>> ker...@vger.kernel.org; Dexuan Cui; Dan Carpenter
>> Subject: [PAT
This patch attempts to simplify the debugging using standard
dev_dbg call so that individual debug prints can be enabled or
disbled by dynamic debugging rather than using module params.
Signed-off-by: Madhusudhanan Ravindran
---
drivers/staging/fbtft/fb_agm1264k-fl.c |6 +++---
drivers/stagi
removed the commented INFO lines.
Signed-off-by: Madhusudhanan Ravindran
---
drivers/staging/emxx_udc/emxx_udc.c | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index 163ca56..4178d96 1006
Fixed indentation issue in few lines.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8712/recv_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/recv_linux.c
b/drivers/staging/rtl8712/recv_linux.c
index 799a0f9..4201ce7 10
if we load the module, unload and then again try to load the module, we
will get a stackdump. In the module_exit function we are unregistering
the device and releasing the parport. So when we reach the detach
function parport is already null and the unregister_reboot_notifier()
is never called. Whe
On Tue, May 12, 2015 at 02:27:13PM +0300, Dan Carpenter wrote:
> On Tue, May 12, 2015 at 04:45:44PM +0530, Sudip Mukherjee wrote:
> > if we load the module, unload and then again try to load the module, we
> > will get a stackdump. In the module_exit function we are unregistering
> > the device and
Casting correct Endianness for __le16 variable used in assignment and
condition check.
Signed-off-by: Gnanachandran Dhanapal
---
v2:Since previous version of the patch had build error.This
version has no build warnings and error.
---
drivers/staging/rtl8192e/rtllib_softmac.c | 14 +
On Tue, May 12, 2015 at 04:45:44PM +0530, Sudip Mukherjee wrote:
> if we load the module, unload and then again try to load the module, we
> will get a stackdump. In the module_exit function we are unregistering
> the device and releasing the parport. So when we reach the detach
> function parport
"Gujulan Elango, Hari Prasath (H.)" writes:
> On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
>> "Gujulan Elango, Hari Prasath (H.)" writes:
>> > On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
>> >> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
>> >>
if we load the module, unload and then again try to load the module, we
will get a stackdump. In the module_exit function we are unregistering
the device and releasing the parport. So when we reach the detach
function parport is already null and the unregister_reboot_notifier()
is never called. Whe
On Tue, May 12, 2015 at 08:41:05AM +, Dan Carpenter wrote:
> On Tue, May 12, 2015 at 07:38:48AM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > @@ -2235,7 +2235,7 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device
> > *ieee, struct sk_buff *skb,
> > struct rtllib_hdr_3addr *header = (s
"Gujulan Elango, Hari Prasath (H.)" writes:
> The variable pHalData is initialized twice in this same function with
> same value.So removing one of them.
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
> 1 file changed, 1 insertion(+),
On Thu, May 07, 2015 at 10:09:59AM -0400, Jes Sorensen wrote:
> "Gujulan Elango, Hari Prasath (H.)" writes:
> > On Thu, May 07, 2015 at 03:19:34PM +0300, Dan Carpenter wrote:
> >> On Thu, May 07, 2015 at 08:03:06AM -0400, Jes Sorensen wrote:
> >> > "Gujulan Elango, Hari Prasath (H.)" writes:
> >>
This patch was generated by 'make coccicheck'
Signed-off-by: Balamanikandan Gunasundar
---
.../lustre/lustre/obdclass/lprocfs_status.c|3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
b/drivers/staging/lustre
The variable pHalData is initialized twice in this same function with
same value.So removing one of them.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/
On Tue, May 12, 2015 at 07:38:48AM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> @@ -2235,7 +2235,7 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device
> *ieee, struct sk_buff *skb,
> struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data;
>
> RTLLIB_DEBUG_MGMT("r
On Mon, May 11, 2015 at 08:40:35PM -0700, David Matlack wrote:
> As per TODO. This commit introduces no functional changes.
>
It's easy for me to imagine that big shared "flags" variable in the
original code is racy so it might introduce a bugfix. :)
Nice improvement.
regards,
dan carpenter
_
Casting correct Endianness for __le16 variable used in assignment and
condition check.
Signed-off-by: Gnanachandran Dhanapal
---
drivers/staging/rtl8192e/rtllib_softmac.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c
b/d
46 matches
Mail list logo
