Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

What? No, that patch can't work at all. It will just oops directly when you do: +memcpy(tx-p1k, tkey-tx_ttak, p1k_len); How come you didn't use my patch as a base to work from, you shouldn't be passing tkip_ctx at all. regards, dan carpenter

[PATCH] staging: wlan-ng: check return value of kmalloc

check return value of kmalloc before accessing the memory pointer.This function returns a non-zero value on failure hence a return value of 1 is used. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/wlan-ng/p80211conv.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()

Actually, to be honest, I would prefer if you moved things without changing it too much. I have a script to review move code to a new function patches but if everything moves and changes as well then it's confusing and I have to do it by hand. regards, dan carpenter

[PATCH] staging: lustre: check kzalloc return value

check the return value of kzalloc before accessing the memory pointer Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/lustre/lustre/llite/llite_lib.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c

Re: [PATCH] staging: lustre: check kzalloc return value

On Wed, May 13, 2015 at 10:36:28AM +, Gujulan Elango, Hari Prasath (H.) wrote: check the return value of kzalloc before accessing the memory pointer Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com Looks good. regards, dan carpenter

Re: [PATCH] staging: wlan-ng: check return value of kmalloc

On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.) wrote: check return value of kmalloc before accessing the memory pointer.This

Re: [PATCH] staging: wlan-ng: check return value of kmalloc

On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.) wrote: check return value of kmalloc before accessing the memory pointer.This function returns a non-zero value on failure hence a return value of 1

Re: lustre_dlm_flags.h GPLv3 license clarification

Hello Oleg, On Wed, May 13, 2015 at 01:53:35AM +, Drokin, Oleg wrote: Hello! On May 12, 2015, at 6:43 PM, George G. Davis wrote: Greetings, Resending this using the correct version of get_maintainers.pl. As recommended in the thread SPDX-License-Identifier” [1], I would like

[PATCHv2] staging: wlan-ng: check return value of kmalloc

check return value of kmalloc before accessing the memory pointer and return -ENOMEM if allocation fails. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- v2:Return -ENOMEM for memory allocation failure. --- drivers/staging/wlan-ng/p80211conv.c | 2 ++ 1 file changed,

Re: [PATCH] staging: wlan-ng: check return value of kmalloc

On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.) wrote: On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 11:32:50AM +, Gujulan Elango, Hari Prasath (H.)

Re: [PATCH] staging: wlan-ng: check return value of kmalloc

On Wed, May 13, 2015 at 05:27:10PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 01:36:44PM +, Gujulan Elango, Hari Prasath (H.) wrote: On Wed, May 13, 2015 at 03:02:25PM +0300, Dan Carpenter wrote: On Wed, May 13, 2015 at 02:51:07PM +0300, Dan Carpenter wrote: On Wed, May

Hadiah Bonus Khas Tahun Baru

Nestle (Malaysia) Berhad 22-1, 22nd floor, Menara Surian No. 1, Jalan PJU 7/3 Mutiara Damansara 47810 Petaling Jaya Selangor, Malaysia. HADIAH BONUS KHAS TAHUN BARU. Kami berasa sukacita untuk memaklumkan kepada anda nantikan siaran keputusan Hadiah Bonus Nestl? (Malaysia) Berhad khas yang

Re: [PATCH net-next,1/1] hv_netvsc: use per_cpu stats to calculate TX/RX data

From: six...@microsoft.com Date: Tue, 12 May 2015 15:50:02 -0700 From: Simon Xiao six...@microsoft.com Current code does not lock anything when calculating the TX and RX stats. As a result, the RX and TX data reported by ifconfig are not accuracy in a system with high network throughput and

[PATCH 2/4] ozwpan: Use unsigned ints to prevent heap overflow

Using signed integers, the subtraction between required_size and offset could wind up being negative, resulting in a memcpy into a heap buffer with a negative length, resulting in huge amounts of network-supplied data being copied into the heap, which could potentially lead to remote code

[PATCH 1/4] ozwpan: Use proper check to prevent heap overflow

Since elt-length is a u8, we can make this variable a u8. Then we can do proper bounds checking more easily. Without this, a potentially negative value is passed to the memcpy inside oz_hcd_get_desc_cnf, resulting in a remotely exploitable heap overflow with network supplied data. This could

[PATCH 302/302] Staging: comedi: comedi: Fixed spelling error

Fixed spelling error in comment Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/comedi/comedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 7455740..66edda1 100644 ---

Re: [PATCH 304/304] Staging: i2o: i2o_proc: fixed spelling issues

On Wed, May 13, 2015 at 02:58:23PM -0700, colincronin wrote: Fixed spelling issues and corrected references. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/i2o/i2o_proc.c | 72 +- 1 file changed, 36 insertions(+), 36

Re: [PATCH 301/301] Staging: comedi: 8255_pci addi_apci_1500: fixed spelling issues

On Wed, May 13, 2015 at 02:08:00PM -0700, colincronin wrote: Fixed some spelling issues. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/comedi/drivers/8255_pci.c | 2 +- drivers/staging/comedi/drivers/addi_apci_1500.c | 4 ++-- 2 files changed, 3

[PATCH 1/2] Drivers: staging: comedi: comedi: Fixed comment spelling error

Fixed a spelling error in a comment. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/comedi/comedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 7455740..66edda1 100644

[PATCH 304/304] Staging: i2o: i2o_proc: fixed spelling issues

Fixed spelling issues and corrected references. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/i2o/i2o_proc.c | 72 +- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/staging/i2o/i2o_proc.c

[PATCH 303/304] Staging: i2o: i2o_scsi: Fixed spelling error

Fixed a spelling error in comments. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/i2o/i2o_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/i2o/i2o_scsi.c b/drivers/staging/i2o/i2o_scsi.c index 1b11dcb..5ff36c4 100644 ---

[PATCH 09/10] staging: rtl8188eu: declare internal symbols as static

Also remove them from .h files. Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman gre...@linux.com Cc: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/include/osdep_intf.h | 2 -- drivers/staging/rtl8188eu/include/recv_osdep.h | 3 ---

[PATCH 08/10] staging: rtl8188eu: remove useless return value

The loadparam() function cannot fail, it's called only once and its return value is ignored there. Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman gre...@linux.com Cc: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +-- 1 file

[PATCH 02/10] staging: rtl8712: remove unneeded forward declaration

Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman g...@kroah.com Cc: Larry Finger larry.fin...@lwfinger.net Cc: Florian Schilhabel florian.c.schilha...@googlemail.com --- drivers/staging/rtl8712/os_intfs.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 07/10] staging: rtl8188eu: add missing blank lines after declarations

Fixes checkpatch warnings: WARNING: Missing a blank line after declarations Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman gre...@linux.com Cc: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++ 1 file changed, 3

[PATCH 01/10] staging: rtl8712: remove useless comment

step 2 does mean much as there is no step 1 stated anywhere... Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman g...@kroah.com Cc: Larry Finger larry.fin...@lwfinger.net Cc: Florian Schilhabel florian.c.schilha...@googlemail.com --- drivers/staging/rtl8712/os_intfs.c | 1

[PATCH 06/10] staging: rtl8188eu: cosmetic: remove useless spaces

Even though these are not reported by checkpatch, they are coding style issues. Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman gre...@linux.com Cc: Larry Finger larry.fin...@lwfinger.net --- drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +-- 1 file changed, 1

[PATCH 03/10] staging: rtl8712: remove useless return value

The loadparam() function cannot fail, it's called only once and its return value is ignored there. Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman g...@kroah.com Cc: Larry Finger larry.fin...@lwfinger.net Cc: Florian Schilhabel florian.c.schilha...@googlemail.com ---

[PATCH 04/10] staging: rtl8723au: remove useless return value

The loadparam() function cannot fail, it's called only once and its return value is ignored there. Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman gre...@linux.com Cc: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 05/10] staging: rtl8723au: remove useless comment

step 2 does mean much as there is no step 1 stated anywhere... Signed-off-by: Luca Ceresoli l...@lucaceresoli.net Cc: Greg Kroah-Hartman gre...@linux.com Cc: Larry Finger larry.fin...@lwfinger.net Cc: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 - 1

[PATCH 10/10] staging: rtl8188eu: return an error code, not a boolean

Several functions in this driver return a boolean: _SUCCESS = 1 on success, _FAIL = 0 on error, defined in drivers/staging/rtl8188eu/include/osdep_service.h. The common practice in the Linux kernel is to return 0 on success, a negative error code otherwise. This has the advantage that the return

Re: [PATCH 302/302] Staging: comedi: comedi: Fixed spelling error

On Wed, May 13, 2015 at 02:26:25PM -0700, colincronin wrote: Fixed spelling error in comment Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/comedi/comedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Where are patches 001-301 in this series? I

[PATCH 2/2] Drivers: staging: skein: skein_api: Fixed spelling errors

Fixed a few spelling errors in comments. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/skein/skein_api.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h index

Re: [PATCH 1/2] Drivers: staging: comedi: comedi: Fixed comment spelling error

On Wed, May 13, 2015 at 05:01:40PM -0700, colincronin wrote: Fixed a spelling error in a comment. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com This name doesn't match the From: line in your email header, please fix it up to match properly. thanks, greg k-h

[PATCH 2/2] Drivers: staging: skein: skein_api: Fixed spelling errors

Fixed a few spelling errors in comments. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/skein/skein_api.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/skein/skein_api.h b/drivers/staging/skein/skein_api.h index

[PATCH 1/2] Drivers: staging: comedi: comedi: Fixed comment spelling error

Fixed a spelling error in a comment. Signed-off-by: Colin Cronin colinpatrickcro...@gmail.com --- drivers/staging/comedi/comedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 7455740..66edda1 100644

Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse warning

On 13/05/15 05:36, Dan Carpenter wrote: How come you didn't use my patch as a base to work from, you shouldn't be passing tkip_ctx at all. Hi Dan, my mistake. To be honest I assumed that the idea was not to touch tkip.c at all, that's why I had to pass tkip_ctx... sorry about that :-( Coming

[PATCH 15/44] staging: unisys: get rid of sparstop

From: David Kershner david.kersh...@unisys.com Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/sparstop.h | 29 - 1 file changed, 29 deletions(-) delete mode 100644

[PATCH 22/44] staging: unisys: Remove dead kobj structs

From: Don Zickus dzic...@redhat.com Remove stale code. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/visorbus_main.c | 32 - 1 file changed, 32 deletions(-) diff --git

[PATCH 26/44] staging: unisys: Add a function to set the clientpartition

From: Don Zickus dzic...@redhat.com This patch is an attempt to help hide the channel info behind accessory functions. I was trying to keep visorchannel as private as possible. The only function missing that seemed to be needed for now was the ability to set the clientpartition. So I expose

[PATCH 14/44] staging: unisys: Get rid of references to common-spar

From: David Kershner david.kersh...@unisys.com Makefiles still had common-spar listed in ccflags. This gets rid of them. Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/Makefile | 2 --

[PATCH 19/44] staging: unisys: Wire up proper device attr for bus

From: Don Zickus dzic...@redhat.com This patch moves the attributes to underneath the bus device correctly. This will help remove a bunch of cruft from the code and let the kernel infrastructure manage the sysfs files instead of the driver. After the move remove all the leftover code.

[PATCH 23/44] staging: unisys: Clean up device sysfs attributes

From: Don Zickus dzic...@redhat.com Properly hook into the struct device groups element. This allows the core infrastructure to manage the files instead of the bus layer. And makes the code easier to read. I didn't clean up the _show functions just modified them a bit to handle the different

[PATCH 18/44] staging: unisys: Embed struct device for easier handling of attr

From: Don Zickus dzic...@redhat.com Handling the sysfs attributes become easier to deal with when you can just run container_of(dev) to get devdata. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 27/44] staging: unisys: Add checks for creation

From: Don Zickus dzic...@redhat.com There was a bunch of channel creation checks before the visorchannel_create function was called, moving some of those checks inside. This keeps the outside code cleaner and handles the situation where a caller forgets to make these checks. Signed-off-by: Don

[PATCH 25/44] staging: unisys: Add visor device find routine

From: Don Zickus dzic...@redhat.com If we are going to remove the bus_info structs than we need a way to find the devices when the *_create/destroy cmds are sent over the vmchannel. This function crudely impements what pci has. It takes a bus_no and dev_no and finds the matching 'struct

[PATCH 17/44] staging: unisys: Remove temporarily added visorbus/ include in Makefile

From: Don Zickus dzic...@redhat.com Now that the header file movement is complete, remove the temporary ccflags include Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/Makefile | 1 - 1 file changed, 1

[PATCH 28/44] staging: unisys: Remove unused intr

From: Don Zickus dzic...@redhat.com The conversion to visor_device caused some compile issues.The main problem was the new fields in 'struct visor_device' were not public. Remove one that wasn't being used for now. struct irq_info intr Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by:

[PATCH 05/44] staging: unisys: Remove appos_subsystems.h

From: David Kershner david.kersh...@unisys.com Get rid of common-spar/include/diagnostics/appos_subsystems.h. No one is using it. Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- .../include/diagnostics/appos_subsystems.h

[PATCH 35/44] staging: unisys: Migrate bus from devdata to visor_device

From: Don Zickus dzic...@redhat.com The bus device and regular device were using two different structs. Let's combine them as they are not entirely different from one another. This allows us to move this creation up the stack later and actually remove bus/dev_info easily. Most of the churn is

[PATCH 38/44] staging: unisys: Do not use 0 as the default bus root device number

From: Don Zickus dzic...@redhat.com I used 0 as the device id for the bus root, neglecting the fact that device 0 is a valid id in Unisys's configuration. Modify this to use UINT_MAX instead as a unique number. As fallout from this change it was noticed the bus_no and dev_no was not defined the

[PATCH 11/44] staging: unisys: vbuschannel belonsg to visorbus

From: David Kershner david.kersh...@unisys.com Move vbuschannel.h into visorbus. Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- .../common-spar/include/channels/vbuschannel.h | 94 --

[PATCH 13/44] staging: unisys: Move files out of common-spar

From: David Kershner david.kersh...@unisys.com Move last three files out of common-spar iochannel.h -- include (will be used by visorhba and visornic) version.h -- moved to include controlvmcompletionstatus.h -- moved to visorbus, part of controlvmchannel.h Signed-off-by: David

[PATCH 06/44] staging: unisys: Include missing headers

From: Jes Sorensen jes.soren...@redhat.com This preps for the possible build breakage in the next few patches. Signed-off-by: Jes Sorensen jes.soren...@redhat.com [updated changelog to reflect new patch order; instead of 'fixes' the patch 'prevents' - dcz] Signed-off-by: Don Zickus

[PATCH 09/44] staging: unisys: Move controlframework into controlvmchannel.h

From: David Kershner david.kersh...@unisys.com Controlframework was only needed by controlvmchannel, move the structures into that header file. Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 02/44] staging: unisys: Remove unused visorchipset_save_message()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/visorchipset.c | 56 -- 1 file changed, 56 deletions(-) diff --git

[PATCH 00/44] staging: unisys: continued rework of s-Par drivers

This patch series continues the redesign and cleanup of the Unisys s-Par driver set, continuing work on the visorbus driver and consolidation of other drivers' code into the visorbus driver to reduce complexity. The patches were cleaned up so there should be no warnings or errors generated at all

[PATCH 04/44] staging: unisys: Remove unused livedump_info

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/visorchipset.c | 18 -- 1 file changed, 18 deletions(-) diff --git

[PATCH 03/44] staging: unisys: visorchipset_init(): Simplify initial checks

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/visorchipset.c | 40 +++--- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git

[PATCH 07/44] staging: unisys: Temporarily add visorbus/ ccflags

From: Don Zickus dzic...@redhat.com To prep for the moving of include files, temporarily add the visorbus/ as a ccflags -I. Once the header files are all transitioned, we can remove this. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 21/44] staging: unisys: Properly move version file into bus attr

From: Don Zickus dzic...@redhat.com Simplify things by moving the version file handling into the core. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/visorbus_main.c | 66 +++-- 1 file

[PATCH 20/44] staging: unisys: Move the visorbus device underneath devices

From: Don Zickus dzic...@redhat.com Mimicing what other drivers do, this seems appropriate. Yeah, it is a bus, but it is a bus _device_. This makes things work better and smoother. Now the sysfs looks like [root@dhcp-17-174 visorbus]# ls -l /sys/bus/visorbus/devices/ total 0 lrwxrwxrwx. 1

[PATCH 36/44] staging: unisys: Remove unused cruft

From: Don Zickus dzic...@redhat.com Removing stuff that isn't being used. Another prepartion patch to allow us to use visor_device everywhere without the baggage of bus/dev_info. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 12/44] staging: unisys: Move diagchannel to include

From: David Kershner david.kersh...@unisys.com Diagchannel needs to go to standard include. Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- .../common-spar/include/channels/diagchannel.h | 427 -

[PATCH 39/44] staging: unisys: Convert bus creation to use visor_device

From: Don Zickus dzic...@redhat.com This patch removes the legacy bus_info struct and instead creates and passes around a traditional struct device. This allows us to remove a lot of the various look up code and removes the doubt if the struct exists or not. Half of the churn is just the

[PATCH 32/44] staging: unisys: Move channel creation up the stack

From: Don Zickus dzic...@redhat.com Instead of creating a channel struct to temporarily hold the channel info and passing it through multiple functions until the device is created, just create the channel from the start. This allows us to remove the channel_info struct. I noticed

[PATCH 37/44] staging: unisys: Remove server flags

From: Don Zickus dzic...@redhat.com The bus driver doesn't work in server mode, just remove the left over pieces. Signed-off-by: Don Zickus dzic...@redhat.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorbus/visorbus_main.c| 66

Re: [PATCH 1/1] drivers: staging: comedi: drivers: ni_mio_common.c: removed no-effect right hand operand

On 13/05/15 05:53, Tolga Ceylan wrote: In ni_ai_cmd() bitwise or construction of ai_trig in case of TRIG_NOW is faulty. Register address is accidentally in the expression, but this has no effect. This is an accidental left-over code that used to call a function with register address as one of

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: (...) */ skb_pull(sub_skb, SNAP_SIZE); - memcpy(skb_push(sub_skb, ETH_ALEN), prxb-src, ETH_ALEN);

[PATCH 4/4] ozwpan: unchecked signed subtraction leads to DoS

The subtraction here was using a signed integer and did not have any bounds checking at all. This commit adds proper bounds checking, made easy by use of an unsigned integer. This way, a single packet won't be able to remotely trigger a massive loop, locking up the system for a considerable amount

[PATCH 3/4] ozwpan: divide-by-zero leading to panic

A network supplied parameter was not checked before division, leading to a divide-by-zero. Since this happens in the softirq path, it leads to a crash. A PoC follows below, which requires the ozprotocol.h file from this module. =-=-=-=-=-= #include arpa/inet.h #include linux/if_packet.h

[PATCH 0/4] ozwpan: Four remote packet-of-death vulnerabilities

The ozwpan driver accepts network packets, parses them, and converts them into various USB functionality. There are numerous security vulnerabilities in the handling of these packets. Two of them result in a memcpy(kernel_buffer, network_packet, -length), one of them is a divide-by-zero, and one