Re: [staging:staging-testing 524/578] drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:721:343: warning: (near initialization for 'lustre_attr_recalc_period.store')

2015-05-30 Thread Oleg Drokin
On May 31, 2015, at 2:32 AM, Greg Kroah-Hartman wrote: > On Sun, May 31, 2015 at 11:59:50AM +0800, kbuild test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git >> staging-testing >> head: 895875a3d85596e3e2e46aeb382bf14f1419de82 >> commit: 24b8c88a7122df

[PATCH] staging/lustre/ldlm: Fix up LDLM_POOL_SYSFS_WRITER*_STORE define

2015-05-30 Thread green
From: Oleg Drokin The store method defined by LDLM_POOL_SYSFS_WRITER_STORE and LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE defines should use size_t count, not unsigned long. This produced a warning on i386 (and other 32bit architectures too, I guess) where unsigned long is not 32 bit. Reported by kbui

Re: [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 11:37:49PM -0700, K. Y. Srinivasan wrote: > Allocate ring buffer memory from the NUMA node assigned to the channel. But you do more than just that. If there's a failure, you fall-back to the old allocation method. Why not mention that as well? And is that what you really

Re: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible()

2015-05-30 Thread Greg Kroah-Hartman
On Sun, May 31, 2015 at 07:54:34AM +0200, Nicholas Mc Guire wrote: > On Sun, 31 May 2015, Greg Kroah-Hartman wrote: > > > On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote: > > > API consolidation with coccinelle found: > > > ./drivers/staging/dgnc/dgnc_utils.c:16:1-17: > > >

Re: [staging:staging-testing 524/578] drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/ldlm_pool.c:721:343: warning: (near initialization for 'lustre_attr_recalc_period.store')

2015-05-30 Thread Greg Kroah-Hartman
On Sun, May 31, 2015 at 11:59:50AM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 895875a3d85596e3e2e46aeb382bf14f1419de82 > commit: 24b8c88a7122df35ce6a413cd76e9581411eab8f [524/578] > staging/lustre/ldlm: mo

Re: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible()

2015-05-30 Thread Nicholas Mc Guire
On Sun, 31 May 2015, Greg Kroah-Hartman wrote: > On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote: > > API consolidation with coccinelle found: > > ./drivers/staging/dgnc/dgnc_utils.c:16:1-17: > > consolidation with schedule_timeout_*() recommended > > > > This is a 1:1 c

[PATCH v2] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread Dighe, Niranjan (N.)
From: Niranjan Dighe Replace kzalloc followed by memcpy by kmemdup. This patch was generated by 'make coccicheck' Signed-off-by: Niranjan Dighe --- drivers/staging/lustre/lustre/obdclass/obd_config.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lus

Re: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread Dighe, Niranjan (N.)
Thanks Greg, I will send out a v2 of the patch with additional "From: " in the email body as you suggested in the mail chain with Madhu. Regards, Niranjan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

[PATCH V2 2/3] Drivers: hv: vmbus: Implement NUMA aware CPU affinity for channels

2015-05-30 Thread K. Y. Srinivasan
Channels/sub-channels can be affinitized to VCPUs in the guest. Implement this affinity in a way that is NUMA aware. The current protocol distributed the primary channels uniformly across all available CPUs. The new protocol is NUMA aware: primary channels are distributed across the available NUMA

[PATCH V2 1/3] Drivers: hv: vmbus: Use the vp_index map even for channels bound to CPU 0

2015-05-30 Thread K. Y. Srinivasan
Map target_cpu to target_vcpu using the mapping table. We should use the mapping table to transform guest CPU ID to VP Index as is done for the non-performance critical channels. While the value CPU 0 is special and will map to VP index 0, it is good to be consistent. Signed-off-by: K. Y. Sriniv

[PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion

2015-05-30 Thread K. Y. Srinivasan
Allocate ring buffer memory from the NUMA node assigned to the channel. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 7a1c2db..603ce97 100644 --- a/

[PATCH V2 0/3] Drivers: hv: vmbus: Make VMBUS driver NUMA aware

2015-05-30 Thread K. Y. Srinivasan
Implement CPU affinity for channels based on NUMA topology. Also, allocate all channel specific memory from the appropriate NUMA node. In this version of the series, I have added additional information to the commit log for some of the patches. K. Y. Srinivasan (3): Drivers: hv: vmbus: Use the

[PATCH 5/6] staging/lustre/obd: Remove nid_stats tracking

2015-05-30 Thread green
From: Oleg Drokin This nid_stats tracking only makes sense on the server side, on the client there are no other clients to keep track of anyway. Signed-off-by: Dmitry Eremin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/dt_object.h | 1 - .../staging/lustre/lustre/inc

[PATCH 6/6] staging/lustre/obd: final removal of procfs stuff

2015-05-30 Thread green
From: Dmitry Eremin Signed-off-by: Dmitry Eremin Signed-off-by: Oleg Drokin --- .../lustre/include/linux/libcfs/linux/libcfs.h | 1 - drivers/staging/lustre/lustre/fid/Makefile | 3 +- drivers/staging/lustre/lustre/fld/Makefile | 3 +- drivers/staging/lustre/lustre/in

[PATCH 3/6] staging/lustre/obd: Rename lprocfs_add_symlink to ldebugfs_add_symlink

2015-05-30 Thread green
From: Oleg Drokin Signed-off-by: Dmitry Eremin --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 12 ++-- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 16 +--- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/staging/lustre/lu

[PATCH 4/6] staging/lustre/obd: remove unused lprocfs_exp_setup() and related functions

2015-05-30 Thread green
From: Oleg Drokin This code only made sense on servers. Signed-off-by: Dmitry Eremin Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lprocfs_status.h | 2 - drivers/staging/lustre/lustre/include/obd.h| 1 - .../lustre/lustre/obdclass/lprocfs_status.c| 182

[PATCH 1/6] staging/lustre/llite: Move all remaining procfs entries to debugfs

2015-05-30 Thread green
From: Oleg Drokin This moves all remaining procfs handling in llite layer to debugfs. Signed-off-by: Dmitry Eremin Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/llite/llite_internal.h | 27 +++- drivers/staging/lustre/lustre/llite/llite_lib.c| 13 +++--- drivers/stagi

[PATCH 2/6] staging/lustre/obd: remove unused proc_lustre_root

2015-05-30 Thread green
From: Dmitry Eremin Signed-off-by: Dmitry Eremin --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 --- .../lustre/lustre/obdclass/linux/linux-module.c| 18 -- 2 files changed, 21 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lprocfs_stat

[PATCH 0/6] Final part of lustre procfs removal series

2015-05-30 Thread green
From: Oleg Drokin Due to a patch naming error this remainder of patches did not merge. Fixed the commit message to resolve this. lustresysctl code still stays in place and would be removed in a separate patch series. Additionally resolved a merge conflict with some other patch that touched lproc

Re: [PATCH 1/3] Drivers: hv: vmbus: Use the vp_index map even for channels bound to CPU 0

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 05:41:34PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Friday, May 29, 2015 10:00 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@lin

Re: [PATCHv3 00/16] vme DMA and user space driver improvements

2015-05-30 Thread Greg Kroah-Hartman
On Thu, May 28, 2015 at 03:06:57PM +0300, Dmitry Kalinkin wrote: > The first item in this submission documents previously introduced > vme_master_mmap() call. Following, there are three fixes for the tsi148 > driver's DMA. There was one bug that rendered it imposible to use DMA > lists with more t

Re: [PATCH v4 00/35] staging: rtl8192e: Fix more checkpatch.pl warnings

2015-05-30 Thread Greg KH
On Thu, May 21, 2015 at 05:53:13PM +0200, Mateusz Kulikowski wrote: > Updated series of patches for rtl8192. > > Rebased to latest staging-next (936a0cd52aa). Built and target tested > (tests like for v3 + download of 1Mb file over http). > Side note: quality/performance of this driver is still p

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-30 Thread Greg KH
On Sun, May 31, 2015 at 11:53:47AM +0900, Greg KH wrote: > On Mon, May 25, 2015 at 11:02:27AM -0500, Larry Finger wrote: > > On 05/23/2015 04:16 PM, Larry Finger wrote: > > >The driver is reporting a warning at kernel/time/timer.c:1096 due to > > >calling > > >del_timer_sync() while in interrupt m

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-30 Thread Greg KH
On Mon, May 25, 2015 at 11:02:27AM -0500, Larry Finger wrote: > On 05/23/2015 04:16 PM, Larry Finger wrote: > >The driver is reporting a warning at kernel/time/timer.c:1096 due to calling > >del_timer_sync() while in interrupt mode. Such warnings are fixed by calling > >del_timer() instead. > > > >

Re: [PATCH] staging: fbtft: replace fbtft_dev_dbg with standard dev_dbg call

2015-05-30 Thread Greg Kroah-Hartman
On Sun, May 31, 2015 at 08:02:22AM +0530, c.r.madhusudha...@gmail.com wrote: > > On 31-May-2015 06:59, "Greg Kroah-Hartman" wrote: > > > > On Tue, May 12, 2015 at 03:15:21PM +, Ravindran, Madhusudhanan (M.) > wrote: > > > This patch attempts to simplify the debugging using standard > > > dev_

Re: [PATCH 45/58] drivers/staging/llite: Move all remaining procfs entries to debugfs

2015-05-30 Thread Greg Kroah-Hartman
On Thu, May 21, 2015 at 03:32:19PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > This moves all remaining procfs handling in llite layer to debugfs. > > Signed-off-by: Dmitry Eremin > Signed-off-by: Oleg Drokin > --- > .../staging/lustre/lustre/llite/llite_internal.h | 27 +

Re: [PATCHv3] staging: sm750fb: Add missing Kconfig dependency

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 28, 2015 at 08:51:06AM +, Gujulan Elango, Hari Prasath (H.) wrote: > The sm750fb driver has few Framebuffer configuration dependencies that > need to be selected in order to get compiled successfully. > > Signed-off-by: Gujulan Elango Hari Prasath > --- > v3: Fix alignment

Re: [PATCH] staging: Replace kzalloc and memcpy by kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Wed, May 20, 2015 at 07:04:27AM +, Dumbre, Nitesh Dilip (N.) wrote: > This patch was generated by coccicheck and replaces kzalloc followed > by memcpy with kmemdup > > Signed-off-by: Nitesh Dumbre Name doesn't match the From: line, please fix your broken email client. WHat is up with thi

Re: [PATCH] staging: rts5208: remove variable and check directly

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 15, 2015 at 11:33:53AM +, Gujulan Elango, Hari Prasath (H.) wrote: > This trivial patch removes temporary variable to check return value of > a function and checks return value directly. > > Signed-off-by: Hari Prasath Gujulan Elango Same name problem here, and on all of your ot

Re: [PATCH] staging: rtl8188eu: remove unwanted assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 14, 2015 at 09:04:00AM +, Gujulan Elango, Hari Prasath (H.) wrote: > remove an unwanted assignment to a variable which is overwritten in the > very next line.The first value assigned is not used. > > Signed-off-by: Hari Prasath Gujulan Elango Your name doesn't match the From: li

Re: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread gre...@linuxfoundation.org
On Sat, May 30, 2015 at 10:22:17AM +, Dighe, Niranjan (N.) wrote: > Replace kzalloc followed by memcpy by kmemdup. This patch was generated > by 'make coccicheck' > > Signed-off-by: Niranjan Dighe Your name here doesn't match the name in the From: line of your email. Please fix up your emai

Re: [PATCH 54/58] staging/lustre/obd: remove unused proc_lustre_root

2015-05-30 Thread Oleg Drokin
On May 30, 2015, at 10:22 PM, Greg Kroah-Hartman wrote: > On Thu, May 21, 2015 at 03:32:28PM -0400, gr...@linuxhacker.ru wrote: >> From: Dmitry Eremin >> >> Signed-off-by: Dmitry Eremin >> --- >> drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 --- >> .../lustre/lustre/obdclass/linu

Re: [PATCH v1] staging: lustre: libcfs: add __user annotation in libcfs_ioctl_data

2015-05-30 Thread Greg Kroah-Hartman
On Mon, May 25, 2015 at 09:40:04PM -0700, David Decotigny wrote: > This fixes the following sparse warnings: >drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect type > in argument 1 (different address spaces) >drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38:expecte

Re: [PATCH] staging: lustre: osc: clean up whitespace and align function parameters

2015-05-30 Thread Greg KH
On Fri, May 22, 2015 at 02:50:47PM -0400, Chris Hanna wrote: > Minor changes to remove excessive whitespace and improve > readability of functions. > > Signed-off-by: Chris Hanna > --- > drivers/staging/lustre/lustre/osc/lproc_osc.c | 56 +++--- > drivers/staging/lustre/lustre/osc/osc_cache.

Re: [PATCH v4 00/13] staging: lustre: lnet: code cleanups

2015-05-30 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sat, May 23, 2015 at 10:05:27AM -0400, Michael Shuey wrote: > Ah - that explains it. I added additional files to the series, but > simply re-applied the original round of patches. They would've not

Re: [PATCH 54/58] staging/lustre/obd: remove unused proc_lustre_root

2015-05-30 Thread Greg Kroah-Hartman
On Thu, May 21, 2015 at 03:32:28PM -0400, gr...@linuxhacker.ru wrote: > From: Dmitry Eremin > > Signed-off-by: Dmitry Eremin > --- > drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 --- > .../lustre/lustre/obdclass/linux/linux-module.c| 18 > -- > 2 files ch

Re: [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

2015-05-30 Thread Greg KH
On Tue, May 26, 2015 at 06:47:14PM -0300, Gaston Gonzalez wrote: > Fix the following sparse warnings: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: > incorrect type in assignment (different base types) > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:

Re: [PATCH 1/2] staging: rtl8192u: r819xU_firmware.h: fix do not use c99 comments

2015-05-30 Thread Greg KH
On Thu, May 21, 2015 at 01:17:51PM +0300, Buţiu Alexandru Octavian wrote: > Fixed coding style error "do not use c99 comments" detected by > checkpatch.pl in r819xU_firmware.h > > Signed-off-by: Buţiu Alexandru Octavian > --- > drivers/staging/rtl8192u/r819xU_firmware.h | 17 ++--- >

Re: [PATCH 2/2] staging: rtl8192u: r819xU_firmware.h: fix line over 80 characters

2015-05-30 Thread Greg KH
On Thu, May 21, 2015 at 01:17:52PM +0300, Buţiu Alexandru Octavian wrote: > Fixed coding style issue line "over 80 characters" detected by > checkpatch.pl in r819xU_firmware.h > > Signed-off-by: Buţiu Alexandru Octavian > --- > drivers/staging/rtl8192u/r819xU_firmware.h | 3 ++- > 1 file change

Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-05-30 Thread Greg KH
On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote: > Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors. > The first one because it has a C99 comment style and the second one because > it is a void > return which is useless. > > Signed-off-by: Pedro Marz

Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 19, 2015 at 04:55:57PM +, Dhere, Chaitanya (C.) wrote: > In this patch: > 1. the if condition is modified to remove > the unnecessary equality check. > 2. The else if condition is replaced by an else condition > since the variable checked in the if statement is a bool > making the e

Re: [PATCH 1/3 v3] Staging: rtl8192u: Simplify error check code at prism2_wep_init

2015-05-30 Thread Greg KH
On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. > > Signed-off-by: Pedro Marzo Perez > --- > .../rtl8192u/ieee80211/ieee80211_cry

Re: [PATCH 2/3 v3] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-05-30 Thread Greg KH
On Tue, May 19, 2015 at 01:32:23AM +0200, Pedro Marzo Perez wrote: > Removed two lines at ieee80211_wep_null which checkpatch.pl reported as > errors. > The first one because it has a C99 comment style and the second one because > it is a void > return which is useless. > > Signed-off-by: Pedro

Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable

2015-05-30 Thread gre...@linuxfoundation.org
On Thu, May 28, 2015 at 06:10:26AM +, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons. > This change was detected with the help of coccinelle tool > > Signed-off-by: Harisangam Sharvari Name doesn't match... _

Re: FW: [PATCH] Staging: vt6655: Remove unnecessary equality checks in rxtx.c

2015-05-30 Thread gre...@linuxfoundation.org
On Fri, May 29, 2015 at 03:54:27PM +, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons in rxtx.c. > This change was detected with the help of coccinelle tool > > Signed-off-by: Harisangam Sharvari > --- > drivers/staging/vt6655/rxtx.c |

Re: [PATCH 1/2] staging: dgnc: use schedule_timeout_interruptible()

2015-05-30 Thread Greg Kroah-Hartman
On Fri, May 29, 2015 at 06:41:27PM +0200, Nicholas Mc Guire wrote: > API consolidation with coccinelle found: > ./drivers/staging/dgnc/dgnc_utils.c:16:1-17: > consolidation with schedule_timeout_*() recommended > > This is a 1:1 conversion with respect to schedule_timeout() to the > schedu

Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible()

2015-05-30 Thread Greg Kroah-Hartman
On Fri, May 29, 2015 at 06:47:28PM +0200, Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Ian Abbott wrote: > > > On 29/05/15 16:58, Nicholas Mc Guire wrote: > >> API consolidation with coccinelle found: > >> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17: > >> consolidation with sche

Re: [PATCH 12/13] staging: unisys: Remove unneeded fields in diagchannel.h

2015-05-30 Thread Greg KH
On Tue, May 26, 2015 at 02:40:57PM -0400, Don Zickus wrote: > From: David Kershner > > Diagchannel.h is used primarily for the diagnostics channel. The > diagnostics channel is not being used by linux guests currently, so > the majority of the file is not needed. What is left is what is > needed

Re: [PATCH 00/13 V3] Continued rest of unisys driver update

2015-05-30 Thread Greg KH
On Tue, May 26, 2015 at 02:40:45PM -0400, Don Zickus wrote: > Hi, > > GregKH ran into an issue where the last 13 patches didn't apply. > > It looks like Ben cleaned up the patches to address checkpatch.pl > warnings and forgot to refresh the patchset. > > I just refreshed the patchset and everyt

Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

2015-05-30 Thread Greg Kroah-Hartman
On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote: > API consolidation with coccinelle found: > ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: > consolidation with schedule_timeout_*() recommended > > This is a 1:1 conversion with respect to schedule_timeout()

Re: [PATCH] staging: wlan-ng: fix long line

2015-05-30 Thread Greg Kroah-Hartman
On Tue, May 19, 2015 at 01:13:42PM -0300, Douglas Barbonaglia Sathler Figueiredo wrote: > Style (line over 80 chars) in drivers/staging/wlan-ng/prism2fw.c > > Signed-off-by: Douglas Barbonaglia Sathler Figueiredo > > --- > drivers/staging/wlan-ng/prism2fw.c | 8 ++-- > 1 file changed, 6 in

Re: [PATCH] staging: fbtft: Add support for Himax HX8357D controller

2015-05-30 Thread Greg KH
On Thu, May 21, 2015 at 10:10:35PM +0200, Heiner Kallweit wrote: > The Himax HX8357D is used e.g. by the Adafruit PITFT Plus 3.5". > They added HX8357D support to an own fork of fbtft and support Raspbian > only (https://github.com/adafruit/adafruit-rpi-fbtft/). > They don't intend to push it upstr

Re: [PATCH] staging: rtl8712: fix indentation issue

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 12, 2015 at 12:25:22PM +, Gujulan Elango, Hari Prasath (H.) wrote: > Fixed indentation issue in few lines. > > Signed-off-by: Hari Prasath Gujulan Elango Same name problem :( ___ devel mailing list de...@linuxdriverproject.org http://d

Re: [PATCH] staging: emxx_udc: remove commented code

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 12, 2015 at 01:56:31PM +, Ravindran, Madhusudhanan (M.) wrote: > removed the commented INFO lines. > > Signed-off-by: Madhusudhanan Ravindran The name here doesn't match the From: line above, please fix that up to match here. thanks, greg k-h ___

Re: [PATCH] staging: fbtft: replace fbtft_dev_dbg with standard dev_dbg call

2015-05-30 Thread Greg Kroah-Hartman
On Tue, May 12, 2015 at 03:15:21PM +, Ravindran, Madhusudhanan (M.) wrote: > This patch attempts to simplify the debugging using standard > dev_dbg call so that individual debug prints can be enabled or > disbled by dynamic debugging rather than using module params. > > Signed-off-by: Madhusud

Re: [PATCH] Patch to integrate RapidDisk and RapidCache RAM Drive / Caching modules into staging subsystem.

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 06:46:26PM -0500, Petros Koutoupis wrote: > Attached is a patch for two modules: RapidDisk & RapidCache. RapidDisk is a > Linux RAM drive module which allows the user to dynamically create, remove, > and > resize RAM-based block devices. RapidDisk is designed to work with b

Re: [PATCH] Patch to integrate RapidDisk and RapidCache RAM Drive / Caching modules into staging subsystem.

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 06:46:26PM -0500, Petros Koutoupis wrote: > Attached is a patch for two modules: RapidDisk & RapidCache. RapidDisk is a > Linux RAM drive module which allows the user to dynamically create, remove, > and > resize RAM-based block devices. RapidDisk is designed to work with b

Re: [PATCH 1/1] drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix

2015-05-30 Thread Greg Kroah-Hartman
On Tue, May 12, 2015 at 08:43:10PM -0700, Tolga Ceylan wrote: > Error code returned from auth_parse() should in cpu byte order. Issue > caught by sparse warning: cast from restricted __le16. > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- > 1 file change

Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 10:12:42PM +0530, Sudip Mukherjee wrote: > On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote: > > On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote: > > > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) > > > wrote: > > > > setup_time

Re: [PATCH] staging: rtl8192e: replace printk with subsystem debug

2015-05-30 Thread gre...@linuxfoundation.org
On Mon, May 18, 2015 at 11:27:38AM +, Gujulan Elango, Hari Prasath (H.) wrote: > replace the printk with netdev subsystem debug infrastructure. > > Signed-off-by: Hari Prasath Gujulan Elango This name doesn't match up to the way you order it in the "From:" line of the patch. Can you please

Re: [PATCHv2] Staging: rtl8192e: Casting correct Endianness

2015-05-30 Thread gre...@linuxfoundation.org
On Tue, May 12, 2015 at 11:30:40AM +, DHANAPAL, GNANACHANDRAN (G.) wrote: > Casting correct Endianness for __le16 variable used in assignment and > condition check. > > Signed-off-by: Gnanachandran Dhanapal > --- > v2:Since previous version of the patch had build error.This > version ha

Re: [PATCH 2/2] staging: wilc1000: Cleanup to coreconfigurator

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 11:44:19PM +0300, Stanislav Kholmanskikh wrote: > Fixed several syntax/style issues found with checkpatch.pl, plus > aligned structs/enums to follow a common style per struct/enum. Again, please only do one thing per patch. thanks, greg k-h ___

Re: [PATCH V2 net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-30 Thread David Miller
From: "K. Y. Srinivasan" Date: Wed, 27 May 2015 13:16:57 -0700 > The current algorithm for deciding on the number of VRSS channels is > not optimal since we open up the min of number of CPUs online and the > number of VRSS channels the host is offering. So on a 32 VCPU guest > we could potentiall

Re: [PATCH 1/2] staging: wilc1000: Fix some compile warnings

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 11:44:18PM +0300, Stanislav Kholmanskikh wrote: > This patch reduces (a little bit) the amount of compile time > warnings. > > The change of WILC_WFI_init_mon_interface() prototype seems to be ok, > because alloc_netdev() also expects 'const char *name'. You are doing diff

Re: [PATCH 05/16] staging: wilc1000: remove time wrapper

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 12:09:23PM +0530, Sudip Mukherjee wrote: > On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote: > > The abstraction for time in this driver is completely > > unused, so remove it. > > > > Signed-off-by: Arnd Bergmann > > --- > > drivers/staging/wilc1000/wilc_osc

[PATCH 2/2] staging: wilc1000: Cleanup to coreconfigurator

2015-05-30 Thread Stanislav Kholmanskikh
Fixed several syntax/style issues found with checkpatch.pl, plus aligned structs/enums to follow a common style per struct/enum. Signed-off-by: Stanislav Kholmanskikh --- drivers/staging/wilc1000/coreconfigurator.c | 53 drivers/staging/wilc1000/coreconfigurator.h | 64 +

[PATCH 1/2] staging: wilc1000: Fix some compile warnings

2015-05-30 Thread Stanislav Kholmanskikh
This patch reduces (a little bit) the amount of compile time warnings. The change of WILC_WFI_init_mon_interface() prototype seems to be ok, because alloc_netdev() also expects 'const char *name'. Signed-off-by: Stanislav Kholmanskikh --- drivers/staging/wilc1000/linux_mon.c | 2 +-

Re: [PATCH] Staging: lustre: fix style issues in dt_object.c

2015-05-30 Thread Julia Lawall
On Sat, 30 May 2015, Zoltán Lajos Kis wrote: > Fixes coding style issues for lustre/lustre/odbclass/dt_object.c that > were found by the checkpatch.pl tool. > > Signed-off-by: Zoltán Lajos Kis > > --- > --- Only one --- is needed. It is better for a patch to do only one thing. This one does a

[PATCH] Staging: lustre: fix style issues in dt_object.c

2015-05-30 Thread Zoltán Lajos Kis
Fixes coding style issues for lustre/lustre/odbclass/dt_object.c that were found by the checkpatch.pl tool. Signed-off-by: Zoltán Lajos Kis --- --- drivers/staging/lustre/lustre/obdclass/dt_object.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread Dighe, Niranjan (N.)
Replace kzalloc followed by memcpy by kmemdup. This patch was generated by 'make coccicheck' Signed-off-by: Niranjan Dighe --- drivers/staging/lustre/lustre/obdclass/obd_config.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/obd

[PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread Dighe, Niranjan (N.)
Sure. I will correct and resend. Thanks, Niranjan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread Julia Lawall
On Sat, 30 May 2015, Dighe, Niranjan (N.) wrote: > Replace kzalloc followed by memcpy by kmemdup. This patch was generated > by 'make coccicheck' > > Signed-off-by: Niranjan Dighe You need a --- here. Also it is nice to put a diffstat below. julia > > diff --git a/drivers/staging/lustre/lus

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-30 Thread Tolga Ceylan
I appreciate the suggestions. I simply grepped this piece of code by chance while looking at an actual sparse warning somewhere else. There's no symptoms and I'm not sure under what conditions this debug statement is printed nor why/when. But this is an obviously buggy code only impacting debug/tr

[PATCH] Staging: lustre: Replace kzalloc followed by memcpy with

2015-05-30 Thread Dighe, Niranjan (N.)
I think it was sent correctly. Somehow gmail web interface messed it up. Please ignore. Regards, Niranjan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: lustre: Replace kzalloc followed by memcpy with

2015-05-30 Thread Dighe, Niranjan (N.)
Sorry for the double "[PATCH]" in the subject line. I will resend with correct subject line. Regards, Niranjan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: lustre: Replace kzalloc followed by memcpy with kmemdup

2015-05-30 Thread Dighe, Niranjan (N.)
Replace kzalloc followed by memcpy by kmemdup. This patch was generated by 'make coccicheck' Signed-off-by: Niranjan Dighe diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c b/drivers/staging/lustre/lustre/obdclass/obd_config.c index 0bda9c5..274cae3 100644 --- a/drivers/staging/l

[PATCH v3 0/3] staging: iio_simple_dummy: minor driver fixes

2015-05-30 Thread Vladimirs Ambrosovs
v3 Fixed the function prototypes in header file, and the dummy inline function return type, which cause the build break when CONFIG_IIO_SIMPLE_DUMMY_EVENTS and CONFIG_IIO_SIMPLE_DUMMY_BUFFER are enabled. v2 Fixed the code as per the comments from version 1: * Removed unnecessary comments

[PATCH v3 2/3] staging: iio_simple_dummy: fix return types

2015-05-30 Thread Vladimirs Ambrosovs
The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and iio_dummy_evgen_release_irq() were changed to return void instead of int. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_dummy_evgen.c | 4 +--- drivers/staging/iio/iio_dummy_evgen.h | 2

[PATCH v3 3/3] staging: iio_simple_dummy: fix module_param type

2015-05-30 Thread Vladimirs Ambrosovs
Fix the module_param "instances" type to uint, since the variable type holding the value is unsigned. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/iio_simple_dummy.c b/driver

[PATCH v3 1/3] staging: iio_simple_dummy: fix init function

2015-05-30 Thread Vladimirs Ambrosovs
This patch fixes the init function for the iio_simple_dummy driver. The main issues were absence of kfree for the allocated array, and no devices being removed in case the probe function fails, running in a loop. Signed-off-by: Vladimirs Ambrosovs --- drivers/staging/iio/iio_simple_dummy.c | 9 +

[PATCH 4.1.0-rc4] STAGING: Declare request_cache as static for drivers/staging/lustre/lustre/ptlrpc/client.c

2015-05-30 Thread Simon Guo
Declare request_cache variable as static. It is only used by drivers/staging/lustre/lustre/ptlrpc/client.c, and its naming is common which will lead to namespace pollution. Signed-off-by: Simon Guo --- drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v2 2/3] staging: iio_simple_dummy: fix return types

2015-05-30 Thread Vladimirs Ambrosovs
On Sat, May 30, 2015 at 12:24:42PM +0530, Sudip Mukherjee wrote: > On Sat, May 30, 2015 at 12:45:22AM +0300, Vladimirs Ambrosovs wrote: > > The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and > > iio_dummy_evgen_release_irq() were changed to return void instead of int, > > b

Re: [PATCH] Drivers: staging: Fixed comment and helpline spelling errors

2015-05-30 Thread Sudip Mukherjee
On Fri, May 29, 2015 at 04:00:53PM -0700, Colin Cronin wrote: > Fixed a few spelling errors in commented code, helpline text, and a TODO list > Files changed: > > diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO > index 2b2c6ea..cbc679d 100644 > --- a/drivers/staging/dgnc/TODO >