Re: [PATCH v3 8/8] staging:lustre: Update license and copyright for the LNET headers

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 04:43:27PM -0400, James Simmons wrote: > Point to the right place for GNU license. Update Intel copyright. > > Signed-off-by: James Simmons is missing regars sudip ___ devel mailing list de...@linuxdriverproject.org http://driv

Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

2015-06-03 Thread Sudip Mukherjee
On Thu, Jun 04, 2015 at 07:50:07AM +0200, Mateusz Kulikowski wrote: > On 04.06.2015 07:18, Sudip Mukherjee wrote: > > On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote: > >> On 03.06.2015 09:26, Sudip Mukherjee wrote: > >>> On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikows

Re: [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 03:57:12PM -0400, James Simmons wrote: > Handle all the style issues reported by checkpatch.pl. > Remove general white spaces, spaces in function calls, > etc. > > Signed-off-by: James Simmons > --- > @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) >

Re: [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 03:57:10PM -0400, James Simmons wrote: > With all the TCPIP handling done in the lnet layer we should > rename all the functions with the prefix lnet_*. One other > change done was changing the remove argument of lnet_sock_getaddr > from a int to a bool. thats two different

Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

2015-06-03 Thread Mateusz Kulikowski
On 04.06.2015 07:18, Sudip Mukherjee wrote: > On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote: >> On 03.06.2015 09:26, Sudip Mukherjee wrote: >>> On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote: >> >> No, I missed that - this one should also be removed - probab

Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote: > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c looks like you have not just renamed the file, but there was also a change in the #include which is not mentioned in the commit message. --- drivers/staging/lustre/lustre/li

Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 08:21:02PM +0200, Mateusz Kulikowski wrote: > On 03.06.2015 09:26, Sudip Mukherjee wrote: > > On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote: > > No, I missed that - this one should also be removed - probably because of > similar naming (DbgMode, dbg_mo

Re: Kindly Reply Me Back

2015-06-03 Thread ALBERT DING
My name is Mr.Albert Ding a legal practitioner with Peter & Associates. I found your cotact/profile some where over the Internet and it gave me the greatest joy, that you are the one I have been looking for. Whom I strongly believe could execute this project with me.Kindly get back to me for more i

[PATCHv2] staging:rtl8712:Fix compressed return statement

2015-06-03 Thread Mutharaju, Prasanna (P.)
From: Prasanna Karthik Fix reported by coccinelle compressing last two lines with single return call Signed-off-by: Prasanna Karthik --- V2: Removed psta structure pointer which is not needed shown by compiler Warning --- --- drivers/staging/rtl8712/rtl871x_sta_mgt.c |4 +--- 1 files

RE: [PATCH 02/10] Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining. We can bo better by using cpu_hotplu

2015-06-03 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, June 3, 2015 5:32 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com > Subject

Re: [PATCH 02/10] Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining. We can bo better by using cpu_hotplu

2015-06-03 Thread Greg KH
On Wed, Jun 03, 2015 at 12:31:54PM -0700, K. Y. Srinivasan wrote: > From: Vitaly Kuznetsov > > Reported-by: Radim Kr.má > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan Your subject is insane, please fix. ___ devel mailing list de

[PATCH v2] staging:lustre: cleanup libcfs lock handling

2015-06-03 Thread James Simmons
Previously with libcfs being built for user land and kernel space wrappers were created to transparently handle locking. Now that user land support has been removed we delete all those locking wrappers with this patch. Many of those changes landed upstream but some nice cleanups still remain that a

[PATCH V2 2/7] scsi: storvsc: Use a single value to track protocol versions

2015-06-03 Thread K. Y. Srinivasan
From: Keith Mange Use a single value to track protocol versions to simplify comparisons and to be consistent with vmbus version tracking. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 35 +-- 1

[PATCH V2 7/7] scsi: storvsc: Set the error code correctly in failure conditions

2015-06-03 Thread K. Y. Srinivasan
In the function storvsc_channel_init(), error code was not getting set correctly in some of the failure cases. Fix this issue. Signed-off-by: K. Y. Srinivasan Reported-by: Dan Carpenter --- drivers/scsi/storvsc_drv.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --

[PATCH V2 3/7] scsi: storvsc: Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-06-03 Thread K. Y. Srinivasan
From: Keith Mange Currently we are making decisions based on vmbus protocol versions that have been negotiated; use storage potocol versions instead. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 109 ++

[PATCH V2 1/7] scsi: storvsc: Rather than look for sets of specific protocol versions, make decisions based on ranges.

2015-06-03 Thread K. Y. Srinivasan
From: Keith Mange Rather than look for sets of specific protocol versions, make decisions based on ranges. This will be safer and require fewer changes going forward as we add more storage protocol versions. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- dr

[PATCH V2 5/7] scsi: storvsc: use storage protocol version to determine storage capabilities

2015-06-03 Thread K. Y. Srinivasan
From: Keith Mange Use storage protocol version instead of vmbus protocol version when determining storage capabilities. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c |8 1 files changed, 4 insertions(+), 4 deletions(

[PATCH V2 6/7] scsi: storvsc: Allow write_same when host is windows 10

2015-06-03 Thread K. Y. Srinivasan
From: Keith Mange Allow WRITE_SAME for Windows10 and above hosts. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/sc

[PATCH V2 4/7] scsi: storvsc: use correct defaults for values determined by protocol negotiation

2015-06-03 Thread K. Y. Srinivasan
From: Keith Mange Use correct defaults for values determined by protocol negotiation, instead of resetting them with every scsi controller. Tested-by: Alex Ng Signed-off-by: Keith Mange Signed-off-by: K. Y. Srinivasan --- drivers/scsi/storvsc_drv.c | 33 +++-- 1

[PATCH V2 0/7] scsi: storvsc: Some miscellaneous cleanup

2015-06-03 Thread K. Y. Srinivasan
Cleanup version handling as well as base feature detection on storage version as opposed to host version. In this version, I have addressed comments from Dan Carpenter. K. Y. Srinivasan (1): scsi: storvsc: Set the error code correctly in failure conditions Keith Mange (6): scsi: storvsc: Rat

[PATCH v3 7/8] staging:lustre: style cleanups for LNet headers

2015-06-03 Thread James Simmons
Handle all the style issues reported by checkpatch.pl. Remove general white spaces, alignmemnts etc. Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/lnet/api.h| 32 +- .../staging/lustre/include/linux/lnet/lib-lnet.h | 36 +- .../staging/lustre/include/linux/lnet/

[PATCH v3 2/8] staging:lustre: fixup LNet resource container api

2015-06-03 Thread James Simmons
Both lnet_res_container_setup and lnet_res_container_create have additional parameters that are no longer used with the removal of the FREELIST code. This patch removes the no longer needed function arguments. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/api-ni.c | 13

[PATCH v3 0/8] staging:lustre: remove kernel defines in userland headers

2015-06-03 Thread James Simmons
Currently the lnet headers used for user land applications contain various kernel definations. This is due to the fact libcfs contains kernel wrappers for user land which will be going away. This patch sorted the header data so all kernel containing structures are moved out of headers that user lan

[PATCH v3 5/8] staging:lustre: separate kernel and user land defines in the LNet headers

2015-06-03 Thread James Simmons
Currently the lnet headers used by user land contain various internal LNet structures that are only used by kernel space. Move the user land structures to headers used by user land. The kernel structures are relocated to headers that are never exposed to user land. Signed-off-by: James Simmons --

[PATCH v3 6/8] staging:lustre: fix camel case for LNetInit and LNetFini

2015-06-03 Thread James Simmons
For the functions LNetInit and LNetFini move away from camel case to lnet_init and lnet_fini. Signed-off-by: James Simmons --- drivers/staging/lustre/include/linux/lnet/api.h|3 --- .../staging/lustre/include/linux/lnet/lib-lnet.h |3 +++ .../staging/lustre/include/linux/lnet/lib-t

[PATCH v3 1/8] staging:lustre: assume a kernel build

2015-06-03 Thread James Simmons
From: John L. Hammond In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that __KERNEL__ is defined). Remove some common code only needed for user space LNet. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-on: http://review.whamcloud

[PATCH v3 3/8] staging:lustre: delete no longer used LNet headers

2015-06-03 Thread James Simmons
Remove the linux specific headers for LNet since they are mostly empty. Also api-support.h and lnet-sysctl.h is not needed by anyone. Lastly we delete ptllnd.h and ptllnd_wire.h which were used by Cray hardware that no longer exist. With the deletion of the headers some conditionals and wrappers th

[PATCH v3 8/8] staging:lustre: Update license and copyright for the LNET headers

2015-06-03 Thread James Simmons
Point to the right place for GNU license. Update Intel copyright. Signed-off-by: James Simmons http://www.sun.com/software/products/lustre/docs/GPLv2.pdf - * - * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, - * CA 95054 USA or visit www.sun.com if you need additional in

[PATCH v3 4/8] staging:lustre: move LNet NID macros to LNet layer

2015-06-03 Thread James Simmons
Currently several special macros LNet NID macros exist in libcfs.h and libcfs_private.h. Move those macros out to the lnet header types.h. The new lnet header nidstr.h contains LNet NID string data that can be used by user land LNet utilities and the LNet kernel drivers. Signed-off-by: James Simmo

[PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning

2015-06-03 Thread Tolga Ceylan
In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock) warning due its inability to detect the noreturn attribute in lbug_with_lock() function inside LBUG macro. With this patch, we unlock the spinlock before checking the error condition to resolve this warning. Signed-off-by: T

[PATCH v4 7/7] staging:lustre: Update license and copyright for lib-socket.c

2015-06-03 Thread James Simmons
Point to the right place for GNU license. Update Intel copyright. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/lib-socket.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c b/drivers/staging/lust

[PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix

2015-06-03 Thread James Simmons
With all the TCPIP handling done in the lnet layer we should rename all the functions with the prefix lnet_*. One other change done was changing the remove argument of lnet_sock_getaddr from a int to a bool. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |

[PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c

2015-06-03 Thread James Simmons
Handle all the style issues reported by checkpatch.pl. Remove general white spaces, spaces in function calls, etc. Signed-off-by: James Simmons --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 +- drivers/staging/lustre/lnet/lnet/lib-socket.c | 207 +--- 2 file

[PATCH v4 2/7] staging:lustre: remove useless libcfs_sock_release

2015-06-03 Thread James Simmons
There is no reason to have a one line exported function libcfs_sock_release. Instead we can call sock_release directly. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 - .../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +- .../staging/lustre/l

[PATCH v4 5/7] staging:lustre: use available kernel wrappers in lib-socket.c

2015-06-03 Thread James Simmons
Instead of handling calls to struct proto ourselves we can use equivalent kernel wrappers. No wrapper exist for unlocked ioctl handling so we create one here for our use. I expect some day that function will be integrated into sock.c. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/

[PATCH v4 1/7] staging:lustre: move tcpip abstraction

2015-06-03 Thread James Simmons
Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/Makefile |7 +- drivers/staging/lustre/lnet/lnet/lib-socket.c | 624 drivers/staging/lustre/lustre/libcfs/Makefile |1 -

[PATCH v4 3/7] staging:lustre: remove useless libcfs_sock_abort_accept

2015-06-03 Thread James Simmons
Another one of those silly one line wrappers which is not needed. Replace libcfs_sock_abort_accept wrapper with a direct call to wake_up_all on the lnet_acceptor_state sock. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 - drivers/staging/lustre/lnet/

[PATCH v4 0/7] staging:lustre: remove tcpip abstraction from libcfs

2015-06-03 Thread James Simmons
Since libcfs no longer builds for user land we can move the TCPIP abstraction that exist to the LNET layer which is the only place that uses it. Also the migrated code will use native linux kernel APIs directly instead of with wrappers. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd

Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

2015-06-03 Thread Mateusz Kulikowski
On 03.06.2015 09:26, Sudip Mukherjee wrote: > On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote: >> dig_t::dbg_mode is initialized to one value and checked only once in code. >> This patch throws it away, and deletes always-true condition. >> >> Signed-off-by: Mateusz Kulikowski >

[PATCH 02/10] Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining. We can bo better by using cpu_hotplug_en

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Reported-by: Radim Kr.má Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c | 38 -- 1 files changed, 4 insertions(+), 34 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_d

[PATCH 08/10] Drivers: hv: fcopy: dynamically allocate smsg_out in fcopy_send_data()

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov struct hv_start_fcopy is too big to be on stack on i386, the following warning is reported: >> drivers/hv/hv_fcopy.c:159:1: warning: the frame size of 1088 bytes is larger >> than 1024 bytes [-Wframe-larger-than=] Reported-by: kbuild test robot Signed-off-by: Vitaly Kuz

[PATCH 01/10] Loaded Hyper-V module will use these functions to disable CPU hotplug under certain circumstances. Convert cpu_hotplug_disabled to a counter (protected by cpu_add_remove_lock) to support

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- Documentation/power/suspend-and-cpuhotplug.txt |6 +++--- kernel/cpu.c | 13 - 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/Document

[PATCH 06/10] Drivers: hv: vmbus: use 'die' notification chain instead of 'panic'

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov current_pt_regs() returns regs of the userspace process and in case of kernel crash this is not what we need to report. E.g. when we trigger crash with sysrq we see the following: ... RIP: 0010:[] [] sysrq_handle_crash+0x16/0x20 RSP: 0018:8800db0a7d88 EFLAGS: 00010

[PATCH 09/10] Drivers: hv: balloon: Enable dynamic memory protocol negotiation with Windows 10 hosts

2015-06-03 Thread K. Y. Srinivasan
From: Alex Ng Support Win10 protocol for Dynamic Memory. Thia patch allows guests on Win10 hosts to hot-add memory even when dynamic memory is not enabled on the guest. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c | 26 -- 1 fil

[PATCH 03/10] Drivers: hv: vmbus: remove hv_synic_free_cpu() call from hv_synic_cleanup()

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov We already have hv_synic_free() which frees all per-cpu pages for all CPUs, let's remove the hv_synic_free_cpu() call from hv_synic_cleanup() so it will be possible to do separate cleanup (writing to MSRs) and final freeing. This is going to be used to assist kexec. Signed

[PATCH 05/10] Drivers: hv: don't do hypercalls when hypercall_page is NULL

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov At the very late stage of kexec a driver (which are not being unloaded) can try to post a message or signal an event. This will crash the kernel as we already did hv_cleanup() and the hypercall page is NULL. Move all common (between 32 and 64 bit code) declarations to the

[PATCH 07/10] Drivers: hv: kvp: check kzalloc return value

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov kzalloc() return value check was accidentally lost in 11bc3a5fa91f: "Drivers: hv: kvp: convert to hv_utils_transport" commit. We don't need to reset kvp_transaction.state here as we have the kvp_timeout_func() timeout function and in case we're in OOM situation it is prefe

[PATCH 04/10] Drivers: hv: vmbus: add special kexec handler

2015-06-03 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov When general-purpose kexec (not kdump) is being performed in Hyper-V guest the newly booted kernel fails with an MCE error coming from the host. It is the same error which was fixed in the "Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state" commit - mo

[PATCH 10/10] Drivers: hv: vmbus: Permit sending of packets without payload

2015-06-03 Thread K. Y. Srinivasan
The guest may have to send a completion packet back to the host. To support this usage, permit sending a packet without a payload - we would be only sending the descriptor in this case. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c |4 +++- 1 files changed, 3 insertions(+), 1 dele

[PATCH 00/10] Drivers: hv: vmbus: Enable kexec and other misc cleanup

2015-06-03 Thread K. Y. Srinivasan
In addition to enabling kexec, this patch-set has a bunch of miscellaneous fixes. Alex Ng (1): Drivers: hv: balloon: Enable dynamic memory protocol negotiation with Windows 10 hosts K. Y. Srinivasan (1): Drivers: hv: vmbus: Permit sending of packets without payload Vitaly Kuznetsov (8):

Re: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c

2015-06-03 Thread Joe Perches
On Wed, 2015-06-03 at 17:12 +, Simmons, James A. wrote: > >On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote: > >> Handle all the style issues reported by checkpatch.pl. > >> Remove general white spaces, spaces in function calls, > >> etc. > >[] > >> @@ -167,13 +164,14 @@ lnet_ipif_enumera

RE: [lustre-devel] [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c

2015-06-03 Thread Simmons, James A.
>On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote: >> Handle all the style issues reported by checkpatch.pl. >> Remove general white spaces, spaces in function calls, >> etc. >[] >> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) >> if (nalloc * sizeof(*ifr) > PAGE_CAC

Re: [lustre-devel] [PATCH v3 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 04:38:36PM +, Simmons, James A. wrote: > >On Wed, Jun 03, 2015 at 10:32:31AM -0400, James Simmons wrote: > >> With all the TCPIP handling done in the lnet layer we should > >> rename all the functions with the prefix lnet_*. One other > >> change done was changing the re

RE: [lustre-devel] [PATCH v3 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix

2015-06-03 Thread Simmons, James A.
>On Wed, Jun 03, 2015 at 10:32:31AM -0400, James Simmons wrote: >> With all the TCPIP handling done in the lnet layer we should >> rename all the functions with the prefix lnet_*. One other >> change done was changing the remove argument of lnet_sock_getaddr >> from a int to a bool. >> >> Signed-o

Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 08:47:38AM -0700, Tolga Ceylan wrote: > The second patch is better (it also keeps the lock locked shorter.) Do > I need to resend? yes, please, it was not formally submitted. regards sudip ___ devel mailing list de...@linuxdriverp

Re: [PATCH v3 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 10:32:31AM -0400, James Simmons wrote: > With all the TCPIP handling done in the lnet layer we should > rename all the functions with the prefix lnet_*. One other > change done was changing the remove argument of lnet_sock_getaddr > from a int to a bool. > > Signed-off-by:

Re: [PATCH 1/1] staging: lustre/lustre/obdclass/llog_cat.c: get rid of sparse context imbalance warning

2015-06-03 Thread Tolga Ceylan
The second patch is better (it also keeps the lock locked shorter.) Do I need to resend? On Tue, Jun 2, 2015 at 11:42 PM, Sudip Mukherjee wrote: > On Tue, Jun 02, 2015 at 12:57:20PM -0700, Tolga Ceylan wrote: >> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock) >> warning

[PATCH v2 2/3] Drivers: hv: vmbus: add special kexec handler

2015-06-03 Thread Vitaly Kuznetsov
When general-purpose kexec (not kdump) is being performed in Hyper-V guest the newly booted kernel fails with an MCE error coming from the host. It is the same error which was fixed in the "Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state" commit - monitor pages remain specia

Re: [PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c

2015-06-03 Thread Joe Perches
On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote: > Handle all the style issues reported by checkpatch.pl. > Remove general white spaces, spaces in function calls, > etc. [] > @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) > if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZ

[PATCH v2 3/3] Drivers: hv: don't do hypercalls when hypercall_page is NULL

2015-06-03 Thread Vitaly Kuznetsov
At the very late stage of kexec a driver (which are not being unloaded) can try to post a message or signal an event. This will crash the kernel as we already did hv_cleanup() and the hypercall page is NULL. Move all common (between 32 and 64 bit code) declarations to the beginning of the do_hyper

[PATCH v2 0/3] Drivers: hv: add kexec support

2015-06-03 Thread Vitaly Kuznetsov
Changes since v1: - rebased on top of current Greg's char-misc-next tree. To make general-purpose kexec (not just kdump) possible for Hyper-V guests we need to perform some additional cleanup before starting new kernel (see [PATCH 2/3] for the detailed description). Know limitations: kexec with b

[PATCH v2 1/3] Drivers: hv: vmbus: remove hv_synic_free_cpu() call from hv_synic_cleanup()

2015-06-03 Thread Vitaly Kuznetsov
We already have hv_synic_free() which frees all per-cpu pages for all CPUs, let's remove the hv_synic_free_cpu() call from hv_synic_cleanup() so it will be possible to do separate cleanup (writing to MSRs) and final freeing. This is going to be used to assist kexec. Signed-off-by: Vitaly Kuznetsov

[PATCH v3 5/7] staging:lustre: use available kernel wrappers in lib-socket.c

2015-06-03 Thread James Simmons
Instead of handling calls to struct proto ourselves we can use equivalent kernel wrappers. No wrapper exist for unlocked ioctl handling so we create one here for our use. I expect some day that function will be integrated into sock.c. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/

[PATCH v3 2/7] staging:lustre: remove useless libcfs_sock_release

2015-06-03 Thread James Simmons
There is no reason to have a one line exported function libcfs_sock_release. Instead we can call sock_release directly. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 - .../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +- .../staging/lustre/l

[PATCH v3 7/7] staging:lustre: Update license and copyright for lib-socket.c

2015-06-03 Thread James Simmons
Point to the right place for GNU license. Update Intel copyright. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/lib-socket.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c b/drivers/staging/lust

[PATCH v3 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix

2015-06-03 Thread James Simmons
With all the TCPIP handling done in the lnet layer we should rename all the functions with the prefix lnet_*. One other change done was changing the remove argument of lnet_sock_getaddr from a int to a bool. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |

[PATCH v3 6/7] staging:lustre: style cleanups for lib-socket.c

2015-06-03 Thread James Simmons
Handle all the style issues reported by checkpatch.pl. Remove general white spaces, spaces in function calls, etc. Signed-off-by: James Simmons --- .../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 +- drivers/staging/lustre/lnet/lnet/lib-socket.c | 210 +--- 2 file

[PATCH v3 0/7] staging:lustre: remove tcpip abstraction from libcfs

2015-06-03 Thread James Simmons
Since libcfs no longer builds for user land we can move the TCPIP abstraction that exist to the LNET layer which is the only place that uses it. Also the migrated code will use native linux kernel APIs directly instead of with wrappers. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd

[PATCH v3 3/7] staging:lustre: remove useless libcfs_sock_abort_accept

2015-06-03 Thread James Simmons
Another one of those silly one line wrappers which is not needed. Replace libcfs_sock_abort_accept wrapper with a direct call to wake_up_all on the lnet_acceptor_state sock. Signed-off-by: James Simmons --- .../staging/lustre/include/linux/libcfs/libcfs.h |1 - drivers/staging/lustre/lnet/

[PATCH v3 1/7] staging:lustre: move tcpip abstraction

2015-06-03 Thread James Simmons
Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/lnet/Makefile |7 +- drivers/staging/lustre/lnet/lnet/lib-socket.c | 624 drivers/staging/lustre/lustre/libcfs/Makefile |1 -

Re: [PATCH] staging:rtl8712:Fix compressed return statement

2015-06-03 Thread Larry Finger
On 06/03/2015 08:28 AM, Mutharaju, Prasanna (P.) wrote: On Wed, Jun 03, 2015 at 02:35:35PM +0530, Sudip Mukherjee wrote: On Wed, Jun 03, 2015 at 08:23:54AM +, Mutharaju, Prasanna (P.) wrote: From: Prasanna Karthik Fix reported by coccinelle compressing last two lines with single return ca

[PATCH] staging: lustre: ptlrpc: clean up whitespace and align function params

2015-06-03 Thread Chris Hanna
Minor changes to remove excessive whitespace and improve readability of ptlrpc functions. Signed-off-by: Chris Hanna --- drivers/staging/lustre/lustre/ptlrpc/client.c | 90 drivers/staging/lustre/lustre/ptlrpc/events.c | 60 +++--- drivers/staging/lustre/lustre/ptlrpc/impo

[PATCH resend] staging: lustre: osc: clean up whitespace and align function parameters

2015-06-03 Thread Chris Hanna
Minor changes to remove excessive whitespace and improve readability of osc functions. Signed-off-by: Chris Hanna --- Sending again due to tree mismatch. drivers/staging/lustre/lustre/osc/lproc_osc.c | 18 +- drivers/staging/lustre/lustre/osc/osc_cache.c | 196 +++--- dri

Re: [PATCH resend] staging: lustre: osc: clean up whitespace and align function parameters

2015-06-03 Thread Chris Hanna
Thanks for noticing, I'll re-submit correctly. Chris On 6/3/15 1:54 AM, Sudip Mukherjee wrote: > On Tue, Jun 02, 2015 at 11:32:19AM -0400, Chris Hanna wrote: >> Signed-off-by: Chris Hanna >> >> Minor changes to remove excessive whitespace and improve >> readability of functions. > this descripti

Re: [PATCH] staging:rtl8712:Fix compressed return statement

2015-06-03 Thread Mutharaju, Prasanna (P.)
On Wed, Jun 03, 2015 at 02:35:35PM +0530, Sudip Mukherjee wrote: > On Wed, Jun 03, 2015 at 08:23:54AM +, Mutharaju, Prasanna (P.) wrote: > > From: Prasanna Karthik > > > > Fix reported by coccinelle compressing last two lines with single return > > call > > > > Signed-off-by: Prasanna Karthi

[PATCH] staging: wilc1000: Remove commented code lines

2015-06-03 Thread Sharma, Abhishek (A.)
From: Abhishek Sharma Removing the commented code lines. Signed-off-by: Abhishek Sharma --- drivers/staging/wilc1000/wilc_wlan.c | 65 1 file changed, 65 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c

RE: [PATCH] staging: wilc1000: Remove commented variable declerations

2015-06-03 Thread Sharma, Abhishek (A.)
Sudip, I have already submitted the patch V2 with additional From: line. Regards Abhishek -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, June 03, 2015 4:53 PM To: Sharma, Abhishek (A.) Cc: Johnny Kim; Rachel Kim; Dean Lee; Chris Park; Greg K

Re: [PATCH 2/2] [PATCH] staging: lustre: llite: Fix space required before the open paranthesis '('

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 03:43:47PM +0530, Aparna Karuthodi wrote: > Added a space before the open paranthesis '(' this patch is 2/2, but where is your 1/2 patch? regards sudip > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxd

Re: [PATCH] staging: wilc1000: Remove commented variable declerations

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 09:56:11AM +, Sharma, Abhishek (A.) wrote: > Removing the commented static variable declerations. > > Signed-off-by: Abhishek Sharma Your email header From: name is not matching with Signed-off-by: name. If you cannot fix your email client then please send v2 with an a

[PATCH 2/2] [PATCH] staging: lustre: llite: Fix space required before the open paranthesis '('

2015-06-03 Thread Aparna Karuthodi
Added a space before the open paranthesis '(' Signed-off-by: Aparna Karuthodi --- drivers/staging/lustre/lustre/llite/lproc_llite.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lpro

[PATCH v2] staging: wilc1000: Remove commented variable declerations

2015-06-03 Thread Sharma, Abhishek (A.)
From: Abhishek Sharma Removing the commented static variable declerations. Signed-off-by: Abhishek Sharma --- drivers/staging/wilc1000/wilc_wlan.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index e63788f.

RE: [PATCH] staging: wilc1000: Remove commented variable declerations

2015-06-03 Thread Sharma, Abhishek (A.)
Please discard this patch . I will send V2 of it . -Original Message- From: Sharma, Abhishek (A.) Sent: Wednesday, June 03, 2015 3:26 PM To: Johnny Kim; Rachel Kim; Dean Lee; Chris Park; Greg Kroah-Hartman; linux-wirel...@vger.kernel.org; de...@driverdev.osuosl.org; linux-ker...@vger.ke

[PATCH] staging: wilc1000: Remove commented variable declerations

2015-06-03 Thread Sharma, Abhishek (A.)
Removing the commented static variable declerations. Signed-off-by: Abhishek Sharma --- drivers/staging/wilc1000/wilc_wlan.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index e63788f..e1d9755 100644 --- a/dri

[PATCH] staging: lustre: llite: Fix No space after the declaration

2015-06-03 Thread Aparna Karuthodi
Added a new line Signed-off-by: Aparna Karuthodi --- drivers/staging/lustre/lustre/llite/llite_capa.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c index aec9a44..a626871 100644 --- a/dr

[PATCH 2/2] staging: wilc1000: remove commented code

2015-06-03 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango Remove commented code from this file. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 117 -- 1 file changed, 117 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.

[PATCH 1/2] staging: wilc1000: remove ununsed function

2015-06-03 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango The function WILC_WFI_InitPriv() is not used anywhere in the driver.Hence remove it. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/dr

Re: [PATCH] staging:rtl8712:Fix compressed return statement

2015-06-03 Thread Sudip Mukherjee
On Wed, Jun 03, 2015 at 08:23:54AM +, Mutharaju, Prasanna (P.) wrote: > From: Prasanna Karthik > > Fix reported by coccinelle compressing last two lines with single return > call > > Signed-off-by: Prasanna Karthik > --- > drivers/staging/rtl8712/rtl871x_sta_mgt.c |3 +-- > 1 files cha

[PATCH] staging:rtl8712:Fix compressed return statement

2015-06-03 Thread Mutharaju, Prasanna (P.)
From: Prasanna Karthik Fix reported by coccinelle compressing last two lines with single return call Signed-off-by: Prasanna Karthik --- drivers/staging/rtl8712/rtl871x_sta_mgt.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_sta_mgt.

Re: [PATCH 07/11] staging: rtl8192e: Remove dead code: dig_t::dbg_mode

2015-06-03 Thread Sudip Mukherjee
On Tue, Jun 02, 2015 at 10:48:11PM +0200, Mateusz Kulikowski wrote: > dig_t::dbg_mode is initialized to one value and checked only once in code. > This patch throws it away, and deletes always-true condition. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtl8192e/rtl_dm.

Re: [PATCH 2/3 v4] Staging: rtl8192u: Remove two useless lines at ieee80211_wep_null

2015-06-03 Thread pmarzo
On mar, 2015-06-02 at 22:40 +0900, Greg KH wrote: > On Tue, Jun 02, 2015 at 03:35:05PM +0200, pmarzo wrote: > > Ok, I will download your staging tree and regenerate patches 1/3 and 2/3 > > with that git tree. That would be v5 1/2 and 2/2 new patches. > > Just one (probably very stupid) question, wh