From: Hari Prasath Gujulan Elango
This patch fixes a build warning related to the use of the time_after_eq
macro.Adding a typecast to the second argument suppresses the
warning.This warning was created by one my previous patch.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wil
Fixed a warning, else is not generally useful after a break or return.
Signed-off-by: Nizam Haider
---
drivers/staging/rts5208/xd.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index 8fd108e..10fea7b 100644
From: Harisangam Sharvari
The unnecessary equality checks for bool variable are removed in rxtx.c.
These changes were detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari
---
drivers/staging/vt6655/rxtx.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Point to the right place for GNU license. Update Intel copyright.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/lib-socket.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c
b/drivers/staging/lust
Handle all the style issues reported by checkpatch.pl.
Remove general white spaces, spaces in function calls,
etc.
Signed-off-by: James Simmons
---
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|4 +-
drivers/staging/lustre/lnet/lnet/lib-socket.c | 203 +---
2 file
Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/lnet/Makefile |7 ---
.../linux/linux-tcpip.c => lnet/lnet/lib-socket.c} |3 ++-
drivers/staging/lustre/lustre/libcfs/Makefile |1 -
3 files chan
Another one of those silly one line wrappers which is not
needed. Replace libcfs_sock_abort_accept wrapper with a
direct call to wake_up_all on the lnet_acceptor_state sock.
Signed-off-by: James Simmons
---
.../staging/lustre/include/linux/libcfs/libcfs.h |1 -
drivers/staging/lustre/lnet/
With all the TCPIP handling done in the lnet layer we should
rename all the functions with the prefix lnet_*. One other
change done was changing the remove argument of lnet_sock_getaddr
from a int to a bool.
Signed-off-by: James Simmons
---
.../staging/lustre/include/linux/libcfs/libcfs.h |
Instead of handling calls to struct proto ourselves we can use
equivalent kernel wrappers. No wrapper exist for unlocked ioctl
handling so we create one here for our use. I expect some day
that function will be integrated into sock.c.
Signed-off-by: James Simmons
---
drivers/staging/lustre/lnet/
There is no reason to have a one line exported function
libcfs_sock_release. Instead we can call sock_release directly.
Signed-off-by: James Simmons
---
.../staging/lustre/include/linux/libcfs/libcfs.h |1 -
.../staging/lustre/lnet/klnds/socklnd/socklnd.c|2 +-
.../staging/lustre/l
Since libcfs no longer builds for user land we can
move the TCPIP abstraction that exist to the LNET
layer which is the only place that uses it. Also
the migrated code will use native linux kernel
APIs directly instead of with wrappers.
Signed-off-by: James Simmons
Intel-bug-id: https://jira.hpdd
On Friday, June 05, 2015 10:30 AM, Ian Abbott wrote:
> Clean up the Comedi "das08" module a bit, mostly for consistent naming
> of things.
> drivers/staging/comedi/drivers/das08.c | 333
> -
> drivers/staging/comedi/drivers/das08.h | 48 ++---
> 2 files changed
On 2015/06/05, 3:02 AM, "Dan Carpenter" wrote:
>On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote:
>> Currently the lnet headers used by user land contain various internal
>> LNet structures that are only used by kernel space. Move the user land
>> structures to headers used by user l
In dir.c and llite_lib.c, sparse reports multiple warnings messages
due to different address spaces. This patch resolves these warnings
by adding the tag __user for username addresses.
Signed-off-by: Tolga Ceylan
---
drivers/staging/lustre/lustre/llite/dir.c | 78 +
dig_t::dbg_mode and drx_path_sel::DbgMode are initialized to one value and
checked only once in code.This patch throws them away, and deletes
always-true conditions.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 8 ++--
drivers/staging/rtl8192e/rtl8192e/
dm_shadow array is no longer used.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 3 ---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
b/drivers/staging/rtl8192e/rtl8
Remaining part of patch after review by Dan and Sudip (thanks!):
- New patch: Remove dm_shadow
- Rework 'Remove dead code' patch - delete DbgMode
All other patches are already applied to staging-testing.
This series applies to current staging-testing (bfee7c9665), and was
target tested (802.11N/
Eliminate "space prohibited before that ','" errors found by checkpatch,
but do this only to lines which after the patch is applied do not
exceed 80 characters. Out of that only those lines are changed, whose
context does not exceed 80 characters in each line. In other words the
changes are limited
On Mon, Jun 08, 2015 at 12:41:08PM -0700, Greg KH wrote:
> On Tue, Jun 02, 2015 at 12:55:06PM +0400, Stanislav Kholmanskikh wrote:
> > Fixed several syntax/style issues found with checkpatch.pl.
>
> What exactly is "several"? Please be specific as to what type of
> changes you are making.
>
> Pl
Fixed the following issues found with checkpatch.pl:
* Multiple debug strings contained " \n". Changed
it to "\n".
* Changed 'return(X)' to 'return X'.
* Aligned TAG_PARAM_OFFSET to fit 80 columns
Signed-off-by: Stanislav Kholmanskikh
---
Changes since v3:
* Put a more detailed explanation
Aligned enum members to follow a common style per enum.
Signed-off-by: Stanislav Kholmanskikh
---
drivers/staging/wilc1000/coreconfigurator.c | 29 +++---
drivers/staging/wilc1000/coreconfigurator.h | 62 ++---
2 files changed, 46 insertions(+), 45 deletions(-)
d
On Tue, Jun 02, 2015 at 03:59:32PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> From: Gnanachandran Dhanapal
>
> Casting correct Endianness for __le16 variable used in assignment and
> condition check
>
> Signed-off-by: Gnanachandran Dhanapal
> ---
> v3: Greg review comments addressed
>
> ---
On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> This patch deletes all references to 'flipbuf'.Memory is allocated and
> freed but never used anywhere in the driver.Also deleted an ununsed
> Macro defined in the header fi
On Mon, Jun 01, 2015 at 04:16:50AM +, Harisangam, Sharvari (S.) wrote:
> From: Sharvari Harisangam
>
> Modified the if-else statements to remove unnecessary comparisons in rxtx.c.
> This change was detected with the help of coccinelle tool
>
> Signed-off-by: Sharvari Harisangam
> ---
> dr
Caro cliente,
Estamos atualizando nosso centro de conta de banco de dados e e-mail. Estamos a
excluir todas as contas de webmail não utilizados e criar mais espaço para
novas contas. Para garantir que você não experimenta a interrupção do serviço
durante este período, você precisa clicar no lin
On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote:
> Please generate patches in -M format, so I can see the rename properly,
> as it is, this is too messy for me to review.
Adding this to the .gitconfig works too
[diff]
renames = true
That should probably be mentioned in Submit
On Mon, Jun 08, 2015 at 09:37:24PM +0200, Ksenija Stanojević wrote:
> Hi Greg,
>
> It's been over two weeks that I've sent this patch. Have you missed it?
Not at all, please look at the output of
$ ./scripts/get_maintainer.pl --file
drivers/staging/media/lirc/lirc_sir.c
To see why I ig
On Mon, 2015-06-08 at 16:54 -0300, Mauro Carvalho Chehab wrote:
> The DVB API was originally defined using typedefs. This is against
> Kernel CodingStyle, and there's no good usage here. While we can't
> remove its usage on userspace, we can avoid its usage in Kernelspace.
>
> So, let's do it.
>
This patch applies cleanly to staging-next tree
Antonio Murdaca (1):
staging: lustre: cleanup not needed else clauses
drivers/staging/lustre/lustre/fid/fid_request.c| 5 ++---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 +--
drivers/staging/lustre/lustre/ldlm/ldlm_lib.
From: Antonio Murdaca
cleanup checkpatch.pl warnings about not needed else
clauses after a break or return
Signed-off-by: Antonio Murdaca
---
drivers/staging/lustre/lustre/fid/fid_request.c| 5 ++---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 +--
drivers/staging/lust
On Tue, Jun 02, 2015 at 12:55:06PM +0400, Stanislav Kholmanskikh wrote:
> Fixed several syntax/style issues found with checkpatch.pl.
What exactly is "several"? Please be specific as to what type of
changes you are making.
Please fix and resend both of these.
thanks,
greg k-h
_
On Wed, Jun 03, 2015 at 04:43:22PM -0400, James Simmons wrote:
> Remove the linux specific headers for LNet since they are
> mostly empty. Also api-support.h and lnet-sysctl.h is not
> needed by anyone. Lastly we delete ptllnd.h and ptllnd_wire.h
> which were used by Cray hardware that no longer ex
Hi Greg,
It's been over two weeks that I've sent this patch. Have you missed it?
Thanks,
Ksenija
On Fri, May 22, 2015 at 9:52 PM, Arnd Bergmann wrote:
> On Friday 22 May 2015 17:58:42 Ksenija Stanojevic wrote:
>> 'struct timeval last_tv' is used to get the time of last signal change
>> and 'st
On Wed, Jun 03, 2015 at 01:20:10PM -0700, Tolga Ceylan wrote:
> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
> warning due its inability to detect the noreturn attribute in
> lbug_with_lock() function inside LBUG macro. With this patch, we unlock
> the spinlock before c
On Mon, Jun 8, 2015 at 9:31 PM, Greg KH wrote:
> On Wed, Jun 03, 2015 at 03:43:47PM +0530, Aparna Karuthodi wrote:
>> Added a space before the open paranthesis '('
If you're having to resend anyway: s,paranthesis,parenthesis,
Frans
___
devel mailing li
On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote:
> Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c
>
> Signed-off-by: James Simmons
> ---
> drivers/staging/lustre/lnet/lnet/Makefile |7 +-
> drivers/staging/lustre/lnet/lnet/lib-socket.c | 624
> +
On Wed, Jun 03, 2015 at 03:43:47PM +0530, Aparna Karuthodi wrote:
> Added a space before the open paranthesis '('
>
> Signed-off-by: Aparna Karuthodi
> ---
> drivers/staging/lustre/lustre/llite/lproc_llite.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I do not see a patch 1/2 for
I'll send a v2 as soon as possible!
2015-06-08 21:28 GMT+02:00 Greg KH :
> On Mon, Jun 01, 2015 at 02:18:51PM +0200, Antonio Murdaca wrote:
>> cleanup checkpatch.pl warnings about not needed else
>> clauses after a break or return
>>
>> Signed-off-by: Antonio Murdaca
>> ---
>> drivers/staging/lu
On Mon, Jun 01, 2015 at 02:18:51PM +0200, Antonio Murdaca wrote:
> cleanup checkpatch.pl warnings about not needed else
> clauses after a break or return
>
> Signed-off-by: Antonio Murdaca
> ---
> drivers/staging/lustre/lustre/fid/fid_request.c| 5 ++-
> .../staging/lustre/lustre/include/lp
On Mon, 2015-06-08 at 20:22 +0530, Sudip Mukherjee wrote:
> On Thu, Jun 04, 2015 at 10:46:51PM -0700, Joe Perches wrote:
> > On Fri, 2015-06-05 at 10:22 +0530, Sudip Mukherjee wrote:
> > > On Thu, Jun 04, 2015 at 01:48:31PM -0700, Joe Perches wrote:
> > []
>
> > I looked at it a bit more and there
On Thu, Jun 04, 2015 at 10:46:51PM -0700, Joe Perches wrote:
> On Fri, 2015-06-05 at 10:22 +0530, Sudip Mukherjee wrote:
> > On Thu, Jun 04, 2015 at 01:48:31PM -0700, Joe Perches wrote:
> []
> I looked at it a bit more and there's a macro that calls
> write_register so there are actually many more
The fields set_oabufs and set_pga fields in the lov_request_set structure
are never set, so drop them. Drop also the corresponding test and free in
lov_finish_set.
Signed-off-by: Julia Lawall
---
drivers/staging/lustre/lustre/lov/lov_internal.h |2 --
drivers/staging/lustre/lustre/lov/lov_
The rq_buflen field of the lov_request structure is never initialized. It
is only used in the free of req->rq_oi.oi_md in lov_finish_set. But no
oi_md field is ever initialized to the result of calling OBD_ALLOC_LARGE.
So it seems that the call to OBD_FREE_LARGE in lov_finish_set and the
rq_bufle
The lov_lock_handles structure is only used as the type of the field
set_lockh in the lov_request_set structure, and this field is never set to
any value. Drop a test and free of this field in lov_finish_set. This
change enables also removing the functions lov_handle2llh and lov_llh_put
that mani
Lov_finish_set in lov_request.c considers freeing various things that
have never been initialized. Drop this and some dependent unnecessary
code.
drivers/staging/lustre/lustre/lov/lov_internal.h | 37
drivers/staging/lustre/lustre/lov/lov_request.c | 10 ---
2 files
Thanks. These look nice.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Jun 8, 2015, at 3:24 AM, Julia Lawall wrote:
>> You are right, set_pga seems to be a dead member. It was alive a once, but
>> somehow not fully removed now,
>> so it's safe to drop the whole if and also the struct member itself.
>> set_oabufs could be dropped as well.
>
> Looking further,
> You are right, set_pga seems to be a dead member. It was alive a once, but
> somehow not fully removed now,
> so it's safe to drop the whole if and also the struct member itself.
> set_oabufs could be dropped as well.
Looking further, in the same function I also don't see any other uses o
48 matches
Mail list logo
