On Tue, Jun 09, 2015 at 08:34:55PM +0100, Daniel Lockyer wrote:
> Fixed the issues with curly braces either needing to be on the line above or
> below in several files.
please rebase your patch against staging-testing. It will not apply.
da295041a811adc2 ("Staging: sm750fb: ddk750_display.c: Inser
On Wed, Jun 10, 2015 at 04:54:47AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> @@ -7159,8 +7144,9 @@ err_stop:
> */
> static void dgap_cleanup_module(void)
> {
> - if (dgap_numboards)
> - pci_unregister_driver(&dgap_driver);
> +
On Wed, Jun 10, 2015 at 01:01:20AM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Deleting obvious comments
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
> > ---
> > drivers/
From: Hari Prasath Gujulan Elango
This patch deletes the comments secion which is obvious and outdated
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Addrressed Dan carpenter review comments to remove the entire
comments section as its outdated and obvious.
---
drivers/staging/dgap/
From: Hari Prasath Gujulan Elango
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
method to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Addressed Dan Carpenters
From: Oleg Drokin
strncpy_from_user could return negative values on error,
so need to take those into account.
Since ll_getname is used to get a single component name from userspace
to transfer to server as-is, there's no need to allocate 4k buffer
as done by __getname. Allocate NAME_MAX+1 buffer
From: Oleg Drokin
Some time ago Al Viro noticed that lustre ll_getname is broken.
At the time a patch was submitted to convert lustre to use
exported getname, that was rejected by hch on the grounds that
filesystem code sould not really be reimplementing their own
lookups which kind of made sense
From: Oleg Drokin
It uses getname in unsafe manner and since it's to deal with corrupted
or inconsistent filesystem, we are probably better to deal with
it from lfsck anyway.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dir.c | 29 -
1 file cha
On Tue, Jun 09, 2015 at 10:26:54PM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 05:26:01PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > The driver remove function is not the right place to cleanup resources
> > allocated in the driver m
From: Hari Prasath Gujulan Elango
This patch fixes a build warning related to the use of the time_after_eq
macro.Adding a typecast to the second argument suppresses the
warning.This warning was created by one my previous patch.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Previous
On Tue, Jun 09, 2015 at 05:28:19PM -0500, Daniel Holman wrote:
> Removed typedef
Why?
I think you just broke userspace, what did you do to verify this still
works properly?
You need a whole lot of justification for making this type of change,
not just 2 words, please provide it.
thanks,
greg k
> -Original Message-
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: Tuesday, June 09, 2015 5:12 PM
> To: Rivera Jose-B46482
> Cc: Greg Kroah-Hartman; Arnd Bergmann; de...@driverdev.osuosl.org; linux-
> kernel; Yoder Stuart-B08248; Sharma Bhupesh-B45370; ag...@suse.de;
> Hamciuc B
Removed typedef
Signed-off-by: Daniel Holman
---
drivers/staging/android/uapi/ion.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/android/uapi/ion.h
b/drivers/staging/android/uapi/ion.h
index 68a14b4..25af17f 100644
--- a/drivers/staging/android/uap
Hi German,
On Tue, Jun 9, 2015 at 6:59 PM, J. German Rivera
wrote:
> This patch series includes new functionality for the Freescale fsl-mc
> bus driver.
>
> Patch 1: MC bus IRQ support
> Patch 2: add device binding path 'driver_override'
> Patch 3: Propagate driver_override for a child DPRC's chi
- Migrated MC bus driver to use DPRC API 0.6.
- Changed IRQ setup infrastructure to be able to program MSIs
for MC objects in an object-independent way.
Signed-off-by: J. German Rivera
---
Changes in v4:
- Fixed new checkpatch warnings and checks
- Add missing error handling in dprc_probe()
d
If the msi-parent property is not present in the fsl,qoriq-mc node
of the device tree, the MC bus driver will assume that the GIC is not
supported.
This change is made in order to be able to use the MC bus driver in a
KVM VM, without having GIC-ITS support in guests. Added function
fsl_mc_interrup
- Refactored fsl_mc_io object to have a DPMCP object attached to it
- Created DPMCP object for DPRC's built-in portal, so that waiting
on MC command completions for MC commands sent on the DPRC's built-in
portal can be done using a DPMCP interrupt and a Linux completion
variable. For most ca
All the IRQs for DPAA2 objects in the same DPRC must use
the ICID of that DPRC, as their device Id in the GIC-ITS.
Thus, all these IRQs must share the same ITT table in GIC. As
a result, a pool of IRQs with the same device Id must be
preallocated per DPRC (fsl-mc bus instance). So, the fsl-mc
bus o
Add a locking mechanism to serialize mc_send_command() calls that use
the same fsl_mc_io object (same MC portal). When the fsl_mc_io object is
created the owner needs to know in which type of context the fsl_mc_io
object is going to be used. A flag passed-in to fsl_create_mc_io()
will indicate whet
When a child DPRC is bound to the vfio_fsl_mc driver via driver_override,
its own children should not be bound to corresponding host kernel
drivers, but instead should be bound to the vfio_fsl_mc driver as
well.
Currently, when a child container is scanned by the vfio_fsl_mc driver,
child devices
From: Bharat Bhushan
This patch is required for vfio-fsl-mc meta driver to successfully bind
layerscape container devices for device passthrough. This patch adds
a mechanism to allow a layerscape device to specify a driver rather than
a layerscape driver provide a device match.
This patch is bas
This patch series includes new functionality for the Freescale fsl-mc
bus driver.
Patch 1: MC bus IRQ support
Patch 2: add device binding path 'driver_override'
Patch 3: Propagate driver_override for a child DPRC's children
Patch 4: Upgraded MC bus driver to match MC fw 7.0.0
Patch 5: Allow the MC
On Tue, Jun 09, 2015 at 05:27:00PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Deleting obvious comments
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/dgap/dgap.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 21175ef7e0db27989f37096ff5121255ac201c12
commit: 52db7520775e5c4103e0e06a61abbadcf73d2d96 [669/741] staging: wilc1000:
fix warning while printing
config: openrisc-allmodconfig (attached as .config)
re
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 21175ef7e0db27989f37096ff5121255ac201c12
commit: 52db7520775e5c4103e0e06a61abbadcf73d2d96 [669/741] staging: wilc1000:
fix warning while printing
config: mn10300-allmodconfig (attached as .config)
rep
This patch replaces the C99-style comments (//) with /* */.
Signed-off-by: Daniel Lockyer
---
drivers/staging/sm750fb/ddk750_dvi.c | 9 +++--
drivers/staging/sm750fb/ddk750_help.c | 4 ++--
drivers/staging/sm750fb/sm750_cursor.c | 5 +++--
3 files changed, 8 insertions(+), 10 deletions(-)
This patch fixes the indenting in several files. Most changes were removing
spaces or tabbing into place.
Signed-off-by: Daniel Lockyer
---
drivers/staging/sm750fb/ddk750_dvi.c | 69 +-
drivers/staging/sm750fb/ddk750_power.c | 34 -
2 files chan
This patch fixes spacing issues reported from checkpatch.pl. These include:
* between a C keyword and the next character ( "if(" => "if (" )
* between a comma and the next character
* between a * and the next character
Signed-off-by: Daniel Lockyer
---
drivers/staging/sm750fb/ddk750_display.c |
Fixed the issues with curly braces either needing to be on the line above or
below in several files.
Signed-off-by: Daniel Lockyer
---
drivers/staging/sm750fb/ddk750_display.c | 66 ++--
drivers/staging/sm750fb/ddk750_dvi.c | 6 +--
drivers/staging/sm750fb/ddk75
Went through a few files and fixed some code style issues reported by
checkpatch.pl.
Signed-off-by: Daniel Lockyer
Daniel Lockyer (4):
SM750FB: Fix bracket placement issue from checkpatch.pl
SM750FB: Fix spacing issues from checkpatch.pl
SM750FB: Fix indenting issues from checkpatch.pl
On Tue, Jun 09, 2015 at 05:26:01PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> The driver remove function is not the right place to cleanup resources
> allocated in the driver module init.The cleanup is moved from remove
> function to module exit as ap
Understood, working on it now! :)
Regards,
Daniel
On Tue, Jun 09, 2015 at 10:47:34AM -0700, Greg KH wrote:
> On Tue, Jun 09, 2015 at 06:14:37PM +0100, Daniel Lockyer wrote:
> > Fixed loads of checkpatch.pl issues. Nothing particularly notable.
>
> But you need to note it.
>
> Also, only do one
On Tue, Jun 09, 2015 at 06:14:37PM +0100, Daniel Lockyer wrote:
> Fixed loads of checkpatch.pl issues. Nothing particularly notable.
But you need to note it.
Also, only do one type of cleanup per patch, otherwise it's impossible
to review, and it can not be accepted. Please break this up into a
On Tue, Jun 09, 2015 at 10:41:18AM -0700, gre...@linuxfoundation.org wrote:
> On Tue, Jun 09, 2015 at 06:43:59AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch fixes a build warning related to the use of the time_after_eq
> > macro.Addi
On Tue, Jun 09, 2015 at 06:43:59AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> This patch fixes a build warning related to the use of the time_after_eq
> macro.Adding a typecast to the second argument suppresses the
> warning.This warning was created b
On Mon, Jun 08, 2015 at 11:54:28PM +0300, Stanislav Kholmanskikh wrote:
> Fixed the following issues found with checkpatch.pl:
>
> * Multiple debug strings contained " \n". Changed
> it to "\n".
>
> * Changed 'return(X)' to 'return X'.
>
> * Aligned TAG_PARAM_OFFSET to fit 80 columns
That is
On Mon, Jun 08, 2015 at 11:54:29PM +0300, Stanislav Kholmanskikh wrote:
> Aligned enum members to follow a common style per enum.
You also reformatted defines, which you didn't mention here :(
___
devel mailing list
de...@linuxdriverproject.org
http://dr
From: Hari Prasath Gujulan Elango
Deleting obvious comments
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgap/dgap.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 185e9e5..03153d8 100644
--- a/drivers/st
From: Hari Prasath Gujulan Elango
The driver remove function is not the right place to cleanup resources
allocated in the driver module init.The cleanup is moved from remove
function to module exit as appropriate.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/dgap/dgap.c | 17
Fixed loads of checkpatch.pl issues. Nothing particularly notable.
Mainly indenting, comments or removing dead code.
Signed-off-by: Daniel Lockyer
---
drivers/staging/sm750fb/ddk750_display.c | 124 +--
drivers/staging/sm750fb/ddk750_dvi.c | 86 ++---
On Tue, Jun 09, 2015 at 06:15:50PM +0200, Ksenija Stanojević wrote:
> On Mon, Jun 8, 2015 at 10:12 PM, Greg KH wrote:
> > On Mon, Jun 08, 2015 at 09:37:24PM +0200, Ksenija Stanojević wrote:
> >> Hi Greg,
> >>
> >> It's been over two weeks that I've sent this patch. Have you missed it?
> >
> > Not
On Mon, Jun 8, 2015 at 10:12 PM, Greg KH wrote:
> On Mon, Jun 08, 2015 at 09:37:24PM +0200, Ksenija Stanojević wrote:
>> Hi Greg,
>>
>> It's been over two weeks that I've sent this patch. Have you missed it?
>
> Not at all, please look at the output of
> $ ./scripts/get_maintainer.pl --fi
>We're going through and re-indenting things. I think just one space
>between type and name is the right thing for .c files but you guys
>really should figure out what style you're using for your header files.
This is good to know. I didn't know how you felt about the lustre style.
I will fix it
>On 2015/06/05, 3:02 AM, "Dan Carpenter" wrote:
>
>>On Wed, Jun 03, 2015 at 04:43:24PM -0400, James Simmons wrote:
>>> Currently the lnet headers used by user land contain various internal
>>> LNet structures that are only used by kernel space. Move the user land
>>> structures to headers used by
From: Gnanachandran Dhanapal
Casting correct Endianness for __le16 variable used in assignment and
condition check
Signed-off-by: Gnanachandran Dhanapal
---
v5: Following review comments given addressed
Blank line in the wrong spot. - v4
the blank line before variab
On Tue, Jun 09, 2015 at 04:41:33PM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath
>
On Tue, Jun 09, 2015 at 04:51:02PM +0300, Dan Carpenter wrote:
> No. See my other email.
>
> Also this is super ugly and your instinct should have told you that ugly
> things are normally wrong.
>
> regards,
> dan carpenter
>
Dan,I guess functionality wise this also does the job.Maybe this is
Em Mon, 08 Jun 2015 13:03:03 -0700
Joe Perches escreveu:
> On Mon, 2015-06-08 at 16:54 -0300, Mauro Carvalho Chehab wrote:
> > The DVB API was originally defined using typedefs. This is against
> > Kernel CodingStyle, and there's no good usage here. While we can't
> > remove its usage on userspac
On Tue, Jun 09, 2015 at 12:22:27PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> From: Gnanachandran Dhanapal
>
> Casting correct Endianness for __le16 variable used in assignment and
> condition check
>
> Signed-off-by: Gnanachandran Dhanapal
> ---
> v4: Greg review comments addressed
Which on
No. See my other email.
Also this is super ugly and your instinct should have told you that ugly
things are normally wrong.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/list
On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> > On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Hari Prasath Gujulan Elango
> > >
> > > Cl
>On Thu, Jun 04, 2015 at 10:34:20AM +0300, Dan Carpenter wrote:
>> On Thu, Jun 04, 2015 at 11:05:54AM +0530, Sudip Mukherjee wrote:
>> > On Wed, Jun 03, 2015 at 03:57:07PM -0400, James Simmons wrote:
>> > > Rename libcfs/linux/linux-tcpip.c to lnet/lnet/lib-socket.c
>> > looks like you have not jus
From: Gnanachandran Dhanapal
Casting correct Endianness for __le16 variable used in assignment and
condition check
Signed-off-by: Gnanachandran Dhanapal
---
v4: Greg review comments addressed
---
drivers/staging/rtl8192e/rtllib_softmac.c | 13 +
1 file changed, 9 insertions(+),
From: Hari Prasath Gujulan Elango
The dgap_stop function need to be invoked only if pci_register_driver()
fails.The same cleanup is done in pci_unregister_driver() function if
pci_register_driver() succeeds.We can avoid same cleanup being done
twice.
Signed-off-by: Hari Prasath Gujulan Elango
-
On Tue, Jun 09, 2015 at 04:38:04PM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath
On Tue, Jun 09, 2015 at 10:54:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> > On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Hari Prasath Gujulan Elango
> > No. this is
On Tue, Jun 09, 2015 at 03:32:20PM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Cleanup the device entry,device class & unregister the character device
> > in the module exit.All
On Tue, Jun 09, 2015 at 09:27:22AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Cleanup the device entry,device class & unregister the character device
> in the module exit.All this cleanup is done already in the dgap_stop()
> function.We need to call t
From: Hari Prasath Gujulan Elango
Cleanup the device entry,device class & unregister the character device
in the module exit.All this cleanup is done already in the dgap_stop()
function.We need to call this in the cleanup module.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/d
On 9 June 2015 at 13:00, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Hari Prasath Gujulan Elango
>
> Cleanup the device entry,device class & unregister the character device
> in the module exit.All this cleanup is done already in the dgap_stop()
> function.We need to call this in the cleanup
while building on i386 it gives a build warning about msg undeclared.
Fixes: e6ffd1ba55a4931c ("staging: fbtft: fix out of bound access")
Reported-by: kbuild test robot
Signed-off-by: Sudip Mukherjee
---
It was my mistake that I missed removing msg in the original patch.
But I am still surprise
On Mon, Jun 08, 2015 at 01:29:30PM -0700, gre...@linuxfoundation.org wrote:
> On Mon, Jun 01, 2015 at 01:06:15PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > This patch deletes all references to 'flipbuf'.Memory is allocated and
> > freed but ne
From: Hari Prasath Gujulan Elango
Cleanup the device entry,device class & unregister the character device
in the module exit.All this cleanup is done already in the dgap_stop()
function.We need to call this in the cleanup module.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/d
63 matches
Mail list logo
