Replace spaces with tabs for indentation to fix the checkpatch.pl warning
'WARNING: please, no spaces at the start of a line'
checkpatch doesn't catch comments indented by spaces but I fixed comments
adjacent to warnings as well so they would remain aligned.
Changes since v1:
fix alignment in
On Fri, Jun 19, 2015 at 10:21 PM, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote:
Replace spaces with tabs for indentation to fix the checkpatch.pl warning
'WARNING: please, no spaces at the start of a line'
checkpatch doesn't catch
Replace spaces with tabs for indentation to fix the checkpatch.pl warning
'WARNING: please, no spaces at the start of a line'
checkpatch doesn't catch comments indented by spaces but I fixed comments
adjacent to warnings as well so they would remain aligned.
Signed-off-by: Juston Li
Used C89 instead of C99 Comments and removed C99 comments performing
prints only.
Problem found using checkpatch.pl
ERROR: do not use C99 // comments
Signed-off-by: Amitoj Kaur Chawla amitoj1...@gmail.com
---
drivers/staging/sm750fb/ddk750_chip.c | 10 ++
1 file changed, 2
Replace spaces with tabs for indentation to fix the checkpatch.pl warning
'WARNING: please, no spaces at the start of a line'
checkpatch doesn't catch comments indented by spaces but I fixed comments
adjacent to warnings as well so they would remain aligned.
Signed-off-by: Juston Li
The presence of comments originally caused the two lines
to be over 80 characters long.
The issue is fixed by moving the comments into a separate line.
Signed-off-by: Arjun Krishna Babu arjunkrishnabab...@gmail.com
---
drivers/staging/vt6656/rxtx.c | 7 +--
1 file changed, 5 insertions(+),
On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote:
Replace spaces with tabs for indentation to fix the checkpatch.pl warning
'WARNING: please, no spaces at the start of a line'
checkpatch doesn't catch comments indented by spaces but I fixed comments
adjacent to warnings as well so
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/dmm32at.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/fl512.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/dac02.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/s626.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/daqboard2000.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Abdul Hussain (6):
staging: comedi: dmm32at: Simplify a trivial if-return sequence
staging: comedi: fl512: Simplify a trivial if-return sequence
staging: comedi: daqboard2000: Simplify
else statement after if is unnecessary, hence removed.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/rtl8712/rtl871x_security.c | 35 ++
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c
On Fri, Jun 19, 2015 at 06:00:06AM +, Abdul, Hussain (H.) wrote:
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
snip
- return 0;
+
On Sun, Jun 14, 2015 at 03:48:53PM +0200, Fabio Falzoi wrote:
Use a helper function to manage delink states
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 141
++--
1 file changed, 72 insertions(+), 69
On Fri, Jun 19, 2015 at 02:22:02PM +0530, Sunil Shahu wrote:
Fix code indentation error by replacing tab in place of spaces.
Signed-off-by: Sunil Shahu shsh...@gmail.com
when you are sending a modified patch, please mark it as [PATCH v2]
otherwise it becomes confusing.
regards
sudip
On Fri, Jun 19, 2015 at 06:08:04AM +, Abdul, Hussain (H.) wrote:
On Friday 19 June 2015 04:30 AM, gre...@linuxfoundation.org wrote:
On Tue, Jun 16, 2015 at 02:03:44PM +, Abdul, Hussain (H.) wrote:
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return
On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote:
It was noticed that iochannel.h was still using pragmas to
pack the datastructures, should be using __packed instead.
Signed-off-by: David Kershner david.kersh...@unisys.com
Could you take some time and figure out which structs
else statement after if is unnecessory, hence removed.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/rtl8712/rtl871x_security.c | 35 ++
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c
On Friday 19 June 2015 04:30 AM, gre...@linuxfoundation.org wrote:
On Tue, Jun 16, 2015 at 02:03:44PM +, Abdul, Hussain (H.) wrote:
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by:
Fix code indentation error by replacing tab in place of spaces.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_sasem.c
On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
Fix code indentation error by replacing tab in place of spaces.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix code indentation error by replacing tab in place of spaces.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_sasem.c
On Sat, Jun 13, 2015 at 02:16:18PM +0530, Sudip Mukherjee wrote:
can you please have a look (when you are free) at it to see if anything
else needs to be done.
Remove any unused macros.
Cleanup indenting in the .h file.
drivers/staging/sm7xxfb/sm7xxfb.c:821 smtcfb_pci_probe() warn:
Fix CHANGE_LINK_STATE value when card_exist is true.
Fixes: a9b693cd77d7 (Staging: rts5208: helper function to manage delink
states)
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Arjun Krishna Babu arjunkrishnabab...@gmail.com
---
drivers/staging/rtl8712/rtl8712_led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_led.c
b/drivers/staging/rtl8712/rtl8712_led.c
index ada8d5d..0df7b0c 100644
---
On Fri, Jun 19, 2015 at 10:41:28PM +0800, Arjun Krishna Babu wrote:
Signed-off-by: Arjun Krishna Babu arjunkrishnabab...@gmail.com
---
drivers/staging/rtl8712/rtl8712_led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_led.c
On Wed, Jun 17, 2015 at 04:54:44PM +0530, Sudip Mukherjee wrote:
@@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char
__user *buf, size_t
dst = buffer;
for (i = c 2; i--;) {
*dst = fb_readl(src++);
-
On Wed, Jun 17, 2015 at 04:54:48PM +0530, Sudip Mukherjee wrote:
Fix the checkpatch warning about CamelCase.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
2 files changed, 2 insertions(+), 2
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Friday, June 19, 2015 8:55 AM
To: Kershner, David A
Cc: gre...@linuxfoundation.org; jes.soren...@redhat.com; *S-Par-
Maintainer; driverdev-devel@linuxdriverproject.org; Romer, Benjamin M
Subject: Re:
Oh. Ok. Fine.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Kershner, David A david.kersh...@unisys.com writes:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Friday, June 19, 2015 8:55 AM
To: Kershner, David A
Cc: gre...@linuxfoundation.org; jes.soren...@redhat.com; *S-Par-
Maintainer;
On Wed, Jun 17, 2015 at 04:54:46PM +0530, Sudip Mukherjee wrote:
+static const struct ModeInit vgamode[] = {
+ {
+ /* mode#0: 640 x 480 16Bpp 60Hz */
+ 640, 480, 16, 60,
+ /* Init_MISC */
+ 0xE3,
+ { /* Init_SR0_SR4 */
+ 0x03,
Fix CHANGE_LINK_STATE value when card_exist is true.
This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Fri, 2015-06-19 at 17:12 +0200, Fabio Falzoi wrote:
Fix CHANGE_LINK_STATE value when card_exist is true.
This bug was introduced in a9b693cd77d70fb93dad8cbce667a49cd9b87352
Please use just 12 byte of the SHA-1 and add the title:
Something like:
This bug was introduced in commit
Hi Mauro, etc:
Are you okay with this change landing in the tip tree?
--Andy
On Fri, Jun 12, 2015 at 4:44 PM, Andy Lutomirski l...@kernel.org wrote:
It wasn't compiled in by default. I suspect that the driver was and
still is broken, though -- it's calling udelay with a parameter
that's
On Fri, Jun 19, 2015 at 01:52:43PM +0530, Sunil Shahu wrote:
else statement after if is unnecessory, hence removed.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/rtl8712/rtl871x_security.c | 35
++
1 file changed, 16 insertions(+), 19
On Fri, Jun 19, 2015 at 03:02:32PM +, Kershner, David A wrote:
Thanks for the find. Unfortunately, all the structs defined in iochannel.h
need to be packed since they are shared across different OS and code
instances. I'll look into changing the s-Par firmware and will update the
40 matches
Mail list logo
