Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code

On 29/06/15 10:15, Ian Abbott wrote: On 27/06/15 06:36, Santhosh Pai wrote: From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 From: santhosh pai santhosh.pa...@yahoo.com Date: Mon, 22 Jun 2015 23:26:33 +0530 Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the

Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote: This patch fixes checkpatch warnings Signed-off-by: Ravi Teja Darbha rav...@gmail.com David, Is this code removed after you ripped out the parahotplug stuff? IOW, the next round of updates from Ben might obsolete this patch.

[PATCH] staging:rtl8188eu: Code cleanup fix reported by coccinelle

From: Prasanna Karthik mkart...@visteon.com bool check modified Signed-off-by: Prasanna Karthik mkart...@visteon.com --- drivers/staging/rtl8188eu/hal/rf_cfg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rf_cfg.c

Re: [PATCH] staging: comedi: adl_pci9118: Delete an unnecessary check before the function call pci_dev_put

On 27/06/15 13:10, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Sat, 27 Jun 2015 13:50:43 +0200 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected

[PATCH] staging: Comedi: comedi_fops: Fixed the return error code

From: Santhosh Pai santhosh.pa...@yahoo.com This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and hence -ENXIO is returned indicating no device or

Re: [PATCH] staging: Comedi: comedi_fops: Fixed the return error code

On 29/06/15 10:41, Ian Abbott wrote: From: Santhosh Pai santhosh.pa...@yahoo.com From: Santhosh Pai santhosh.pa...@yahoo.com Oops. I managed to screw it up as well. I'll repost it. -- -=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=- -=( Web:

[PATCH] staging: Comedi: comedi_fops: Fixed the return error code

From: Santhosh Pai santhosh.pa...@yahoo.com From: Santhosh Pai santhosh.pa...@yahoo.com This patch fixes the checkpatch.pl warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else try_module_get fails when the reference count of the module is not allowed to be incremented ,and

[PATCH v4 00/19] staging: sm750fb: checkpatch.pl fixes

This patch set includes 19 patches fixing indentation, spacing, brace placement and missing blank lines from checkpatch.pl warnings/errors in staging/sm750fb. Regards Juston - Changes since v3: * Fix comment placement 16/19 * Rebase to current staging-testing Changes since v2: *

[PATCH v4 05/19] staging: sm750fb: remove space between function name and parenthesis

Fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/sm750_accel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v4 03/19] staging: sm750fb: remove space before close parenthesis

Fixes checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 3 files changed, 3

[PATCH v4 02/19] staging: sm750fb: remove spacing after open parenthesis

Fixes checkpatch.pl warning: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_power.c | 8 3 files

[PATCH v4 14/19] staging: sm750fb: remove trailing whitespace

Fixes checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- drivers/staging/sm750fb/sm750_hw.c| 24 3 files changed, 15

[PATCH v4 15/19] staging: sm750fb: remove unnecessary whitespace

Fixes checkpatch.pl warning: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/sm750.c| 2 +- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v4 17/19] staging: sm750fb: move while to follow do close brace

Fixes checkpatch.pl error: ERROR: while should follow close brace '}' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_display.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c

[PATCH v4 16/19] staging: sm750fb: fix brace placement

Fix brace placement errors caught by checkpatch.pl ERROR: that open brace { should be on the previous line Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_chip.h| 12 +++ drivers/staging/sm750fb/ddk750_display.c | 56 ++--

[PATCH v4 09/19] staging: sm750fb: add space after struct definition

Fixes checkpatch.pl warning: WARNING: missing space after struct definition Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/sm750.h| 12 ++-- drivers/staging/sm750fb/sm750_hw.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v4 11/19] staging: sm750fb: consistent spacing around operators

Fixes checkpatch.pl error: ERROR: need consistent spacing around operator Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_chip.c| 4 ++-- drivers/staging/sm750fb/ddk750_display.h | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +-

[PATCH v4 08/19] staging: sm750fb: add space after enum definition

Fixes checkpatch.pl warning: WARNING: missing space after enum definition Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_display.h | 2 +- drivers/staging/sm750fb/sm750_hw.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v4 01/19] staging: sm750fb: use tabs for indentation

Replace spaces with tabs for indentation to fix the checkpatch.pl error ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_display.c | 100

[PATCH v4 13/19] staging: sm750fb: add space after semicolon

Fixes checkpatch.pl error: ERROR: space required after that ';' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/sm750.h| 2 +- drivers/staging/sm750fb/sm750_cursor.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v4 12/19] staging: sm750fb: add spaces around operators

Fixes checkpath.pl error: ERROR: spaces required around that operator Note running checkpatch.pl with '--strict' catches more of these errors along with cases where spacing is optional but preferred. Take care of these in a future patch. Signed-off-by: Juston Li juston.h...@gmail.com ---

[PATCH v4 10/19] staging: sm750fb: add space after return type

Fixes checkpatch.pl warning: WARNING: missing space after return type Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/sm750.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h

[PATCH v4 06/19] staging: sm750fb: add space before open brace

Fixes checkpatch.pl error: ERROR: space required before the open brace '{' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_display.c | 14 drivers/staging/sm750fb/ddk750_mode.c| 8 ++--- drivers/staging/sm750fb/ddk750_power.c | 4 +--

[PATCH v4 19/19] staging: sm750fb: add missing blank line after declarations

Fixes checkpatch.pl WARNING: Missing a blank line after declarations Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_chip.c| 1 + drivers/staging/sm750fb/ddk750_display.c | 2 ++ drivers/staging/sm750fb/ddk750_dvi.c | 1 +

[PATCH v4 18/19] staging: sm750fb: remove unnecessary braces

Fixes checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/sm750_accel.c | 9 +++-- drivers/staging/sm750fb/sm750_hw.c| 6 ++ 2 files changed, 5 insertions(+), 10

[PATCH v4 04/19] staging: sm750fb: add space before open parenthesis

Fixes checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_display.c | 20 +-- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_help.c| 2 +-

[PATCH v4 07/19] staging: sm750fb: add space after close brace

Fixes checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 2 +- drivers/staging/sm750fb/ddk750_power.c | 2 +-

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby niko...@gnu.org wrote: This fixes a typo: base_flag_bumber to base_flag_number Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/hv/hyperv_vmbus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hyperv_vmbus.h

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

On Mon, Jun 29, 2015 at 06:11:22PM -0300, Fabio Estevam wrote: On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby niko...@gnu.org wrote: This fixes a typo: base_flag_bumber to base_flag_number Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/hv/hyperv_vmbus.h | 2 +- 1 file changed, 1

RE: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

-Original Message- From: Nik Nyby [mailto:niko...@gnu.org] Sent: Monday, June 29, 2015 2:59 PM To: Fabio Estevam Cc: KY Srinivasan; de...@linuxdriverproject.org Subject: Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct Fabio Estevam feste...@gmail.com writes:

[PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

This fixes a typo: base_flag_bumber to base_flag_number Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/hv/hyperv_vmbus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h index cddc0c9..6383707 100644 ---

Re: [PATCH] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: 1. Fix line over 80 characters warning. Great, but: 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rtl8712_recv.c:499: +

[PATCH RESEND] rtl8712:Fix checkpatch warning

Fix line over 80 characters warning. Signed-off-by: Ravi Teja Darbha rav...@gmail.com --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c index

Re: [PATCH RESEND] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:48:48AM +0530, Ravi Teja Darbha wrote: Fix line over 80 characters warning. Signed-off-by: Ravi Teja Darbha rav...@gmail.com --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Drivers: hv: vmbus: fix typo in hv_port_info struct

Fabio Estevam feste...@gmail.com writes: On Mon, Jun 29, 2015 at 5:55 PM, Nik Nyby niko...@gnu.org wrote: This fixes a typo: base_flag_bumber to base_flag_number Signed-off-by: Nik Nyby niko...@gnu.org --- drivers/hv/hyperv_vmbus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] rtl8712:Fix checkpatch warning

1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rtl8712_recv.c:499: +return false; +else while(condition1) { if(condition2) foo();

Re: [PATCH RESEND] rtl8712:Fix checkpatch warning

On Mon, Jun 29, 2015 at 10:18 PM, Ravi Teja Darbha rav...@gmail.com wrote: Fix line over 80 characters warning. Signed-off-by: Ravi Teja Darbha rav...@gmail.com --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] [RESEND] rtl8712:Fix checkpatch warning

Fix line over 80 characters warning. Signed-off-by: Ravi Teja Darbha rav...@gmail.com --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c index

Re: [PATCH] staging: lustre: lnet: fix type warning in lib-socket.c

This patch isn't the correct fix. The lustre people need to go through and cleanup this stuff, it's not really a good patch for a newbie to start with. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings

On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote: This patch fixes checkpatch warnings This patch is scary for how wrong it looks. But the changelog is definitely wrong so I'm not going to try understand the patch. regards, dan carpenter

Re: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code

On 27/06/15 06:36, Santhosh Pai wrote: From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 From: santhosh pai santhosh.pa...@yahoo.com Date: Mon, 22 Jun 2015 23:26:33 +0530 Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code try_module_get

Re: [V2][v3.14.y][PATCH 0/1] Drivers: hv: vmbus: Add support for VMBus panic notifier handler

On Wed, Jun 17, 2015 at 02:18:18PM -0400, Joseph Salisbury wrote: Hello, Please consider including upstream commits 96c1d0581d00f7abe033350edb021a9d947d8d81 and 5ef5b6927f14f29cacd78fa1fb861661a5367f13 in the next v3.14.y release. They were included mainline as of v4.1-rc1. They have

Re: [PATCH] rtl8712:Fix checkpatch warning

On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: 1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rtl8712_recv.c:499: +return

Re: [PATCH] rtl8712:Fix checkpatch warning

On 06/29/2015 11:29 PM, Sudip Mukherjee wrote: On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: 1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE:

[PATCH] rts5208:Fix checkpatch warnings

Else condition after if statement is not necessary, hence removed. Signed-off-by: Ravi Teja Darbha rav...@gmail.com --- drivers/staging/rts5208/xd.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c index