On Mon, 2015-07-06 at 08:07 +0200, Krzysztof Hałasa wrote:
Joe Perches j...@perches.com writes:
Nah, you're not an extremist, you're just preferring narrowly
localized readability over global consistency.
That's fine and all, until you come up to LCONSOLE_ERROR_MSG
type use which blows
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote:
This patch fixes the checkpatch.pl warning:
WARNING: Macros with flow control statements should be avoided
Replace the macro with a function doing the exact same task as the
macro.
No. You haven't understood what
On Mon, Jul 06, 2015 at 08:07:52AM +0200, Krzysztof Hałasa wrote:
Joe Perches j...@perches.com writes:
Nah, you're not an extremist, you're just preferring narrowly
localized readability over global consistency.
That's fine and all, until you come up to LCONSOLE_ERROR_MSG
type use
Joe Perches j...@perches.com writes:
So, could we have the localized readability when it makes sense,
and the default rules when nothing else applies?
Then the question becomes how local.
The answer seems easy to me: as much as it's needed to get the best
readability.
If that means 4 or 2
On Mon, Jul 06, 2015 at 05:45:24PM +0530, Ravi Teja Darbha wrote:
What you need to do is to replace all DGNC_VERIFY_BOARD() macro calls with
its definition.
And repeating the same code 12 times??
That is why the macro is there, to avoid the duplication of code.
regards
sudip
On 25/06/15 13:05, Dmitry Kalinkin wrote:
This is why I think this is not a “we broke userspace” situation.
The vme_user module is also in the staging tree and (almost) by
definition the API shouldn't be considered as stable.
Martyn
--
Martyn Welch (Lead Software Engineer) | Registered
What you need to do is to replace all DGNC_VERIFY_BOARD() macro calls with its
definition.
Regards,
Ravi Teja
On Sun, Jul 05, 2015 at 11:46:28PM +0530, Arjun Krishna Babu wrote:
This patch fixes the checkpatch.pl warning:
WARNING: Macros with flow control statements should be avoided
On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch martyn.we...@ge.com wrote:
On 26/06/15 21:39, Dmitry Kalinkin wrote:
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
---
drivers/staging/vme/devices/vme_user.c | 47
--
1 file changed, 11 insertions(+),
A helper function is also added.
Signed-off-by: Dexuan Cui de...@microsoft.com
---
include/linux/hyperv.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 30d3a1f..aa21814 100644
--- a/include/linux/hyperv.h
+++
With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver
can register 2 callbacks and can know when a new hvsock connection is
offered by the host, and when a hvsock connection is being closed by the
host.
Signed-off-by: Dexuan Cui de...@microsoft.com
---
drivers/hv/Makefile
This will be used by the coming net/hvsock driver.
Signed-off-by: Dexuan Cui de...@microsoft.com
---
drivers/hv/channel.c | 131 ++
drivers/hv/hyperv_vmbus.h | 4 ++
drivers/hv/ring_buffer.c | 14 +
include/linux/hyperv.h| 33
On 26/06/15 21:39, Dmitry Kalinkin wrote:
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
---
drivers/staging/vme/devices/vme_user.c | 47 --
1 file changed, 11 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism
between Windowsd 10 (or later) host and a guest. It's kind of TCP over
VMBus, but the transportation layer (VMBus) is much simpler than IP.
With Hyper-V VM Sockets, applications between the host and a guest can
talk with
Hi Dmitry,
These are looking good to me.
You mention error handling in relation to vme_master_mmap, am I right in
thinking patch 3 avoids errors being recorded when triggered by an mmap
access (so as not to appear as a spurious error on a later access)?
I think it would be worth at least
Hyper-V VM sockets (hvsock) supplies a byte-stream based communication
mechanism between the host and a guest. It's kind of TCP over VMBus, but
the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM
Sockets, applications between the host and a guest can talk with each
other
In the SMP guest case, when the per-channel callback hvsock_events() is
running on virtual CPU A, if the guest tries to close the connection on
virtual CPU B: we invoke vmbus_close() - vmbus_close_internal(),
then we can have trouble: on B, vmbus_close_internal() will send IPI
reset_channel_cb()
This will be used by the coming net/hvsock driver.
Signed-off-by: Dexuan Cui de...@microsoft.com
---
include/linux/hyperv.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 307910b3..c52f4cb 100644
--- a/include/linux/hyperv.h
+++
On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said:
Why would you use a macro to avoid code duplication?
The macro does end up putting code in each place it's used.
However, the actual code is in one place rather than open-coded
in multiple places that can diverge over time (somebody
Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism
between Windowsd 10 (or later) host and a guest. It's kind of TCP over
VMBus, but the transportation layer (VMBus) is much simpler than IP.
With Hyper-V VM Sockets, applications between the host and a guest can
talk with
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
drivers/staging/comedi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index 7dee73dfbf88ff09..57e71f9f14a2385b 100644
---
[Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on
CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:
Hi all,
On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven ge...@linux-m68k.org
wrote:
On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang
On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote:
Sorry about the *really* late reply, loads of emails some how missed my
periodic search of the mailing list.
I'm happy with the addition of DMA, just not sure whether it's worth adding
an extra device file just to handle
On 06/07/15 14:10, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 3:51 PM, Martyn Welch martyn.we...@ge.com wrote:
On 26/06/15 21:39, Dmitry Kalinkin wrote:
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
---
drivers/staging/vme/devices/vme_user.c | 47
Hi Paul,
On Mon, Jul 6, 2015 at 3:42 PM, Paul Gortmaker
paul.gortma...@windriver.com wrote:
BTW, Chen's patch is missing the OF_IRQ dependency Geert found in
his build coverage; I'd folded that into the v2 above, figuring
that is what he'd desired I do with it.
Which I'm very grateful for.
Since this is turning into a long thread, the correct thing is to copy
3eb141511bd5 ('staging: dgap: get rid of nasty DGAP_VERIFY_BOARD macro').
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
From: Oleg Drokin gr...@linuxhacker.ru
It was used to control allocation failure rate, but there is
in-kernel way of doing that that's more versatile too.
This is going to remove just the sysctl, the underlying variable
will be removed once all OBD_ALLOC* macros removal patchseries land.
From: Oleg Drokin gr...@linuxhacker.ru
This patch series removes the sysctls (also under /proc) from Lustre.
/proc/sys/lnet is moved to debugfs and
/proc/sys/lustre content is moved to /sys/fs/lustre
Additionally we now have the tools that understand the new layout,
and so first few patches fix
From: Oleg Drokin gr...@linuxhacker.ru
Dan Carpenter noticed that procfs conversion patches introduced
a bug where should kobject_create_and_add, an error is not returned
from class_procfs_init.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
From: Oleg Drokin gr...@linuxhacker.ru
This helps to avoid use after free on unmount.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
drivers/staging/lustre/lustre/lov/lov_obd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
From: Oleg Drokin gr...@linuxhacker.ru
This is the first step of moving lustre sysctls from
/proc/sys/lustre to /sys/fs/lustre
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
drivers/staging/lustre/lustre/include/obd_class.h | 4 +-
drivers/staging/lustre/lustre/obdclass/class_obd.c | 6
From: Oleg Drokin gr...@linuxhacker.ru
max_dirty_mb is now a parameter in /sys/fs/lustre/
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 74 +-
drivers/staging/lustre/sysfs-fs-lustre | 12
2 files
From: Oleg Drokin gr...@linuxhacker.ru
In the past when Lustre did its own allocation amounts tracking
the results were shown in sysctl as current and overall max
number of bytes and pages allocated. Now that we don't
track these, remove the sysctls.
Signed-off-by: Oleg Drokin
From: Oleg Drokin gr...@linuxhacker.ru
Adaptive Timeouts controls are being moved from /proc/sys/lustre
to /sys/fs/lustre
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 45 --
drivers/staging/lustre/sysfs-fs-lustre
From: Oleg Drokin gr...@linuxhacker.ru
Parameters in lnet sysctl are of debug quantity, so let's move them
to debugfs instead.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
drivers/staging/lustre/lustre/libcfs/module.c | 86 +--
1 file changed, 56 insertions(+), 30
From: Oleg Drokin gr...@linuxhacker.ru
debug_peer_on_timeout, dump_on_timeout and dump_on_eviction
controls from /proc/sys/lustre to /sys/fs/lustre
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 28 ++
From: Oleg Drokin gr...@linuxhacker.ru
It turns out if you call ldlm_pools_fini without completing the
ldlm_pools_init, then attempt to unregister not yet registered
shrinkers makes the kernel very unhappy.
So make sure we have them registered first.
Signed-off-by: Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com
It is no longer used anywhere.
Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 1 -
drivers/staging/lustre/lustre/libcfs/debug.c | 3 ---
On 07/06/2015 06:47 PM, Greg KH wrote:
How about making it a patch for drivers/staging/ ? That way the code
can get cleaned up in-tree by others?
Ah, I thought that was what I did? As in, I checked out the kernel git
repository, moved the driver code into drivers/staging/, and used git diff
From: Oleg Drokin gr...@linuxhacker.ru
module parameter libcfs_console_backoff accessible through
/sys/module/libcfs/parameters/libcfs_console_backoff would
do the same thing, just add a special uintpos parameter
type to disallow 0 values too.
Also add a symlink to the module parameter variable
From: Oleg Drokin gr...@linuxhacker.ru
Since all of the variables from /proc/sys/lustre were moved to
/sys/fs/lustre, get rid of the remaining infrastructure.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
---
drivers/staging/lustre/lustre/include/obd_class.h | 1 -
From: Oleg Drokin gr...@linuxhacker.ru
ldlm_timeout is used server-side to determine AST timeouts,
so it makes no sense on the client, esp. since it's not really used
anywhere.
Remove all traces of it except from the config where make
it a noop.
Signed-off-by: Oleg Drokin gr...@linuxhacker.ru
From: Dmitry Eremin dmitry.ere...@intel.com
Remove portal_enter_debugger because it's not used any more.
Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com
---
drivers/staging/lustre/lustre/libcfs/debug.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
From: Dmitry Eremin dmitry.ere...@intel.com
/proc/sys/lnet/lnet_memused
Remove memory tracking for LNet.
Remove redundant enums definition.
Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com
---
.../lustre/include/linux/libcfs/libcfs_private.h | 28 +--
From: Oleg Drokin gr...@linuxhacker.ru
It's just a fancy libcfs_debug_mb module parameter wrapper,
so just add debug buffer size check and resizing and the same
functionality now would be accessible via
/sys/module/libcfs/parameters/libcfs_debug_mb
Also add a symlink for backwards compatibility.
From: Oleg Drokin gr...@linuxhacker.ru
/proc/sys/lnet/console_ratelimit, debug_path and panic_on_lbug
are module parameters with no special magic accessible via
/sys/module/libcfs/parameters/libcfs_console_ratelimit,
/sys/module/libcfs/parameters/libcfs_debug_file_path and
On Mon, Jul 06, 2015 at 07:01:30PM +0200, P. Varet wrote:
On 07/06/2015 06:47 PM, Greg KH wrote:
How about making it a patch for drivers/staging/ ? That way the code
can get cleaned up in-tree by others?
Ah, I thought that was what I did? As in, I checked out the kernel git
repository,
From: Dmitry Eremin dmitry.ere...@intel.com
They are just fancy module parameters wrappers,
so just the same functionality now would be accessible via
/sys/module/libcfs/parameters/libcfs_console_{min,max}_delay
Also install compatibility symlinks
Signed-off-by: Dmitry Eremin
On Mon, Jul 6, 2015 at 5:48 PM, Martyn Welch martyn.we...@ge.com wrote:
On 06/07/15 14:50, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote:
Sorry about the *really* late reply, loads of emails some how missed my
periodic search of the mailing
On Mon, Jul 06, 2015 at 06:25:25PM +0200, P. Varet wrote:
Hi all,
This is me keeping a promise I made to Greg KH half a year ago. (Thread
here:
https://www.reddit.com/r/linux/comments/2ny1lz/im_greg_kroahhartman_linux_kernel_developer_ama/cmhyvqh)
WHAT IS THIS?
=
This
When packet encapsulation is in use, the MTU needs to be reduced for
headroom reservation.
The existing code takes the updated MTU value only from the host side.
But vSwitch extensions, such as Open vSwitch, require the flexibility
to change the MTU to different values from within a guest during
On Mon, Jul 06, 2015 at 09:53:26PM -0400, Sreenath Madasu wrote:
When the checkpatch.pl script was run, it showed lines with length
more than 80 characters in rtw_ap.c file. Fixed line number 382 by
breaking it up into two lines within 80 characters.
Signed-off-by: Sreenath Madasu
On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
This patch fixes the checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
+#define CONSUME(val, ptr) (val) = consume(sizeof(val),
On Fri, Jun 26, 2015 at 04:43:44PM +0200, Luis de Bethencourt wrote:
Patches to be applied on top of
https://patchwork.kernel.org/patch/6655831/
I don't use patchwork, and when on an airplane with no internet access
(like right now), a url provides no context at all. Always use email
subject
On Tue, Jun 30, 2015 at 05:34:34PM +0900, Dean Lee wrote:
delete odd structure and rework it.
what do you mean by rework it? It looks like you just made it a void
* everywhere, which is what I explicitly said to not do.
sorry, can't take this.
greg k-h
On Sat, Jun 27, 2015 at 04:36:14PM +0200, SF Markus Elfring wrote:
From: Markus Elfring elfr...@users.sourceforge.net
Date: Sat, 27 Jun 2015 15:56:57 +0200
Why is this in the body of the email? Please fix your email client or
just use git send-email properly.
On Sat, Jun 27, 2015 at 04:37:24PM +0200, SF Markus Elfring wrote:
From: Markus Elfring elfr...@users.sourceforge.net
Date: Sat, 27 Jun 2015 16:00:59 +0200
Again, please fix.
The kfree() function was called in two cases by the mac_ioctl() function
during error handling even if the passed
On Tue, Jun 30, 2015 at 05:34:37PM +0900, Dean Lee wrote:
modify it
modify what?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote:
On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
[]
Here is another version with macro expansion. Inline function
expansion doesn't
seem like a good idea
It is to fix:
hv_kvp_daemon.c:705:2: warning: format not a string literal and no format
arguments [-Wformat-security]
Signed-off-by: Dexuan Cui de...@microsoft.com
---
tools/hv/hv_kvp_daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hv/hv_kvp_daemon.c
Joe Perches j...@perches.com writes:
Nah, you're not an extremist, you're just preferring narrowly
localized readability over global consistency.
That's fine and all, until you come up to LCONSOLE_ERROR_MSG
type use which blows the nice old formatting up.
So what I suggested is just a
Hello,
The ion has internal page pool to keep freed pages.
There is no way to shrink the pool so that the pool sometimes
grows too big.
For example my platform allocates some graphic memory via ion.
Sometimes the pool can be several hundreds MB. I want to
flush the pool before critical page
This patch enables debugfs file /sys/kernel/debug/ion/heaps/system_shrink
to shrink pool and get pool size. This technically enables debugfs
shrinking for all heaps, not just the system heap although the system heap
is the only one with a shrinker right now. It is already implemented
but not
This patch shrink page-pool by page unit.
The system shrinker calls ion_heap_shrink_count() to get nr_to_scan,
and pass it to ion_heap_shrink_scan().
The problem is the return value of ion_heap_shrink_count() is the number
of pages but ion_system_heap_shrink(), which is called by
On 06/07/15 14:41, Geert Uytterhoeven wrote:
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
drivers/staging/comedi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
index
That's the ticket :-)
On 06/07/15 15:43, Dmitry Kalinkin wrote:
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
---
This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
---
drivers/vme/vme.c | 7
On 13/06/15 01:28, Greg Kroah-Hartman wrote:
On Thu, May 28, 2015 at 03:07:05PM +0300, Dmitry Kalinkin wrote:
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by: Dmitry Kalinkin
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin dmitry.kalin...@gmail.com
---
This depends on '[PATCH 0/3] VME bus error handling overhaul' patchset.
---
drivers/vme/vme.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/vme/vme.c
Hi Paul,
On Mon, 6 Jul 2015 09:42:47 -0400 Paul Gortmaker paul.gortma...@windriver.com
wrote:
[Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on
CLKDEV_LOOKUP] On 06/07/2015 (Mon 08:48) Stephen Rothwell wrote:
On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven
On 06/07/15 14:50, Dmitry Kalinkin wrote:
On Mon, Jul 6, 2015 at 4:22 PM, Martyn Welch martyn.we...@ge.com wrote:
Sorry about the *really* late reply, loads of emails some how missed my
periodic search of the mailing list.
I'm happy with the addition of DMA, just not sure whether it's worth
69 matches
Mail list logo
