[PATCH] staging: lustre: libcfs: move assignment out of conditional

Found by checkpatch.pl Signed-off-by: Perry Hooker Please enter the commit message for your changes. Lines starting --- .../staging/lustre/include/linux/libcfs/libcfs_fail.h | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/lustre/include/

Re: [HPDD-discuss] [PATCH] staging: lustre: libcfs: move assignment out of if condition

Thank you - you're right. Apologies for the mistake. On 07/12/2015 07:20 PM, Patrick Farrell wrote: This changes the logic here; the assignment is done conditionally based on the precheck. From: HPDD-discuss [hpdd-discuss-boun...@lists.01.org] on behalf

RE: [HPDD-discuss] [PATCH] staging: lustre: libcfs: move assignment out of if condition

This changes the logic here; the assignment is done conditionally based on the precheck. From: HPDD-discuss [hpdd-discuss-boun...@lists.01.org] on behalf of Perry Hooker [perry.hoo...@gmail.com] Sent: Sunday, July 12, 2015 4:27 PM To: oleg.dro...@intel.co

[PATCH] staging: lustre: libcfs: move assignment out of if condition

Found by checkpatch.pl Signed-off-by: Perry Hooker --- drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h b/drivers/staging/lustre/include/linux/libcfs/libcf

[PATCH 21/22] staging: rtl8192e: Make rtllib_rx_mgt() static

Function is not referenced outside of rtllib_rx.c Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h| 3 --- drivers/staging/rtl8192e/rtllib_rx.c | 10 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers

[PATCH 22/22] staging: rtl8192e: rtllib_softmac: Make functions static

Make as many functions as possible static in rtllib_softmac.c. The following functions were affected: - rtllib_sta_wakeup - rtllib_TURBO_Info - rtllib_get_beacon_ - rtllib_send_probe_requests - rtllib_update_active_chan_map - rtllib_softmac_scan_syncro Signed-off-by: Mateusz Kulikowski --- driv

[PATCH 10/22] staging: rtl8192e: Remove DMESG macro

It is used in several places, but expands to nothing. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 drivers/staging/rtl8192e/rtllib_debug

[PATCH 20/22] staging: rtl8192e: rtllib_tx: Make functions static

Make as many functions as possible static in rtllib_tx.c. The following functions were affected: - rtllib_xmit_inter - rtllib_query_seqnum - rtllib_put_snap Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h| 3 --- drivers/staging/rtl8192e/rtllib_tx.c | 8 2 f

[PATCH 16/22] staging: rtl8192e: Make phy_RF8256_Config_ParaFile() static

Relocate function in driver to avoid adding unnecessary fw decl. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 18 +- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.h | 1 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --

[PATCH 17/22] staging: rtl8192e: rtl_core: Make functions static

Make as many functions as possible static in rtl_core.c. If needed - move fw declaration from header. The following functions were affected: - rtl8192_is_tx_queue_empty - rtl819x_watchdog_wqcallback - watch_dog_timer_callback - rtl8192_data_hard_stop - rtl8192_data_hard_resume - rtl8192_hard_data_

[PATCH 11/22] staging: rtl8192e: Remove rtl819x_process_cck_rxpathsel()

Function is empty. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 3 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8192

[PATCH 04/22] staging: rtl8192e: Remove unused enums

Remove ack_policy enum and some unused RTL_DEBUG enums. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_Qos.h | 5 - drivers/staging/rtl8192e/rtllib_debug.h | 6 -- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_Qos.h b/drivers/st

[PATCH 09/22] staging: rtl8192e: Remove read|write_nic_io_(d)word|byte()

None of this functions was used. Also remove PlatformIOCheckPageLegalAndGetRegMask() used by them. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 158 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 7 -- 2 files changed, 165 del

[PATCH 07/22] staging: rtl8192e: Remove unused rtllib_device::freq_band

Member is never referenced. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 13bf8d1..5b25060 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++

[PATCH 05/22] staging: rtl8192e: Remove unused fields from rtllib_stats

None of them are used in the driver. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 8ba92ed..dc0653a 100644 --- a/drivers/

[PATCH 08/22] staging: rtl8192e: Remove DOT11D_GetMaxTxPwrInDbm()

Function is not used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/dot11d.c | 15 --- drivers/staging/rtl8192e/dot11d.h | 1 - 2 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c index 7f48845..fcf9b

[PATCH 12/22] staging: rtl8192e: probe: Remove bdma64 check

It is always false. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 57eb43e..1dc119ea 100644 --- a/drivers/s

[PATCH 01/22] staging: rtl8192e: Remove ToLegalChannel()

Function is not used. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/dot11d.c | 24 drivers/staging/rtl8192e/dot11d.h | 1 - 2 files changed, 25 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c index ef9da

[PATCH 06/22] staging: rtl8192e: Remove unused ether_header structure

Structure is not used in the driver. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index dc0653a..13bf8d1 100644 --- a/drivers/staging/rtl8192

[PATCH 15/22] staging: rtl8192e: rtllib_HTProc: Make functions static

Make as many functions as possible static in rtllib_HTProc.c. The following functions were affected: - HTMcsToDataRate - HTFilterMCSRate Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 5 +++-- drivers/staging/rtl8192e/rtllib.h | 3 --- 2 files changed,

[PATCH 18/22] staging: rtl8192e: r8192e_phy: Make functions static

Make as many functions as possible static in r8192E_phy.c. The following functions were affected: - rtl8192_phyConfigBB - rtl8192_SwChnl_WorkItem - rtl8192_SetBWModeWorkItem Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 6 +++--- drivers/staging/rtl8192e

[PATCH 14/22] staging: rtl8192e: rtl_dm: Make functions static

Make as many functions as possible static in rtllib_dm.c. The following functions were affected: - dm_check_fsync - dm_CheckRfCtrlGPIO - dm_fsync_timer_callback Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 9 ++--- drivers/staging/rtl8192e/rtl8192e/rtl_

[PATCH 00/22] staging: rtl8192e: Various cleanups

This series does some more cleanup for driver. Patches 1-13 just remove features that are not used. Remaining patches make some functions static (where possible); If making function static required something more than moving fw declaration and removing it from header - it is a separate patch. O

[PATCH 13/22] staging: rtl8192e: Remove rtl8192_rx_cmd()

Function is empty. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 1dc119ea..a550634 100644 --- a/drive

[PATCH 19/22] staging: rtl8192e: Make rtl8192_QueryIsShort() static

Relocate function within file to avoid unnecessary fw decl. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 24 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h | 1 - 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/

[PATCH 03/22] staging: rtl8192e: Remove undefs

They relate to macros that are not used in the driver. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_

[PATCH 02/22] staging: rtl8192e: Remove unused defines

Remove most of unused defines (excluding phyreg/hw registers). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/dot11d.h | 4 -- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 46 -- .../staging/rtl8192e/rtl8192e/r8192E_firmware.h| 2

[PATCH] Const-qualify, WARNING, out-of memory usage fixes

Signed-off-by: Vinay Simha BN --- drivers/staging/sm750fb/sm750.c | 53 + 1 file changed, 32 insertions(+), 21 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 6b642d7..f378843 100644 --- a/drivers/staging/s

[PATCH] Staging: vt6655: Replace C99 comments in rf.h and rf.c.

This patch replaces C99 comments in rf.h and rf.c, with C89 comments, fixing the checkpatch.pl errors. Signed-off-by: Nicholas Parkanyi --- drivers/staging/vt6655/rf.c | 532 ++-- drivers/staging/vt6655/rf.h | 24 +- 2 files changed, 278 insertions(+), 27

[PATCH] Staging: vt6655: Remove do { } while (0) from single-statement macros in upc.h.

This patch fixes checkpatch.pl warnings in upc.h regarding single-statement macros embedded within do { } while (0) blocks. Signed-off-by: Nicholas Parkanyi --- drivers/staging/vt6655/upc.h | 36 1 file changed, 12 insertions(+), 24 deletions(-) diff --git