From: Dexuan Cui
By default lsvmbus lists all the devices in the VMBus.
With -v or -vv, more information is printed, including the VMBus
Rel_ID, class ID, device ID and which channel is bound to which
virtual processor, etc.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
tools/
> -Original Message-
> From: K. Y. Srinivasan [mailto:k...@microsoft.com]
> Sent: Wednesday, August 5, 2015 12:52 AM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com; jasow...@redhat.c
From: Vitaly Kuznetsov
As a prerequisite to exporting cpu_hotplug_enable/cpu_hotplug_disable
functions to modules we need to convert cpu_hotplug_disabled to a counter
to properly support disable -> disable -> enable call sequences. E.g.
after Hyper-V vmbus module (which is supposed to be the firs
From: Viresh Kumar
Migrate hv driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.
This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.
Cc: "K. Y. Srinivasan"
Cc
The current code tracks the assigned CPUs within a NUMA node in the context of
the primary channel. So, if we have a VM with a single NUMA node with 8 VCPUs,
we may
end up unevenly distributing the channel load. Fix the issue by tracking
affiliations
globally.
Signed-off-by: K. Y. Srinivasan
--
From: Jake Oshins
This patch deletes the logic from hyperv_fb which picked a range of MMIO space
for the frame buffer and adds new logic to hv_vmbus which picks ranges for
child drivers. The new logic isn't quite the same as the old, as it considers
more possible ranges.
Signed-off-by: Jake Osh
From: Vitaly Kuznetsov
Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer
hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining.
We can bo better by using cpu_hotplug_enable/disable functions instead of
such hard-coding.
Reported-by: Radim Kr.má
Signed-o
From: Vitaly Kuznetsov
Hyper-V module needs to disable cpu hotplug (offlining) as there is no
support from hypervisor side to reassign already opened event channels
to a different CPU. Currently it is been done by altering
smp_ops.cpu_disable but it is hackish.
Signed-off-by: Vitaly Kuznetsov
R
From: Dexuan Cui
This is useful to analyze performance issue.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/vmbus_drv.c | 38 ++
1 files changed, 38 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv
The current Hyper-V clock source is based on the per-partition reference counter
and this counter is being accessed via s synthetic MSR -
HV_X64_MSR_TIME_REF_COUNT.
Hyper-V has a more efficient way of computing the per-partition reference
counter value that does not involve reading a synthetic MSR
From: Jake Oshins
This patch changes the logic in hv_vmbus to record all of the ranges in the
VM's firmware (BIOS or UEFI) that offer regions of memory-mapped I/O space for
use by paravirtual front-end drivers. The old logic just found one range
above 4GB and called it good. This logic will fin
From: Christopher Oo
Fixes a bug where previously hv_ringbuffer_read would pass in the old
number of bytes available to read instead of the expected old read index
when calculating when to signal to the host that the ringbuffer is empty.
Since the previous write size is already saved, also change
From: Dexuan Cui
Keep track of CPU affiliations of sub-channels within the scope of the primary
channel. This will allow us to better distribute the load amongst available
CPUs.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c | 20 ++--
From: Dexuan Cui
The 4 sysfs files should be stable ABIs to the user space.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
Documentation/ABI/stable/sysfs-bus-vmbus | 29 +
MAINTAINERS |1 +
2 files changed, 30 inser
Miscellaneous fixes/improvements. The patches that were sent over the last
couple of months have been consolidated in this submission. All review
comments have been addressed.
Christopher Oo (1):
Drivers: hv_vmbus: Fix signal to host condition
Dexuan Cui (4):
Drivers: hv: vmbus: Further impro
Fixed coding styles issues with braces.
Signed-off-by: Daniel Machon
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cfgoperation
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, August 4, 2015 10:29 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com;
> jasow...@redhat.com; Jake O
On Wed, Aug 05, 2015 at 12:14:55AM -0500, Pradheep Shrinivasan wrote:
> From: pradheep
Dan had previously told you that it is wrong.
Here From: line is only required if you are not able to configure the
email From: header while using some corporate server. But your email
From: header is ok.
regar
On Wed, Aug 05, 2015 at 12:08:16AM +0200, Daniel Machon wrote:
> Fixed brace coding styles issues
>
> Signed-off-by: Daniel Machon
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/wilc1
On Sat, Aug 01, 2015 at 04:08:15PM -0700, K. Y. Srinivasan wrote:
> From: ja...@microsoft.com
That's not his name :(
I've stopped here, please fix up and resend the rest of the series.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.
The waring message will mislead developers and users. This will cause a
potential damage. Fix the waring message to give developers and users the
correct guidance.
Signed-off-by: Navy Cheng
---
drivers/staging/vme/devices/vme_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
On Tue, Aug 04, 2015 at 08:44:52PM +0200, Adrian Remonda wrote:
> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing the offending 0 with NULL.
>
> Signed-off-by: Adrian Remonda
> ---
> drivers/staging/most/mostcore/core.c | 2 +-
> 1 file chan
On Tue, Aug 04, 2015 at 08:44:51PM +0200, Adrian Remonda wrote:
> This is a patch to the mostcore/core.c file. It makes
> several local functions and structures static to prevent global
> visibility.
>
> Signed-off-by: Adrian Remonda
> ---
> @@ -1255,7 +1255,7 @@ static void arm_mbo(struct mbo *
From: pradheep
This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan
---
drivers/staging/media/lirc/lirc_imon.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --gi
From: pradheep
This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan
---
drivers/staging/media/lirc/lirc_imon.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: pradheep
This patche removes the extra braces found in
drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by
checkpatch.pl
Signed-off-by: Pradheep Shrinivasan
---
drivers/staging/media/lirc/lirc_imon.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --gi
This fix changes the space in the code to tab to fix the ERROR
"ERROR: code indent should use tabs where possible"
Signed-off-by: Pradheep Shrinivasan
---
drivers/staging/media/lirc/lirc_sasem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_s
On Tue, 2015-08-04 at 16:10 +0800, Jandy Gou wrote:
> Signed-off-by: Jandy Gou
[]
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
> b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
[]
> @@ -721,7 +721,7 @@ kiblnd_nid2peerlist (lnet_nid_t nid)
> unsigned int hash =
>
remove extra space
replace tab to space after a variable
Jandy Gou (1):
Staging: android: timed_gpio.c: fix coding style errors
drivers/staging/android/timed_gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.9.1
___
devel mail
remove extra space and replace tab to space after a variable
Signed-off-by: Jandy Gou
---
drivers/staging/android/timed_gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/timed_gpio.c
b/drivers/staging/android/timed_gpio.c
index 938a35c..ce117
Globals are initialized to zero or NULL by GCC. No need to explicitly
initialize them.
Signed-off-by: Daniel Machon
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
Fixed brace coding styles issues
Signed-off-by: Daniel Machon
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000/wilc_wfi_cfgoperations
On Aug 4, 2015, at 5:48 PM, Shraddha Barke wrote:
> The Coccinelle semantic patch that makes these changes is as follows:
>
> @@ struct usb_endpoint_descriptor *epd; @@
>
> - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
> + usb_endpoint_type(epd)
>
> Signed-off-by: Shraddha Barke
>
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddha Barke
---
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddha Barke
---
Changes in v2:
-Fix subject line
drivers/staging/media/lirc/l
On Wed, Aug 05, 2015 at 02:14:19AM +0530, Shraddha Barke wrote:
> This patch introduces the use of the function usb_endpoint_type.
Your subject doesn't make much sense, please fix up and resend both of
these.
thanks,
greg k-h
___
devel mailing list
de
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddha Barke
---
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddha Barke
--
This patch uses kasprintf which combines kzalloc and sprintf.
kasprintf also takes care of the size calculation.
Semantic patch used is as follows:
@@
expression a,flag;
expression list args;
statement S;
@@
a =
- \(kmalloc\|kzalloc\)(...,flag)
+ kasprintf (flag,args)
<... when != a
if (a =
The Linux kernel coding style guidelines suggest not using typedefs for
structure and enum types. This patch gets rid of the typedefs for
Ack_session_info_t.
The following Coccinelle semantic patch detects the cases for struct type:
@tn@
identifier i;
type td;
@@
-typedef
struct i { ... }
-td
Patch created to satisfy checkpatch.pl
Signed-off-by: Lior Pugatch
---
drivers/staging/vt6655/rxtx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index b9bd163..54694df 100644
--- a/drivers/staging/vt6655/rxtx.h
From: Neil Horman
Switch the visornic over to use napi. Currently there is a kernel
thread that sits and waits on a wait queue to get notified of incoming
virtual interrupts. It would be nice if we could handle frame reception
using the standard napi processing instead. This patch creates our n
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-
This is a patch to the most/aim_cdev.c file. It makes several
local functions and structures static to prevent global visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/aim-cdev/cdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/
This is a patch to the most/hdm-usb/hdm_usb.c file. It
makes several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/hdm-usb/hdm_usb.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/d
This patch series fix several warnings reported by the Sparse tool
v2: Fixed patch format and comments as noted by
Greg Kroah-Hartman and clear a few more warnings
v3: Fixed patch format as noted by Greg Kroah-Hartman
v4: Fixed patch format as noted by Greg Kr
This is a patch to the mostcore/core.c file. It makes
several local functions and structures static to prevent global
visibility.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/mostcore/core.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/stag
This patch fixes the warning generated by sparse: "Using plain integer
as NULL pointer" by replacing the offending 0 with NULL.
Signed-off-by: Adrian Remonda
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/mostcore
On Fri, Jul 31, 2015 at 04:00:52PM +0200, Robert Baldyga wrote:
> Rework ep_matches() function to make it shorter and more readable.
>
> Signed-off-by: Robert Baldyga
this regresses at least mass storage. How did you test it ? I'll keep
all patches up to this one, please fix the problem, rebase
On Tue, Aug 04, 2015 at 07:19:01PM +0100, Salah Triki wrote:
> This patch replaces pr_info/pr_warn/pr_err with
> dev_info/dev_warn/dev_err.
>
> Signed-off-by: Salah Triki
> ---
> drivers/block/zram/zram_drv.c | 40 +++-
> 1 file changed, 23 insertions(+), 17 d
This patch replaces pr_info/pr_warn/pr_err with
dev_info/dev_warn/dev_err.
Signed-off-by: Salah Triki
---
drivers/block/zram/zram_drv.c | 40 +++-
1 file changed, 23 insertions(+), 17 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zra
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/st
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 123
1 file changed, 61 insertions(+), 62 deletions
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt". `udelay()` is only used in the
firmware upload process. Replace them with `usleep_range()` with a
reasonable upper limit.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kr
The hardware returns two's complement values for the analog input
samples. These need to be converted to the unsigned binary format
that the comedi core expects. Introduce a helper function to handle
this.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 23
Format the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 74 -
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/c
The me4000_ai_cancel() already reset this register.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/staging/comedi/drivers/me4000.c
index 048340b..409483a 100644
For aesthetics, add some white space to the analog output subdevice
initialization.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/dr
Currently me4000_reset() always enables the PLX interrupt. Move the
enable of the interrupt into me4000_auto_attach() and only do the
enable if we actually have and irq.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 13 +++--
1 file changed, 7 insertions(
Firmware loading was fixed by:
Commit: ac584af5
"staging: comedi: me4000: fix firmware downloading"
Change the driver status to "untested" and remove the comments about
the driver being broken,
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --g
The ai (*do_cmd_test) validates the trigger sources in Step 2b to ensure
that they are compatible. Save the 'ai_ctrl_mode' that will be used in the
private data so that ai_prepare(), which is called by the ai (*do_cmd),
does not have to recheck the sources in order to figure it out.
Also, tidy up
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name. Also, use ME4000_AI_STATUS_REG instead of ME4000_AI_CTRL_REG
when reading the register (they happen to be the same).
Signed-off-by: H Hartley Sweeten
---
drivers/s
This function never fails and it's only called by me4000_ai_do_cmd().
Absorb it and remove the unnecessary failure check.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 31 +--
1 file changed, 9 insertions(+), 22 deletions(-)
diff --g
The chanspec channel, range, and aref are unsigned int values. Use the
correct types when extracting them.
Signed-off-by: H Hartley Sweeeten
---
drivers/staging/comedi/drivers/me4000.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me40
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 51 -
1 file changed, 25 insertions(+), 26 deletions
The comedi core ensures that the subdevice is not busy before it allows
starting a new command. The subdevice (*cancel) is called when the
subdevice is set to not busy. In this driver the me4000_ai_cancel()
is the ai (*cancel) so the extra call in the ai (*do_cmd) is not
necessary. Remove it.
Sign
There is no real reason to reset the board when detaching. But the PLX
interrupts should be disabled. Currently the PLX interrupt is left
enabled when the driver is detached.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 8 ++--
1 file changed, 6 insertions(+
This define evaluates to 0 and is OR'ed with the 'entry' value that is
written to the ME4000_AI_CHANNEL_LIST_REG when the channel aref is a
single-ended type (AREF_GROUND or AREF_COMMON). OR'ing a zero value is
pretty silly, just remove it.
Simplify me4000_ai_insn_read() a bit. The 'aref' is valid
This function always succeeds. Change the return type to void and
remove the unnecessary error check in me4000_ai_do_cmd().
Move the function call in me4000_ai_do_cmd_test() from before Step 1
to Step 3 where the arguments are validated. There is no reason to
get the values if the previous steps f
Reset the analog input control register after ensuring that any active
conversions have been stopped. This mimics what the ai subdevice (*cancel)
does.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/stag
The irq handler does not need to manually stop conversions and disable
interrupts when "end-of-acquisition", "error", or "overflow" events are
detected. The comedi_handle_events() will call the subdevice (*cancel)
when these are detected and stop the acquisition.
Signed-off-by: H Hartley Sweeten
Change the MODULE_DESCRIPTION to something more useful than "Comedi low-
level driver"
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/me4000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/d
Some of the boards supported by this driver can do analog input sample &
hold on 8 of the channels. The 'ai_sh_nchan' member of the boardinfo is
used to indicate which boards support this feature. To save a bit of space,
convert this member to a bit-field, 'can_do_sh_ai'. Note, this feature is
not
In comedi drivers the local variable used for the dev->private pointer is
normally named 'devpriv'. For aesthetics, rename the variables in this
driver. Also, rename the struct to follow the norm.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 44 -
The 'board' pointer is only used in this function to verify that the
'chan' is valid for an aref of AREF_DIFF. The comedi core ensures that
that aref is only possible if the subdevice has the SDF_DIFF subdevice_flag
set. If so, the maximum channel is half the subdevice 'n_chan'. Use that
instead an
The comedi_lrange table for the analog inputs is inverted compared
to the values that need to be written to the ME4000_AI_CHANNEL_LIST_REG
to select the range.
Create a macro, ME4000_AI_LIST_RANGE(), to handle the inversion. Remove
the old defines and simplify the code a bit.
Signed-off-by: H Har
The comedi core validates that the 'chan' is valid for the subdevice
before calling the (*insn_read) operation. Remove the unnecessary check.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comed
Rename this function so it has namespace associated with the driver.
The last entry of the chanlist needs the ME4000_AI_LIST_LAST_ENTRY bit
set to end the list. Fix the function and tidy if up a bit.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 23 -
This function always returns 0 and the return value is never checked.
Just return void.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/stag
The ai (*do_cmd_test) calls me4000_ai_round_cmd_args() to calculate the
timing values needed to the command. The the command test passes, the
core will then call the ai (*do_cmd) which then has to call
me4000_ai_round_cmd_args() again in order to get the same values to
pass to ai_prepare() in order
Use the helper function to check the range type instead of relying on the
value. For aesthetics, rename the local variable used for the range.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dr
Introduce a helper function to stop any ai conversions and reset the
ai control register. This consolidates the common code in me4000_reset()
and me4000_ai_cancel().
Use the new helper in the ai (*insn_read) to ensure that the ai control
register is set to a known state after reading the samples.
This function is only called by me4000_ai_do_cmd(). Absorb it.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 35 +
1 file changed, 14 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/s
The STOP and IMMEDIATE_STOP bits in the ME4000_AI_CTRL_REG should be set,
not cleared, to stop any running conversions.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/
Some of the boards supported by this driver do not have differential analog
inputs. Only set the SDF_DIFF subdev_flag when the board supports it.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dr
The maximum differential channel is half the subdevice 'n_chan'. Use
that instead and remove the need for the 'board' variable.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/come
Use the BIT() macro to define the bits of this register.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/drivers/staging/comedi/drivers/me4000.c
index 1
Use the comedi_timeout() helper to busy-wait for the analog input end-of-
conversion instead of the udelay().
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/sta
For the boards that have analog output capability, there are always
4 analog output channels. Convert the 'ao_nchan' member of the boardinfo
into a bit-field, 'has_ao', to save a bit of space and set the analog
output subdevice 'n_chan' to 4 when supported.
Signed-off-by: H Hartley Sweeten
---
d
This member of the boardinfo is only used as a flag indicating that the
board supports differential analog inputs. Convert the member to a bit-
field to save a bit of space. For aesthetics, rename the member to
'can_do_diff_ai'.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers
This member of the boardinfo is always '4' for the boards that have an
analog output FIFO. Covert it to a bit-field, 'has_ao_fifo', to save a
bit of space.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-
All the boards supported by this driver have 32 digital I/O channels.
Remove the unnecessary boardinfo.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 38 +++--
1 file changed, 8 insertions(+), 30 deletions(-)
diff --git a/drivers/stag
The coemdi (*insn_read) functions are supposed to read insn->n values
from the hardware. Make this function work like the core expects.
Use the comedi_offset_munge() helper to munge the two's complement
values to offset binary.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers
Use the BIT() marco to define the bits of this register.
For aesthetics, rename all the defines to remove the '_BIT' from the
name.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
dif
Here's the big cleanup series for the Comedi me4000 driver.
This fixes all the checkpatch issues and removes a bunch of cruft
from the driver.
H Hartley Sweeten (46):
staging: comedi: me4000: remove 'dio_nchan' boardinfo
staging: comedi: me4000: all board types have analog inputs
staging: c
Change the boardinfo 'has_counter' and 'ai_trig_analog' flags into
bit-fields to save a bit of space.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/me4000.c
b/dr
All the boards supported by this driver have analog inputs. They just
differ in the number of channels (32 or 16).
Always initialize the analog input subdevice in me4000_auto_attach().
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/me4000.c | 39 +---
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
Changes in v4:
-Added Signed-off-by line
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 inser
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
Changes in v4:
-Added Signed-off-by line
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion(+),
1 - 100 of 127 matches
Mail list logo
