From: Johnny Kim
The driver communicates with the chipset via the address of handlers
to distinguish async data frame. The SendConfigPkt function gets the
pointer address indicating the handlers as the last argument, but this
requires redundant typecasting and does not support the 64 bit machine.
From: Johnny Kim
This patch changes the type of gu8FlushedJoinReqDrvHandler with his real
data type becasue typecasting is not necessary. In result, typecasting
which is not necessary and some building warnings is removed.
Signed-off-by: Johnny Kim
Signed-off-by: Tony Cho
---
drivers/staging/
From: Johnny Kim
This patch replaces the void pointer type in the host interface
functions which process the message from host thread by the real data
type, tstrWILC_WFIDrv because the void pointer type as the arguments
is not clear and concise. In addition, typecasting to the void pointer
type i
From: Johnny Kim
The structure, WILC_WFIDrvHandle is used to save the pointer address
for the driver handler which is used throughout the driver but it's
not easy to understand what it means. In addition, it doesn't support
the 64 bit machine and also causes the warnings for the 64 bit build.
Th
From: Johnny Kim
This patch changes the void pointer member of the tstrHostIFmsg to the
real data type because the void pointer type is ambiguous and not
readable.
Signed-off-by: Johnny Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 inserti
This series of patch includes new design for 64 bits. The driver uses the
redundant typecasting to communicate with the chipset, which causes several
compile warnings.
However, this patch uses the real data type and removes unnecessary typecasting.
Also, the driver allocates the ID value to the po
Use the comedi_offset_munge() helper to convert the hardware two's
complement values to the offset binary format expected by comedi.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 14 --
1 file changed, 4 in
The comedi_offset_munge() helper is used to convert unsigned int data
values from the comedi offset binary format to two's complement values
for hardware that needs the data in that format. The comedi data is
always checked against s->maxdata before writing to the hardware so
the current implementa
Merge the two comments and format it in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usb
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
CHECK: Prefer kernel type 'u32' over 'uint32_t'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 39 ++--
1 file change
Add some missing space to quiet the checkpatch.pl issues about:
CHECK: spaces preferred around that '/' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: H Hartley Sweeten
Fix some minor checkpatch.pl issues and use the comedi_offset_munge()
helper to do the two's complement to offset binary munging.
H Hartley Sweeten (5):
staging: comedi: usbduxsigma: add missing spaces
staging: comedi: usbduxsigma: use prefered kernel types
staging: comedi: usbduxsigma: tidy
Use register bit defines from addi_tcw.h to remove the "magic" numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
Use register bit defines from addi_tcw.h to remove the "magic" numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/com
Use register bit defines from addi_tcw.h to remove the "magic" numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/driv
Use register bit defines from addi_tcw.h to remove the "magic" numbers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/co
The APCI3501_TIMER_* register defines in this driver are that same as
the ADDI_TCW_* defines with an additional offset.
Add a 'tcw' (timer/counter/watchdog) member to the private data to
hold the address for the iobase of the registers. Use that and the
defines from addi_tcw.h to address the regis
Rename the CamelCase local variables.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_
Change the register bit defines to use the BIT macro.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_35
Rename this CamelCase member of the private data.
Also, fix the type of the member, it holds a pci_resource_start()
address and should be an unsigned long.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3501.c | 15 +++--
The handling for the watchdog and timer modes is very similar. Refactor
this function to use a common code path for both modes.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3501.c | 59 +-
1 file chan
The handling of the ADDIDATA_WATCHDOG and ADDIDATA_TIMER is identical
except for the "stop" operation. Refactor this function to use a common
code path for both timer modes.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3501.c
The handling of the ADDIDATA_WATCHDOG and ADDIDATA_TIMER is identical.
Refactor this function to use a common code path for both timer modes.
Remove the incorrect dev_err() noise. The subdevice is valid but the
timer_mode is not supported.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Gre
Rename this CamelCase local variable.
For aesthetics, split the mask/set operations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3501.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
di
Rename this CamelCase local variable.
For aesthetics, split the mask/set operations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3501.c | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
di
The hwdrv_apci3501.c file is included by the addi_apci_3501 driver to provide
the support code for the timer subdevice. The code in this file is broken with
respect to how comedi works with subdevices.
Tidy it up so that it can be fixed.
H Hartley Sweeten (15):
staging: comedi: hwdrv_apci3501:
The watchdog is stopped in apci3501_write_insn_timer() by writing a 0 to
the timer control register. There is no need to read the register first
and mask it (as done when the timer is used as a timer).
Reported-by: coverity (CID 1227052)
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg K
Rename this CamelCase member of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/hwdrv_apci3501.c| 16
drivers/staging/comedi/drivers/addi_apci_3501.c | 2 +-
2 files changed, 9 inse
Currently, media_entity_init() creates an array with the links,
allocated at init time. It provides a parameter (extra_links)
that would allocate more links than the current needs, but this
is not used by any driver.
As we want to be able to do dynamic link allocation/removal,
we'll need to change
Now that a link can be either between two different graph
objects, we'll need to add more functions to create links.
So, rename the existing one that create links only between
two pads as media_create_pad_link().
No functional changes.
This patch was created via this shell script:
for i i
Change the internal namespace for links between two pads to
have the "pad" there.
We're also numbering it, as a common constructor is to do
things like:
if (link->port1.type != MEDIA_GRAPH_PAD)
continue;
if (link->pad1_sink->entity == entity)
/* do
This patch fixes issue generated by commit ca93dcba3a92
("staging: rtl8192e: Remove assert() macro")
One negation was missed in conversion, therefore
asserted message was always printed.
For 1MB file downloaded via http, ~500 messages
were generated.
Signed-off-by: Mateusz Kulikowski
---
Notes:
On Wed, Aug 12, 2015 at 10:30:47AM -0700, H Hartley Sweeten wrote:
> @@ -1061,6 +1061,14 @@ static int do_chaninfo_ioctl(struct comedi_device *dev,
> if (it.maxdata_list) {
> if (s->maxdata || !s->maxdata_list)
> return -EINVAL;
> + /*
> +
This patch enables setting the module's debug options WARN and INFO in the
debugfs file 'wilc_debug_level'. This enables the user to enable logging
of warning and other information. Before this change writes to this debugfs
file sets only one option DGB. This is additional to the default option
The copy_to_user() that returns the subdevice 'maxdata_list' in this
function has the possibility of overflowing due to the calculation
of the size of the copy. In reality this should never happen but add
a sanity check just to be safe.
Reported-by: coverity (CID 143110)
Signed-off-by: H Hartley S
On Tuesday, August 11, 2015 7:32 AM, Abhilash Jindal wrote:
> Subject: [PATCH] staging: comedi: Use monotonic clock
Nitpick... The subject above should have the driver name in it.
" staging: comedi: serial2002: Use monotonic clock"
The current subject makes this commit appear to effect all of co
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Wednesday, August 12, 2015 22:11
> To: Dexuan Cui
> Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com;
> driverdev-devel@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> a...@canon
On Wed, Aug 12, 2015 at 08:41:42PM +0530, Aparna Karuthodi wrote:
> Added a newline character to remove a coding style warning detected
> by checkpatch.
>
> The warning is given below:
> drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
> across lines
>
> Signed-off-by:
On 08/12/2015 03:25 PM, sdliy...@gmail.com wrote:
> From: Yong Li
>
> Load the driver using the below command:
> echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device
>
> In sysfs, the iio name is hmc5843, however the i2c name is hmc5983,
> they are inconsistent.
>
> With this patch, the ii
Added a newline character to remove a coding style warning detected
by checkpatch.
The warning is given below:
drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
across lines
Signed-off-by: Aparna Karuthodi
---
drivers/staging/media/lirc/lirc_serial.c |2 +-
1 file
On Wed, Aug 12, 2015 at 01:35:07PM +, Dexuan Cui wrote:
> > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > On Wed, Aug 12, 2015 at 12:29:46PM +, Dexuan Cui wrote:
> > > > This fixes the recent commit:
> > > > Drivers: hv: vmbus: Further improve CPU affiliation logic
> >
> > Sinc
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Wednesday, August 12, 2015 21:06
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@r
On Wed, Aug 12, 2015 at 1:19 PM, Pali Rohár wrote:
> On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
>> From: Yash Shah
>>
>> Fix line over 80 characters warning as detected by checkpatch.pl
>>
>> Signed-off-by: Yash Shah
>> ---
>> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 +
From: Yong Li
Load the driver using the below command:
echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device
In sysfs, the iio name is hmc5843, however the i2c name is hmc5983,
they are inconsistent.
With this patch, the iio name will be the same as the i2c device name
Signed-off-by: Yong
This fixes the recent commit:
Drivers: hv: vmbus: Further improve CPU affiliation logic
Without the fix, reloading hv_netvsc hangs the guest.
Signed-off-by: Dexuan Cui
---
Change since V1:
clear the related bit(s) in hv_process_channel_removal() rather
than in init_vp_index().
On Wed, Aug 12, 2015 at 12:29:46PM +, Dexuan Cui wrote:
> > This fixes the recent commit:
> > Drivers: hv: vmbus: Further improve CPU affiliation logic
Since you are redoing this anyway, include the git hash so we can look
it up. In fact, just use the Fixes tag.
regards,
dan carpenter
__
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf
> Of Dexuan Cui
> Sent: Wednesday, August 12, 2015 21:49
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.c
This fixes the recent commit:
Drivers: hv: vmbus: Further improve CPU affiliation logic
Without the fix, reloading hv_netvsc hangs the guest.
Signed-off-by: Dexuan Cui
---
drivers/hv/channel_mgmt.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/hv/channel_mgmt.c b/dr
On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
> From: Yash Shah
>
> Fix line over 80 characters warning as detected by checkpatch.pl
>
> Signed-off-by: Yash Shah
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> d
From: Yash Shah
Fix line over 80 characters warning as detected by checkpatch.pl
Signed-off-by: Yash Shah
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c
b/drivers/staging/med
thanks for your comments. let me submit another one
发自我的 iPhone
> 在 2015年8月12日，16:28，Lars-Peter Clausen 写道：
>
>> On 08/12/2015 10:20 AM, sdliy...@gmail.com wrote:
>> From: Yong Li
>>
>> Load the driver using the below command:
>> echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device
>>
>
From: Yong Li
Load the driver using the below command:
echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device
In sysfs, the iio name is hmc5843, however the i2c name is hmc5983,
they are inconsistent.
With this patch, the iio name will be the same as the i2c device name
Signed-off-by: Yong
On 08/12/2015 10:20 AM, sdliy...@gmail.com wrote:
> From: Yong Li
>
> Load the driver using the below command:
> echo hmc5983 0x1e > /sys/bus/i2c/devices/i2c-?/new_device
>
> In sysfs, the iio name is hmc5843, however the i2c name is hmc5983,
> they are inconsistent.
>
> With this patch, the ii
On Wed, 2015-08-12 at 10:30 +0530, Sudip Mukherjee wrote:
> On Tue, Aug 11, 2015 at 09:32:30PM +0800, Swee Hua Law wrote:
> > Add blank line after variable declaration
[]
> > diff --git a/drivers/staging/lustre/lustre/llite/lloop.c
> > b/drivers/staging/lustre/lustre/llite/lloop.c
[]
> > @@ -372,9
54 matches
Mail list logo
