[PATCH 00/20] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports

Hello, This patches series fixes all the checkpatch.pl errors and warnings on the file drivers/staging/rtl8192u/r8192U_core.c. checkpatch.pl tail output before patches: (on staging-testing) total: 334 errors, 402 warnings, 4909 lines checked checkpath.pl output after patches:

[PATCH 09/20] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h

Use #include linux/uaccess.h instead of asm/uaccess.h Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error

Fix multiple occurences of the need consistent spacing code style error Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH 18/20] staging: rtl8192u: r8192U_core: fix quoted string split across lines code style issue

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 511e979..0048cff 100644 ---

[PATCH 06/20] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing code style error

A missing struct keyword in variable declaration triggered a need consistent spacing around '*' code style error. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 05/20] staging: rtl8192u: r8192U_core: fix else following close brace code style error

Fix else should follow close brace code style error. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 04/20] staging: rtl8192u: r8192U_core: fix code indent using spaces code style error

Fix code indent should use tabs where possible code style error Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 03/20] staging: rtl8192u: t8192U_core: fix space before close parenthesis code style error

A space existed before the close parenthesis of an if statement. This patch removes it to follow the kernel code style. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 11/20] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue

braces {} are not necessary for any arm of a statement containing one statement on each side. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 1/3] staging: wilc1000: code style: fix macro with multiple statements

Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/wilc_exported_buf.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH 2/3] staging: wilc1000: code style: fix globals initialized to false

Globals should not be initialized to 0 or NULL. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] staging: wilc1000: code style: fix open brace { on wrong line

Open braces should be on the same line as if and for statements. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)

[PATCH 0/3] staging: wilc1000: code style patches

Hello, Please find in following emails code style patches for the driver wilc1000 in staging. Raphaël Raphaël Beamonte (3): staging: wilc1000: code style: fix macro with multiple statements staging: wilc1000: code style: fix globals initialized to false staging: wilc1000: code style: fix

Re: [PATCH] Staging: vt6655: rf: fix C99 // comments coding style error

This doesn't apply to my staging-next branch of staging-git :( Please rebase and resend. Seems it already has been fixed in your staging-git! I switched to this git for future changes. (was using the linux.git) Thanks! Raphaël ___ devel mailing list

[PATCH 08/20] staging: rtl8192u: r8192_core: clean C99 // comments

Replace C99 // comments by /* comments */ to follow the kernel code style. Remove some unuseful comments. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 636 - 1 file changed, 316 insertions(+), 320

[PATCH 13/20] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue

kfree(NULL) is safe and the checks were not required. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 17/20] staging: rtl8192u: r8192U_core: fix missing blank line after declarations code style issue

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 44 +++--- 1 file changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index

[PATCH 16/20] staging: rtl8192u: r8192U_core: fix unnecessary whitespace code style issue

Whitespaces are not necessary before a quoted newline. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 15/20] staging: rtl8192u: r8192U_core: fix unnecessary else after return code style issue

An else statement is not useful after a return. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 19/20] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

[PATCH 14/20] staging: rtl8192u: r8192U_core: fix unnecessary parentheses code style issue

Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 99d7f7c..25d31fe 100644 ---

[PATCH 20/20] staging: rtl8192u: r8192U_core: fix line over 80 characters code style issue

Light code refactoring to keep the lines under 80 characters to follow the kernel code style. Signed-off-by: Raphaël Beamonte raphael.beamo...@gmail.com --- drivers/staging/rtl8192u/r8192U_core.c | 1248 ++-- lib/Kconfig.debug |2 +- 2 files

Re: [PATCH] staging: lustre: ptlrpc: add missing include directive

On Fri, 14 Aug 2015 18:50:24 -0700 Greg KH gre...@linuxfoundation.org wrote: On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote: Without including ptlrpc_internal.h, GCC gives prototype warnings pack_generic.c:642:5: warning: no previous prototype for ... It does? What

Re: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing include directive

Hello! On Aug 15, 2015, at 4:13 AM, Ioan-Adrian Ratiu wrote: Without including ptlrpc_internal.h, GCC gives prototype warnings pack_generic.c:642:5: warning: no previous prototype for ... It does? What version of gcc give you that, I don't see that here. Yes, but it's a non-default warning

[PATCH v3] staging: wilc1000: Process WARN, INFO options of debug levels from user

This patch enables setting the module's debug options WARN and INFO in the debugfs file 'wilc_debug_level'. This functionality allows the user to enable logging of warnings and other information. Before this change, writes to this debugfs file set only one option - DEBUG. Another option that is

[PATCH] staging: android: fix coding style checks in sw_sync.c

replace comparison obj to NULL with !obj Signed-off-by: Trung Thanh Le trungthanh1...@yahoo.com --- drivers/staging/android/sw_sync.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index

Re: [PATCH] staging: lustre: ptlrpc: add missing include directive

On Sat, Aug 15, 2015 at 11:13:39AM +0300, Ioan-Adrian Ratiu wrote: On Fri, 14 Aug 2015 18:50:24 -0700 Greg KH gre...@linuxfoundation.org wrote: On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote: Without including ptlrpc_internal.h, GCC gives prototype warnings

Re: [PATCH v2] staging: iio: hmc5843: Set iio name dynamically

On 12/08/15 16:21, Lars-Peter Clausen wrote: On 08/12/2015 03:25 PM, sdliy...@gmail.com wrote: From: Yong Li sdliy...@gmail.com Load the driver using the below command: echo hmc5983 0x1e /sys/bus/i2c/devices/i2c-?/new_device In sysfs, the iio name is hmc5843, however the i2c name is

Re: [PATCH 1/2] Staging: iio: trigger: Alignment should match open parenthesis

On 11/08/15 11:18, Cristina Opriceana wrote: Fix alignment for function parameters as suggested by checkpatch.pl. Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com Whilst I find it a little hard to care about tidying up in these two drivers, we haven't explicitly noted they are

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

On 11/08/15 19:43, Lars-Peter Clausen wrote: On 08/10/2015 11:51 PM, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches j...@perches.com Acked-by: Lars-Peter Clausen l...@metafoo.de Applied to the togreg branch of iio.git. 4.4 material

Re: [PATCH 2/2] Staging: iio: trigger: Use braces on both branches of if statement

On 11/08/15 11:20, Cristina Opriceana wrote: Fix style issue related to missing braces, detected by checkpatch.pl. Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com Applied to the togreg branch of iio.git. This one used to be left as optional, so there are a lot of these in older

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

On 08/15/2015 09:57 PM, Jonathan Cameron wrote: On 11/08/15 19:43, Lars-Peter Clausen wrote: On 08/10/2015 11:51 PM, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches j...@perches.com Acked-by: Lars-Peter Clausen l...@metafoo.de Applied

Re: [patch] iio: accel: sca3000: memory corruption in sca3000_read_first_n_hw_rb()

On 08/08/15 20:16, Dan Carpenter wrote: num_read is in byte units but we are write u16s so we end up write twice as much as intended. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Hi Dan, This is fine. Given it's an old bug, Greg is not going to take this sort of fix until after the

Re: [PATCH 05/19] staging: iio: Remove unnecessary externs

On 15/08/15 21:05, Lars-Peter Clausen wrote: On 08/15/2015 09:57 PM, Jonathan Cameron wrote: On 11/08/15 19:43, Lars-Peter Clausen wrote: On 08/10/2015 11:51 PM, Joe Perches wrote: Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches j...@perches.com