Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-08-23 Thread Noralf Trønnes
Den 24.08.2015 00:24, skrev Stefan Brüns: Avoid a crash, as master->setup may be NULL (e.g. xilinx controller). Even if master->setup is set, spi_setup does several compatibility/ sanity checks which should not be skipped (fixes problems with displays/controllers needing emulation for bits_per_w

[PATCH 1/2] spi: check bits_per_word in spi_setup

2015-08-23 Thread Stefan Brüns
This allows drivers for devices connected via SPI to check if the controller supports a given bits_per_word value during setup. Currently any BPW value is accepted durings setup, and transfers are rejected later. Signed-off-by: Stefan Brüns --- drivers/spi/spi.c | 27 +++

[PATCH 0/2] Fix displays requiring 9 bit transfers on RPi

2015-08-23 Thread Stefan Brüns
Some displays need 9 bit long SPI transfers (Command/Data flag plus 8 bit data). FBTFT has emulation code in case the controller only supports 8 bit transfers, but this is only used if the controller setup function reports an error if bits_per_word is set to 9. SPI: Report unsupported bits_per_wor

[PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-08-23 Thread Stefan Brüns
Avoid a crash, as master->setup may be NULL (e.g. xilinx controller). Even if master->setup is set, spi_setup does several compatibility/ sanity checks which should not be skipped (fixes problems with displays/controllers needing emulation for bits_per_word = 9). Signed-off-by: Stefan Brüns ---

[PATCH v7 28/44] [media] media: use macros to check for V4L2 subdev entities

2015-08-23 Thread Mauro Carvalho Chehab
Instead of relying on media subtype, use the new macros to detect if an entity is a subdev or an A/V DMA entity. Please note that most drivers assume that there's just AV_DMA or V4L2 subdevs. This is not true anymore, as we've added MC support for DVB, and there are plans to add support for ALSA a

[PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-23 Thread Mauro Carvalho Chehab
From: Javier Martinez Canillas The struct media_entity does not have an .id field anymore since now the entity ID is stored in the embedded struct media_gobj. This caused the omap4iss driver fail to build. Fix by using the media_entity_id() macro to obtain the entity ID. Signed-off-by: Javier M

[PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-23 Thread Mauro Carvalho Chehab
Now that a link can be either between two different graph objects, we'll need to add more functions to create links. So, rename the existing one that create links only between two pads as media_create_pad_link(). No functional changes. This patch was created via this shell script: for i i

[PATCH v7 32/44] [media] davinci_vbpe: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-23 Thread Mauro Carvalho Chehab
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV: - it uses a hack to check if the remote entity is a subdev; - it still uses the legacy entity subtype check macro, that will be removed soon. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/d

[PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-23 Thread Mauro Carvalho Chehab
From: Javier Martinez Canillas The struct media_entity has a .parent field that stores a pointer to the parent struct media_device. But recently a media_gobj was embedded into the entities and since struct media_gojb already has a pointer to a struct media_device in the .mdev field, the .parent f

[PATCH v7 29/44] [media] omap3/omap4/davinci: get rid of MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-23 Thread Mauro Carvalho Chehab
On omap3/omap4/davinci drivers, MEDIA_ENT_T_V4L2_SUBDEV macro is abused in order to "simplify" the pad checks. Basically, it does a logical or of this macro, in order to check for a local index and if the entity is either a subdev or not. As we'll get rid of MEDIA_ENT_T_V4L2_SUBDEV macro, replace

[PATCH v7 33/44] [media] omap4iss: stop MEDIA_ENT_T_V4L2_SUBDEV abuse

2015-08-23 Thread Mauro Carvalho Chehab
This driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, as it uses a hack to check if the remote entity is a subdev. Get rid of it. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c b/drivers/staging/media/omap4iss/iss_ipipe.c index e1a7b7ba7362..4ae354fe1723

[PATCH] staging: fbtft: Made into two lines

2015-08-23 Thread Aparna Karuthodi
Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now? Signed-off-by: Aparna Karuthodi --- drivers/staging/fbtft/fb_pcd8544.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd854

Re: [PATCH] staging: fbtft: Made into two lines

2015-08-23 Thread Giedrius Statkevičius
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: > Made the comment into a new lineto remove a coding style error detected > by checkpatch. > The warning is given below: > drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters > > Signed-off-by: Aparna Karuthodi