[PATCH 1/6] fix android/ashmem.c several coding style issues

Corrections based on checkpatch.pl with --strict 1) spaces preferred around that '-' 2) No space is necessary after a case 3) Alignment should match open parenthesis Signed-off-by: Peng Sun --- drivers/staging/android/ashmem.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-)

[PATCH 0/6] fix drivers/staging/android several coding issues

patches based on linux-next next-20150824 Corrections based on checkpatch.pl with --strict Peng Sun (6): fix android/ashmem.c several coding style issues fix android/lowmemorykiller.c several coding style issues fix android/sw_sync.c several coding style issues fix android/sync.c several

[PATCH 4/6] fix android/sync.c several coding style issues

Corrections based on checkpatch.pl with --strict 1) Comparison to NULL could be written "!*" 2) Alignment should match open parenthesis Signed-off-by: Peng Sun --- drivers/staging/android/sync.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/

[PATCH 2/6] fix android/lowmemorykiller.c several coding style issues

Corrections based on checkpatch.pl with --strict 1) Prefer kernel type 'u32' over 'uint32_t' 2) Please use a blank line after function/struct/union/enum declarations 3) Alignment should match open parenthesis Signed-off-by: Peng Sun --- drivers/staging/android/lowmemorykiller.c | 8 +--- 1 f

[PATCH 5/6] fix android/sync.h several coding style issues

Corrections based on checkpatch.pl with --strict 1) spinlock_t definition without comment 2) Alignment should match open parenthesis Signed-off-by: Peng Sun --- drivers/staging/android/sync.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/sync.h

[PATCH 3/6] fix android/sw_sync.c several coding style issues

Corrections based on checkpatch.pl with --strict 1) Comparison to NULL could be written "!obj" 2) Comparison to NULL could be written "!pt" 3) Comparison to NULL could be written "!fence" Signed-off-by: Peng Sun --- drivers/staging/android/sw_sync.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 6/6] fix android/timed_gpio.c several coding style issues

Corrections based on checkpatch.pl with --strict 1) Please don't use multiple blank lines 2) spinlock_t definition without comment 3) Alignment should match open parenthesis Signed-off-by: Peng Sun --- drivers/staging/android/timed_gpio.c | 15 --- 1 file changed, 8 insertions(+), 7

Re: [PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The struct media_entity has a .parent field that stores a pointer > to the parent struct media_device. But recently a media_gobj was > embedded into the entities and since struct media_gojb already has > a p

Re: [PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This caused the omap4iss driver fail to build. Fix by using the > media_

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren --- drivers/staging/fbtft/fbtft-core.c |7 +++ drivers/staging/fbtft/flexfb.c |7 +++ 2 files c

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Better. Also, submit it again with proper commit message and put "PATCH v2" in the subject. > > Signed-off-by: Aparna Karuthodi > --- > dri

Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote: > Oh! Sorry! I made the changes to correct the faults you figured out. > Is it okay now? Resubmit it properly with "PATCH v2" in the title and a good commit message. > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/fb

[PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren --- drivers/staging/fbtft/fbtft-core.c |7 +++ drivers/staging/fbtft/flexfb.c |7 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/st

[PATCH RFC 1/2] staging: fbtft: replace master->setup() with spi_setup()

Calling the setup of the SPI master directly causes a NULL pointer dereference with master drivers without a separate setup function. This problem is reproduceable on ARM MXS platform. So fix this issue by using spi_setup() instead. Signed-off-by: Stefan Wahren --- drivers/staging/fbtft/fb_uc16

[PATCH RFC 0/2] staging: fbtft: fix 9-bit SPI support

This patch series fixes the 9-bit SPI support of fbtft. Stefan Wahren (2): staging: fbtft: replace master->setup() with spi_setup() staging: fbtft: fix 9-bit SPI support detection drivers/staging/fbtft/fb_uc1611.c|2 +- drivers/staging/fbtft/fb_watterott.c |4 ++-- drivers/stagin

Re: [PATCH v7 02/44] [media] staging: omap4iss: get entity ID using media_entity_id()

On Sun, Aug 23, 2015 at 2:17 PM, Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This caused the omap4iss driver fail to build. Fix by using the

[PATCH v3 10/13] staging: comedi: usbduxfast: document strange ai maxdata

The subdevice 'maxdata' is typically a mask of the valid bits that can be returned by a subdevice, (1 << bits) - 1. The analog inputs of this device have a resolution of 12-bits so the 'maxdata' should be 0x0fff. But, this hardware can produce a value of 0x1000 indicating an overflow from the ADC.

[PATCH v3 12/13] staging: comedi: usbduxfast: absorb usbduxfast_attach_common()

This function is only called by the (*auto_attach) to do the final setup of the analog input subdevice. For aesthetics absorb it into usbduxfast_auto_attach() and reorder the initialization of the subdevice to better follow the "norm" in comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian A

[PATCH v3 11/13] staging: comedi: usbduxfast: remove unnecessary semaphore down/up

The semaphore down/up in usbduxfast_attach_common() is not necessary. This function is only called as part of the (*auto_attach) and does not talk to the USB device. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 9 +

[PATCH v3 13/13] staging: comedi: usbduxfast: remove unnecessary clearing of private data

The clearing of the private data members in the (*detatch) is not necessary. The comedi core is going to kfree the private data as soon as the (*detach) finishes. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 6 --

[PATCH v3 07/13] staging: comedi: usbduxfast: TRIG_EXT is only valid for cmd->start_src

According to the code, and verified with the author Bernd Porr, the TRIG_EXT trigger is only valid for the cmd->start_src. Remove this trigger from the cmd->scan_begin_src and cmd->convert_src. The only valid scan_begin_src is then TRIG_FOLLOW and the convert_src is only TRIG_TIMER. Remove the re

[PATCH v3 09/13] staging: comedi: usbduxfast: use a common exit path in ai (*do_cmd)

For aesthetics, use 'goto' and a common exit point in this function so that the up of the semaphore is not overlooked. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 21 + 1 file changed, 9 insertions

[PATCH v3 08/13] staging: comedi: usbduxfast: tidy up the conversion timing validation

Cleanup the validation of the cmd->convert_arg to use the same calculation in the (*do_cmdtest) and the (*do_cmd). Remove the, then unnecessary, redundant check in the (*do_cmd). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfa

[PATCH v3 06/13] staging: comedi: usbduxfast: TRIG_EXT only works for 1 or 16 channels

Move this check from the (*do_cmd) to the (*do_cmdtest). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/usbdux

[PATCH v3 05/13] staging: comedi: usbduxfast: fix multi-line comment

This comment does not need to be multi-line. Fix it to remove the checkpatch warning. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/com

[PATCH v3 01/13] staging: comedi: usbduxfast: chanlist check is Step 5 of (*do_cmdtest)

The channel list should be checked in Step 5 of the (*do_cmdtest) not as part of the (*do_cmd). Factor the check out of usbduxfast_ai_cmd(). Tidy up the factored out code. The channel number 'i' will never be greater than NUMCHANNELS due to the subdevice setup and the checks done in the code. The

[PATCH v3 00/13] staging: comedi: usbduxfast: tidy up

Fix a couple minor checkpatch.pl issues. Tidy up the ai (*do_cmdtest) and (*do_cmd) a bit. v3: modify patch 10 According to the driver author, Bernd Porr, the hardware can produce an anaog input value of 0x1000. The analog inputs are 12-bits (0x0fff) and the extra bit indicates an ove

[PATCH v3 04/13] staging: comedi: usbduxfast: use preferred kernel types

As suggested by checkpatch.pl: CHECK: Prefer kernel type 'u8' over 'uint8_t' CHECK: Prefer kernel type 's8' over 'int8_t' For consistency, also change the uint16_t and int16_t types to u16 and s16. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/com

[PATCH v3 03/13] staging: comedi: usbduxfast: remove impossible 'if (!devpriv)' checks

The private data 'devpriv' is allocated in the (*auto_attach) before the subdevices are initialized and the (*auto_attach) has to complete successfully before the core will call any of the subdevice operations. Because of this the (!devpriv) checks in the subdevice code can never fail. Remove them.

[PATCH v3 02/13] staging: comedi: usbduxfast: only chanlist of 1, 2, 3, or 16 are supported

The analog input (*do_cmd) only supports channel lists of 1, 2, 3, or 16 channels. Add a check for this to usbduxfast_ai_check_chanlist() and remove the check from usbduxfast_ai_cmd(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usb

[PATCH] mtd: nand: pass page number to ecc->write_xxx() methods

The ->read_xxx() methods are all passed the page number the NAND controller is supposed to read, but ->write_xxx() do not have such a parameter. This is a problem if we want to properly implement data scrambling/randomization in order to mitigate MLC sensibility to repeated pattern: to prevent bit

RE: [PATCH v2 10/13] staging: comedi: usbduxfast: fix analog input 'maxdata'

On Monday, August 24, 2015 6:36 AM, Ian Abbott wrote: > On 17/08/15 19:31, H Hartley Sweeten wrote: >> The analog inputs have 12-bit resoultion. The subdevice 'maxdata' is >> a mask value for the resolution. Fix the value. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Ian Abbott >> Cc: Greg Kroah

[PATCH] staging/lustre: change Lustre URLs and mailing list

From: Andreas Dilger Now that the lustre.org domain has been liberated we can again use that for the main website URL and mailing list. Also update the URL for userspace tools downloads and Git repo. Signed-off-by: Andreas Dilger Signed-off-by: Oleg Drokin --- MAINTAINERS

[PATCH] staging: most: make helper functions static

This fixes two "symbol was not declared. Should it be static?" sparse warnings. Signed-off-by: Michał Bartoszkiewicz --- drivers/staging/most/aim-sound/sound.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/

[PATCH v2] staging: most: NULL comparison style

checkpatch complains when a variable comparison to NULL is written as: variable == NULL or variable != NULL. Signed-off-by: Sudip Mukherjee --- drivers/staging/most/aim-cdev/cdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/aim-cdev/cdev

Re: [PATCH v2 10/13] staging: comedi: usbduxfast: fix analog input 'maxdata'

On 17/08/15 19:31, H Hartley Sweeten wrote: The analog inputs have 12-bit resoultion. The subdevice 'maxdata' is a mask value for the resolution. Fix the value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 2 +- 1

Re: [PATCH 0/6] fix drivers/staging/android some coding style issues

On Fri, Aug 21, 2015 at 02:13:51PM +0800, Peng Sun wrote: > > patches based on commit f0359ead9129821e4b3b5486e7837d3001a95574 > linux-next next-20150820 you have almost similar subject for all patches in the series and please mention which coding style you have changed. regards sudip ___

Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote: > Made the comment into a new lineto remove a coding style error detected > by checkpatch. > The warning is given below: > drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters > > Signed-off-by: Aparna Karuthodi

Re: [PATCH] staging: fbtft: Removed space before parenthesis

On Fri, Aug 21, 2015 at 09:05:47PM +0530, Aparna Karuthodi wrote: > Removed space before parenthesis in two different lines to remove coding > style errors detected by checkpatch. > The errors are given below: > drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before > that close paren

Re: [PATCH] staging: fbtft: Removed a space before comma

On Thu, Aug 20, 2015 at 08:57:57PM +0530, Aparna Karuthodi wrote: > Removed a space before coma to remove a coding style error detected by > checkpatch. > The error is given below: > drivers/staging/fbtft/fb_ili9340.c:47: ERROR: space prohibited before > that ',' (ctx:WxW) > > Signed-off-by: Aparn

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take > the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is > the appropriate lock, since it is intended for poll scheduling and > dgnc_poll_tick

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote: > In cases where visorbus is compiled directly into the kernel, if > visorbus registration fails for any reason, it is still possible for > other drivers to call visorbus_register_visor_driver(), which could > cause an oops. Prevent th