Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

On Mon, Aug 24, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: > On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: > > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take > > the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is > > the appropr

Re: [PATCH v3 00/13] staging: comedi: usbduxfast: tidy up

On 24/08/15 18:13, H Hartley Sweeten wrote: Fix a couple minor checkpatch.pl issues. Tidy up the ai (*do_cmdtest) and (*do_cmd) a bit. v3: modify patch 10 According to the driver author, Bernd Porr, the hardware can produce an anaog input value of 0x1000. The analog inputs are 12-bits

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

Sudip Mukherjee writes: > On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote: >> In cases where visorbus is compiled directly into the kernel, if >> visorbus registration fails for any reason, it is still possible for >> other drivers to call visorbus_register_visor_driver(), which cou

Re: [PATCH 0/6] fix drivers/staging/android several coding issues

On Tue, 2015-08-25 at 14:53 +0800, Peng Sun wrote: > patches based on linux-next next-20150824 > Corrections based on checkpatch.pl with --strict > > Peng Sun (6): > fix android/ashmem.c several coding style issues > fix android/lowmemorykiller.c several coding style issues > fix android/sw_

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

> Noralf Trønnes hat am 25. August 2015 um 00:00 > geschrieben: > > > > Den 24.08.2015 20:33, skrev Stefan Wahren: > > Since bits_per_word isn't usually checked during SPI setup the 9-bit > > support must be checked manually. > > > > Signed-off-by: Stefan Wahren > > --- > > drivers/staging/fbtft

Re: [PATCH RFC 2/2] staging: fbtft: fix 9-bit SPI support detection

Den 25.08.2015 19:34, skrev Stefan Wahren: Noralf Trønnes hat am 25. August 2015 um 00:00 geschrieben: Den 24.08.2015 20:33, skrev Stefan Wahren: Since bits_per_word isn't usually checked during SPI setup the 9-bit support must be checked manually. Signed-off-by: Stefan Wahren --- drivers

RE: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, August 20, 2015 2:35 AM > To: Rivera Jose-B46482 > Cc: gre...@linuxfoundation.org; a...@arndb.de; > de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Yoder Stuart- > B08248; katz Itai-RM05

Re: [PATCH V2] staging: dgnc: take lock when storing value in dgnc_poll_tick

On Tue, Aug 25, 2015 at 08:44:39AM +0100, Salah Triki wrote: > On Mon, Aug 24, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote: > > On Wed, Aug 19, 2015 at 07:11:55PM +0100, Salah Triki wrote: > > > poll_tick is declared global, so dgnc_driver_pollrate_store needs to take > > > the lock dgnc_poll_l

Re: [PATCH v7 10/44] [media] media: rename the function that create pad links

On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > Now that a link can be either between two different graph > objects, we'll need to add more functions to create links. Is this an incomplete sentence. Should it read: "either between two different graph objects or two pads" ? > So, rename the

[PATCH v3] staging: dgnc: take lock when storing value in dgnc_poll_tick

poll_tick is declared global, so dgnc_driver_pollrate_store needs to take the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock the appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick contains the poll rate. dgnc_poll_lock needs to be declared not static a

Re: [PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

On Tue, Aug 25, 2015 at 12:36 AM, Hans Verkuil wrote: > On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: >> From: Javier Martinez Canillas >> >> The struct media_entity has a .parent field that stores a pointer >> to the parent struct media_device. But recently a media_gobj was >> embedded in

[PATCH 0/2] staging: fbtft: Avoid calling SPI master setup directly

This patch series fixes issues caused by calling SPI master setup function directly. Changes since RFC: * use only bits_per_word_mask for 9-bit support detection (suggested by Noralf Trønnes) * change patch order Stefan Wahren (2): staging: fbtft: fix 9-bit SPI support detection stag

[PATCH 2/2] staging: fbtft: replace master->setup() with spi_setup()

Calling the setup of the SPI master directly causes a NULL pointer dereference with master drivers without a separate setup function. This problem is reproduceable on ARM MXS platform. So fix this issue by using spi_setup() instead. Signed-off-by: Stefan Wahren --- drivers/staging/fbtft/fb_uc16

[PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection

Since the result of the setup function isn't adequate to check 9-bit SPI support, we better check bits_per_word_mask. Btw this change avoids a NULL pointer dereference with master drivers without a separate setup function. Signed-off-by: Stefan Wahren --- drivers/staging/fbtft/fbtft-core.c | 1

[PATCH v3] staging: unisys: add visorhid driver

From: Erik Arfvidson This driver provides mouse and keyboard input to Unisys s-Par Partition Desktop application. This device is created by the visorbus device. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer Signed-off-by: Tim Sell --- v2: * address visorhid issues indicated by

Re: [PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection

Den 25.08.2015 23:04, skrev Stefan Wahren: Since the result of the setup function isn't adequate to check 9-bit SPI support, we better check bits_per_word_mask. Btw this change avoids a NULL pointer dereference with master drivers without a separate setup function. Signed-off-by: Stefan Wahren

[PATCH 2/8] fix staging:android style issue:No space is necessary after a cast

Signed-off-by: Peng Sun --- drivers/staging/android/ashmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index b340ddc..1312600 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/andro

[PATCH 0/8] fix drivers/staging/android several coding style issues

patches based on linux-next next-20150825 Corrections based on checkpatch.pl with --strict Peng Sun (8): fix staging:android style issue:spaces preferred around that '-' fix staging:android style issue:No space is necessary after a cast fix staging:android style issue:Alignment sh

[PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis

Signed-off-by: Peng Sun --- drivers/staging/android/ashmem.c | 8 drivers/staging/android/lowmemorykiller.c | 4 ++-- drivers/staging/android/sync.c| 4 ++-- drivers/staging/android/sync.h| 2 +- drivers/staging/android/timed_gpio.c | 12 +++-

[PATCH 4/8] fix staging:android style issue:Prefer kernel type 'u32' over 'uint32_t'

Signed-off-by: Peng Sun --- drivers/staging/android/lowmemorykiller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 61937ab..78e1281 100644 --- a/drivers/staging/android/lowmemorykil

[PATCH 6/8] fix staging:android style issue:Comparison to NULL could be written

Signed-off-by: Peng Sun --- drivers/staging/android/sw_sync.c | 6 +++--- drivers/staging/android/sync.c| 18 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index c90838d..29b5c35 1006

[PATCH 1/8] fix staging:android style issue:spaces preferred around that '-'

Signed-off-by: Peng Sun --- drivers/staging/android/ashmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index 60200a3..b340ddc 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android

[PATCH 5/8] fix staging:android style issue:Please use a blank line after function/struct/union/enum declarations

Signed-off-by: Peng Sun --- drivers/staging/android/lowmemorykiller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 78e1281..3f1311f 100644 --- a/drivers/staging/android/lowmemoryk

[PATCH 7/8] fix staging:android style issue:definition without comment

Signed-off-by: Peng Sun --- drivers/staging/android/sync.h | 2 +- drivers/staging/android/timed_gpio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h index 18a94ed..bb42923 100644 --- a/drivers/staging/

[PATCH 8/8] fix staging:android style issue:Please don't use multiple blank lines

Signed-off-by: Peng Sun --- drivers/staging/android/timed_gpio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index 5c55463..33acbbe 100644 --- a/drivers/staging/android/timed_gpio.c +++ b/drivers/staging/android/t

[PATCH v3] staging: unisys: Add s-Par visorhba

From: David Kershner This driver create a host bus adapter device when s-Par sends a device create message to create a storage adapter on the visorbus. When the message is received by visorbus, the visorhba_probe function is called and the hba device is created and managed by the visorhba driver.