Fix several coding style issue as suggested by checkpatch.pl with
--strict option
Ravi Teja Darbha (3):
staging: emxx_udc: Remove FSF mailing address
staging: emxx_udc: Avoid using multiple blank lines
staging: emxx_udc: Fix NULL comparison style
drivers/staging/emxx_udc/emxx_udc.c | 75 ++
FSF mailing address is no longer required to be specified. Hence
removed.
Signed-off-by: Ravi Teja Darbha
---
drivers/staging/emxx_udc/emxx_udc.c | 4
drivers/staging/emxx_udc/emxx_udc.h | 4
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/s
Fixed multiple blank lines warning by checkpatch.pl
Signed-off-by: Ravi Teja Darbha
---
drivers/staging/emxx_udc/emxx_udc.c | 9 -
drivers/staging/emxx_udc/emxx_udc.h | 26 --
2 files changed, 35 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/d
Fixed NULL comparison style as suggested by checkpatch.pl
Signed-off-by: Ravi Teja Darbha
---
drivers/staging/emxx_udc/emxx_udc.c | 62 ++---
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emx
On 3 September 2015 at 15:35, Geert Uytterhoeven wrote:
> Hi Ulf,
>
> On Thu, Sep 3, 2015 at 2:53 PM, Ulf Hansson wrote:
>> On 17 June 2015 at 10:38, Geert Uytterhoeven wrote:
>>> Add support for easy registering of one ore more platform devices that
>>> may:
>>> - need clocks that are describ
On 03/09/15 18:44, Nayeemahmed Badebade wrote:
Fixed checkpatch.pl warning in kcomedilib_main.c:
- Block comments use * on subsequent lines
Signed-off-by: Nayeemahmed Badebade
---
.../staging/comedi/kcomedilib/kcomedilib_main.c| 32 +++---
1 file changed, 16 insertions(
Patchset covers checkpatch recommendations and code cleanup of
multiple duplicate or unncessary cpp defines.
Anish Bhatt (5):
staging/wlan-ng : Prefer ether_addr* functions over mem*
staging/wlan-ng : Remove duplicated defines from p80211
staging/rtl* Remove unused macro definitions.
stag
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8188eu/include/wifi.h | 5 -
drivers/staging/rtl8712/wifi.h | 4
2 files changed, 9 deletions(-)
diff --git a/drivers/staging/rtl818
ETH_ALEN/ETH_HLEN can be used instead of
WLAN_ETHADDR_LEN & WLAN_ETHHDR_LEN, replace directly or
use eth_addr* functions where applicable.
Signed-off-by: Anish Bhatt
---
drivers/staging/wlan-ng/p80211conv.c | 50 ++--
drivers/staging/wlan-ng/p80211conv.h | 7 ++-
Replace memcmp/memcpy(... ETH_ALEN) with ether_addr_copy()/
ether_addr_equal_unaligned()
Signed-off-by: Anish Bhatt
---
drivers/staging/wlan-ng/p80211conv.c | 22 +++---
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
drivers/staging/wlan-ng/prism2sta.c| 16 +---
The BIT() macro is already defined in bitops.h,
remove duplicate definitions.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8188eu/include/rtl8188e_spec.h | 4
drivers/staging/rtl8188eu/include/wifi.h | 7 ---
drivers/staging/rtl8712/osdep_service.h | 4
driv
Replace (1 << x) by BIT(x) as recommended by
checkpatch.pl
Signed-off-by: Anish Bhatt
---
drivers/staging/wilc1000/wilc_wlan.c | 64 +---
1 file changed, 31 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc10
If memdup_user() fails then it will return the error code in ERR_PTR. We
were checking it with IS_ERR but then again trying to free it on the
error path.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/wilc1000/linux_wlan.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --g
On Fri, Sep 04, 2015 at 02:08:08AM -0700, Anish Bhatt wrote:
> Replace (1 << x) by BIT(x) as recommended by
> checkpatch.pl
>
> Signed-off-by: Anish Bhatt
> ---
You need to refresh your tree. This patch is not applying because of
some other changes.
regards
sudip
On Fri, Sep 04, 2015 at 02:08:07AM -0700, Anish Bhatt wrote:
> The BIT() macro is already defined in bitops.h,
> remove duplicate definitions.
>
> Signed-off-by: Anish Bhatt
> ---
This patch is adding new build warnings.
regards
sudip
___
devel mailing
channel->dev has already been checked for NULL and if it was NULL then
we have returned with -EPIPE. So at this point it can not be NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/aim-cdev/cdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mo
The return type of get_aim_dev() is a pointer but we were returning 0
incase of failure.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/aim-v4l2/video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-v4l2/video.c
b/drivers/staging/most/aim-
BOOLEAN tests do not need any comparison to TRUE or FALSE.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/hdm-usb/hdm_usb.c | 10 +-
drivers/staging/most/mostcore/core.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_
The loop cursor of list_for_each_entry_safe() can never be NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index 7b
The platform driver core will set the owner value, we do not need to do
it in the module.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c
b/drivers/staging/most/hdm-dim2/dim2_
On Fri, Sep 04, 2015 at 11:42:37AM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 03, 2015 at 01:13:14PM +0200, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by:
On 09/02/2015 08:40 PM, Greg KH wrote:
These aren't all "fixes" so I can't just add them to the 4.3-final
release, but some look like they should go there. So please split this
into two different series and resend, one for 4.3-final and one for
4.4-rc1.
Greg,
We've been running and testing wi
These variables were only assigned some values but they were never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/slicoss/slicoss.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slic
On Fri, Sep 04, 2015 at 09:20:23AM -0400, Ben Romer wrote:
> On 09/02/2015 08:40 PM, Greg KH wrote:
> >These aren't all "fixes" so I can't just add them to the 4.3-final
> >release, but some look like they should go there. So please split this
> >into two different series and resend, one for 4.3-f
On 09/04/2015 09:41 AM, Sudip Mukherjee wrote:
Any new developments can only go in rc1 release. 4.3 merge window is
already open so new developments cannot be added to 4.3-rc1. New codes
has to go to 4.4-rc1.
4.3-rc2 - 4.3-rc7 (or 8) can only have fixes.
I don't think any of the patches in this s
On Wed 02-09-15 18:06:20, Greg KH wrote:
[...]
> And if we aren't taking patch 1/2, I guess this one isn't needed either?
Unlike the patch1 which was pretty much cosmetic this fixes a real
issue.
--
Michal Hocko
SUSE Labs
___
devel mailing list
de...@li
On Fri, Sep 04, 2015 at 09:58:10AM -0400, Ben Romer wrote:
> On 09/04/2015 09:41 AM, Sudip Mukherjee wrote:
> >Any new developments can only go in rc1 release. 4.3 merge window is
> >already open so new developments cannot be added to 4.3-rc1. New codes
> >has to go to 4.4-rc1.
> >4.3-rc2 - 4.3-rc7
On Fri, Sep 04, 2015 at 09:58:10AM -0400, Ben Romer wrote:
> On 09/04/2015 09:41 AM, Sudip Mukherjee wrote:
> >Any new developments can only go in rc1 release. 4.3 merge window is
> >already open so new developments cannot be added to 4.3-rc1. New codes
> >has to go to 4.4-rc1.
> >4.3-rc2 - 4.3-rc7
Hi Ulf,
On Fri, 4 Sep 2015, Ulf Hansson wrote:
> On 3 September 2015 at 15:35, Geert Uytterhoeven wrote:
> > On Thu, Sep 3, 2015 at 2:53 PM, Ulf Hansson wrote:
> >> On 17 June 2015 at 10:38, Geert Uytterhoeven
> >> wrote:
> >>> Add support for easy registering of one ore more platform
On Fri, Sep 04, 2015 at 02:44:08PM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: 20aaa13f9b1de5756512cb1680329648406340a2
> commit: 20aaa13f9b1de5756512cb1680329648406340a2 [158/158] staging: wilc1000:
> remo
This set of patches contains fixes for bugs found in testing, and by the
kernel release bot.
Benjamin Romer (2):
staging: unisys: stop device registration before visorbus registration
staging: unisys: visornic: handle error return from device
registration
David Kershner (3):
staging: un
There is no code to handle an error return in visornic, when it tries to
register with visorbus. This patch handles an error return from
visorbus_register_visor_driver() by dropping out of initialization.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 5 +++--
In cases where visorbus is compiled directly into the kernel, if
visorbus registration fails for any reason, it is still possible for
other drivers to call visorbus_register_visor_driver(), which could
cause an oops. Prevent this by saving the result of the call to
create_bus() in a static variable
From: David Kershner
If there is an error in registering driver attributes, unregister
the driver as well.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unis
From: David Kershner
Noticed we were not unregistering the netdevice if we failed to
create the debugfs entries. This patch fixes that problem.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 5 -
1 file changed, 4 insertio
From: David Kershner
The receive byte statistics was wrong in /proc/net/dev.
Move the collection of statistics after the proper amount
of bytes has been calculated and make sure you add it to
rx_bytes instead of just replacing it.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
--
From: Tim Sell
Update documentation (including TODO) to reflect the current state of
the drivers.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
.../Documentation/ABI/sysfs-platform-visorchipset | 2 +
drivers/staging/unisys/Documentation/overview.txt | 458 ++--
On Fri, Sep 04, 2015 at 12:13:26PM -0400, Benjamin Romer wrote:
> From: Tim Sell
>
> Update documentation (including TODO) to reflect the current state of
> the drivers.
>
> Signed-off-by: Tim Sell
> Signed-off-by: Benjamin Romer
> ---
> .../Documentation/ABI/sysfs-platform-visorchipset |
On Fri, Sep 04, 2015 at 03:01:55PM +0900, johnny.kim wrote:
>
>
> On 2015년 09월 04일 12:51, Greg KH wrote:
> >On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote:
> >>
> >>On 2015년 09월 04일 00:47, Greg KH wrote:
> >>>On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote:
> Hello Greg
From: Tim Sell
Update documentation (including TODO) to reflect the current state of
the drivers.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: resend due to patch corruption
---
.../Documentation/ABI/sysfs-platform-visorchipset | 2 +
drivers/staging/unisys/Documentation
On Fri, Sep 04, 2015 at 04:05:59PM +0200, Michal Hocko wrote:
> On Wed 02-09-15 18:06:20, Greg KH wrote:
> [...]
> > And if we aren't taking patch 1/2, I guess this one isn't needed either?
>
> Unlike the patch1 which was pretty much cosmetic this fixes a real
> issue.
Ok, then it would be great
Greg KH wrote:
> On Fri, Sep 04, 2015 at 04:05:59PM +0200, Michal Hocko wrote:
> > On Wed 02-09-15 18:06:20, Greg KH wrote:
> > [...]
> > > And if we aren't taking patch 1/2, I guess this one isn't needed either?
> >
> > Unlike the patch1 which was pretty much cosmetic this fixes a real
> > issue.
The cleanup1 label does nothing but return. Better way is to return
immediately instead of using goto. Hence, removed.
Signed-off-by: Ravi Teja Darbha
---
drivers/staging/emxx_udc/emxx_udc.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/emxx_udc/emx
Remove unnecessary braces where appropriate.
This removes the following checkpatch warnings:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Maciek Borzecki
---
drivers/staging/media/lirc/lirc_imon.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Replace custom debug macro dprintk() with pr_debug() or
dev_dbg(). Remove unused module param `debug`.
This removes the following checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
+
Fix non-tab indentation.
This resolves the following checkpatch problem:
ERROR: code indent should use tabs where possible
Signed-off-by: Maciek Borzecki
---
drivers/staging/media/lirc/lirc_sasem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/lir
A tiny patch series that addresses warnings or errors identified by
checkpatch.
The patches were first submitted to driver-devel sometime in June.
While on driver-devel, Sudip Mukherjee helped to cleanup all
issues. I'm resending the set to linux-media so that they can be
picked up for the media t
On Sat, Sep 05, 2015 at 03:06:46AM +0900, Tetsuo Handa wrote:
> Greg KH wrote:
> > On Fri, Sep 04, 2015 at 04:05:59PM +0200, Michal Hocko wrote:
> > > On Wed 02-09-15 18:06:20, Greg KH wrote:
> > > [...]
> > > > And if we aren't taking patch 1/2, I guess this one isn't needed either?
> > >
> > > U
ETH_ALEN/ETH_HLEN can be used instead of
WLAN_ETHADDR_LEN & WLAN_ETHHDR_LEN, replace directly or
use eth_addr* functions where applicable.
Signed-off-by: Anish Bhatt
---
drivers/staging/wlan-ng/p80211conv.c | 50 ++--
drivers/staging/wlan-ng/p80211conv.h | 7 ++-
Patchset covers checkpatch recommendations and code cleanup of
multiple duplicate or unncessary cpp defines.
v2 : Rebase on top for staging-testing instead of master
Silence build warnings
Anish Bhatt (5):
staging/wlan-ng : Prefer ether_addr* functions over mem*
staging/wlan-ng : Remove
The BIT() macro is already defined in bitops.h,
remove duplicate definitions. Fix any resultant build or
checkpatch warnings.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 7 +--
drivers/staging/rtl8188eu/core/rtw_wlan_util.c| 6 --
drivers/stagin
Replace memcmp/memcpy(... ETH_ALEN) with ether_addr_copy()/
ether_addr_equal_unaligned()
Signed-off-by: Anish Bhatt
---
drivers/staging/wlan-ng/p80211conv.c | 22 +++---
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
drivers/staging/wlan-ng/prism2sta.c| 16 +---
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8188eu/include/wifi.h | 5 -
drivers/staging/rtl8712/wifi.h | 4
2 files changed, 9 deletions(-)
diff --git a/drivers/staging/rtl818
Replace (1 << x) by BIT(x) as recommended by
checkpatch.pl. Fix any resultant build warnings.
Signed-off-by: Anish Bhatt
---
drivers/staging/wilc1000/wilc_wlan.c | 72 ++--
1 file changed, 35 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/wilc1000/wi
This is a patch to the ieee80211_softmac_wx.c file that corrects several
checkpatch.pl warnings and errors.
Signed-off-by: Mike Dupuis
---
.../rtl8192u/ieee80211/ieee80211_softmac_wx.c | 114 ++--
1 file changed, 54 insertions(+), 60 deletions(-)
diff --git a/drivers/stag
On Fri, Sep 04, 2015 at 11:00:06PM +, Mike Dupuis wrote:
> This is a patch to the ieee80211_softmac_wx.c file that corrects several
> checkpatch.pl warnings and errors.
> Signed-off-by: Mike Dupuis
You need a blank line before the signed-off-by line.
Also, please break this up into multiple
56 matches
Mail list logo
