On Wed, Sep 9, 2015 at 10:19 AM, Laura Abbott wrote:
> (adding Colin and John)
>
>
> On 09/09/2015 12:41 AM, Shawn Lin wrote:
>>
>> we found this issue but still exit in lastest kernel. Simply
>> keep ion_handle_create under mutex_lock to avoid this race.
>>
>> WARNING: CPU: 2 PID: 2648 at drivers
On Thu, Sep 10, 2015 at 11:08:25AM +0900, Tony Cho wrote:
> Hi Greg,
>
> I want to make sure one thing before moving further. Are you saying
> the errorsupport.h file as the os wrapper remaining in the oswrapper.h
> file? If not, can you let me know what you point out as remaining os
> wrapper in
On Wed, Sep 09, 2015 at 11:20:08PM +0200, Noralf Trønnes wrote:
>
> Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
> >On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
> >>Instead of defining DRVNAME and using it in all calls to pr_* family of
> >>macros lets start using pr_fmt.
>
From: Glen Lee
The macro WILC_MALLOC is not used in the driver anymore, so just
delete files.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/wilc_memory.c| 16
drivers/staging/wilc1000/wilc_memory.h
From: Glen Lee
This patch calls kmalloc() directly. No need to wrap kmalloc().
All is not holding a spin lock or in interrupt context. So use GFP_KERNEL
flag for kmalloc.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 110 +++---
This patch removes BROKEN status from the Kconfig.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig
index 51bbf46..59ccecc 100644
--- a/drivers/staging/wilc1000/Kcon
Hi Greg,
I want to make sure one thing before moving further. Are you saying the
errorsupport.h file as the os wrapper remaining in the oswrapper.h file?
If not, can you let me know what you point out as remaining os wrapper in the
oswrapper.h file?
If yes, I have been already replacing all of
On 2015년 09월 10일 03:17, Greg KH wrote:
On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote:
From: Glen Lee
Call kmalloc directly. No need to wrap kmalloc.
Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
interrupt context or process context. In this case, We call
The BIT() macro is already defined in bitops.h,
remove duplicate definitions.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8712/osdep_service.h | 4
drivers/staging/rtl8712/wifi.h | 5 -
2 files changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8712/osdep_service.h
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8712/wifi.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
index 17f5131..67c6eb
The BIT() macro is already defined in bitops.h, remove duplicate
definitions. Users of BIT() macro are expecting unsigned int/u32, so
add typecasts where this creates a build warning.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 7 +--
drivers/staging/rt
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8188eu/include/wifi.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
b/drivers/staging/rtl8188eu/incl
Patchset removes unused macro definitions and removes duplicate
definitions of BIT() macro from rtl8188eu & rtl8712 drivers.
v2 : Rebase on top for staging-testing instead of master
Silence build warnings
v3 : Split patchset into per driver patches.
Strictly do one thing per patch
Anish
Den 09.09.2015 20:35, skrev Greg Kroah-Hartman:
On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
Instead of defining DRVNAME and using it in all calls to pr_* family of
macros lets start using pr_fmt.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/fbtft/fbtft_device.c |
On Sat, Sep 05, 2015 at 07:13:45PM +0530, Sudip Mukherjee wrote:
> Instead of defining DRVNAME and using it in all calls to pr_* family of
> macros lets start using pr_fmt.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/fbtft/fbtft_device.c | 79
> ---
On Fri, Sep 04, 2015 at 06:53:18PM +0530, Sudip Mukherjee wrote:
> These variables were only assigned some values but they were never used.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/slicoss/slicoss.c | 27 ++-
> 1 file changed, 6 insertions(+), 21 deletio
On Fri, Sep 04, 2015 at 02:00:31PM -0700, Anish Bhatt wrote:
> WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
> are unused, duplicate or unnecessary, remove.
>
> Signed-off-by: Anish Bhatt
> ---
> drivers/staging/rtl8188eu/include/wifi.h | 5 -
> drivers/staging/rtl8712/wifi.h | 4
On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> Call kmalloc directly. No need to wrap kmalloc.
> Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
> interrupt context or process context. In this case, We call in_interrupt to
> decide the flag
On Fri, Sep 04, 2015 at 02:00:29PM -0700, Anish Bhatt wrote:
> Replace memcmp/memcpy(... ETH_ALEN) with ether_addr_copy()/
> ether_addr_equal_unaligned()
You need to prove that this is ok to do so.
___
devel mailing list
de...@linuxdriverproject.org
htt
On Fri, Sep 04, 2015 at 02:00:33PM -0700, Anish Bhatt wrote:
> Replace (1 << x) by BIT(x) as recommended by
> checkpatch.pl. Fix any resultant build warnings.
>
> Signed-off-by: Anish Bhatt
> ---
> drivers/staging/wilc1000/wilc_wlan.c | 72
> ++--
> 1 file change
On Tue, Sep 08, 2015 at 05:07:59PM +0900, Tony Cho wrote:
> From: Johnny Kim
>
> This patch adds new define, IDLE_MODE to change comparison statement which
> is wrong due to typecasting to null.
>
> Signed-off-by: Johnny Kim
> Signed-off-by: Tony Cho
> ---
> drivers/staging/wilc1000/host_inte
On Wed, Sep 09, 2015 at 04:08:12PM +0900, Tony Cho wrote:
> From: Glen Lee
>
> wilc1000 driver runs on Linux. No need to have oswrapper or platform
> dependent files.
> Before delete two header files, move two structures in wilc_platform.h to
> wilc_msgqueue.h where it is used. Include linux head
On Fri, Sep 04, 2015 at 02:00:32PM -0700, Anish Bhatt wrote:
> The BIT() macro is already defined in bitops.h,
> remove duplicate definitions. Fix any resultant build or
> checkpatch warnings.
"any"? Please be specific and only do one thing per patch.
Again, this is multiple drivers.
__
On Wed, Sep 09, 2015 at 12:55:38AM +0900, Chaehyun Lim wrote:
> This patch replaces WILC_WFI_CfgSetChannel with
> wilc_cfg80211_set_monitor_channel to avoid CamelCase.
Like was said, this is now longer, how about something "simple" like
wilc_set_channel()?
Actually, as this is a static function,
On Wed, Sep 09, 2015 at 09:27:04AM +0800, Boqun Feng wrote:
> After commit:
>
> atomics: add acquire/release/relaxed variants of some atomic operations
>
> Architectures may only provide {cmp,}xchg_relaxed definitions in
> asm/cmpxchg.h. Other variants, such as {cmp,}xchg, may be built in
> linux
(adding Colin and John)
On 09/09/2015 12:41 AM, Shawn Lin wrote:
we found this issue but still exit in lastest kernel. Simply
keep ion_handle_create under mutex_lock to avoid this race.
WARNING: CPU: 2 PID: 2648 at drivers/staging/android/ion/ion.c:512
ion_handle_add+0xb4/0xc0()
ion_handle_add
we found this issue but still exit in lastest kernel. Simply
keep ion_handle_create under mutex_lock to avoid this race.
WARNING: CPU: 2 PID: 2648 at drivers/staging/android/ion/ion.c:512
ion_handle_add+0xb4/0xc0()
ion_handle_add: buffer already found.
Modules linked in: iwlmvm iwlwifi mac80211 c
Hi Dan,
Many thanks for this first review.
2015-09-09 5:38 GMT+02:00 Daniel Kurtz :
> Hi Eric,
>
> Thanks for starting to upstream this Analogix Slimport driver!
> As Greg says, please move this driver to its intended directory, I presume:
> /drivers/gpu/drm/bridge
>
I sent yesterday another ver
From: Leo Kim
This patch removes the preprocessor definition, PLAT_RK3026_TCHIP which
is not used anymore.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan.c | 24
1 file changed, 24 deletions(-)
diff --git a/drivers/staging/wilc1
From: Glen Lee
Call kmalloc directly. No need to wrap kmalloc.
Only one function, wilc_mq_send which use WILC_MALLOC, can be running in
interrupt context or process context. In this case, We call in_interrupt to
decide the flag, GFP_ATOMIC or GFP_KERNEL, for kmalloc properly. Additionally,
there
From: Glen Lee
The macro WILC_MALLOC is not used in the driver anymore, so just
delete files.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/Makefile | 2 +-
drivers/staging/wilc1000/wilc_memory.c| 16
drivers/staging/wilc1000/wilc_memory.h
From: Glen Lee
wilc1000 driver runs on Linux. No need to have oswrapper or platform
dependent files.
Before delete two header files, move two structures in wilc_platform.h to
wilc_msgqueue.h where it is used. Include linux header files where is needs
since wilc_platform is deleted.
Finally, remov
32 matches
Mail list logo
