[PATCH] staging: sm750fb: Added a space

Added a space to fix the following coding style error detected by checkpatch. ERROR: space required before the open parenthesis '(' Signed-off-by: Anjali Menon --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

On Mon, Sep 14, 2015 at 05:37:45PM +0530, Ronit Halder wrote: > I checked but it didn't show me any warning. > Can you please specify the warning? try with --strict option of checkpatch. regards sudip ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCHv3 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

Hi Enric, Partial review for now, thanks for you work. Best, On Thu, Sep 10, 2015 at 06:35:52PM +0200, Enric Balletbo i Serra wrote: > At the moment it only supports ANX7814. > > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > This

Re: [PATCH] Staging: wilc1000: Use NULL instead of zero

I checked but it didn't show me any warning. Can you please specify the warning? regards On Mon, Sep 14, 2015 at 2:06 PM, Sudip Mukherjee wrote: > On Mon, Sep 14, 2015 at 11:03:34AM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by sparse >>

Re: [PATCH 00/39] drop null test before destroy functions

> Recent commits to kernel/git/torvalds/linux.git have made the following > functions able to tolerate NULL arguments: > > kmem_cache_destroy (commit 3942d29918522) > mempool_destroy (commit 4e3ca3e033d1) > dma_pool_destroy (commit 44d7175da6ea) How do you think about to extend an other SmPL

[PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros. Build tested it. Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/libcfs/tracefile.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git

Re: [PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

On Mon, Sep 14, 2015 at 07:54:30PM +0530, Shraddha Barke wrote: > > > On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote: > > >On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote: > >>Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros. > >> > >>Build tested it. > > >

[PATCH 2/2] Staging: rtl8192u: ieee80211: Use pr_info/pr_warn/pr_alert/pr_debug macros

Replace all occurrences of printk(KERN_* by pr_info and pr_alert macros. Build tested it. Signed-off-by: Shraddha Barke --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 2/2] Staging: rtl8192u: ieee80211: Use pr_info/pr_warn/pr_alert/pr_debug macros

On Mon, Sep 14, 2015 at 07:17:30PM +0530, Shraddha Barke wrote: > Replace all occurrences of printk(KERN_* by pr_info and pr_alert macros. > > Build tested it. Same comments as the other patch. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line

On Mon, Sep 14, 2015 at 02:41:24PM +0530, Sakshi Vaid wrote: > Added a missing blank line after declarations. > > 158: WARNING: Missing a blank line after declarations > 183: WARNING: Missing a blank line after declarations > > Signed-off-by: Sakshi Vaid > --- >

Re: [PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote: On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote: Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros. Build tested it. Why put this here in the changelog area? You always have to at least build test your

Re: [PATCH] staging: ft1000: code style cleanup

On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote: > On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote: > > There was a stray '*' in a comment block. > > > > Signed-off-by: lucasg > > --- > Greg has already applied your patch, but next time you send

Re: [PATCH] staging: ft1000: code style cleanup

On Mon, Sep 14, 2015 at 07:33:47AM -0700, Greg KH wrote: > On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote: > > On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote: > > > There was a stray '*' in a comment block. > > > > > > Signed-off-by: lucasg > >

Re: [PATCH 1/2] Staging: lustre: libcfs: Use pr_info and pr_warn macros

On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote: > Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros. > > Build tested it. Why put this here in the changelog area? You always have to at least build test your changes, so this is always implied. And can some

[PATCH] staging: ft1000: code style cleanup

There was a stray '*' in a comment block. Signed-off-by: Lucas Georges --- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c

[PATCH v2] Staging: lustre: lustre: lov: lov_dev.c: Added missing blank line

line 158: WARNING: Missing a blank line after declarations line 183: WARNING: Missing a blank line after declarations Added a missing blank line after declartions. Signed-off-by: Sakshi Vaid --- drivers/staging/lustre/lustre/lov/lov_dev.c | 2 ++ 1 file changed, 2

Re: [PATCH v2 00/12] New paravirtual PCI front-end for Hyper-V VMs

Hi Jake, In the future, please CC me on anything that touches irqdomains, along with Jiang Liu as we both co-maintain this piece of code. On 11/09/15 01:00, ja...@microsoft.com wrote: > From: Jake Oshins > > The patch series updates the one sent about a month ago in three

Re: [PATCH] staging: ft1000: code style cleanup

On Mon, Sep 14, 2015 at 08:24:24PM +0530, Sudip Mukherjee wrote: > On Mon, Sep 14, 2015 at 07:33:47AM -0700, Greg KH wrote: > > On Mon, Sep 14, 2015 at 01:48:09PM +0530, Sudip Mukherjee wrote: > > > On Sun, Sep 13, 2015 at 12:55:42AM +0200, lucasg wrote: > > > > There was a stray '*' in a comment

[PATCH] drivers: stating: wilc1000: Add a check for SPI availability

NULL pointer deference is observed in the wilc1000.ko module with bus type SPI and when SPI is not ready. Signed-off-by: Chandra S Gorentla --- Following are the steps to reproduce. $ sudo insmod drivers/staging/wilc1000/wilc1000.ko $ sudo ifconfig wlan1 up wlan1 in the

[PATCH] staging: netlogic: platform: Fix miscellaneous coding style issues

This patch fixes all alignment issues, as well as a multiple assignment and multiple blank lines issues. Signed-off-by: Martin Pietryka --- drivers/staging/netlogic/platform_net.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff

Re: [PATCH RESEND 01/16] staging: rtl8188eu: rtw_mlme_ext.c: reorder the report functions

On 09/14/2015 05:34 PM, Luca Ceresoli wrote: Dear Larry, All, Luca Ceresoli wrote: Dear Larry, thanks for your review. Larry Finger wrote: On 08/28/2015 03:45 PM, Luca Ceresoli wrote: Some of the report_*() functions are internal and will be declared static, and their declaration removed

[PATCH 15/19] staging/lustre: Remove unused MAY_ constants

From: Ben Evans Remove unused MAY_ constants from lustre_idl.h Signed-off-by: Ben Evans Reviewed-on: http://review.whamcloud.com/15398 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6450 Reviewed-by: John L. Hammond Reviewed-by:

[PATCH 19/19] staging/lustre/ptlrpc: make ptlrpcd threads cpt-aware

From: Olaf Weber On NUMA systems, the placement of worker threads relative to the memory they use greatly affects performance. The CPT mechanism can be used to constrain a number of Lustre thread types, and this change makes it possible to configure the placement of ptlrpcd threads

[PATCH 16/19] staging/lustre/osc: use global osc_rq_pool to reduce memory usage

From: Li Xi The per-osc request pools consume a lot of memory if there are hundreds of OSCs on one client. This will be a critical problem if the client doesn't have sufficient memory for both OSCs and applications. This patch replaces per-osc request pools with a global pool

[PATCH 09/19] staging/lustre/osc: LBUG in osc_lru_reclaim

From: Hiroya Nozaki LASSERT touches cl_client_cache->ccc_lru without any protection. So this patch the LASSERT moves to the section protected by cl_client_cache->ccc_lru_lock Signed-off-by: Hiroya Nozaki Reviewed-on:

[PATCH 18/19] staging/lustre/libcfs: remove unused cfs_timer_done

From: James Simmons Remove the cfs_timer_done function in the libcfs kernel module since it is not used anywhere. Signed-off-by: James Simmons Signed-off-by: frank zago Reviewed-on: http://review.whamcloud.com/13917 Intel-bug-id:

Re: [PATCH] linux-firmware: Add firmware blobs for Digi International Acceleport Xr cards

On Mon, 2015-09-14 at 16:29 -0400, Mark Hounschell wrote: [...] > +Driver: dgap - Digi International Acceleport Xr PCI, Acceleport Xr 920 PCI, > + Acceleport Xem PCI, Acceleport C/X PCI, and Acceleport EPC/X > + PCI families of adapters. > + > +File: dgap/cxcon.bin >

[PATCH] Staging: fbtft: Replace pr_info with dev_info

Replace pr_info with dev_info when appropriate device structure is present Signed-off-by: Shraddha Barke --- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c

Re: [PATCH RESEND 01/16] staging: rtl8188eu: rtw_mlme_ext.c: reorder the report functions

Dear Larry, All, Luca Ceresoli wrote: Dear Larry, thanks for your review. Larry Finger wrote: On 08/28/2015 03:45 PM, Luca Ceresoli wrote: Some of the report_*() functions are internal and will be declared static, and their declaration removed from rtw_mlme_ext.h, in a later commit. This

Re: [PATCH] staging: lustre: lnet: lnet: Added a space

On 09/13/15 06:14, Anjali Menon wrote: > Added a space to fix the following coding style warning detected by > checkpatch: Both your commit title and message say (or imply) you've added a space, but this patch, in fact, removes a space, doesn't it? > WARNING: space prohibited between function

[PATCH 04/19] staging/lustre/llite: strengthen checks for hsm flags and archive id

From: Bruno Faccini Prior to this patch undefined flags bits and out of range archive id can be set. Signed-off-by: Bruno Faccini Reviewed-on: http://review.whamcloud.com/13337 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5757

[PATCH 05/19] staging/lustre/ptlrpc: remove LUSTRE_MSG_MAGIC_V1 support

From: Andreas Dilger Remove the remains of LUSTRE_MSG_MAGIC_V1 support from ptlrpc. It has not been supported since 1.8 and is not functional since 2.0. In lustre_msg_check_version(), return an error for unsupported RPC versions so that the server will reject such RPCs

[PATCH 01/19] staging/lustre/lnet: Reenable lnet router debugfs

From: Oleg Drokin It looks like router proc files were defined out, so I missed them during debugfs conversion. Reenable the code and move all the variables to debugfs. Signed-off-by: Oleg Drokin --- .../staging/lustre/include/linux/libcfs/libcfs.h

[PATCH 07/19] staging/lustre/llite: deny non-root user for changelog operations

From: Niu Yawei To avoid potential security problems, non-privileged users should have no permission to run 'lfs changelog' & 'lfs changelog_clear'. Signed-off-by: Niu Yawei Reviewed-on: http://review.whamcloud.com/14280 Intel-bug-id:

[PATCH 14/19] staging/lustre/obdclass: Eliminate hash bucket scans in lu_cache_shrink

From: Ann Koehler The lu_cache_shrink slab shrinker is too slow, accounting for > 90% of the time spent in shrink_slab when allocating huge pages. Most of its time is spent iterating over the buckets in each site's object hash table to compute the number of freeable objects. This

[PATCH 10/19] staging/lustre/libcfs: minor fix in cfs_hash_for_each_relax()

From: Niu Yawei cfs_hash_for_each_relax() should break iteration when callback returns non-zero value. Signed-off-by: Niu Yawei Reviewed-on: http://review.whamcloud.com/14927 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6636 Reviewed-by: Bobi

[PATCH 12/19] staging/lustre/o2iblnd: wrong uses of kib_tx_t::tx_nfrags

From: Isaac Huang The kib_tx_t::tx_nfrags field is the # entries in the kib_tx_t::tx_frags array, rather than # DMA mapped entries. So kiblnd_send/kiblnd_recv should use kib_rdma_desc_t::rd_nfrags instead. Signed-off-by: Isaac Huang Reviewed-on:

[PATCH 17/19] staging/lustre/o2iblnd: leak cmid in kiblnd_dev_need_failover

From: Liang Zhen cmid created by kiblnd_dev_need_failover should always be destroyed, however it is not the case in current implementation and we will leak cmid when this function detected a device failover. Signed-off-by: Liang Zhen Reviewed-on:

[PATCH 03/19] staging/lustre/llite: cleanup open handle for client open failure

From: Fan Yong For open case, the client side open handling thread may hit error after the MDT grant the open. Under such case, the client should send close RPC to the MDT as cleanup; otherwise, the open handle on the MDT will be leaked there until the client umount or

[PATCH 02/19] staging/lustre/obdclass: reorganize busy object accounting

From: Frank Zago Due to some accounting bug, lsb_busy of a hash bucket can become larger than the total number of objects in said bucket. A busy object can be counted more than once. When that happens, a negative value is returned by the shrinker callback. Instead of trying (and

[PATCH 00/19] Lustre fixes

From: Oleg Drokin This batch of changes is for various accumulated fixes since the last time I had a chance to look at it. The only "exception" is the last patch in the series - the CPT-aware ptlrpcd patch. This one is included because there was a strange code in that area

[PATCH 11/19] staging/lustre/lnet: fix deadloop in ksocknal_push

From: Liang Zhen ksocknal_push() should break the loop if it can't find matching peer Signed-off-by: Liang Zhen Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4423 Reviewed-on: http://review.whamcloud.com/10128 Reviewed-by: James Simmons

[PATCH 06/19] staging/lustre/lmv: fix potential null pointer dereference

From: Oleg Drokin In lmv_disconnect_mdc do procfs removal only if we actually know the name. Reviewed-on: http://review.whamcloud.com/14605 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6517 Reviewed-by: James Simmons Reviewed-by: John L.

[PATCH 08/19] staging/lustre/o2iblnd: connection refcount fix for kiblnd_post_rx

From: Liang Zhen kiblnd_post_rx() can't refer to rx::rx_conn anymore after ib_post_recv() because this rx can be polled out by another thread which may drop this rx and destroy rx::rx_conn. This patch fixes this issue by taking an extra refcount on connection before

[PATCH 13/19] staging/lustre/llite: ASSERTION( atomic_read(>ld_ref) == 0 ) failed

From: Andrew Perepechko ll_iget_for_nfs() can call unbalanced iput() causing memory leaks. This patch removes this iput() call. Also, avoid unhashing disconnected dentries in d_lustre_invalidate(), which is another source of memory leaks. One of the symptoms of

Re: [PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote: > In cases where WILC_ERRORREPORT does not require cleanup actions, but > causes immediate return from the function it can be replaced with return > statement. > > Signed-off-by: Mike Rapoport > --- Have you

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

Hi Greg, I am sorry but please ignore this patch in this time. It's my mistake to include this patch from my queue into the series of 7 patches. Thanks, Tony. On 2015년 09월 11일 16:52, Tony Cho wrote: This patch removes the preprocessor definition, RX_BH_TYPE and uses the

[PATCH 6/7] staging: wilc1000: replace wilc error types with kernel generic error type.

From: Leo Kim This patch replaces the wilc error types with kernel generic error type. - WILC_SUCCESS 0 - WILC_FAIL -EFAULT - WILC_BUSY -EBUSY - WILC_INVALID_ARGUMENT -EINVAL -

[PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK

From: Leo Kim This patch removes the definition WILC_NULLCHECK which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 ++--

[PATCH 7/7] staging: wilc1000: remove wilc_errorsupport

From: Leo Kim This patch removes the file, wilc_errorsupport which is not used anymore. Remove #include "wilc_errorsupport.h" from the source code. Signed-off-by: Leo Kim Signed-off-by: Tony Cho ---

[PATCH 5/7] staging: wilc1000: remove definitions unused

From: Leo Kim Remove the definitions which are not used anywhere. - WILC_ALREADY_EXSIT - WILC_EMPTY - WILC_FULL - WILC_CANCELED - WILC_INVALID_FILE - WILC_UNSUPPORTED_VERSION - WILC_FILE_EOF Remove the definition which is not used anymore. - WILC_CATCH Signed-off-by: Leo Kim

[PATCH 4/7] staging: wilc1000: remove definition WILC_ERRORREPORT

From: Leo Kim This patch removes the definition WILC_ERRORREPORT which is not used anymore, and also replace PRINT_ER with printk error log. The compiler complains the build warnings in some functions for WILC_CATCH and ERRORHANDLER as unused definitions. So, this patch also

[PATCH 3/7] staging: wilc1000: remove definition WILC_ERRORCHECK

From: Leo Kim This patch removes the definition WILC_ERRORCHECK which is not used anymore and replaces PRINT_ER with printk. There are build warnings from some functions because WILC_CATCH definition is not used. So, this patch also removes WILC_CATCH from the functions.

[PATCH 1/7] staging: wilc1000: remove definition WILC_IS_ERR

From: Leo Kim This patch removes the definition WILC_IS_ERR which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

This patch aims to remove the wilc_errorsupport.h which is unnecessary in the wilc driver. This patch replaces the error types defined by wilc driver with kernel generic error types and removes macros which handles the errors. Leo Kim (7): staging: wilc1000: remove definition WILC_IS_ERR

[PATCH 05/18] staging: wilc1000: use u16 instead of uint16_t

This patch replaces uint16_t with u16 that is preferred kernel type. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_spi.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c | 12 ++-- drivers/staging/wilc1000/wilc_wlan.h | 6 +++---

[PATCH 04/18] staging: wilc1000: use u8 instead of uint8_t

This patch replaces uint8_t with u8 that is a preferred kernel type. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/linux_mon.c | 2 +- drivers/staging/wilc1000/linux_wlan.c

[PATCH 02/18] staging: wilc1000: rename WILC_WFI_cfg80211_ops

This patch replaces WILC_WFI_cfg80211_ops with wilc_cfg80211_ops to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/18] staging: wilc1000: rename WILC_WFI_priv

This patch replaces WILC_WFI_priv with wilc_priv to avoid CamelCase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 12 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |

[PATCH 01/18] staging: wilc1000: remove duplicated include

wilc_wfi_cfgoperations.h and linux_wlan_common.h are included as duplicated in linux_wlan.c. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_wlan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c

Re: [PATCH] staging: netlogic: platform: Fix miscellaneous coding style issues

On Mon, Sep 14, 2015 at 10:31:05PM +, Martin Pietryka wrote: > This patch fixes all alignment issues, as well as a multiple > assignment and multiple blank lines issues. These are too many things to be included in a single patch. Please break them into a series. One patch should do only one

Re: [PATCH] Staging: fbtft: Replace pr_info with dev_info

On Tue, 15 Sep 2015, Shraddha Barke wrote: Replace pr_info with dev_info when appropriate device structure is present Signed-off-by: Shraddha Barke --- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drivers: stating: wilc1000: Add a check for SPI availability

On Mon, Sep 14, 2015 at 10:21:14PM +0530, Chandra S Gorentla wrote: > NULL pointer deference is observed in the wilc1000.ko module > with bus type SPI and when SPI is not ready. > > Signed-off-by: Chandra S Gorentla > --- A small spelling mistake in the subject. It should

[PATCH 4/4] staging: wilc1000: remove unused variable g_flushing_in_progress

From: Glen Lee g_flushing_in_progress is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 3/4] staging: wilc1000: coreconfigurator.h: remove unused defines

From: Glen Lee The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver. Delete two defines. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 3 --- 1 file

[PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

From: Glen Lee SendRawpacket is declared but not implemented. It is not used also. So just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 1 - 1 file changed, 1

Re: [PATCH 1/4] Staging: rtl8192u: space required before open parentheses

On Mon, Sep 14, 2015 at 08:48:04AM -0800, Mike Dupuis wrote: > > In your previous patches this From: line was not there. Why now? > > I did not do that by hand. I changed some SSMTP and git configuration > settings recently-- perhaps that is related. If this is a problem, I will > correct it. The

[PATCH 08/18] staging: wilc1000: remove useless extern declarations

This patch removes useless extern declarations. This function is not existed in the driver. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 18/18] staging: wilc1000: wilc_wfi_cfgoperations.h: align defines

This patch fix alignment of some defines in wilc_wfi_cfgoperations.h Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 44 +++ 1 file changed, 22 insertions(+), 22 deletions(-) diff --git

[PATCH 17/18] staging: wilc1000: remove if defined codes of FORCE_P2P_CLIENT

This patch removes if defined codes of FORCE_P2P_CLIENT. This macro is deleted because it it commented out. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 8 deletions(-) diff --git

[PATCH 11/18] staging: wilc1000: remove unused defines

The macros are not used anywhere in this driver, so just delete it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h

[PATCH 13/18] staging: wilc1000: fix alignment of enum

This patch fix alignment of enum. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 76 +++ 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h

[PATCH 06/18] staging: wilc1000: use u32 instead of uint32_t

This patch replaces uint32_t with u32 that is a preferred kernel type. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 +- drivers/staging/wilc1000/linux_mon.c | 4 +- drivers/staging/wilc1000/linux_wlan.c

[PATCH 10/18] staging: wilc1000: remove bit shift macro that is custom defined

This patch remove bit shift macro that is custom defined, then it is replaced BIT(x) macro. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH 07/18] staging: wilc1000: remove commented codes

This patch removes commented codes. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.h | 13 --- drivers/staging/wilc1000/linux_mon.c | 59 --- drivers/staging/wilc1000/wilc_sdio.c | 2 --

[PATCH 16/18] staging: wilc1000: remove FORCE_P2P_CLIENT

This patch removes FORCE_P2P_CLIENT that is commented. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h

Re: [PATCH] Staging: lustre: lustre: lclient: lcommon_cl.c: Fixed coding style error

On Mon, Sep 14, 2015 at 02:53:11PM +0530, Sakshi Vaid wrote: > Fixed the following error. > WARNING: More than 80 characters in a line. > > Signed-off-by: Sakshi Vaid > --- This has already been done by 159dc4bff27a ("staging: lustre: lclient: remove extra

[PATCH 09/18] staging: wilc1000: use BIT macro

This patch replaces bit shift with BIT(x) macro. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.h

[PATCH] staging/rtl8192u: remove unused function

Remove N_DBPSOfRate used in ComputeTxTime, remove by commit 742728f97a99 ("staging: rtl8192u: remove unused function.") Signed-off-by: Nicolas Joseph --- drivers/staging/rtl8192u/r8192U_core.c | 44 -- 1 file changed, 44

RE: [PATCH v2 00/12] New paravirtual PCI front-end for Hyper-V VMs

> -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Monday, September 14, 2015 8:01 AM > To: Jake Oshins ; gre...@linuxfoundation.org; KY > Srinivasan ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org;

Re: [PATCH] staging/rtl8192u: remove unused function

2015-09-14 14:00 GMT-04:00 Nicolas Joseph : > Remove N_DBPSOfRate used in ComputeTxTime, remove by > commit 742728f97a99 ("staging: rtl8192u: remove unused function.") > > Signed-off-by: Nicolas Joseph > --- >

[PATCH 02/13] staging: wilc1000: reduce WILC_{ERRORREPORT, CATCH} usage

In cases when WILC_ERRORREPORT is immidiately followed by WILC_CATCH, no goto is actually performed and therefore WILC_ERRORREPORT may be replaced with either printout or assignment of the error value, and WILC_CATCH may be completely removed. Signed-off-by: Mike Rapoport

[PATCH 12/13] staging: wilc1000: fix compilation warning

Fix the following compilation warning: CC [M] drivers/staging/wilc1000/wilc_wfi_cfgoperations.o drivers/staging/wilc1000/wilc_wfi_cfgoperations.c: In function ‘CfgScanResult’: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:378:6: warning: unused variable ‘s32Error’ [-Wunused-variable]

[PATCH 06/13] staging: wilc1000: remove usage of WILC_ERRORCHECK

The WILC_ERRORCHECK macro is replaced with printout or direct call to return statement, together with removal of several WILC_CATCH accompaniyng WILC_ERRORCHECK. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 6 ++

[PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

In cases where WILC_ERRORREPORT does not require cleanup actions, but causes immediate return from the function it can be replaced with return statement. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/coreconfigurator.c | 3 +-

[PATCH 08/13] staging: wilc1000: Handle_Scan: refactor error handling

In case SendConfigPkt fails, the error handling code performs deletion of timer, calls Handle_ScanDone and falls through freeing of allocated memory which is common for both success and error paths. The deletion of timer and invocation of Handle_ScanDone can be performed in 'then' clause of check

[PATCH 05/13] staging: wilc1000: replace WILC_NULLCHECK with return

WILC_NULLPTR can be replaced with test for NULL pointer and return of WILC_NULL_PTR. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 8 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 20 2 files

[PATCH 00/13] staging: wilc1000: remove WILC_CATCH and friends

Hi, These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK, WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error value or sets the error code and uses goto to jump to error handling code. Mike Rapoport (13): staging: wilc1000: replace WILC_ERRORREPORT with

[PATCH 09/13] staging: wilc1000: hif_ger_cfg: refactor error handling

Check whether the driver is initialized before getting the semaphore thus eliminating the need for WILC_ERRORREPORT and WILC_CATCH constructs and s32Error variable. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 13 + 1 file

[PATCH 10/13] staging: wilc1000: host_interface: refactor error handling

Use error value assignment and goto instead of WILC_ERRORREPORT and WILC_CATCH. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 93 +-- 1 file changed, 52 insertions(+), 41 deletions(-) diff --git

[PATCH 04/13] staging: wilc1000: wilc_mq_send: refactor allocation errors handling

In case the first allocation fails, we can return directly, and if the second allocation fails we can goto to the end of the function where we free the memory and return error. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/wilc_msgqueue.c | 21

[PATCH 03/13] staging: wilc1000: wilc_mq_send: reorder spin_lock and allocations

Make memory allocations outside of spin lock, so that ellocation errors handling will not require unlocking Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 11/13] staging: wilc1000: stop using WILC_CATCH

There are few WILC_CATCH() uses that still remain. They are not needed and can be removed. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 68 --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 --

[PATCH 07/13] staging: wilc1000: Handle_CfgParam: refactor error handling

Use plain goto instead of WILC_ERRORREPORT Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 42 +++ 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 13/13] staging: wilc1000: wilc_errorsupport: remove unused macros

The macros WILC_IS_ERR, WILC_ERRORCHECK, WILC_ERRORREPORT, WILC_NULLCHECK and WILC_CATCH are not used and may be removed. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/wilc_errorsupport.h | 27 --- 1 file changed, 27 deletions(-)

[PATCH 2/4] Staging: rtl8192u: suspect code indent for conditional statment

From: Mike Dupuis This is a patch to correct an improperly indented block of code in ieee80211_softmac_wx.c Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 3/4] Staging: rtl8192u: do not use C99 // comments

From: Mike Dupuis This is a patch to convert C99-style comments to C89-style comments in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- .../rtl8192u/ieee80211/ieee80211_softmac_wx.c | 28 +++--- 1 file changed, 14

[PATCH 1/4] Staging: rtl8192u: space required before open parentheses

From: Mike Dupuis This is a patch to add spaces where required before open parentheses in ieee80211_softmac_wx.c Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 12 ++-- 1 file changed, 6

[PATCH 0/4] Staging: rtl8192u: fix checkpatch.pl issues

From: Mike Dupuis This is a series of patches to fix several checkpatch.pl issues in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis Checkpatch.pl output before: total: 34 errors, 29 warnings, 605 lines checked Checkpatch.pl output after:

[PATCH 4/4] Staging: rlt8192u: Remove spaces at the start of lines

From: Mike Dupuis This is a patch to remove spaces at the start of lines in ieee80211_softmac_wx.c. Signed-off-by: Mike Dupuis --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac_wx.c | 8 1 file changed, 4 insertions(+), 4

  1   2   >