The cinfo struct has a hole after the last struct member so we need to
zero it out. Otherwise we disclose some uninitialized stack data.
Signed-off-by: Dan Carpenter
---
v2: typo in changelog
diff --git a/drivers/staging/rdma/hfi1/file_ops.c
b/drivers/staging/rdma/hfi1/file_ops.c
index 4698617
On Wed, Sep 16, 2015 at 08:25:00AM +0200, Julia Lawall wrote:
> On Wed, 16 Sep 2015, Dan Carpenter wrote:
>
> > The cinfo struct has a hole after the last struct member so we need to
> > zero it out. Otherwise we don't disclose some uninitialized stack data.
>
> I think the "don't" wasn't intend
On Wed, 16 Sep 2015, Dan Carpenter wrote:
> The cinfo struct has a hole after the last struct member so we need to
> zero it out. Otherwise we don't disclose some uninitialized stack data.
I think the "don't" wasn't intended in the second sentence?
julia
>
> Signed-off-by: Dan Carpenter
>
>
mutex_trylock() returns zero on failure, not EBUSY.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index 654eafe..aa58e59 100644
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers/staging/rdma/hfi1/chip.c
@@ -2710,7 +2710,7 @@ int
__get_txreq() returns an ERR_PTR() but this checks for NULL so it would
oops on failure.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rdma/hfi1/verbs.c
b/drivers/staging/rdma/hfi1/verbs.c
index 53ac214..41bb59e 100644
--- a/drivers/staging/rdma/hfi1/verbs.c
+++ b/drivers/staging/rd
The cinfo struct has a hole after the last struct member so we need to
zero it out. Otherwise we don't disclose some uninitialized stack data.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rdma/hfi1/file_ops.c
b/drivers/staging/rdma/hfi1/file_ops.c
index 4698617..2c43ca5 100644
---
On Tue, Sep 15, 2015 at 08:30:41PM -0400, gr...@linuxhacker.ru wrote:
> From: Oleg Drokin
>
> Since the client can never be server, this is all dead code.
>
> Signed-off-by: Oleg Drokin
> ---
OOPS.. build fails with error:
error: ‘lsi’ undeclared (first use in this function)
reegards
sudip
___
On Tue, Sep 15, 2015 at 08:09:54PM -0300, Marcos Canán wrote:
> This is a patch to the prism2fw.c file that fixes
> too long lines.
>
> Signed-off-by: Marcos Canán
> ---
This will not apply because of cfa6954ced97 ("staging: wlan-ng: fix long line").
Which tree you have used?
regards
sudip
_
On Tue, Sep 15, 2015 at 06:05:29AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
> >
> > Signed-off-by: Mark Hounschell
> > Cc: Greg Kroah-Hartman
> > Cc: Ben Hutchings
> > ---
> > MAINTAINERS | 1 -
> > 1 file changed, 1 deletion(-)
>
>
On Tue, Sep 15, 2015 at 07:57:29PM -0500, Larry Finger wrote:
> On 09/15/2015 11:43 AM, Luca Ceresoli wrote:
> broke a driver, that person's future patches are suspect. We had one
> case a few months ago that was so bad, the person is permanently
> black listed.
which one? The one I am thinking of
On Tue, Sep 15, 2015 at 07:24:00PM +0530, Aparna Karuthodi wrote:
> Removed the curly braces of a single statement if block to remove a
> coding style warning detected by checkpatch.
> The warning is given below:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by:
From: Glen Lee
g_flushing_in_progress is never used so just delete it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/
From: Glen Lee
This patch removes follwing unused defines.
MAX_CFG_PKTLEN
MSG_HEADER_LEN
QUERY_MSG_TYPE
WRITE_MSG_TYPE
RESP_MSG_TYPE
WRITE_RESP_SUCCESS
INVALID
MAC_ADDR_LEN
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 8
1 file cha
From: Glen Lee
The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver.
Delete two defines.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/corec
From: Glen Lee
Variable g_num_total_switches is never used so just remove it.
gastrWIDs is also not used because g_num_total_switches is deleted.
Remove gastrWIDs also.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 127 --
From: Glen Lee
SendRawpacket is declared but not implemented. It is not used also.
So just delete it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.h
This patch removes one of the platform dependencies, PANDA_BOARD from the
driver codes. The device tree will provide the platform dependencies in
the future commits.
Signed-off-by: Tony Cho
Signed-off-by: Glen Lee
---
drivers/staging/wilc1000/linux_wlan.c | 4
drivers/staging/wilc1
From: Glen Lee
wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and
it's related code.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconf
From: Glen Lee
The define PHY_802_11n is useless because wilc1000 support 802.11n as always.
Remove PHY_802_11n and it related code.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/
From: Glen Lee
gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in
the drivers. So just delete the variables and it's related code.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 11 ---
1 file changed, 11 delet
From: Glen Lee
Function NetworkInfoReceived, GnrlAsyncInfoReceived and
host_int_ScanCompleteReceived are declared in the header file already.
Just removes the declaration and comments.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 8
This series of patches are being resent becasue it seems that we are out of
sync with Greg. In this series, I squashed two commits seperately issued for
removing variable, g_num_total_switches which is not used anymore to avoid
more confusions.
Glen Lee (9):
staging: wilc1000: remove useless def
On 2015년 09월 15일 22:46, Greg KH wrote:
On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
From: Glen Lee
g_num_total_switches is never used so just delete it.
Signed-off-by: Gl
Hi Greg,
If it's already in your tree and can be applied alone, no problem to me. I will
later send remaining series of it.
Thanks,
Tony.
On 2015년 09월 15일 22:31, Greg KH wrote:
On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote:
Hi Greg,
I am sorry but please ignore this patch in th
On 09/15/2015 11:43 AM, Luca Ceresoli wrote:
Dear Larry,
Larry Finger wrote:
BTW, if a do a change not related to checkpatch warnings, say I remove
unneeded typecasts, and the change has impact on long lines which are
still long after the change, should I also wrap code to fit 80 chars _in
the
From: Oleg Drokin
These macros are not used anymore, so let's remove them,
also __OBD_VMALLOC_VEROBSE and OBD_CPT_VMALLOC
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/obd_support.h| 29 --
1 file changed, 29 deletions(-)
diff --git a/drivers/staging
From: Oleg Drokin
Part of effort to get rid of custom Lustre allocation macros.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/fld/fld_cache.c
b/drivers/staging/lust
From: Oleg Drokin
This bunch of patches removes significant chunks of
Lustre specific allocators which is possible thanks to prior patches
from Julia Lawall.
Also removed are some server-only bits of code that make no sense
to retain in a client.
Please consider.
Oleg Drokin (19):
staging/lus
From: Oleg Drokin
Since the client can never be server, this is all dead code.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_disk.h| 2 -
drivers/staging/lustre/lustre/mgc/mgc_request.c| 37 ++
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 85 +
From: Oleg Drokin
These could only happen on the server, so they make no sense
on the client.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_disk.h | 3 ---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 7 ---
drivers/staging/lustre/lustre/obdclass/obd_
From: Oleg Drokin
These are converted to regular kzalloc/kfree calls.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lu_object.h
b/drivers/staging/lu
From: Oleg Drokin
Since everything is now supposed to use regular kernel alloc and
free functions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_lib.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
drivers/staging/lustre/lustre/llite/file.c
From: Oleg Drokin
Lustre memory allocation wrappers also included a fault injection
framework that's totally redundant, since in-kernel offering is
actually superior to what we had.
So let's remove it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_support.h | 20 +---
From: Oleg Drokin
Take initial stab at removing server-disk related defines that
client does not need.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_disk.h| 137 -
.../staging/lustre/lustre/obdclass/llog_internal.h | 8 --
2 files changed, 14
From: Oleg Drokin
Lustre memory allocation framework has a feature to track amount
of allocated memory, but since it's not being used consistently anymore
and is on the way out in general, just remove it.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/obd_support.h| 60 +-
From: Oleg Drokin
The remaining users in ll_open_cleanup and obd_mod_alloc
are converted to regular kzalloc/kfree.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 4 ++--
drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +-
2 files changed, 3 insertions(+),
From: Oleg Drokin
Part of effort of getting rid of custom Lustre alloc/free macros
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h
b
From: Oleg Drokin
Now that we no longer track allocated memory, remove
obd_memory statistics counter and all references to it everywhere
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_support.h| 7 ---
drivers/staging/lustre/lustre/obdclass/class_obd.c |
From: Oleg Drokin
This removes now unused OBD_ALLOC, OBD_ALLOC_GFP, OBD_ALLOC_PTR,
OBD_ALLOC_LARGE and supporting infrastructure.
Also OBD_FREE, OBD_FREE_PTR, OBD_FREE_LARGE and supporting infrastructure.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/obd_support.h| 52 --
From: Oleg Drokin
OBD_ALLOC_LARGE is now replaced with libcfs_kvzalloc and
OBD_FREE_LARGE is now replaced with kvfree.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_lib.h | 2 +-
drivers/staging/lustre/lustre/include/obd.h| 8
2 files changed, 5 i
From: Oleg Drokin
Part of getting rid of custom Lustre allocation macros.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/cl_page.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c
b/drivers/staging/lu
From: Oleg Drokin
The UTILS are userland and I see it's causing confusion
with things being already converted to kmalloc,
so just remove it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_support.h | 18 --
1 file changed, 18 deletions(-)
diff --git a
From: Oleg Drokin
Remove OBD_CPT_ALLOC_LARGE define and convert the only user to
libcfs_kvzalloc_cpt.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_support.h | 5 -
drivers/staging/lustre/lustre/ptlrpc/service.c | 6 --
2 files changed, 4 insertions(+),
From: Oleg Drokin
Part of effort of getting rid of custom Lustre allocation macros
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_cfg.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_cfg.h
b/d
From: Oleg Drokin
OBD_CPT_ALLOC and friends are no longer used, so remove them.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd_support.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h
b/drivers/staging/
From: Olaf Hering
The "state" is used by several threads of execution.
Propagate the state to make changes visible. Also propagate context
change in hv_fcopy_onchannelcallback.
Without this change fcopy may hang at random points.
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
---
From: Jake Oshins
This defines the channel type for PCI front-ends in Hyper-V VMs.
Signed-off-by: Jake Oshins
Signed-off-by: K. Y. Srinivasan
---
include/linux/hyperv.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/h
From: Jake Oshins
This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This
is necessary for retargeting an interrupt when it is given a new affinity.
Since we are exporting this API, rename the API as it will be visible outside
the hv.c file.
Signed-off-by: Jake Oshins
S
From: Jake Oshins
This patch exposes the mapping between Linux CPU number and Hyper-V virtual
processor number. This is necessary because the hypervisor needs to know which
virtual processors to target when making a mapping in the Interrupt Redirection
Table in the I/O MMU.
Signed-off-by: Jake
The patch set for supporting PCI Express pass through on Hyper-V has been
posted and
is currently under review. These vmbus patches are needed for the PCI
Express pass through driver. Since these need to go through Greg's tree,
I am posting these separately here.
Jake Oshins (3):
drivers:hv: E
> -Original Message-
> From: Marc Zyngier [mailto:marc.zyng...@arm.com]
> Sent: Tuesday, September 15, 2015 2:57 AM
> To: Jake Oshins ; gre...@linuxfoundation.org; KY
> Srinivasan ; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@
> > ---
> > @@ -91,7 +91,7 @@ static int query_hypervisor_info(void)
> > /*
> > * do_hypercall- Invoke the specified hypercall
> > */
> > -static u64 do_hypercall(u64 control, void *input, void *output)
> > +u64 do_hypercall(u64 control, void *input, void *output)
>
> do_hypercall() is not an
> -Original Message-
> From: ja...@microsoft.com [mailto:ja...@microsoft.com]
> Sent: Thursday, September 10, 2015 5:01 PM
> To: gre...@linuxfoundation.org; KY Srinivasan ; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; vkuzn...@redhat
From: Olaf Hering
The callbacks in kvp, vss and fcopy code are called both from the main thread
as well as from interrupt context. If a state change is done by the main
thread it is not immediately seen by the interrupt. As a result the
state machine gets out of sync.
Force propagation of state
From: Olaf Hering
The "state" is used by several threads of execution.
Propagate the state to make changes visible. Also propagate context
change in kvp_on_msg.
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_kvp.c | 39 +--
1
From: Olaf Hering
The "state" is used by several threads of execution.
Propagate the state to make changes visible. Also propagate context
change in vss_on_msg.
Signed-off-by: Olaf Hering
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/hv_snapshot.c | 37 -
From: Dexuan Cui
This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24:
Drivers: hv: vmbus: Further improve CPU affiliation logic
Without the fix, reloading hv_netvsc hangs the guest.
Signed-off-by: Dexuan Cui
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel_mgmt.c |
The Copy-VMFile cmdlet on the host may fail because the guest fcopy
driver state machine gets out of sync. This happens because the ->state
and ->context variables are accessed by the main thread and from
interrupt context. If an interrupt happens between fcopy_respond_to_host
and hv_poll_channel i
This is a patch to the prism2fw.c file that fixes
too long lines.
Signed-off-by: Marcos Canán
---
drivers/staging/wlan-ng/prism2fw.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan-ng/prism2fw.c
index 940864
The DPAA2 management complex has a versioned binary interface
that has to be kept in sync with the DPAA2 drivers. This patch
uprevs the APIs that build MC commands and parse results.
This uprev is needed to support object interrupts.
MC binary interface changes
-overall version from 6.0 to 8.0
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 46 ++---
1 file changed, 19 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
i
From: Jes Sorensen
This eliminates the ugly Hal_EEValueCheck() function
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 42 ++-
1 file changed, 11 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_ini
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
index 0ae525
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 27 +++--
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
i
From: Jes Sorensen
Hi,
Reading through some of the rate setup code, I was forced to clean up
some of the components to be able to read it properly.
Cheers,
Jes
Jes Sorensen (6):
staging: rtl8723au: Simplify eeprom content checking
staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck()
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 32 +
1 file changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c
i
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
b/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c
index 7fa9780..8764538 100644
--- a/dr
On Tue, Sep 15, 2015 at 06:57:37AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Sep 15, 2015 at 01:07:06PM +0300, Mike Rapoport wrote:
> > if ((pstrNetworkInfo == NULL)
> > || (pstrWFIDrv->strWILC_UsrScanReq.pfUserScanResult ==
> > NULL)) {
> > - WILC_ER
Dear Larry,
Larry Finger wrote:
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
The boolean tests should have been or-ed.
Reported-by: David Binderman
Reviewed-by: Jubin John
Signed-off-by: Mike Marciniszyn
---
drivers/staging/rdma/hfi1/sdma.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi
On Tue, Sep 15, 2015 at 06:46:25AM -0700, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
> >
> >
> > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> > >>From: Glen Lee
> > >>
> > >>g_num_total_switches is
> Subject: [patch] IB/hfi1: fix copy_to/from_user() error handling
>
> copy_to/from_user() returns the number of bytes which we were not able to
> copy. It doesn't return an error code.
>
> Also a couple places had a printk() on error and I removed that because
> people can take advantage of it
On Tue, Sep 15, 2015 at 01:07:06PM +0300, Mike Rapoport wrote:
> In cases where WILC_ERRORREPORT does not require cleanup actions, but
> causes immediate return from the function it can be replaced with return
> statement.
>
> Signed-off-by: Mike Rapoport
> ---
> drivers/staging/wilc1000/corecon
Hello!
On Sep 15, 2015, at 9:26 AM, Trevor Woerner wrote:
> On 09/14/15 18:41, gr...@linuxhacker.ru wrote:
>> Reviewed-on: http://review.whamcloud.com/14605
>
> I'm confused why the patch found in this email doesn't match the patch I
> find when I click on the above link? Some of the patches in
Removed the curly braces of a single statement if block to remove a
coding style warning detected by checkpatch.
The warning is given below:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Aparna Karuthodi
---
drivers/staging/wilc1000/coreconfigurator.c |3 +--
> Subject: [PATCH 11/39] hfi1: drop null test before destroy functions
>
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_de
On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote:
> This patch fixes the warning generated by sparse
> "Using plain integer as NULL pointer" by using NULL
> instead of zero.
>
> Signed-off-by: Ronit halder
> ---
>
> v2: added a new patch in this patch series to fix the NULL compariso
On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote:
>
>
> On 2015년 09월 15일 16:13, Sudip Mukherjee wrote:
> >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote:
> >>From: Glen Lee
> >>
> >>g_num_total_switches is never used so just delete it.
> >>
> >>Signed-off-by: Glen Lee
> >>Sign
On Tue, Sep 15, 2015 at 11:53:36AM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes the definition WILC_NULLCHECK which is not used anymore.
No, it is used, you just remove all usages of it in this patch as well
:)
Also, your fixes are not correct, you are not keeping the same code
On Tue, Sep 15, 2015 at 4:32 PM, Greg Kroah-Hartman
wrote:
> On Mon, Sep 14, 2015 at 10:00:42PM +0300, Mike Rapoport wrote:
>> Hi,
>>
>> These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK,
>> WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error
>> value or sets t
On 09/15/2015 09:05 AM, Greg Kroah-Hartman wrote:
On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
Removes myself from the MAINTAINERS file for the dgap driver.
There appears to be no way to get the firmware files required
by the dgap driver into the linux-firmware tree. The dgap
On Mon, Sep 14, 2015 at 04:28:20PM +0530, Anjali Menon wrote:
> Added a space to fix the following coding style error detected by
> checkpatch.
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> 1 file
On Mon, Sep 14, 2015 at 10:00:42PM +0300, Mike Rapoport wrote:
> Hi,
>
> These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK,
> WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error
> value or sets the error code and uses goto to jump to error handling code.
As S
On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote:
> Hi Greg,
>
> I am sorry but please ignore this patch in this time.
It's already in my tree, right? I can revert it if you want me to, but
I can't ignore it anymore, sorry.
greg k-h
___
devel
On 09/14/15 18:41, gr...@linuxhacker.ru wrote:
> Reviewed-on: http://review.whamcloud.com/14605
I'm confused why the patch found in this email doesn't match the patch I
find when I click on the above link? Some of the patches in this series
match what I find on your jenkins URLs, and some do not.
On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote:
> Removes myself from the MAINTAINERS file for the dgap driver.
> There appears to be no way to get the firmware files required
> by the dgap driver into the linux-firmware tree. The dgap
> driver is useless wihtout this firmware. Thi
Removes myself from the MAINTAINERS file for the dgap driver.
There appears to be no way to get the firmware files required
by the dgap driver into the linux-firmware tree. The dgap
driver is useless wihtout this firmware. This product is
considered an obsolete product by Digi. They will not respon
NULL pointer deference is observed in the wilc1000.ko module
with bus type SPI and when SPI is not ready.
Signed-off-by: Chandra S Gorentla
---
v2 - Subject corrected 'stating:' -> 'staging:'
Following are the steps to reproduce.
$ sudo insmod drivers/staging/wilc1000/wilc1000.ko
$ sudo ifconf
If the size of the firmware is not as expected then we are jumping to the
error path but we missed releasing the firmware.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/
copy_to/from_user() returns the number of bytes which we were not able
to copy. It doesn't return an error code.
Also a couple places had a printk() on error and I removed that because
people can take advantage of it to fill /var/log/messages with spam.
Signed-off-by: Dan Carpenter
---
This pat
Hello Dan.
On 2015년 09월 15일 15:54, Dan Carpenter wrote:
The > should be >= here or we read beyond the end of the array.
You are right. :)
Thanks a lot.
Johnny.
Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/wilc1
In case SendConfigPkt fails, the error handling code performs deletion of
timer, calls Handle_ScanDone and falls through freeing of allocated memory
which is common for both success and error paths. The deletion of timer and
invocation of Handle_ScanDone can be performed in 'then' clause of check o
In cases where WILC_ERRORREPORT does not require cleanup actions, but
causes immediate return from the function it can be replaced with return
statement.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/coreconfigurator.c | 3 +-
drivers/staging/wilc1000/host_interface.c
WILC_NULLPTR can be replaced with test for NULL pointer and return of
WILC_NULL_PTR.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 8 +++
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 26 +++
2 files changed, 16 insertions(+),
Use plain goto instead of WILC_ERRORREPORT
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 42 +++
1 file changed, 20 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_i
The macros WILC_IS_ERR, WILC_ERRORCHECK, WILC_ERRORREPORT,
WILC_NULLCHECK and WILC_CATCH are not used and may be removed.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/wilc_errorsupport.h | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/staging/
The WILC_ERRORCHECK macro is replaced with printout or direct call to
return statement, together with removal of several WILC_CATCH accompaniyng
WILC_ERRORCHECK.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 6 ++
drivers/staging/wilc1000/wilc_msgqueue
Check whether the driver is initialized before getting the semaphore
thus eliminating the need for WILC_ERRORREPORT and WILC_CATCH constructs
and s32Error variable.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 13 +
1 file changed, 5 insertions(+), 8 d
Make memory allocations outside of spin lock, so that ellocation errors
handling will not require unlocking
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c
Use error value assignment and goto instead of WILC_ERRORREPORT and
WILC_CATCH.
Signed-off-by: Mike Rapoport
---
drivers/staging/wilc1000/host_interface.c | 93 +--
1 file changed, 52 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface
1 - 100 of 114 matches
Mail list logo