Hello,
This was previously posted as a RFC[1] to linux-wireless. Following
Larry Finger's suggestion[2] I'm resending it as a proposed patch.
This patch is intended as a debugging aid for people working on the
rtl8188eu driver. I started working on it because debug logs from
rtl8188eu driver go
This adds support for monitoring IEEE 802.11 Data and Management frames
received or transmitted by a RTL8188EU-based device handled by this
driver.
The monitor interface is not enabled by default and will be registered
only if monitor_enable module parameter is set to 1. When enabled it
will show
From: Dmitry Kalinkin
Also changes vme_bus_error_handler to take generic address modifier code
instead of raw contents of a device-specific attribute register.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/vme/bridges/vme_tsi148.c |4 ++-
drivers/vme/vme.c|
From: Dmitry Kalinkin
Error handling code found in tsi148 is not device specific. In fact it
already relies on shared vme_bus_error struct and vme_bridge.vme_errors
field. The other bridge driver could reuse this code if it is shared.
This introduces a slight behavior change: vme error message w
From: Dmitry Kalinkin
The current VME bus error handler adds errors to the bridge error list.
vme_master_{read,write} then traverses that list to look for relevant
errors.
Such scheme didn't work well for accesses going through vme_master_mmap
because they would also allocate a vme_bus_error, bu
From: Dmitry Kalinkin
This moves tsi148 error handling into VME subsystem so it can be shared with
the other bridge driver. Then there is a change to close a fixme on separating
errors by address space. And finally a fix for memory leak problem that was
introduced with support of mmap's.
The
From: Dmitry Kalinkin
This will enable error messages for accesses done through mmap.
Signed-off-by: Dmitry Kalinkin
---
drivers/vme/vme.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 7a10d92..72924b0 100644
--- a/drivers/vme/vme.c
+
Some miscellaneous fixes.
K. Y. Srinivasan (1):
storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag
Vitaly Kuznetsov (2):
scsi_scan: don't dump trace when scsi_prep_async_scan() is called
twice
scsi: introduce short_inquiry flag for broken host adapters
drivers/scsi/scsi_scan.c
Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying
tags. Qlogic driver does not work correctly if the SRB_FLAGS_QUEUE_ACTION_ENABLE
is set and no action tag is specified.
Signed-off-by: K. Y. Srinivasan
Tested-by: Vivek Yadav
Reviewed-by: Long Li
---
drivers/scsi/stor
From: Vitaly Kuznetsov
Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the
SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at
least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan:
INQUIRY result too short (5), using 36' messages on cons
From: Vitaly Kuznetsov
The only user of scsi_prep_async_scan() is scsi_scan_host() and it handles
the situation correctly. Move 'called twice' reporting to debug level as
well.
The issue is observed on Hyper-V: on any device add/remove event storvsc
driver calls scsi_scan_host() and in case prev
I have recently left GE and the email address listed for me in the
maintainers file is no longer valid. Updating email address.
Signed-off-by: Martyn Welch
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7ba7ab7..a77fe5b 100644
2015-09-17 1:18 GMT-04:00 Greg Kroah-Hartman :
> On Thu, Sep 17, 2015 at 01:06:33AM -0400, Raphaël Beamonte wrote:
>> 2015-09-17 0:57 GMT-04:00 Greg Kroah-Hartman :
>>
>> >> @@ -1748,8 +1755,9 @@ static short rtl8192_usb_initendpoints(struct
>> >> net_device *dev)
>> >> oldaddr = pr
On 09/17/2015 11:14 AM, Anjali Menon wrote:
Removed the else statement along with some unwanted brackets
to fix the following coding style warning detected by
checkpatch.
WARNING: else is not generally useful after a break or return
Signed-off-by: Anjali Menon
---
drivers/staging/lustre/lus
slic_link_event_handler() issues command READ_LINK_STATUS to be executed
asynchronously, which is followed by UP configuration write command. But
it can fail while setting up the command and in that case the link will
not be up. Lets check the status and return it.
Signed-off-by: Sudip Mukherjee
If we are not able to setup the LINK UP command then don't increment the
interrupt count.
Signed-off-by: Sudip Mukherjee
---
This is placed at the last as I am not sure if we should be decrement
the count. We got the interrupt but we could not service it properly.
But in any case this count is n
In the ioctl function if we are not able to UP the link after setting
the new parameters then return an error code to the userspace.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/slicoss/slicoss.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/
While initializing the interface if we are not able to setup the command
to UP the link then we release everything and return the error code.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/slicoss/slicoss.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a
Remove unneeded #include's in COMEDI's "drivers.c" and add/change
kernel-doc for exported functions.
1) staging: comedi: drivers.c: remove irrelevant #includes
2) staging: comedi: drivers.c: replace #include
3) staging: comedi: drivers.c: document exported functions
drivers/staging/comedi/drive
Add missing kernel-doc to the low-level COMEDI driver API functions
exported from "drivers.c" and tart up some of the existing kernel-doc
comments for consistency.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers.c | 327 ++-
1 file changed, 258 in
Comedi's "drivers.c" doesn't use anything from ``,
but it does use `DMA_NONE` from ``, so replace
the appropriate `#include` directive.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/driver
Comedi's "drivers.c" doesn't use anything from these included headers,
so remove them.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 387fac1..e3b9
Removed the else statement along with some unwanted brackets
to fix the following coding style warning detected by
checkpatch.
WARNING: else is not generally useful after a break or return
Signed-off-by: Anjali Menon
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 16 +++-
On Thu, Sep 17, 2015 at 06:14:04AM -0700, Greg Kroah-Hartman wrote:
> On Thu, Sep 17, 2015 at 01:48:14PM +0800, Navy Cheng wrote:
> > On Wed, Sep 16, 2015 at 09:52:06PM -0700, Greg Kroah-Hartman wrote:
> > > On Wed, Sep 16, 2015 at 09:06:13PM +0800, Navy Cheng wrote:
> > > > The type of value is u1
On Thu, Sep 17, 2015 at 03:24:37PM +0100, Viacheslav Kovalevskyi wrote:
> Hi there,
>
> Apologies for the complete nuby question, I want to help with porting
> Android LMK (drivers/staging/android/lowmemorykiller.c) from the
> staging to the master. Where I can find more information about the
> cu
Hi there,
Apologies for the complete nuby question, I want to help with porting
Android LMK (drivers/staging/android/lowmemorykiller.c) from the
staging to the master. Where I can find more information about the
current challenges that need to be solved before porting it to the
master?
Or, maybe,
On Thu, Sep 17, 2015 at 01:48:14PM +0800, Navy Cheng wrote:
> On Wed, Sep 16, 2015 at 09:52:06PM -0700, Greg Kroah-Hartman wrote:
> > On Wed, Sep 16, 2015 at 09:06:13PM +0800, Navy Cheng wrote:
> > > The type of value is u16 however the return type of cpu_to_le16() is
> > > __le16. The incorrect ty
On Thu, Sep 17, 2015 at 7:34 PM, Sudip Mukherjee
wrote:
> On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote:
>> This patch replaces int8_t with int. just use return type as int.
>>
>> Signed-off-by: Chaehyun Lim
>> ---
> but isn't int8_t is defined as char?
>
Even int8_t is defined as
On Thu, Sep 17, 2015 at 03:46:38PM +0530, Shraddha Barke wrote:
> Use msecs_to_jiffies instead of driver specific macro
> MSECS.
>
> Signed-off-by: Shraddha Barke
> ---
This will not apply. please rebase on the current staging tree.
regards
sudip
___
d
On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote:
> This patch replaces int8_t with int. just use return type as int.
>
> Signed-off-by: Chaehyun Lim
> ---
but isn't int8_t is defined as char?
regards
sudip
___
devel mailing list
de...@linu
On Thu, Sep 17, 2015 at 04:48:42PM +0900, Chaehyun Lim wrote:
> This patch removes INLINE macro that is used anymore.
used? if used then why are you removing it? :)
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxd
Use msecs_to_jiffies instead of driver specific macro
MSECS.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
b/drivers/staging/rtl8192u/i
Use msecs_to_jiffies instead of driver specific macro
MSECS.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8192u/r8192U_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index cfb07
From: Leo Kim
This patch fix alignment of some defines in wilc_wlan_if.h.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan_if.h | 580
1 file changed, 290 insertions(+), 290 deletions(-)
diff --git a/drivers/staging/wilc10
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl
for line over 80 characters.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan_if.h | 650 ++--
1 file changed, 374 insertions(+), 276 deletions(-)
diff --g
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl
for using multiple blank lines.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan_if.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wla
The previous series of 4 patches include a commit message ambiguous and
not enough to explain why the patch is made and needed. So, this version 2
includes the modification on the commit message of the patch for a null check
fix.
Leo Kim (4):
staging: wilc1000: fix null check routine
staging:
From: Leo Kim
This patch removes the potential faults which may happen when unexpectedly
getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely
to be invalid. However, it is safer to return error when the invalid
memory is unfortunately accessed.
Signed-off-by: Leo Kim
Signed-
On 2015년 09월 17일 18:06, Nicolas Ferre wrote:
Le 17/09/2015 10:50, Tony Cho a écrit :
From: Leo Kim
This patch modify null check routine.
- Null check error non return. (Handle_RcvdGnrlAsyncInfo)
It doesn't parse...
Is it fixing a bug? What were the consequences without the return?
Bye,
Le 17/09/2015 10:50, Tony Cho a écrit :
> From: Leo Kim
>
> This patch modify null check routine.
> - Null check error non return. (Handle_RcvdGnrlAsyncInfo)
It doesn't parse...
Is it fixing a bug? What were the consequences without the return?
Bye,
> Signed-off-by: Leo Kim
> Signed-off-by:
On 16/09/15 21:48, Marcos Canán wrote:
This is a patch to the drivers.c file that fixes
a block comment style.
Signed-off-by: Marcos Canán
---
drivers/staging/comedi/drivers.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/sta
From: Leo Kim
This patch fix alignment of some defines in wilc_wlan_if.h.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan_if.h | 580
1 file changed, 290 insertions(+), 290 deletions(-)
diff --git a/drivers/staging/wilc10
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl
for using multiple blank lines.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan_if.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wla
From: Leo Kim
This patch removes the warnings reported by checkpatch.pl
for line over 80 characters.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan_if.h | 650 ++--
1 file changed, 374 insertions(+), 276 deletions(-)
diff --g
From: Leo Kim
This patch modify null check routine.
- Null check error non return. (Handle_RcvdGnrlAsyncInfo)
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wil
This series of patch is the version 2 for the RX_BH_TYPE patch before sent.
Glen Lee (2):
staging: wilc1000: remove define RX_BH_TYPE
staging: wilc1000: remove do-nothing ifdef statement
drivers/staging/wilc1000/linux_wlan.c | 149 +-
drivers/staging/wilc1000/
From: Glen Lee
This patch removes the preprocessor definition, RX_BH_TYPE and uses the
request_threaded_irq instead of kernel thread to execute the interrupt
handler.
As a result, linux_wlan_enable_irq() and linux_wlan_disable_irq() are also
removed from the linux_wlan.c file.
Signed-off-by: Gl
From: Glen Lee
This patch removes do-nothing ifdef, else statement and add ifdef WILC_SDIO
for disable_sdio_interrupt().
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/dri
This patch removes WILC_TIME typedef that is not used anymore.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/wilc_platform.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_platform.h
b/drivers/staging/wilc1000/wi
This patch removes the declaration of wilc_get_chipid function.
It is included wilc_wlan_if.h that has declaration of wilc_get_chipid.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletion
This patch removes INLINE macro that is used anymore.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/coreconfigurator.c | 1 -
drivers/staging/wilc1000/wilc_wlan.c| 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/c
This patch replaces int8_t with int. just use return type as int.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgo
This patch fixes error check of kzalloc.
If kzalloc is failed, return type is used as -ENOMEM.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/linux_wlan_spi.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a
This patch removes useless comment that is included "BugID_"
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/host_interface.c | 36 ---
drivers/staging/wilc1000/host_interface.h | 4 ---
drivers/staging/wilc1000/li
This patch removes unused defines.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/wilc_platform.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_platform.h
b/drivers/staging/wilc1000/wilc_platform.h
index 1e5697
This patch replaces __inline with inline. plain inline is more
preferred than __inline.
Signed-off-by: Chaehyun Lim
---
V2 : rebase latest staging-testing
drivers/staging/wilc1000/wilc_wlan.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/wilc10
56 matches
Mail list logo
