Зqpaвcтвyйтe! Bac интepecyюm бaзы данныx нoвыx kлиентoв qля Baшeгo Бизнeсa?

2015-09-30 Thread annabragina35
Зqpaвcтвyйтe! Bac интepecyюm бaзы данныx нoвыx kлиентoв qля Baшeгo Бизнeсa? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] staging: comedi: comedi_pci.c: Fix kernel-doc Return tags

2015-09-30 Thread Hartley Sweeten
On Wednesday, September 30, 2015 8:44 AM, Ian Abbott wrote: > Fix the 'Return' tags in the kernel-doc comments as they currently say > 'Returns', which is not recognized by kernel-doc. > > Signed-off-by: Ian Abbott Reviewed-by: H Hartley Sweeten

RE: [PATCH] staging: comedi: comedi_usb.c: improve function documentation

2015-09-30 Thread Hartley Sweeten
On Wednesday, September 30, 2015 9:37 AM, Ian Abbott wrote: > Expand the descriptions of the functions and document the return values. > > Signed-off-by: Ian Abbott Reviewed-by: H Hartley Sweeten ___

RE: [PATCH] staging: comedi: comedi_pcmcia.c: improve function documentation

2015-09-30 Thread Hartley Sweeten
On Wednesday, September 30, 2015 9:11 AM, Ian Abbott wrote: > Expand the descriptions of the functions and document the return values. > > Signed-off-by: Ian Abbott Reviewed-by: H Hartley Sweeten ___

Re: [PATCH 1/1] staging: ion: Fix error handling in ion_buffer_create

2015-09-30 Thread Laura Abbott
On 09/29/2015 10:37 PM, Rohit kumar wrote: This patch fixes error handling case when buffer->pages allocation fails. Also, it removes unreachable code of checking ret variable although it is not updated. Reviewed-by: Laura Abbott Signed-off-by: Rohit kumar

Re: [PATCH 3/3] Staging: rts5208: Coding style warnings fix for block comments

2015-09-30 Thread punit vara
On Tue, Sep 29, 2015 at 5:55 AM, Greg KH wrote: > On Mon, Sep 21, 2015 at 11:29:50PM +0530, Punit Vara wrote: >> This patch is to rtsx_chip.h that fixes up following warning reported >> by checkpatch.pl : >> >> -Block comments use * on subsequent lines >> -Block

Re: [staging:staging-testing 959/962] drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit declaration of function 'memset'

2015-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2015 at 05:13:43PM +0900, Chaehyun Lim wrote: > On Wed, Sep 30, 2015 at 3:01 PM, Greg Kroah-Hartman > wrote: > > On Wed, Sep 30, 2015 at 01:15:51PM +0800, kbuild test robot wrote: > >> tree:

[PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
In dgap_parsefile() char pointers are set with kstrdup() without checking that some string is allocated to that char pointer before. This patch frees the memory if already allocated and then set the poniter with kstrdup(). Signed-off-by: Ronit halder ---

[PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

2015-09-30 Thread Chaehyun Lim
The kbuild test robot reports the following build error for openrisc-allmodconfig. >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit >> declaration of function 'memset' The error occurs due to missing a standard header file as so that three .c files are included it. Signed-off-by:

Re: [staging:staging-testing 959/962] drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit declaration of function 'memset'

2015-09-30 Thread Greg Kroah-Hartman
On Wed, Sep 30, 2015 at 01:15:51PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 7477929566b65f692b79974b784ee59e8b2b9f18 > commit: e215a871255f9256de77e1b9c32b84d3a80122c1 [959/962] staging: wilc1000: >

[PATCH 18/32] staging: wilc1000: remove struct timer_cb

2015-09-30 Thread Tony Cho
This patch removes struct timer_cb which is not used. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 21/32] staging: wilc1000: rename strHostIfSetDrvHandler

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetDrvHandler to drv to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 20/32] staging: wilc1000: rename strHostIfStaInactiveT

2015-09-30 Thread Tony Cho
This patch renames strHostIfStaInactiveT to mac_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 19/32] staging: wilc1000: rename strPowerMgmtparam

2015-09-30 Thread Tony Cho
This patch renames strPowerMgmtparam to pwr_mgmt_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 16/32] staging: wilc1000: rename strDelStaParam

2015-09-30 Thread Tony Cho
This patch renames strDelStaParam to del_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 15/32] staging: wilc1000: rename strAddStaParam

2015-09-30 Thread Tony Cho
This patch renames strAddStaParam to add_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH 29/32] staging: wilc1000: rename strHostIfRegisterFrame

2015-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 06:55:11PM +0900, Tony Cho wrote: > This patch renames strHostIfRegisterFrame to reg_f to avoid CamelCase > naming convention. Could we go with "reg_frame"? f is very ambigous. regards, dan carpenter ___ devel mailing list

[PATCH 22/32] staging: wilc1000: rename strHostIfSetIP

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetIP to ip_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 12/32] staging: wilc1000: remove struct del_beacon

2015-09-30 Thread Tony Cho
This patch removes struct del_beacon which is not necessary. This patch also changes Handle_DelBeacon function by removing 2nd parameter, struct del_beacon because it is not used inside. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 24

[PATCH 17/32] staging: wilc1000: rename strEditStaParam

2015-09-30 Thread Tony Cho
This patch renames strEditStaParam to edit_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 09/32] staging: wilc1000: remove struct get_channel

2015-09-30 Thread Tony Cho
This patch removes struct get_channel from the driver because it is not used anywhere. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 08/32] staging: wilc1000: rename strHostIFCfgParamAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFCfgParamAttr to cfg_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 10/32] staging: wilc1000: rename struct set_channel

2015-09-30 Thread Tony Cho
This patch renames struct set_channel to channel_attr to keep the naming convention such as scan_attr and connect_attr. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 07/32] staging: wilc1000: rename strHostIFkeyAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFkeyAttr to key_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 100 +++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git

[PATCH 13/32] staging: wilc1000: rename struct set_beacon

2015-09-30 Thread Tony Cho
This patch renames struct set_beacon to beacon_attr to keep the naming convention as scan_attr, connect_attr and channel_attr. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 14/32] staging: wilc1000: rename strHostIFSetBeacon

2015-09-30 Thread Tony Cho
This patch renames strHostIFSetBeacon to beacon_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 11/32] staging: wilc1000: rename strHostIFSetChan

2015-09-30 Thread Tony Cho
This patch renames strHostIFSetChan to channel_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 23/32] staging: wilc1000: rename strHostIfSetMulti

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetMulti to multicast_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 25/32] staging: wilc1000: rename strHostIfSetMacAddress

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetMacAddress to set_mac_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 30/32] staging: wilc1000: rename pUserData

2015-09-30 Thread Tony Cho
This patch renames pUserData to data to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 26/32] staging: wilc1000: rename strHostIfGetMacAddress

2015-09-30 Thread Tony Cho
This patch renames strHostIfGetMacAddress to get_mac_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Dan Carpenter
Ugh... No. Just do this: diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 869736a..52d8f95 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c +++ b/drivers/staging/wilc1000/wilc_msgqueue.c @@ -102,6 +102,8 @@ int

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

2015-09-30 Thread Chaehyun Lim
On Wed, Sep 30, 2015 at 7:20 PM, Greg KH wrote: > On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote: >> The kbuild test robot reports the following build error for >> openrisc-allmodconfig. >> >> >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit

[PATCH 05/32] staging: wilc1000: rename strRcvdNetworkInfo

2015-09-30 Thread Tony Cho
This patch renames strRcvdNetworkInfo to net_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 03/32] staging: wilc1000: rename strHostIFscanAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFscanAttr to scan_info in order to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH 06/32] staging: wilc1000: rename strRcvdGnrlAsyncInfo

2015-09-30 Thread Tony Cho
This patch renames strRcvdGnrlAsyncInfo to async_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 31/32] staging: wilc1000: rename strHostIFDelAllSta

2015-09-30 Thread Tony Cho
This patch renames strHostIFDelAllSta to del_all_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 24/32] staging: wilc1000: rename strHostIfSetOperationMode

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetOperationMode to mode to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Tony Cho
From: Leo Kim This patch fix kernel fail after ifconfig wlan0 up. - if normal operation, kfree functions don't execute. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_msgqueue.c | 16 ++--

[PATCH 27/32] staging: wilc1000: rename strHostIfBASessionInfo

2015-09-30 Thread Tony Cho
This patch renames strHostIfBASessionInfo to session_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 29/32] staging: wilc1000: rename strHostIfRegisterFrame

2015-09-30 Thread Tony Cho
This patch renames strHostIfRegisterFrame to reg_f to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 28/32] staging: wilc1000: rename strHostIfRemainOnChan

2015-09-30 Thread Tony Cho
This patch renames strHostIfRemainOnChan to remain_on_ch to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 11:39:45AM +0530, Ronit Halder wrote: > In dgap_parsefile() char pointers are set with kstrdup() > without checking that some string is allocated to that > char pointer before. Why would this happen? Wouldn't it be better to reject the invalid config file? regards, dan

[PATCH 01/32] staging: wilc1000: remove PLL_WORKAROUND

2015-09-30 Thread Tony Cho
This patch removes unnecessary definition, PLL_WORKAROUND from the Makefile. There is no use throughout the driver. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/32] staging: wilc1000: remove AGING_ALG

2015-09-30 Thread Tony Cho
This patch removes AGING_ALG from the Makefile because it is always in use. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 1 - drivers/staging/wilc1000/coreconfigurator.h | 2 -- 2 files changed, 3 deletions(-) diff --git

[PATCH 04/32] staging: wilc1000: rename strHostIFconnectAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFconnectAttr to con_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 32 +++ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

2015-09-30 Thread Greg KH
On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote: > The kbuild test robot reports the following build error for > openrisc-allmodconfig. > > >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit > >> declaration of function 'memset' > > The error occurs due to missing a

[PATCH] staging: rtl8192e: rtl_wx: fix negative noise value

2015-09-30 Thread Luis de Bethencourt
wstats->qual.noise is of type uint8, so it shouldn't be assigned a negative number. Assigning it 0x100 - 100, which is the equivalent to -100 dBm when IW_QUAL_DBM is set. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- 1 file

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Chandra Gorentla
On Tue, Sep 29, 2015 at 05:31:53AM +0300, Dan Carpenter wrote: > On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > > - The message queue is replaced with standard Linux linked list > > - kmem_cache is used for list members > > - A check for return value of receive method is

[PATCH] staging: vt6655: Fixed two lines over 80 characters long

2015-09-30 Thread Arjun Krishna Babu
Two lines of code that were over 80 characters long is fixed by splitting them across multiple lines. The lines of code are now easier to comprehend. Issue found by checkpatch. Signed-off-by: Arjun Krishna Babu --- drivers/staging/vt6655/baseband.c | 14

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 06:12:50PM +0530, Chandra Gorentla wrote: > > > while (1) { > > > - wilc_mq_recv(, , sizeof(struct host_if_msg), > > > ); > > > + ret = wilc_mq_recv(, , > > > + sizeof(struct host_if_msg), ); > > > + if (ret) > > >

RE: [PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Kim, Leo
Dear Dan, Thank you! Always helpful your advice listen carefully. I will send in the morning.  Thanks, BR  Leo -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, September 30, 2015 7:05 PM To: Cho, Tony Cc: gre...@linuxfoundation.org;

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Chandra Gorentla
On Tue, Sep 29, 2015 at 02:44:02AM +0200, Greg KH wrote: > On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > > - The message queue is replaced with standard Linux linked list > > - kmem_cache is used for list members > > Why? The list entires are of fixed type and repeatedly

[PATCH 20/32] staging/lustre/ldlm: Remove unused ldlm_pool_set_slv()

2015-09-30 Thread green
From: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 1 - drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 13 - 2 files changed, 14 deletions(-) diff --git

[PATCH 19/32] staging/lustre/ldlm: Remove unused ldlm_pool_get_clv()

2015-09-30 Thread green
From: Oleg Drokin Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 1 - drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 16 2 files changed, 17 deletions(-) diff --git

[PATCH 14/32] staging/lustre/ldlm: Remove unused ldlm_enqueue_pack()

2015-09-30 Thread green
From: Oleg Drokin Not used anywhere Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 1 - drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 21 - 2 files changed, 22 deletions(-) diff --git

[PATCH 05/32] staging/lustre/lov: Remove unused lov_dump_lmm/pool()

2015-09-30 Thread green
From: Oleg Drokin These generic switch functions appear to be unused as all the individual ones are called directly. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_internal.h | 2 --

[PATCH 11/32] staging/lustre/ldlm: Get rid of lr_converting queue

2015-09-30 Thread green
From: Oleg Drokin Now that we removed all the lock conversion functions, also get rid of the converson queue since nothing could ever get there anyway. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 --

[PATCH 13/32] staging/lustre/ldlm: Remove unused ldlm_init/fini_flock_export

2015-09-30 Thread green
From: Oleg Drokin And all supporting export infrastructure. There's no use for it all on client. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c| 102 -

[PATCH 03/32] staging/lustre: Remove ununused ll_ra_read_get()

2015-09-30 Thread green
From: Oleg Drokin Also ll_ra_read_get_locked that was only used by it. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/llite/llite_internal.h | 1 - drivers/staging/lustre/lustre/llite/rw.c | 24 -- 2 files

[PATCH 21/32] staging/lustre/ldlm: Remove ldlm_refresh/del_waiting_lock()

2015-09-30 Thread green
From: Oleg Drokin Nothing adds locks into waiting list on the client, so no point in retaining those. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 8

[PATCH 02/32] staging/lustre: KEY_DEFAULT/MAX_COOKIESIZE key is unused, remove them

2015-09-30 Thread green
From: Oleg Drokin Also remove the lmv and mdc infrastructure to query these keys. In fact this whole "unlink cookies" thing becomes irrelevant with newer servers, but since we still retain 2.[123] servers commpatibility, we cannot completely remove all traces of it yet.

[PATCH 01/32] staging/lustre/llite: Remove unused ll_get_default/max_cookiesize()

2015-09-30 Thread green
From: Oleg Drokin This was used for a function that's no longer important, but is no longer used anywhere. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/llite/llite_internal.h | 2 -- drivers/staging/lustre/lustre/llite/llite_lib.c

[PATCH 10/32] staging/lustre/ldlm: Remove unimplemented lock conversion traces.

2015-09-30 Thread green
From: Oleg Drokin Lock conversion is not really implemented, so let's stop pretending here. This removes ldlm_lock_convert, ldlm_cli_lock_convert and ldlm_lock_downgrade. Signed-off-by: Oleg Drokin ---

[PATCH 08/32] staging/lustre/ldlm: Remove unused ldlm_cancel_locks_for_exports()

2015-09-30 Thread green
From: Oleg Drokin This is only used on the server in case a client gets disconnected. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 2 - drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 50

[PATCH 07/32] staging/lustre/ldlm: Remove unused interval tree bits

2015-09-30 Thread green
From: Oleg Drokin On client side interval-tree code operations are pretty basic, so get rid of the code that is only used on the server to figure out how much to extend the locks and such. Signed-off-by: Oleg Drokin ---

[PATCH 09/32] staging/lustre/ldlm: Remove ldlm_init/destroy_export()

2015-09-30 Thread green
From: Oleg Drokin These functions are used on the server-only, so get rid of them. Also get rid of ldlm export hash operations and the struct. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 -

[PATCH 04/32] staging/lustre/llite: Remove unused ll_rmdir_entry()

2015-09-30 Thread green
From: Oleg Drokin The ioctl for this function was removed, but the function was forgotten, so kill it now. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/llite/llite_internal.h | 1 - drivers/staging/lustre/lustre/llite/namei.c|

[PATCH 06/32] staging/lustre/lov: Remove unused lov_lsm_decref()

2015-09-30 Thread green
From: Oleg Drokin Also lov_lsm_addref is only used in the file it is defined, so make it static Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_cl_internal.h | 3 --- drivers/staging/lustre/lustre/lov/lov_object.c | 13

[PATCH 00/32] Lustre (mostly locking) unused code removal

2015-09-30 Thread green
From: Oleg Drokin This continues the quest for killing unused code in the Lustre client. Main focus in this set is on Lustre LDLM code - it kills both outright unused code and code that looks like it's used, but in fact also unused as various conditions that would lead to

[PATCH 31/32] staging/lustre/ldlm: Remove posix lock (flock) deadlock detection

2015-09-30 Thread green
From: Oleg Drokin This is server-side code that cannot work on the client (vfs would do this check on the local node). Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 132 1 file changed, 132

[PATCH 26/32] staging/lustre: Remove ns_is_client()

2015-09-30 Thread green
From: Oleg Drokin Since staging tree code is just the client, ns_is_client is always true, so change all callers as such and drop all the dead code for when it's false. Signed-off-by: Oleg Drokin ---

[PATCH 29/32] staging/lustre/ldlm: Remove unused exported symbols.

2015-09-30 Thread green
From: Oleg Drokin This rather large patch prunes all unused EXPORT_SYMBOLS and marks functions only used locally as static lustre ldlm module. The only two remaining nonstatic functions that should be static now are: ldlm_cancel_lru_local ldlm_resource_putref_locked But

[PATCH 12/32] staging/lustre/ldlm: Remove unused ldlm_cli_enqueue_local()

2015-09-30 Thread green
From: Oleg Drokin This is only used on the server. Also while we are at it, remove unused prototypes for ldlm_server_ast and ldlm_handle_enqueue0() that are not defined anywhere Signed-off-by: Oleg Drokin ---

[PATCH 24/32] staging/lustre/ldlm: Remove unused ldlm_resource_insert_lock_after()

2015-09-30 Thread green
From: Oleg Drokin It was only used on the server. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 26 -- 2 files changed, 28

[PATCH 15/32] staging/lustre/ldlm: Remove ldlm_errno2error()

2015-09-30 Thread green
From: Oleg Drokin This particular incarnation is only used on the server. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 3 +- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 36 -- 2

[PATCH 17/32] staging/lustre/ldlm: Remove ldlm_lock_fail_match()

2015-09-30 Thread green
From: Oleg Drokin It's not used anywhere. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 1 - drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 8 2 files changed, 9 deletions(-) diff --git

[PATCH 23/32] staging/lustre/ldlm: Remove unused ldlm_reprocess_all*()

2015-09-30 Thread green
From: Oleg Drokin They are only used on the server. Also remove helper functions and cleanup callsites. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 - drivers/staging/lustre/lustre/ldlm/ldlm_flock.c| 1

[PATCH 27/32] staging/lustre: Remove ns_is_server()

2015-09-30 Thread green
From: Oleg Drokin Since the code we have is Lustre-client only, this function always returns 0, so drop it and amend all the callsites to drop dead code. One of the places also sets LDLM_FL_NS_SRV to indicate a lock is in a server namespace. This too cannot happen in this

[PATCH 28/32] staging/lustre/ldlm: Remove server side code from pool support.

2015-09-30 Thread green
From: Oleg Drokin Server-side scanning is not really used in the client code, so it's ok to drop it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 3 - drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 348

[PATCH 30/32] staging/lustre/ldlm: Remove ldlm_namespace_inactive_list()

2015-09-30 Thread green
From: Oleg Drokin Since there are no server namespaces, just replace it with ldlm_cli_inactive_namespace_list pointer. Also make ldlm_cli_inactive_namespace_list static as it's only used in ldlm_resource.c Signed-off-by: Oleg Drokin ---

[PATCH 16/32] staging/lustre/ldlm: Remove ldlm_glimpse_ast()

2015-09-30 Thread green
From: Oleg Drokin Only used on the server. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 1 - drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 28 -- 2 files changed, 29 deletions(-)

[PATCH 25/32] staging/lustre/ldlm: Remove unused ldlm_blocking_ast/_nocheck()

2015-09-30 Thread green
From: Oleg Drokin All users are gone, and they were used on the server anyway. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 3 - drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 70 --

[PATCH 32/32] staging/lustre/ldlm: Make ldlm_add_ast_work_item() static

2015-09-30 Thread green
From: Oleg Drokin Now that ldlm_flock code no longer uses it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 2 -- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 5 +++-- 2 files changed, 3 insertions(+), 4

[PATCH 22/32] staging/lustre/ldlm: Remove intent policies handler.

2015-09-30 Thread green
From: Oleg Drokin This includes ldlm_register_intent(), ns_policy field in the namespace and all of it's users, as this could only happen on the server. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 8 --

[PATCH 18/32] staging/lustre/ldlm: Remove ldlm_namespace_free()

2015-09-30 Thread green
From: Oleg Drokin It was directly used only on the server. Client side part was split into smaller chunks to avoid deadlocks. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 --

Re: [PATCH] staging: dgap: fix memory leak in dgap_parsefile()

2015-09-30 Thread Ronit Halder
The existing dgap_parsefile() rejects invalid config file. But before we know that config file is invalid a lot of memory leak can happen. Removing the chances of memory leak won't heart anyone. regards, Ronit Halder ___ devel mailing list

RE: [PATCH 1/1] staging: ion: Fix error handling in ion_buffer_create

2015-09-30 Thread PINTU KUMAR
> -Original Message- > From: Laura Abbott [mailto:labb...@redhat.com] > Sent: Wednesday, September 30, 2015 11:42 PM > To: Rohit kumar; gre...@linuxfoundation.org; a...@android.com; > riandr...@android.com; dan.carpen...@oracle.com; > sumit.sem...@linaro.org; mitch...@codeaurora.org;

[PATCH] staging: comedi: comedi_usb.c: improve function documentation

2015-09-30 Thread Ian Abbott
Expand the descriptions of the functions and document the return values. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_usb.c | 75 + 1 file changed, 52 insertions(+), 23 deletions(-) diff --git

[PATCH v2] staging/wlan-ng: Fix potential buffer overflow in firmware handling

2015-09-30 Thread Tillmann Heidsieck
This patch fixes a potential buffer overflow detected by smatch. pda16 has length 512, while processing an element with index < 512 we are checking for an end marker in the next element. This poses a potential buffer overflow if no end marker is present. Signed-off-by: Tillmann Heidsieck

[PATCH] staging: comedi: comedi_pcmcia.c: improve function documentation

2015-09-30 Thread Ian Abbott
Expand the descriptions of the functions and document the return values. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_pcmcia.c | 104 - 1 file changed, 76 insertions(+), 28 deletions(-) diff --git

[PATCH] staging: rtl8188eu: Add missing include

2015-09-30 Thread Larry Finger
In commit 0a0796eb16f3, there is no include to mon.h, a newly created header file. This omission leads to the following Sparse warnings: CHECK drivers/staging/rtl8188eu/os_dep/mon.c drivers/staging/rtl8188eu/os_dep/mon.c:81:6: warning: symbol 'rtl88eu_mon_recv_hook' was not declared. Should

[PATCH] staging: comedi: comedi_pci.c: Fix kernel-doc Return tags

2015-09-30 Thread Ian Abbott
Fix the 'Return' tags in the kernel-doc comments as they currently say 'Returns', which is not recognized by kernel-doc. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_pci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git