The getChipClock function is used only to get MXCLK frequency, which
makes most of getPllValue function unused and thus. The detection of
MXCLK frequency may be implemented directly in getChipClock rendering
getPllValue and calcPLL unused.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb
The getChipClock is used to detect MXCLK frequency. Make it's name
reflect what the function is actually doing.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.c
Hi,
The pacthes in this serie refactor detection of MXCLK frequency.
v2:
- rebased on current staging-testing
Mike Rapoport (3):
staging: sm750fb: merge calcPLL and getPllValue into getChipClock
staging: sm750fb: rename getChipClock to get_mxclk_freq
staging: sm750fb: remove some unnecessa
The clock divisor calculations in setMasterClock and setMemoryClock
unnecessaryly cast unsigned int to unsigned int. Removing the casting.
Signed-off-by: Mike Rapoport
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagin
On Tue, Oct 13, 2015 at 11:40:00AM +0800, Greg KH wrote:
- ashmem_area_cachep = kmem_cache_create("ashmem_area_cache",
- sizeof(struct ashmem_area),
- 0, 0, NULL);
+ ashmem_area_cachep =
+ km
On Mon, Oct 12, 2015 at 08:30:41PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Oct 09, 2015 at 12:32:32PM +0530, Sudip Mukherjee wrote:
> > On Thu, Oct 08, 2015 at 09:11:07PM +0100, Mike Rapoport wrote:
> > > Hi Sudip,
> > >
> > > On Thu, Oct 08, 2015 at 11:46:28AM +0530, Sudip Mukherjee wrote:
> >
On Tue, Oct 13, 2015 at 11:32:31AM +0800, Liao Tonglang wrote:
> Cleanup for checkpatch.pl warn below:
> CHECK: Alignment should match open parenthesis
> #836: FILE: drivers/staging/android/ashmem.c:836:
> by split three lines to four.
>
> Signed-off-by: Liao Tonglang
> ---
> drivers
On Tue, Oct 06, 2015 at 05:46:22PM +0100, Ian Abbott wrote:
> On 05/10/15 23:33, H Hartley Sweeten wrote:
> >Cleanup this driver a bit and add support for the 8254 counter/timer.
> >
> >v2: Fix patch 11/14, Ian Abbott pointed out that the odd munging
> > of the encoder data does make sense. Add
On Sat, Oct 10, 2015 at 03:41:54PM +0300, Stanislav Kholmanskikh wrote:
> The config option in the subject may be removed, because,
> indeed, it only serves as the 'n' value for
> CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER
>
> Signed-off-by: Stanislav Kholmanskikh
> ---
> drivers/staging/wilc
On Mon, Oct 12, 2015 at 03:19:47PM -0400, Benjamin Romer wrote:
> From: David Kershner
>
> Convert from pragma to __packed
>
> Signed-off-by: David Kershner
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorbus/vmcallinterface.h | 4 +---
> 1 file changed, 1 insertion(+), 3
On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote:
> Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E
> and it transformed to pretty get_channel_group(const u8 channel).
>
> Also removed code for 5 GHz frequency in Hal_ReadPowerValueFromPROM_8188E.
Why did you do t
On Sat, Oct 10, 2015 at 01:27:00PM +0700, Ivan Safonov wrote:
> Correct channels range is 1..14 (numbering from 1) but not 0..13.
Why? Have you tested this?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mail
On Sat, Oct 10, 2015 at 01:28:34PM +0700, Ivan Safonov wrote:
> This patch replace BITn macro to BIT(n).
Why? Have you deleted the BITn macros?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo
On Tue, Oct 13, 2015 at 12:19:12AM +0530, punit vara wrote:
> On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara wrote:
> > This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> > warning reported by checkpatch.pl :
> >
> > -Prefer ether_addr_equal() or ether_addr_equal_unaligned() o
On Sun, Oct 04, 2015 at 06:55:57PM -0400, Raphaël Beamonte wrote:
> Add some temporary variables to reduce line length under the maximum
> of 80 characters, as per the kernel code style.
>
> Signed-off-by: Raphaël Beamonte
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 130
> +
On Tue, Oct 06, 2015 at 09:42:15AM +0100, Mike Rapoport wrote:
> The getChipClock function is used only to get MXCLK frequency, which
> makes most of getPllValue function unused and thus. The detection of
> MXCLK frequency may be implemented directly in getChipClock rendering
> getPllValue and calc
On Fri, Oct 09, 2015 at 12:32:32PM +0530, Sudip Mukherjee wrote:
> On Thu, Oct 08, 2015 at 09:11:07PM +0100, Mike Rapoport wrote:
> > Hi Sudip,
> >
> > On Thu, Oct 08, 2015 at 11:46:28AM +0530, Sudip Mukherjee wrote:
> > > On Tue, Oct 06, 2015 at 04:49:13PM +0100, Mike Rapoport wrote:
> > > > Curr
Use the BIT(x) macro directly instead using multiple
BITX defines.
Signed-off-by: Anish Bhatt
---
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 10 +-
drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 49 ++--
drivers/staging/rtl8192u/r8192U.h| 95 +--
dr
Cleanup for checkpatch.pl warn below:
CHECK: Alignment should match open parenthesis
#836: FILE: drivers/staging/android/ashmem.c:836:
by split three lines to four.
Signed-off-by: Liao Tonglang
---
drivers/staging/android/ashmem.c | 7 ---
1 file changed, 4 insertions(+), 3 d
On Fri, Oct 02, 2015 at 07:53:25AM +0200, Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/randomizati
For aesthetics, move this comment to follow the format of the other
subdevices.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/dri
The hardware has an 8254 counter/timer to provide a pacer clock using
counters 1 and 2. Counter 0 is available to the user.
Hook up the subdevice support to allow the user to use counter 0.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drive
For aesthetics, rename these private data members to match the registers
they are associated with.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 64 ++--
1 file changed, 32 insertions(+), 32 del
The PC-CARD DAS16/16-AO board only has 4 digital I/O channels. The other
boards supported by this driver have 8. Add the boardinfo to correctly
initialize the subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 6
This driver currently code not support async commands. Remove the
SDF_CMD_READ subdev_flag and len_chanlist initialization from the
subdevice init.
For aesthetics, rename the (*insn_read) function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/come
For aesthetics, add _REG to all the register map offsets and convert
the values to hex.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 45 +++-
1 file changed, 25 insertions(+), 20 deletions(-)
The ai mux register is used program the hi/lo channels in a scan.
According to the user manual, the hi and lo channels should be
the same to sample one channel.
Introduce some macros to set the appropriate bits in the ai mux
register and fix the ai (*insn_read).
Signed-off-by: H Hartley Sweeten
Define the bits in these registers and use them to remove the "magic"
values in the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 96 +---
1 file changed, 74 insertions(+), 22 deletions(
Only one of the boards supported by this driver has analog outputs.
For aesthetics, change the 'n_ao_chans' member of the boardinfo into
a bit-field flag 'has_ao'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 10 -
Fix the checkpatch.pl issues in this driver and tidy it up a bit.
H Hartley Sweeten (10):
staging: comedi: cb_das16_cs: tidy up multi-line comments
staging: comedi: cb_das16_cs: rename register map defines
staging: comedi: cb_das16_cs: fix ai mux register programming
staging: comedi: cb_da
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 61 ++--
1 file changed, 31 insertions(+), 30 deletions(-)
diff --git a/drivers/staging
From: Tim Sell
Prevent faults that would occur during this sequence of activity during
network stress:
rmmod visornic
modprobe visornic
/etc/init.d/network restart
The problem fixed was that the back-end IO partition was holding onto
stale receive buffers after the "rmmod visornic",
According to the user manual, analog input bipolar data is 2's
complement and unipolar is straight binry. Use the core helpers
to munge the data appropriately.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 16 +
For aesthetics, move and reword the comment to follow the format of
the other subdevices.
Signed-off-by: H Hartley Sweeten
CC: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/
For aesthetics, move the comedi_lrange definition used in this driver
to the follow the norm in comedi drivers and rename the variable.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 22 +++---
1 file ch
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 61 +---
1 file changed, 28 insertions(+), 33 deletions(-)
diff --git a/drivers/staging
From: David Kershner
Need to convert from #pragma to __packed for channel structures.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/channel.h | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/inclu
From: David Kershner
Cleanup the checkpatch.pl check alignment should match open parenthesis, in
visor_periodic_work_create().
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/periodic_work.h | 11 ++-
1 file changed, 6 insertions(+), 5 de
This driver supports three board types with these differences:
104-AIO12-8 - eight 12-bit analog in, four 12-bit analog out
104-AI12-8 - eight 12-bit analog in
104-AO12-4 - four 12-bit analog out
Convert the boardinfo 'ai_nchan' and 'ao_nchan' into bit-field
flags 'has_ai' and 'has_ao' so
This board name is incorrect. The proper name is 104-AO12-4.
Change the boardinfo name to 'aio_aio12_4' to follow the format of
the other boardtypes.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 4 ++--
1 file change
The analog outputs are all single-ended. Remove the SDF_DIFF
subdev_flag from the subdevice initialization.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This patch series fixes incorrect pragma statements, cleans up some
formatting problems, and removes disused fields from header files.
David Kershner (9):
staging: unisys: channel.h covert from pragma to __packed
staging: unisys: channel.h Fix spacing around operands.
staging: unisys: visorc
From: David Kershner
Clean up the seven checks reported by checkpatch.pl --strict.
CHECK: spaces preferred around that '<<' (ctx:VxV)
+#define SIGNATURE_16(A, B) ((A) | (B<<8))
^
CHECK: spaces preferred around that '+' (ctx:VxV)
+#define COVERQ(v, d) (((v)+(d)
From: David Kershner
Clean up the following checkpatch.pl --strict checks:
CHECK: No space is necessary after a cast
+ buf = (u8 *) __get_free_page(GFP_KERNEL);
CHECK: No space is necessary after a cast
+ free_page((unsigned long) buf);
CHECK: spaces preferred around that '+' (ctx:
Fix the checkpatch.pl issues in this driver and tidy it up a bit.
H Hartley Sweeten (10):
staging: comedi: aio_aio12_8: prefer using the BIT macro
staging: comedi: aio_aio12_8: tidy up multi-line comments
staging: comedi: aio_aio12_8: update MODULE_DESCRIPTION
staging: comedi: aio_aio12_8:
This board has an industry-standard 8254 chip with the gate, clock,
and output pins for each counter available on the connector.
Hookup the 8254 counter as a comedi subdevice.
Provice an (*insn_config) for the user to query the clock source
for each channel.
Signed-off-by: H Hartley Sweeten
Cc:
As suggested by checkpatch.pl, use the BIT macro to define the
register bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 40 +++-
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
From: David Kershner
Convert from pragma to __packed
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/vmcallinterface.h
b/dr
From: David Kershner
Cleanup the multiple blank lines check in periodic_work.h.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/periodic_work.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/periodic_work.h
b/d
From: David Kershner
Some more churn of the drivers have made more fields unused, get
rid of them.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/diagchannel.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/unisys/includ
From: David Kershner
Fix the checkpatch.pl -strict check:
CHECK: Unnecessary parentheses around sig_hdr.num_overflows
+ &(sig_hdr.num_overflows),
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/visorchannel.c |
From: David Kershner
With the simplified driver models we have more vmcalls that aren't
supported by linux guests.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 46 ---
1 file changed, 46 deletions(-)
d
On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara wrote:
> This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> warning reported by checkpatch.pl :
>
> -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
>
> bssid and pnetwork->network.MacAddress both are 6 byt
On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring wrote:
> On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott
> wrote:
[...]
>> +Example:
>> +
>> + ion {
>> + compatbile = "linux,ion";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> +
This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
bssid and pnetwork->network.MacAddress both are 6 byte
array which aligned with u16
Signed-off-by: Punit Vara
---
Rename the CamelCase and use the BIT macro to define the bits.
Also, rename the associated CamelCase members of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 78 ++--
1 file ch
Rename thie CamelCase member of the private data. Add a comment in
the interrupt handler to clarify why the channel interval is updated
again.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 9 +
1 file changed,
The PCI-1720 board is supported by this driver but uses a different
register map. For aesthetics, rename the defines to match the
PCI171X_* format.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 41 ++---
Rename these CamelCase defines.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 93 ++--
1 file changed, 47 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.
Reformat the multi-line comments in the kernel CodingStyle. And
refactor them to follow the normal format for comedi drivers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 53 ++--
1 file change
Rename the CamelCase and use the BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 32 +---
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/stag
Fix the checkpaatch.pl issues in this driver.
v2: reword the comments in patch 6 to clarify the 'ai_et_MuxVal'.
H Hartley Sweeten (6):
staging: comedi: adv_pci1710: tidy up multi-line comments
staging: comedi: adv_pci1710: tidy up status register and bits
staging: comedi: adv_pci1710: tidy
Use a local variable for the 'devpriv->ai_bounce_buffer' to shorten
the lines in pci9111_handle_fifo_half_full() and gix the checkpath.pl
issue about:
CHECK: Alignment should match open parenthesis
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/come
Rename the CamelCase parameters of plx9050_interrupt_control().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/comedi/dr
For aesthetics, define a macro to set the analog input range bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/dr
Reformat the multi-line comments in the kernel CodingStyle.
Remove the unnecessary CHANGELOG information, git provided this
better.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 104 ---
1 file
As suggested by checkpatch.pl, use the BIT macro to define the
register bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git
Fix the checkpatch.pl issues in this driver.
v2: split the ai range macro out of patch 1 as requested by Ian Abbott.
H Hartley Sweeten (5):
staging: comedi: adl_pci9111: prefer using the BIT macro
staging: comedi: adl_pci9111: define a macro for the ai range bits
staging: comedi: adl_pci911
On Mon, Oct 12, 2015 at 05:22:29PM +, Hartley Sweeten wrote:
> On Monday, October 12, 2015 10:03 AM, Ian Abbott wrote:
> > Fix some checkpatch issues in "comedidev.h". There are still some
> > CamelCase warnings, but since those are for the use of "mA" and it
> > represents "milliamps", I thin
On Monday, October 12, 2015 10:03 AM, Ian Abbott wrote:
> Fix some checkpatch issues in "comedidev.h". There are still some
> CamelCase warnings, but since those are for the use of "mA" and it
> represents "milliamps", I think I'll leave them alone.
>
> 1) staging: comedi: comedidev.h: add comment
On Monday, October 12, 2015 9:21 AM, Ian Abbott wrote:
> Tidy up the "read" file operation handler, `comedi_read()` a bit and
> improve the error handling and the "end-of-file" handling.
>
> There are some other changes I want to make, such as switching to the
> newer wait API (prepare_to_wait()/fi
Fix the checkpatch.pl issues:
CHECK: spinlock_t definition without comment
CHECK: struct mutes definition withoug comment
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
Fix the checkpatch.pl issues:
CHECK: spaces preferred around that '*' (ctx:VxV)
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedidev.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedide
Fix some checkpatch issues in "comedidev.h". There are still some
CamelCase warnings, but since those are for the use of "mA" and it
represents "milliamps", I think I'll leave them alone.
1) staging: comedi: comedidev.h: add comments to spin-lock and mutex
2) staging: comedi: comedidev.h: spaces
`comedi_read()` is the handler for the "read" file operation for COMEDI
devices. It mostly runs without using the main mutex of the COMEDI
device, but uses the `attach_lock` rwsemaphore to protect against the
COMEDI device becoming "detached". A file object can read data
resulting from a COMEDI a
If an asynchronous "read" command is no longer running but the subdevice
is still busy, it becomes non-busy once there is no more data available
in the buffer. Some or all of the data written to the buffer might not
have been "munged" yet, and it cannot be read until it has been munged
by the writ
In order to perform a "read" file operation, an asynchronous COMEDI
command in the "read" direction needs to have been set up by the current
file object on the COMEDI "read" subdevice associated with the file
object. If there is a "read" subdevice, but a command has not been set
up by the file obj
The "read" file operation handler, `comedi_read()` returns an error for
pretty much any condition that prevents a "read" going ahead. One of
the conditions that prevents a "read" going ahead is that no
asynchronous command has been set up, but that currently results in a
return value of 0 (unless
If the "read" file operation handler, `comedi_read()` is passed 0 for
the amount to read, some error conditions are currently skipped and the
function just returns 0. Change it to check those error conditions and
return an error value if appropriate. The trickiest case is the check
for when the p
`comedi_read()` copies data from the acquisition data buffer, which is
cyclic, to the user buffer using a single call to `copy_to_user()`. It
currently avoids having to deal with wraparound of the cyclic buffer by
limiting the amount it copies (and the amount returned to the user).
Change it to de
At one point in `comedi_read()`, the variable `n` gets assigned to the
minimum of the parameter `nbytes` and the amount of readable buffer
space `m`. The way that is done currently is unsafe in the unlikely
case that `nbytes` exceeds `UINT_MAX`, so fix it.
Signed-off-by: Ian Abbott
---
drivers/
`comedi_read()` initializes `retval` to 0. The other `retval = 0`
assignments are superfluous, so remove them.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_fops.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/
In `comedi_read()`, the `n` and `m` variables are of type `int`. Change
them to `unsigned int` as they are used to measure a positive number of
bytes. The `count` variable is also of type `int` and holds the
returned number of bytes. Change it to type `ssize_t` to match the
function's return typ
If a COMEDI subdevice is busy handling an asynchronous command in the
"read" direction, then after the command has terminated itself, the
"read" file operation handler, `comedi_read()` should keep the subdevice
busy until all available data has been read and it has returned 0 to
indicate an "end-of
Tidy up the "read" file operation handler, `comedi_read()` a bit and
improve the error handling and the "end-of-file" handling.
There are some other changes I want to make, such as switching to the
newer wait API (prepare_to_wait()/finish_wait()) and preventing several
tasks trying to read or writ
Em Mon, 12 Oct 2015 18:35:05 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote:
> > Em Mon, 12 Oct 2015 00:07:52 +0300
> > Sakari Ailus escreveu:
> >
> > > Hi Mauro,
> > >
> > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Ca
Em Mon, 12 Oct 2015 18:38:23 +0300
Sakari Ailus escreveu:
> If the function of an entity is not one of the pre-defined ones, it is not
> correctly recognised as a V4L2 sub-device.
>
> Signed-off-by: Sakari Ailus
> ---
> include/media/media-entity.h | 1 +
> 1 file changed, 1 insertion(+)
>
>
If the function of an entity is not one of the pre-defined ones, it is not
correctly recognised as a V4L2 sub-device.
Signed-off-by: Sakari Ailus
---
include/media/media-entity.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index
Hi Mauro,
On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 12 Oct 2015 00:07:52 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Carvalho Chehab wrote:
> > > Instead of relying on media subtype, use the new ma
On Sun, 2015-10-11 at 16:42 +0530, punit vara wrote:
> following are the two structure need to be consider for alignment.
>
> struct iw_pmksa {
> __u32 cmd; /* 0 4 */
> struct sockaddrbssid;/* 416 */
> __u8
Link status poll function is already controlled by open/stop functions,
so we don't need to do it on init.
This eliminates a redundant xaui link status notification when the module
is loaded.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-xaui.c | 4
1 file changed, 4 del
Use common init.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-xaui.c | 7 ---
drivers/staging/octeon/ethernet.c| 2 +-
drivers/staging/octeon/octeon-ethernet.h | 1 -
3 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-x
On Mon, Oct 12, 2015 at 01:35:54PM +0200, Tillmann Heidsieck wrote:
>
> I must have rediscovered a problem I already fixed :-(
Which tree are you using? You should be using staging-testing branch of
the staging tree.
regards
sudip
___
devel mailing lis
Oh sorry for the noise ... I officially suck and will try to better
myself.
I must have rediscovered a problem I already fixed :-(
Again sorry for the noise
Tillmann
On Mon, Oct 12, 2015 at 04:32:17PM +0530, Sudip Mukherjee wrote:
> On Sat, Oct 10, 2015 at 09:56:16PM +0200, Tillmann Heidsieck w
On Mon, Oct 12, 2015 at 09:48:27AM +0800, Binbin Zhou wrote:
> The PM_EVENT_RESUME state is needed when SM750 resume, otherwise it
> will be failed in the second time of continuous suspend/resume.
>
> Cc: Sudip Mukherjee
> Signed-off-by: Binbin Zhou
> Reviewed-by: Huacai Chen
> Reviewed-by: Ted
On Sat, Oct 10, 2015 at 09:56:16PM +0200, Tillmann Heidsieck wrote:
> This patch fixes a potential buffer overflow detected by smatch.
>
> pda16 has length 512, while processing an element with index < 512 we
> are checking for an end marker in the next element. This poses a
> potential buffer ove
This patch renames strHostIFwpaAttr of union host_if_key_attr to wpa to
avoid CamelCase naming convention.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 95 ++-
1 file changed, 44 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/w
This patch renames strHostIFpmkidAttr of union host_if_key_attr to
pmkid to avoid CamelCase naming convention.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/wilc1000/hos
This patch renames tenuAuth_type of struct host_if_wep_attr to auth_type
to avoid CamelCase naming convention.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/host_interface.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
1 - 100 of 138 matches
Mail list logo
