It's a minor issue, but the code would be a little clearer if it were made
explicit that the function always succeeds.
julia
On Wed, 14 Oct 2015, kbuild test robot wrote:
> CC: kbuild-...@01.org
> CC: de...@driverdev.osuosl.org
> TO: Oleg Drokin
> CC: "Greg Kroah-Hartman"
>
> tree: https:/
From: Leo Kim
This patch removes goto ERRORHANDER and the result variable in wilc_mq_send.
Then, the error type is directly returned. If normal operation, freeing memory
is not needed in this function.
If an error occurs, returns an error after releasing the spin lock.
Signed-off-by: Leo Kim
Si
On 2015년 10월 13일 23:08, Mike Rapoport wrote:
On Tue, Oct 13, 2015 at 08:02:12PM +0900, Tony Cho wrote:
From: Leo Kim
This patch removes goto ERRORHANDER and the result variable in wilc_mq_send.
Then, the error type is directly returned. If normal operation, freeing memory
is not needed in th
Change the MODULE_DESCRIPTION to something more useful than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
The comedi core expects (*insn_write) functions to write insn->n
data values to the hardware. Fix this function to work like the
core expects.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 11 +++
1 file changed,
The comedi core expects (*insn_write) functions to write insn->n
data values to the hardware. Fix this function to work like the
core expects.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 11 +++
1 file changed,
The analog output and analog input interrupts are currently cleared
as they are handled. Refactor the code to gather all the bits needed
to clear the interrupts and do it once at the end of the interrupt
handler.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
driver
The ao (*cancel) function does not need commented.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c
b/drivers/staging/comedi/drive
This inline function just returns the bits needd to enable
a calibration source. For aethetics, absorb it into the callers.
Sorten the variable name in the private data used to hold the
current calibration source.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drive
Clarify the interrupt handler by splitting the analog input handling
into a new function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 80 ++
1 file changed, 47 insertions(+), 33 deletions(-)
Rename this function so it has namespace associated with the
driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_
For aesthetics, add some whitespace to the subdevice initialization
and rename the subdevice functions to follow the normal form in
comedi drivers.
Async command support uses interrupts. For clarity, make sure the
driver has an IRQ before initializing command support.
Signed-off-by: H Hartley Swe
For aesthetics, add some whitespace to the subdevice initialization
and rename the (*insn_write) functions to follow the normal form
in comedi drivers.
It's not possible to actually read the analog outpus. For convienence
the subdevice readback provided by the core is used to return the
last value
For aesthetics, rename this member of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas
For aesthetics, rename this member of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 35 +++---
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/com
The comedi core expects (*insn_read) operations to return insn->n
data values. Refactor this function to work like the core expects.
For aesthetics, nvram_read() and use the comedi_timeout() helper
to handle the busy wait for the eeprom to be "ready".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abb
For aesthetics, add some whitespace to the initialization of this
subdevice.
Rename the (*insn_read) function so it has namespace associated with
the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 19 ++--
For aesthetics, add some whitespace to the subdevice init.
It's not possible to actually read from the caldac. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.
Signed-off-by:
Rename this function so it has namespace associated with the driver.
Also rename the 'value' parameter to avoid having to split the line
to keep it under 80 chars.
Remove the unnecessary masking on the 'value'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers
For aesthetics, add some whitespace to the subdevice init.
It's not possible to actually read from the dac08. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.
Signed-off-by: H
Only the pci-das1602/16 boards have an AD8402 trimpot. The rest of
the boards supported by this driver have an AD7376 trimpot.
Replace the 'enum trimpot_module' in the boardinfo with a bit-field
flag 'has_ad8402' to save a bit of space.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg K
All the boards supported by this driver have an AD7376 or AD8402
trimpot. Replace the switch () with and if () and remove the
unreachable dev_err() noise.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 10 ++
1 fi
These functions are all just wrappers for cb_pcidas_calib_write().
Remove them and absorb the code into the callers.
Remove the unnecessary masking of the 'chan'. It will always be in
range due to the subdevice initialization.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartm
Refactor this function to handle the common code used to select the
calibration device (trimpot or caldac) and latch the data after
sending the bitstream.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 90
Rename this function so it has namespace associated with the driver.
For aesthetics, remove the 'static const' local variables. They don't
add any significant value.
Remove the 'bitstream' local variable. Change the type of the 'value'
param to match the callers type and write_calibration_bitstre
Rename this function so it has namespace associated with the driver.
Change the return type to void, it always returns '0' and the return
value is never checked.
For aesthetics, remove the 'static const' local variables. They don't
add any significant value.
Remove the 'bitstream' local variable.
Rename this function so it has namespace associated with the driver.
Change the return type to void, it always returns '0' and the return
value is never checked.
For aesthetics, remove the 'static const' local variables. They don't
add any significant value.
Remove the 'bitstream' local variable.
For aesthetics, add some whitespace to the subdevice init.
It's not possible to actually read from the trimpot. For convienence
the subdevice readback provided by the core is used to return the
last value written to the subdevice. Remove the SDF_READABLE flag
from the subdev_flags.
Move the comme
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/com
Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.
For aesthetics, rename the associated member of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi
Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 56 +++---
1 file ch
Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 38 --
1 file ch
Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 56 --
1 file ch
Rename this register and its bit defines so they have namespace
associated with the driver. Use the BIT macro to define the bits.
For aesthetics, rename the associated member of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi
Rename the defines for the PCI BAR2 register offsets so they have
namespace associated with the driver and convert the offsets to
hex.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 18 +-
1 file changed,
For aesthetics, convert the inline functions that return the bits
used to set the DAC range and enable bits to macros.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 26 --
1 file changed, 8 insert
Rename the defines for the PCI BAR3 register offsets so they have
namespace associated with the driver and convert the offsets to
hex.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 16 +---
1 file changed, 9
Instead of relying on the IS_UNIPOLAR mask value, use the comedi
helper function to check if the range is unipolar.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(
Convert the inline function DAC_DATA_REG() into a simple macro.
Rename the defines for the PCI BAR4 register offsets so they have
namespace associated with the driver and convert the offsets to
hex.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
This member of the private data holds the PCI BAR4 resource starting
address. For aesthetics, rename this member to 'pcibar4'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 20
1 file changed, 12 ins
This member of the private data holds the PCI BAR2 resource starting
address. For aesthetics, rename this member to 'pcibar2'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 20 +++-
1 file changed, 11 ins
This member of the private data holds the PCI BAR1 resource starting
address. For aesthetics, rename this member to 'pcibar1'.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 82 +++---
1 file chang
All the boards supported by this driver have 16 analog input channels.
Remove this unnecessary information from the boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 13 ++---
1 file changed, 2 insertions(
All the boards, except the 'pci-das1001', use the normal analog input
range table 'cb_pcidas_ranges'. Convert the 'ranges' boardinfo into
a bit-field flag 'use_alt_range' to save a bit of space.
For aesthetics, reword the comments in the boardinfo for the bit-field
members so they align.
Signed-o
Only some of the boards supported by this driver have analog outputs
but they always have 2 channels. Refactor the 'ao_nchan' member of
the boardinfo into a bit-field flag 'has_ao' to save a bit of space.
Also, convert the 'has_ao_fifo' member into a bit-field flag.
Signed-off-by: H Hartley Sweete
The boards supported by this driver either have 16-bit or 12-bit
analog input/output resolution. For aesthetics, replace the 'ai_bits'
member of the boardinfo with a bit-field flag 'is_16bit'. Also,
change the types of the other bit-field flags to unsigned int.
Signed-off-by: H Hartley Sweeten
Cc
These defines don't add any additional clarity to the driver. Just
remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging
Following is the big cleanup of the comedi cb_pcidas driver.
H Hartley Sweeten (45):
staging: comedi: cb_pcidas: tidy up multi-line comments
staging: comedi: cb_pcidas: remove NUM_CHANNELS_* defines
staging: comedi: cb_pcidas: refactor 'ai_bits' boardinfo
staging: comedi: cb_pcidas: refact
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 115 ++---
1 file changed, 57 insertions(+), 58 deletions(-)
diff --git a/drivers/staging
Hi Aya,
[auto build test WARNING on staging/staging-next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Aya-Mahfouz/staging-lustre-remove-uses-and-definition-of-container_of0/20151014-062751
config: arm6
Hi Aya,
[auto build test WARNING on staging/staging-next -- if it's inappropriate base,
please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Aya-Mahfouz/staging-lustre-remove-uses-and-definition-of-container_of0/20151014-062751
config: blac
Check that resource is not NULL before de-referencing it.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/staging/fsl-mc/bus/mc-allocator.c
index a45293b..88d1857 100644
--- a/dri
Changed these two fields from 32-bit integers to 16-bit integers in
struct fsl_mc_io, as 32 bits is too much for these fields. This
change does not affect other components since fsl_mc_io is an opaque
type.
---
drivers/staging/fsl-mc/include/mc-sys.h | 4 ++--
1 file changed, 2 insertions(+), 2 de
Each fsl_mc_io object is associated with an fsl_mc_device object
of type "dpmcp" representing the MC portal associated with the
fsl_mc_io object. Before, we were representing this association with
an fsl_mc_resource pointer. To enhance code clarity, it is more
straight forward to use an fsl_mc_devi
owner needs to be initialized as THIS_MOUDLE.
---
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/drivers/staging/fsl-mc/bus/mc-bus.c
index 4ac3d07..84db55b 100644
--- a/drivers/staging/fsl-mc/bus/mc-bus.c
+++ b/drivers
Changed dev_info() calls to dev_dbg() in
fsl_mc_allocator_probe/fsl_mc_allocator_remove, as they
are useful only for debugging.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/dri
When initializing the object attributes for the root dprc, the
irq_count was uninitialized. Initialize it to 1.
---
drivers/staging/fsl-mc/bus/mc-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c
b/drivers/staging/fsl-mc/bus/mc-bus.c
index fd13053..4ac3
Call fsl_mc_resource_pool_remove_device() only if mc_dev->resource
is not NULL.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/staging/fsl-mc/bus/mc-allocator.c
index 527
Replaced error gotos with direct returns in fsl_mc_allocator_probe()
and fsl_mc_allocator_remove(), since the only error handling done
in those functions is to exit.
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 23 +--
1 file changed, 9 inse
The macros were a left-over from a previous implementation
of the dpmcp APIs and are no longer used.
---
drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 79 --
1 file changed, 79 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpmcp-cmd.h
b/drivers/staging/fsl-mc/bu
Whitespace cleanup-- add missing spaces in column 1 of copyright
---
drivers/staging/fsl-mc/include/dpcon-cmd.h | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/fsl-mc/include/dpcon-cmd.h
b/drivers/staging/fsl-mc/include/dpcon-cm
Before, we were opening and closing a mc_io's dpmcp object
in fsl_mc_portal_reset(), since that was the only function that was
calling dpmcp MC operations. However, it is better for maintainability
to open the dpmcp object when it gets associated with an mc_io object,
and close it when this associa
This patch series includes the following code cleanup and
bug fixes for the fsl-mc bus driver:
Patch 1: Naming cleanup in fsl_mc-portal_allocate
Patch 2: fsl_mc_io object refactoring
Patch 3: dpmcp opening/closing refactoring
Patch 4: Changed dev_info() calls to dev_dbg()
Patch 5: Changed types of
mc_adev is a local variable for the allocated dpmcp object.
Renamed mc_adev as dpmcp_dev for clarity.
---
drivers/staging/fsl-mc/bus/mc-allocator.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/mc-allocator.c
b/drivers/staging/fsl-mc
On 2015/10/13, 16:19, "Aya Mahfouz" wrote:
>container_of0 can be replaced by the Linux kernel macro container_of.
>The only difference is that container_of0 tries to evade type casting
>when the pointer is erroneous or null. All uses of container_of0 have
>been replaced by container_of and then t
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya Mahfou
All uses of container_of0 have been replaced by container_of.
container_of0 and __container_of can be safely removed.
Signed-off-by: Aya Mahfouz
---
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/lustre/include
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya Mahfou
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya Mahfou
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya Mahfou
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Signed-off-by: Aya Mahfou
Replaces container_of0 by container_of. The only difference between
the two implementations is that container_of0 tries to evade
type casting if the pointer is erroneous or null. The use of
container_of is encouraged to bring lustre one step closer to
community standards.
Cc: jes.soren...@gmail.co
container_of0 can be replaced by the Linux kernel macro container_of.
The only difference is that container_of0 tries to evade type casting
when the pointer is erroneous or null. All uses of container_of0 have
been replaced by container_of and then the macro was removed in the last
patch.
Aya Mahf
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Tuesday, October 13, 2015 2:47 AM
> To: KY Srinivasan
> Cc: Vitaly Kuznetsov ; gre...@linuxfoundation.org;
> linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> a...@canonical.com; jasow...@redhat.com
> Su
In a recent change, we made a bool into a tristate in:
"drivers/staging: make android tegra_ion.c properly tristate", since it
was self evident that was the original intention. However on the final
link phase we'll see an allmodconfig fail with:
ERROR: "ion_device_add_heap" [drivers/staging/andro
[[staging:staging-testing 1385/1471] ERROR: "ion_device_add_heap" undefined!]
On 13/10/2015 (Tue 20:14) kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-testing
> head: fa7ac9c0fc5418154a6356583f880164cdcaa7f1
> commit: 35890c28eec
The Backup integration service on WS2012 has appearently trouble to
negotiate with a guest which does not support the provided util version.
Currently the VSS driver supports only version 5/0. A WS2012 offers only
version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an
empty icframe
On Tue, Oct 13, 2015 at 11:22:18AM +0200, Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/randomizati
October 13, 2015 1:34 PM
> To: Stephen Rothwell; linux-next; linux-kernel; Romer, Benjamin M;
> Kershner, David A; Greg Kroah-Hartman; *S-Par-Maintainer; devel
> Subject: randconfig build error with next-20151013, in
> drivers/staging/unisys/visorinput
>
> Building with the
Building with the attached random configuration file,
ERROR: "input_free_device"
[drivers/staging/unisys/visorinput/visorinput.ko] undefined!
ERROR: "input_set_capability"
[drivers/staging/unisys/visorinput/visorinput.ko] undefined!
ERROR: "input_set_abs_params"
[drivers/staging/unisys/visorinput/
On 10/13/2015 10:40 PM, Greg Kroah-Hartman wrote:
On Tue, Oct 13, 2015 at 10:00:41PM +0700, Ivan Safonov wrote:
On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote:
On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote:
Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E
On Tue, Oct 13, 2015 at 10:00:41PM +0700, Ivan Safonov wrote:
> On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote:
> >On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote:
> >>Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E
> >>and it transformed to pretty get_channel_g
From: David Kershner
Convert from pragma to __packed
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
v2: remove comments about pragma as well
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drive
On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote:
On Sat, Oct 10, 2015 at 01:27:00PM +0700, Ivan Safonov wrote:
Correct channels range is 1..14 (numbering from 1) but not 0..13.
Have you tested this?
I have not tested it.
Why?
From condition
if (chnl <= 14) {
bIn24G = true;
On 10/12/2015 11:51 PM, Greg KH wrote:
On Mon, Oct 12, 2015 at 03:19:47PM -0400, Benjamin Romer wrote:
From: David Kershner
Convert from pragma to __packed
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 4 +---
1 file c
On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote:
On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote:
Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E
and it transformed to pretty get_channel_group(const u8 channel).
Also removed code for 5 GHz frequency in Hal_Re
On Tue, Oct 13, 2015 at 08:02:12PM +0900, Tony Cho wrote:
> From: Leo Kim
>
> This patch removes goto ERRORHANDER and the result variable in wilc_mq_send.
> Then, the error type is directly returned. If normal operation, freeing memory
> is not needed in this function.
>
> Signed-off-by: Leo Kim
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: fa7ac9c0fc5418154a6356583f880164cdcaa7f1
commit: 35890c28eec9535d910380b598712bd4b6d7717d [1385/1471] drivers/staging:
make android tegra_ion.c properly tristate
config: arm-allmodconfig (attached a
Fixes checkpatch.pl WARNING:LINE_SPACING: Missing a blank line after
declarations.
The patch is generated using checkpatch.pl --fix-inplace:
for f in $(find drivers/staging/lustre/ -type f) ; do
./scripts/checkpatch.pl --types "LINE_SPACING" --test-only=Missing \
--fix-inplace -f $f
done
Hi,
These patches add/remove blank lines to fix several types of LINE_SPACING
warnings reported by the checkpatch.pl
Mike Rapoport (3):
staging: lustre: add missing blank line after declarations
staging: lustre: remove multiple blank lines
staging: lustre: add a blank line after function/st
Fixes checkpatch.pl CHECK:LINE_SPACING: Please don't use multiple blank
lines.
The patch is generated using checkpatch.pl --fix-inplace:
for f in $(find drivers/staging/lustre/ -type f) ; do
./scripts/checkpatch.pl --types "LINE_SPACING" --test-only=multiple \
--fix-inplace -f $f
done
S
Fixes checkpatch.pl CHECK:LINE_SPACING: Please use a blank line after
function/struct/union/enum declarations
The patch is generated using checkpatch.pl --fix-inplace:
for f in $(find drivers/staging/lustre/ -type f) ; do
./scripts/checkpatch.pl --types "LINE_SPACING" --fix-inplace -f $f
done
On 13/10/15 00:07, H Hartley Sweeten wrote:
Fix the checkpatch.pl issues in this driver and tidy it up a bit.
H Hartley Sweeten (10):
staging: comedi: cb_das16_cs: tidy up multi-line comments
staging: comedi: cb_das16_cs: rename register map defines
staging: comedi: cb_das16_cs: fix ai
On Mon, Oct 12, 2015 at 05:11:08PM +0530, Sudip Mukherjee wrote:
> On Mon, Oct 12, 2015 at 01:35:54PM +0200, Tillmann Heidsieck wrote:
> >
> > I must have rediscovered a problem I already fixed :-(
>
> Which tree are you using? You should be using staging-testing branch of
> the staging tree.
Th
On 12/10/15 20:16, H Hartley Sweeten wrote:
Fix the checkpatch.pl issues in this driver and tidy it up a bit.
H Hartley Sweeten (10):
staging: comedi: aio_aio12_8: prefer using the BIT macro
staging: comedi: aio_aio12_8: tidy up multi-line comments
staging: comedi: aio_aio12_8: update M
On 12/10/15 19:01, H Hartley Sweeten wrote:
Fix the checkpaatch.pl issues in this driver.
v2: reword the comments in patch 6 to clarify the 'ai_et_MuxVal'.
H Hartley Sweeten (6):
staging: comedi: adv_pci1710: tidy up multi-line comments
staging: comedi: adv_pci1710: tidy up status registe
On 12/10/15 18:42, H Hartley Sweeten wrote:
Fix the checkpatch.pl issues in this driver.
v2: split the ai range macro out of patch 1 as requested by Ian Abbott.
H Hartley Sweeten (5):
staging: comedi: adl_pci9111: prefer using the BIT macro
staging: comedi: adl_pci9111: define a macro for
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: fa7ac9c0fc5418154a6356583f880164cdcaa7f1
commit: 35890c28eec9535d910380b598712bd4b6d7717d [1385/1471] drivers/staging:
make android tegra_ion.c properly tristate
config: arm64-allmodconfig (attached
Hi,
Is drivers/staging/lustre/TODO file updated?
-thanks-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Leo Kim
This patch removes goto ERRORHANDER and the result variable in wilc_mq_send.
Then, the error type is directly returned. If normal operation, freeing memory
is not needed in this function.
Signed-off-by: Leo Kim
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_msgqueue.c
1 - 100 of 158 matches
Mail list logo
