[PATCH V2 37/40] staging: wilc1000: move variable FALSE_FRMWR_CHANNEL

2015-10-15 Thread Tony Cho
From: Leo Kim This patch move variable 'FALSE_FRMWR_CHANNEL' to local define position. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/

[PATCH V2 39/40] staging: wilc1000: fixes alignment should match open parenthesis

2015-10-15 Thread Tony Cho
From: Leo Kim This patch fixes the checks reported by checkpatch.pl for alignment should match open parenthesis. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 155 +++--- 1 file changed, 79 insertions(+), 76 deletions(-)

[PATCH V2 35/40] staging: wilc1000: rename variable s32Error

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable s32Error to result to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 784 ++ 1 file changed, 371 insertions(+), 413 deletions(-) diff --git

[PATCH V2 38/40] staging: wilc1000: fixes unnecessary variable replacement

2015-10-15 Thread Tony Cho
From: Leo Kim This patch removes an unnecessary variable use for the errors and returns errors directly without a result variable. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 28 +--- 1 file changed, 9 insertions(+), 1

[PATCH V2 36/40] staging: wilc1000: move variable clients_count

2015-10-15 Thread Tony Cho
From: Leo Kim This patch move static variable clients_count to local variable position. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH V2 40/40] staging: wilc1000: fixes comparison to NULL could be written

2015-10-15 Thread Tony Cho
From: Leo Kim This patch fixes the checks reported by checkpatch.pl for comparison to NULL could be written. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 220 ++ 1 file changed, 106 insertions(+), 114 deletions(-)

[PATCH V2 34/40] staging: wilc1000: rename variable gu8FlushedJoinReqDrvHandler

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8FlushedJoinReqDrvHandler to join_req_drv to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:270:20: sparse: symbol 'join_req_drv' was not declared. Shou

[PATCH V2 25/40] staging: wilc1000: rename variable gu32InactiveTime

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu32InactiveTime to inactive_time to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/s

[PATCH V2 31/40] staging: wilc1000: rename variable gu8FlushedAuthType

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8FlushedAuthType to auth_type to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:267:4: sparse: symbol 'auth_type' was not declared. Should it be static?

[PATCH V2 29/40] staging: wilc1000: rename variable gu8FlushedInfoElemAsoc

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8FlushedInfoElemAsoc to info_element to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:268:5: sparse: symbol 'info_element' was not declared. Should it be

[PATCH V2 30/40] staging: wilc1000: rename variable gu8Flushed11iMode

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8Flushed11iMode to mode_11i to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:266:4: sparse: symbol 'mode_11i' was not declared. Should it be static? S

[PATCH V2 33/40] staging: wilc1000: rename variable gu32FlushedInfoElemAsocSize

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu32FlushedInfoElemAsocSize to info_element_size to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:269:5: sparse: symbol 'info_element_size' was not decla

[PATCH V2 24/40] staging: wilc1000: rename variable gs8GetIP

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gs8GetIP to get_ip to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/

[PATCH V2 32/40] staging: wilc1000: rename variable gu32FlushedJoinReqSize

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu32FlushedJoinReqSize to join_req_size to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:268:5: sparse: symbol 'join_req_size' was not declared. Should i

[PATCH V2 26/40] staging: wilc1000: rename variable gu8DelBcn

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8DelBcn to del_beacon to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH V2 27/40] staging: wilc1000: remove unused variable gu32WidConnRstHack

2015-10-15 Thread Tony Cho
From: Leo Kim This patch removes unused the variable gu32WidConnRstHack. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host

[PATCH V2 28/40] staging: wilc1000: rename variable gu8FlushedJoinReq

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8FlushedJoinReq to join_req to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:264:4: sparse: symbol 'join_req' was not declared. Should it be static? S

[PATCH V2 21/40] staging: wilc1000: rename variable gs8lnkspd

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gs8lnkspd to link_speed. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/s

[PATCH V2 23/40] staging: wilc1000: rename variable gs8SetIP

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gs8SetIP to set_ip to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/

[PATCH V2 22/40] staging: wilc1000: rename variable gu8Chnl

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gu8Chnl to ch_no to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host

[PATCH V2 20/40] staging: wilc1000: rename variable gs8Rssi

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gs8Rssi to rssi to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/hos

[PATCH V2 19/40] staging: wilc1000: rename variable gbScanWhileConnected

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gbScanWhileConnected to scan_while_connected to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:254:6: sparse: symbol 'scan_while_connected' was not declar

[PATCH V2 15/40] staging: wilc1000: rename variable hWaitResponse

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable hWaitResponse to hif_sema_wait_response to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(

[PATCH v2 18/40] staging: wilc1000: rename variable gapu8RcvdAssocResp

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gapu8RcvdAssocResp to rcv_assoc_resp to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH V2 17/40] staging: wilc1000: rename variable g_hPeriodicRSSI

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable g_hPeriodicRSSI to periodic_rssi to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:248:19: sparse: symbol 'periodic_rssi' was not declared. Should it be s

[PATCH V2 16/40] staging: wilc1000: rename variable hSemHostIntDeinit

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable hSemHostIntDeinit to hif_sema_deinit to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:247:18: sparse: symbol 'hif_sema_deinit' was not declared. Should i

[PATCH V2 14/40] staging: wilc1000: rename variable hSemDeinitDrvHandle

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable hSemDeinitDrvHandle to hif_sema_driver to avoid CamelCase naming convention. Add to static because follow warning reported by kbuild system. - drivers/staging/wilc1000/host_interface.c:245:18: sparse: symbol 'hif_sema_driver' was not declared. Should

[PATCH V2 13/40] staging: wilc1000: rename variable hSemHostIFthrdEnd

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable hSemHostIFthrdEnd to hif_sema_thread to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH V2 10/40] staging: wilc1000: remove unused variable gWFiDrvHandle

2015-10-15 Thread Tony Cho
From: Leo Kim This patch removes unused the variable gWFiDrvHandle. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interf

[PATCH V2 12/40] staging: wilc1000: rename variable gMsgQHostIF

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable gMsgQHostIF to hif_msg_q to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 109 +++--- 1 file changed, 53 insertions(+), 56 deletions(-) diff -

[PATCH V2 11/40] staging: wilc1000: rename variable HostIFthreadHandler

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames variable HostIFthreadHandler to hif_thread_handler to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a

[PATCH V2 08/40] staging: wilc1000: rename au8Interval of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames au8Interval of struct join_bss_param to interval to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH V2 07/40] staging: wilc1000: rename au8Duration of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames au8Duration of struct join_bss_param to duration to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH V2 06/40] staging: wilc1000: rename u8Index of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames u8Index of struct join_bss_param to idx to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH V2 09/40] staging: wilc1000: rename au8StartTime of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames au8StartTime of struct join_bss_param to start_time to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH V2 04/40] staging: wilc1000: rename u8CtWindow of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames u8CtWindow of struct join_bss_param to ct_window to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH V2 05/40] staging: wilc1000: rename u8Count of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames u8Count of struct join_bss_param to cnt to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH V2 02/40] staging: wilc1000: rename u8NoaEnbaled of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames u8NoaEnbaled of struct join_bss_param to noa_enabled to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

[PATCH V2 01/40] staging: wilc1000: rename ssidLen of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames ssidLen of struct join_bss_param to ssid_len to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stag

[PATCH V2 03/40] staging: wilc1000: rename u8OppEnable of struct join_bss_param

2015-10-15 Thread Tony Cho
From: Leo Kim This patch renames u8OppEnable of struct join_bss_param to opp_enabled to avoid CamelCase naming convention. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --

Re: [PATCH 02/10] staging: most: fix usage of false data type

2015-10-15 Thread Christian Gromm
On Thu, 15 Oct 2015 15:47:39 +0300 Dan Carpenter wrote: > On Thu, Oct 15, 2015 at 01:28:52PM +0200, Christian Gromm wrote: > > This patch changes the data type from u32 to u16 used for temporary > > variable. It is needed to stay in the correct range and get rid of > > the unnecessary cast. > >

[PATCH] Staging: lustre: obd_support.h: Remove unused OBD_SLAB_FREE_RTN0

2015-10-15 Thread Shraddha Barke
Remove macro OBD_SLAB_FREE_RTN0 since it is defined but not used Signed-off-by: Shraddha Barke --- drivers/staging/lustre/lustre/include/obd_support.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_support.h b/drivers/staging/lustre/lustre/inc

Re: lustre: TODO updated?

2015-10-15 Thread Drokin, Oleg
Hello! On Oct 13, 2015, at 8:12 AM, Xose Vazquez Perez wrote: > Is drivers/staging/lustre/TODO file updated? Yes, it's still accurate from 10.000 ft view. If you need some more detailed ideas, here's my current list of stuff: getting rid of remaining lustre allocation macros: OBD_SLAB_ALLOC/F

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-15 Thread Dan Carpenter
Oh. I use a script to check these... It doesn't break anything except for that commented out code which should be deleted anyway. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailma

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-15 Thread David Daney
On 10/15/2015 06:40 AM, Dan Carpenter wrote: On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote: and make sure you don't break the driver. I'm not seeing how this patch breaks anything? What am I missing? Did you apply it and then compile the result? If not, then how can you asse

Re: [PATCH] staging: rtl8192u: simplify conditional statement

2015-10-15 Thread kbuild test robot
Hi Luis, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Luis-de-Bethencourt/staging-rtl8192u-simplify-conditional-statement/20151015-203425 config:

[PATCH v2] staging: netlogic: xlr_net.h: fixed coding style warnings

2015-10-15 Thread Sakshi Bansal
Fixed block comments usage of * on subsequent lines Signed-off-by: Sakshi Bansal --- Changes in v2: - Made the commit message more clearer drivers/staging/netlogic/xlr_net.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/netlogic/xlr_net.h b/drivers/sta

Re: [PATCH] staging: octeon: fixed few coding style warnings

2015-10-15 Thread Dan Carpenter
On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote: > and make sure you don't break the driver. I'm not seeing how this patch breaks anything? What am I missing? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http:

Re: [PATCH 40/40] staging: wilc1000: fixes comparison to NULL could be written

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 01:25:21PM +0900, Tony Cho wrote: > @@ -2306,7 +2303,8 @@ static void Handle_AddBeacon(struct host_if_drv > *hif_drv, > strWID.type = WID_BIN; > strWID.size = pstrSetBeaconParam->head_len + > pstrSetBeaconParam->tail_len + 16; > strWID.val = kmalloc(strWI

Re: [PATCH] staging: rtl8192u: simplify conditional statement

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 01:33:14PM +0100, Luis de Bethencourt wrote: > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index c443e2e..1c2d1a4 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++

Re: [PATCH 02/10] staging: most: fix usage of false data type

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 01:28:52PM +0200, Christian Gromm wrote: > This patch changes the data type from u32 to u16 used for temporary > variable. It is needed to stay in the correct range and get rid of > the unnecessary cast. > > Signed-off-by: Christian Gromm > --- > drivers/staging/most/hdm-

[PATCH] staging: rtl8192u: simplify conditional statement

2015-10-15 Thread Luis de Bethencourt
The code can be much cleaner and readable by simplifying the conditional statement. Only need to check if (ieee->state > IEEE80211_LINKED) and not >= because (ieee->state == IEEE80211_LINKED) is already checked a few lines above. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/i

[PATCH] staging: vt6655: Remove boolean comparisons

2015-10-15 Thread Luis de Bethencourt
Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/vt6655/card.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index f842be6..5159270 10

Re: [PATCH] drivers:staging:gdm72xx: Fix coding style issues

2015-10-15 Thread Mike Rapoport
On Wed, Oct 14, 2015 at 09:40:37PM +0300, Janis Gengeris wrote: > Fixes coding style warnings as reported by checkpatch.pl. Please be more elaborate and describe what warning was fixed > Signed-off-by: Janis Gengeris > --- > drivers/staging/gdm72xx/gdm_wimax.c | 4 ++-- > 1 file changed, 2 ins

Re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 02:38:45PM +0300, Dan Carpenter wrote: > Actually this we can't overflow here, it will return -EFAULT if param is > NULL and paramlen is non-zero. I'll send a patch to clean this up. Ugh... No, I won't send a patch for this. That LIBCFS_ALLOC() macro is inscrutible and I

Re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
Actually this we can't overflow here, it will return -EFAULT if param is NULL and paramlen is non-zero. I'll send a patch to clean this up. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.o

[PATCH 10/10] staging: most: fix line-over-80-characters violations

2015-10-15 Thread Christian Gromm
This patch prevents code from crossing the 80 character margin. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c |3 ++- drivers/staging/most/hdm-dim2/dim2_hdm.h |3 ++- drivers/staging/most/mostcore/core.c |6 -- 3 files changed, 8 i

[PATCH 06/10] staging: most: make hdm-usb follow the coding style

2015-10-15 Thread Christian Gromm
This patch fixes a couple of issues of the hdm-usb module found by checkpatch.pl. Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-usb/hdm_usb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/stagi

[PATCH 00/10] staging: most: fix checkpatch issues

2015-10-15 Thread Christian Gromm
This patchset is needed to remove warnings generated by checkpatch. Christian Gromm (9): staging: most: correct coding style breaches staging: most: fix usage of false data type staging: most: remove constants from comparisons staging: most: fix checkpatch issues of hdm i2c staging: most

[PATCH 09/10] staging: most: change parameter description

2015-10-15 Thread Christian Gromm
This patch changes the description of a function parameter for a better understanding. Signed-off-by: Christian Gromm --- drivers/staging/most/mostcore/mostcore.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/mostcore/mostcore.h b/drivers/staging/mo

[PATCH 05/10] staging: most: fix checkpatch issues of hdm i2c

2015-10-15 Thread Christian Gromm
This patch fixes the issues of HDM module i2c found by checkpatch.pl Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-i2c/hdm_i2c.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-i2c/hdm_i2c.c b/drivers/staging/most/hdm-i2c/hd

[PATCH 04/10] staging: most: remove constants from comparisons

2015-10-15 Thread Christian Gromm
This patch removes constants from comparisons and fixes checkpatch warnings about constants being put in the wrong place inside a comparison. Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 07/10] staging: most: fix misplaced constants in comparisons

2015-10-15 Thread Christian Gromm
This patch removes and fixes constants being misplaced in comparisons. Signed-off-by: Christian Gromm --- drivers/staging/most/mostcore/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c i

[PATCH 08/10] staging: most: replace memcpy by ether_addr_copy

2015-10-15 Thread Christian Gromm
This patch replaces memcpy() by the preferred function ether_addr_copy(). Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/m

[PATCH 02/10] staging: most: fix usage of false data type

2015-10-15 Thread Christian Gromm
This patch changes the data type from u32 to u16 used for temporary variable. It is needed to stay in the correct range and get rid of the unnecessary cast. Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/dim2_hdm.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 01/10] staging: most: correct coding style breaches

2015-10-15 Thread Christian Gromm
This patch fixes line-over-80-characters violation and removes the splitting of quoted strings. Signed-off-by: Christian Gromm --- drivers/staging/most/hdm-dim2/dim2_hal.c | 21 - drivers/staging/most/hdm-dim2/dim2_hdm.c | 20 ++-- drivers/staging/most

[PATCH 03/10] staging: most: fix style issue in aim-cdev/cdev.c

2015-10-15 Thread Christian Gromm
From: Gavin Thomas Claugus Fix 80+ character line in cdev.c to stop checkpatch.pl from raising a warning. Signed-off-by: Gavin Thomas Claugus Signed-off-by: Christian Gromm --- drivers/staging/most/aim-cdev/cdev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
Hello Lustre Devs, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lnet/selftest/console.c:1330 lstcon_test_add() error: 'paramlen' from user is not capped properly dr

re: staging: add Lustre file system client support

2015-10-15 Thread Dan Carpenter
Hello Lustre Devs, The patch d7e09d0397e8: "staging: add Lustre file system client support" from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lustre/libcfs/kernel_user_comm.c:150 libcfs_kkuc_group_rem() error: buffer overflow 'kkuc_groups' 3

Re: [PATCH] staging: netlogic: xlr_net.h: fixedcoding stly warnings

2015-10-15 Thread Mike Rapoport
On Wed, Oct 14, 2015 at 07:29:30PM +0530, Sakshi Bansal wrote: > Fixed block comments usage of * on subsequent lines > > Signed-off-by: Sakshi Bansal > --- > drivers/staging/netlogic/xlr_net.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Please fix the patch subject. There's a spac

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Marc Dietrich
Am Donnerstag, 15. Oktober 2015, 11:48:12 schrieb Dan Carpenter: > On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > > - if (unlikely(nvec->rx == NULL)) { > > > > + if (!unlikely(nvec->rx)) { > > > > > > This isn't right. You intented

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote: > > > - if (unlikely(nvec->rx == NULL)) { > > > + if (!unlikely(nvec->rx)) { > > > > This isn't right. You intented to say: > > > > if (unlikely(!nvec->rx)) { > > > > But even better to just remov

Re: [PATCH] staging: nvec: fixed few coding style warnings

2015-10-15 Thread Marc Dietrich
Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter: > On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote: > > Fixed allignmnet issues and block comments usage > > Split it apart by type of fix. > > > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) >

[RFC PATCH] staging: wilc1000: join_req_drv can be static

2015-10-15 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- host_interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 704419f..ca6f3983 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/driv

Re: [PATCH 34/40] staging: wilc1000: rename variable gu8FlushedJoinReqDrvHandler

2015-10-15 Thread kbuild test robot
Hi Leo, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-rename-ssidLen-of-struct-join_bss_param/20151015-123159 repr

Re: [PATCH 33/40] staging: wilc1000: rename variable gu32FlushedInfoElemAsocSize

2015-10-15 Thread kbuild test robot
Hi Leo, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-rename-ssidLen-of-struct-join_bss_param/20151015-123159 repr

[RFC PATCH] staging: wilc1000: info_element_size can be static

2015-10-15 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- host_interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 961e853..965fffb 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drive

Re: [PATCH 32/40] staging: wilc1000: rename variable gu32FlushedJoinReqSize

2015-10-15 Thread kbuild test robot
Hi Leo, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-rename-ssidLen-of-struct-join_bss_param/20151015-123159 repr

Re: [PATCH 30/40] staging: wilc1000: rename variable gu8Flushed11iMode

2015-10-15 Thread kbuild test robot
Hi Leo, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-rename-ssidLen-of-struct-join_bss_param/20151015-123159 repr

[RFC PATCH] staging: wilc1000: mode_11i can be static

2015-10-15 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- host_interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 778d9b3..3b86b97 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drive

[RFC PATCH] staging: wilc1000: join_req can be static

2015-10-15 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- host_interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 38ce396..a9b17fc0 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/driv

Re: [PATCH 28/40] staging: wilc1000: rename variable gu8FlushedJoinReq

2015-10-15 Thread kbuild test robot
Hi Leo, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Tony-Cho/staging-wilc1000-rename-ssidLen-of-struct-join_bss_param/20151015-123159 repr