Re: [PATCH 00/10] staging: comedi: adl_pci9118: tidy up ai command support

On 19/10/15 21:12, H Hartley Sweeten wrote: Clean up the analog input async command support code and the interrupt handler. H Hartley Sweeten (10): staging: comedi: adl_pci9118: TRIG_INT is not vaild for scan_begin_src staging: comedi: adl_pci9118: remove unnecessary check in

[PATCH 01/10] staging: lustre: remove unused OBD_SLAB_CPT_ALLOC* macros

The OBD_SLAB_CPT_ALLOC* macros are not used and can be removed Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/include/obd_support.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd_support.h

[PATCH 00/10] staging: lustre: remove OBD_SLAB_ALLOC/FREE and friends

These patches replace OBD_SLAB_ALLOC/FREE and friends with direct use of kmem_cache_alloc/free. Mike Rapoport (10): staging: lustre: remove unused OBD_SLAB_CPT_ALLOC* macros staging: lustre: replace OBDO_ALLOC with kmem_cache_alloc staging: lustre: replace OBDO_FREE with kmem_cache_free

[PATCH 03/10] staging: lustre: replace OBDO_FREE with kmem_cache_free

Use kmem_cache_free directly instead of wrapping macro. Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/llite/file.c| 2 +- drivers/staging/lustre/lustre/llite/llite_close.c | 2 +- drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +-

[PATCH 06/10] staging: lustre: replace OBD_SLAB_ALLOC_PTR_GFP with kmem_cache_alloc

The OBD_SLAB_ALLOC_PTR_GFP macro expands to call to kmem_cache_alloc, which may be used directly. Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 10 +- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c| 2 +-

[PATCH 07/10] staging: lustre: replace OBD_SLAB_ALLOC_GFP with kmem_cache_alloc

Use kmem_cache_free directly instead of wrapping macro. Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/llite/remote_perm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c

[PATCH 09/10] staging: lustre: replace OBD_SLAB_FREE with kmem_cache_free

Use kmem_cache_free directly instead of wrapping macro. Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 2 +- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c | 6 +++---

[PATCH 05/10] staging: lustre: replace OBD_SLAB_ALLOC_PTR with kmem_cache_alloc

The OBD_SLAB_ALLOC_PTR macro expands to call to kmem_cache_alloc, which may be used directly. Signed-off-by: Mike Rapoport --- drivers/staging/lustre/lustre/osc/osc_quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 00/23] Update driver to 0.9-294

> > Perhaps I did not chose my words carefully enough. > > The largest issue on the TODO list is the refactoring of the code to be > shared between the hfi1 and qib driver. While the hardware between hfi1 and > qib is similar and thus the initial code looked similar, our performance > tuning

[PATCH 06/13] staging: wilc1000: chage_virtual_intf: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 85 --- 1 file

[PATCH 04/13] staging: wilc1000: mac_open: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 20 1 file changed, 12

[PATCH 02/13] staging: wilc1000: wilc1000_wlan_init: use netdev private wilc

From: Glen Lee This patch use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 25 + 1 file

[PATCH 03/13] staging: wilc1000: wlan_init_locks: change parameter and use wilc

From: Glen Lee This patch changes function parameter type wilc with net_device and use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho ---

[PATCH 09/13] staging: wilc1000: add_key: use netdev private wilc instead of g_linux_wlan

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++-- 1 file changed, 6

[PATCH 11/13] staging: wilc1000: wilc_mgmt_frame_register: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++ 1 file changed, 3

[PATCH 07/13] staging: wilc1000: wilc1000_wlan_deinit: change argument and use wilc

From: Glen Lee This patch changes function argument wilc with net_device and use nic->wilc instead of global variable g_linux_wlan. The null check codes should be placed before it is used so move it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho

[PATCH 08/13] staging: wilc1000: CfgConnectResult: use netdev private wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++-- 1 file changed, 6

[PATCH 05/13] staging: wilc1000: mac_close: use netdev private wilc instead of g_linux_wlan

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 16 +--- 1 file changed, 9

[PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure

From: Glen Lee This patch add wilc to struct perInterface_wlan_t which is netdev private data to access wilc via netdev_priv function. Assign wilc to nic->wilc. The global variable g_linux_wlan will be replaced with netdev private data member wilc step by step.

[PATCH 13/13] staging: wilc1000: init_irq: change argument and use netdev private wilc

From: Glen Lee This patch changes function argument type wilc with net_device and use netdev private data member wilc instead of p_nic. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 18

[PATCH 12/13] staging: wilc1000: start_ap: use netdev private data wilc

From: Glen Lee Use netdev private data member wilc instead of global variable g_linux_wlan. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +- 1 file changed, 5

[PATCH v2] Drivers: hv: vss: run only on supported host versions

The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an empty

Re: [PATCH 00/23] Update driver to 0.9-294

On Tue, Oct 20, 2015 at 03:45:47PM +0300, Moni Shoua wrote: > > > > Perhaps I did not chose my words carefully enough. > > > > The largest issue on the TODO list is the refactoring of the code to be > > shared between the hfi1 and qib driver. While the hardware between hfi1 > > and qib is similar

Re: [RFC][PATCH 1/2] WIP: Devicetree bindings for Ion

On Tue, Oct 13 2015 at 11:14:23 AM, Andrew wrote: > On 2015-10-12 21:39, Mitchel Humpherys wrote: >> On Tue, Oct 06 2015 at 05:35:41 PM, Rob Herring >> wrote: >>> On Tue, Oct 6, 2015 at 3:47 PM, Laura Abbott >>> wrote: >> >>

[PATCH 12/19] staging/wilc1000: use device pointer for phy creation

wilc_create_wiphy tries to get a pointer to a device from the global wilc1000_sdio_func variable. This is a layering violation and we can use the wilc1000_dev->dev pointer instead. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 2 +-

[PATCH 13/19] staging/wilc1000: move COMPLEMENT_BOOT code to linux_wlan_sdio.c

The COMPLEMENT_BOOT code is used only for SDIO and is aware of details of the SDIO implementation that don't belong into the common linux_wlan.c file. This moves the functions to linux_wlan_sdio.c to get them out of the way. Signed-off-by: Arnd Bergmann ---

[PATCH 09/19] staging/wilc1000: move init/exit functions to driver files

The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so this is where the init and exit functions should be. Splitting this up enables further cleanups, including eventually allowing both modules to be built together. Signed-off-by: Arnd Bergmann ---

[PATCH 11/19] staging/wilc1000: move wilc1000_ops to drivers

The two instances of struct wilc1000_ops reference functions that are defined in just one file each. By moving the operations there, we can mark all those functions as 'static' and avoid a number of #ifdefs. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c

Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try

On Monday 19 October 2015 11:53:40 Arnd Bergmann wrote: > On Monday 19 October 2015 11:39:31 Arnd Bergmann wrote: > > On Monday 19 October 2015 16:54:23 Tony Cho wrote: > > > Hi Arnd Bergmann, > > > > > > When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) > > > because

[PATCH 19/19] [RFC] staging/wilc1000: use more regular probing

So far, my patches tried to do equivalent conversions of the existing code. This one goes beyond that by restructuring how the devices get probed. In particular, the spi driver no longer creates the netdev until the device is probed, and I've removed the global wilc1000_sdio_func and wilc_spi_dev

[PATCH 17/19] staging/wilc1000: pass hif operations through initialization

The wilc1000_hif_spi and wilc1000_hif_sdio structures are part of the bus specific code, and the generic code should have no knowledge of their addresses. This changes the code to reference them only from the bus specific initialization code, which we can then use to split up the driver into

[PATCH 04/19] staging/wilc1000: move extern declarations to headers

'extern' declarations belong into a header file rather than a .c file, to ensure that the definition matches the declaration. This moves all declarations into a header file that seems most appropriate for it. Signed-off-by: Arnd Bergmann ---

[PATCH 14/19] staging/wilc1000: get rid of WILC_SDIO_IRQ_GPIO

Whether the SDIO function uses an internal or external interrupt should not be a compiletime decision but be determined at runtime. This changes the code to pass a GPIO number from the init code as early as possible, and leaves just one #ifdef WILC_SDIO_IRQ_GPIO to preserve the previous behavior.

[PATCH 01/19] staging/wilc1000: remove unused functions

A number of symbols in the wilc1000 driver are completely unused and can be removed. This includes two variables that are only written but not read. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/host_interface.c | 311 --

[PATCH 15/19] staging/wilc1000: turn enable_irq/disable_irq into callbacks

As a preparation for turning the SDIO side of wilc1000 into a separate module, this removes the last direct caller from the core module into the sdio specific portion. All calls to wilc1000_sdio_enable_interrupt() and wilc1000_sdio_disable_interrupt() now go through a function pointer in

[PATCH 10/19] staging/wilc1000: unify device pointer

struct wilc has two pointers to store the device, one for sdio_func and one for spi_device. By changing the pointer to a 'struct device', we can simplify the logic and avoid a few #ifdefs. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 29

[PATCH 00/19] staging/wilc1000 cleanups

After I screwed up two or three times trying to get the dependencies with the SPI and SDIO backends right, I ended up taking the time to do the real fix and make both coexist. This is a series of patches that address various issues with the driver, but is mainly targetted at splitting out the spi

[PATCH 07/19] staging/wilc1000: remove linux_wlan_{device_power, device_detection}

The driver provides an interface for custom power management and detection that is meant to be filled by people customizing the driver. The default implementation of this is empty, and we don't actually want people to have to modify the source code. If anybody needs this, they need to describe

[PATCH 08/19] staging/wilc1000: move wilc_wlan_inp_t into struct wilc

wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c to have knowledge of the specific sdio and spi front-ends. This removes the structure and places the members with a constant 'struct wilc1000_ops' pointer inside of 'struct wilc'. Signed-off-by: Arnd Bergmann

[PATCH 16/19] staging/wilc1000: remove WILC_SDIO/WILC_SPI macros

The last remaining user of WILC_SDIO macro checks for the correct time to wait in an interrupt for the PLL to settle. We can replace this with a runtime check and remove both WILC_SDIO and WILC_SPI, as we no longer need conditional compilation based on the hardware type. Signed-off-by: Arnd

[PATCH 02/19] staging/wilc1000: make symbols static if possible

All symbols that are only referenced in the file that defines them can be declared 'static' to avoid namespace pollution, to produce better object code, and to make the source more readable. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Makefile | 3

[PATCH 18/19] staging/wilc1000: split out bus specific modules

The SPI and SDIO specific code is now separate enough that we just need to restructure the Makefile and Kconfig logic a bit and export a couple of symbols from the common module to have separate bus glue drivers. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Kconfig

[PATCH 06/19] staging/wilc1000: avoid static definitions in header

The wilc_wfi_cfgoperations.h header defines the ieee80211_txrx_stypes and cipher_suites variables that are only used in wilc_wfi_cfgoperations.c and should not be shared in a header file. This moves over all that data into the .c file, and also moves all the macro definitions from the file that

[PATCH 05/19] staging/wilc1000: use NO_SECURITY instead of NO_ENCRYPT

The linux_wlan.c file uses a set of enums from wilc_wlan_if.h, with the exception of the NO_ENCRYPT that comes from wilc_wfi_cfgoperations.h. The two sets of enums clearly have the same intention but are defined a bit different. To prepare to clean up the ones in wilc_wfi_cfgoperations.h, this

Re: [PATCH] Staging: comedi: removing useless init/exit

On Wed, Oct 21, 2015 at 08:41:52AM +0530, Ronit Halder wrote: > Removing init and exit functions as they do nothing. Really? Did you test this? ___ devel mailing list de...@linuxdriverproject.org

[PATCH] Staging: comedi: removing useless init/exit

Removing init and exit functions as they do nothing. Signed-off-by: Ronit Halder --- drivers/staging/comedi/comedi_usb.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/comedi/comedi_usb.c b/drivers/staging/comedi/comedi_usb.c index