Re: [PATCH 7/7] staging: lustre: remove container_of0 and __container_of

Hi Aya, [auto build test ERROR on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Aya-Mahfouz/staging-lustre-remove-uses-and-definition-of-container_of0/20151014-062751 config: x86_64

[PATCH 3/3] Staging: wilc1000: Remove boolean comparision

This patch is to the host_interface.c file that fixes up following warning reported by coccicheck: WARNING: Comparison to bool Boolean tests do not need explicit comparison to true or false Signed-off-by: Punit Vara --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 inse

[PATCH 2/3] Staging: wilc1000: Remove comparision of field address to NULL

This is patch to the linux_wlan file that fixes up following error reported by coccicheck : ERROR: test of a variable/field address Signed-off-by: Punit Vara --- drivers/staging/wilc1000/linux_wlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wil

[PATCH 0/3] Staging: wilc1000: Remove coccicheck warnings and error

Punit Vara (3): staging: wilc1000: Remove reference preceded by free Staging: wilc1000: Remove comparision of field address to NULL Staging: wilc1000: Remove boolean comparision drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/linux_wlan.c |

[PATCH 1/3] staging: wilc1000: Remove reference preceded by free

This patch is to the wilc_wfi_cfgoperations.c file that fixes up following error reported by coccicheck: ERROR: reference preceded by free on line 1219 For (params->seq_len) <= 0 memory is already freed when (params->seq_len) >0 then memory was alloted. So there is no need to use kfree whenever p

[PATCH 21/21] staging: rtl8188eu: pwrGrpCnt variable removed in store_pwrindex_offset function

This variable used only once in the beginning of the function, it can be removed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/b

[PATCH 09/21] staging: rtl8188eu: unused MIN macro removed

This patch removes unused MIN macro from include/rtw_security.h. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/rtw_security.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_security.h b/drivers/staging/rtl8188eu/include/rtw_securi

[PATCH 17/21] staging: rtl8188eu: checkpatch fixes: alignment should match open parenthesis

This is checkpatch fixes for hal/bb_cfg.c file: alignment should match open parenthesis. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/

[PATCH 01/21] staging: rtl8188eu: sizeof/sizeof replaced by ARRAY_SIZE kernel macro

ARRAY_SIZE shorter and more difficult to create bugs. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/mac_cfg.c| 2 +- drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions

[PATCH 05/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

min macro better conveys the meaning of the code. Expressions types explicitly specified to suppress compiler warnings about incompatible types. Types of the macro arguments match the types of the left side. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-

[PATCH 12/21] staging: rtl8188eu: occurrence of the 5 GHz code marked

Channel numbers greater than 14 are used here, which are possible only for the 5 GHz frequency. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/sta

[PATCH 11/21] staging: rtl8188eu: increment placed into for loop header

The increment at the end of the cycle, and it can be placed in the loop header. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 +-- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 15 --- 2 files changed, 5 insertions(+), 13 deletions(-) diff --

[PATCH 20/21] staging: rtl8188eu: new variable for hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] in store_pwrindex_offset function

hal_data->MCSTxPowerLevelOriginalOffset[pwrGrpCnt] frequent in this function, so it replaced by the power_level_offset new variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-)

[PATCH 07/21] staging: rtl8188eu: unused SUCCESS and FAIL macros removed

This patch removes unused SUCCESS and FAIL macros in include/basic_types.h. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/basic_types.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers/staging/rtl8188eu/include/b

[PATCH 21/21] pwrGrpCnt variable removed in store_pwrindex_offset function

This variable used only once in the beginning of the function, it can be removed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/b

[PATCH 16/21] staging: rtl8188eu: checkpatch fixes: unnecessary parentheses removed in hal/bb_cfg.c

This is checkpatch fixes for hal/bb_cfg.c file: unnecessary parentheses around . Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/

[PATCH 03/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

min (or max) kernel macro better conveys the meaning of the code. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 6 ++ drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 4 ++-- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 2 +- 3 files changed, 5 insertio

[PATCH 08/21] staging: rtl8188eu: unused MEM_ALIGNMENT_OFFSET and MEM_ALIGNMENT_PADDING macros removed

This patch removes unused MEM_ALIGNMENT_OFFSET and MEM_ALIGNMENT_PADDING macros from include/basic_types.h. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/basic_types.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/dri

[PATCH 14/21] staging: rtl8188eu: checkpatch fixes: spaces preferred around that '|' in hal/bb_cfg.c

This is checkpatch fixes for hal/bb_cfg.c file: spaces preferred around that '|'. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal

[PATCH 18/21] staging: rtl8188eu: checkpatch fixes: line over 80 characters splited into two parts

This is checkpatch fixes for hal/bb_cfg.c file: line over 80 characters. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal

[PATCH 13/21] staging: rtl8188eu: operator = replaced by += in loop increment

x = x + a and x += a equivalen, but second preferably. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c | 6 +++--- drivers/staging/rtl8188eu/hal/mac_cfg.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c

[PATCH 04/21] staging: rtl8188eu: ternary operator (?:) replaced by min/max kernel macro

min macro better conveys the meaning of the code. Constants types explicitly specified to suppress compiler warnings about incompatible types. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +- drivers/

[PATCH 06/21] staging: rtl8188eu: abs kernel macro used in simularity_compare function

abs macro is useful for determining the difference between the two integers. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/phy.c b/drivers/staging/rtl8188eu/hal/phy.c index 2e

[PATCH 19/21] staging: rtl8188eu: checkpatch fixes: 'Avoid CamelCase' in hal/bb_cfg.c

This is checkpatch fixes for hal/bb_cfg.c file: Avoid CamelCase. Additionaly unnecessary space before line removed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 15/21] staging: rtl8188eu: BITn macro replaced by BIT(n) in hal/bb_cfg.c

BIT(n) macro preferable BITn. The BITn definitions saved, because BITn used in other files. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/bb_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188

[PATCH 02/21] staging: rtl8188eu: clamp kernel macro used in proc_get_rx_signal

To limit the range of integers there is clamp macro. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c b/drivers/staging/rtl8188eu/core/rtw_debug.c index 993

[PATCH 10/21] staging: rtl8188eu: while loop replaced by for loop in rtw_restruct_wmm_ie

This patch replaces while loop with for loop, because the initial condition and the increment clearly and briefly defined for this loop. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/stag

[PATCH 00/21] staging: rtl8188eu: code cleanups

Kernel macros used, unnecessary macro removed, some checkpatch fixes performed and other changes added. Ivan Safonov (21): staging: rtl8188eu: sizeof/sizeof replaced by ARRAY_SIZE kernel macro staging: rtl8188eu: clamp kernel macro used in proc_get_rx_signal staging: rtl8188eu: ternary opera

Re: [PATCH v2 1/3] staging: rtl8712: Remove boolean comparisons

On 22/10/15 20:05, Dan Carpenter wrote: > On Mon, Oct 19, 2015 at 06:14:29PM +0100, Luis de Bethencourt wrote: >> Boolean tests do not need explicit comparison to true or false. >> >> Signed-off-by: Luis de Bethencourt >> --- >> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c >> b/drivers/st

[PATCH] lustre: obdclass: fix sparse warning

This patch fixes the following warnings given by the sparse: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_pro

Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

On Fri, Oct 23, 2015 at 2:04 AM, Dan Carpenter wrote: > First fetch the changes, then check them out. > > $ git fetch git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-next > $ git checkout FETCH_HEAD > > regards, > dan carpenter > Thank you very much Dan. Problem is solv