Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > #define APCI1032_CTRL_INT_OR (0 << 1) > +#define APCI1032_CTRL_INT_AND BIT(1) And now you have two

[PATCH] comedi: drivers: Fix - BIT macro used coding style issue

BIT macro is used for defining bit location instead of shifting operator - coding style issue Signed-off-by: Ranjith T --- drivers/staging/comedi/drivers/addi_apci_1032.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] lustre: obdclass: fix sparse warning

Fix the following warning given by sparse: drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static? Signed-off-by: Paul Davies C --- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +- 1 file

[PATCH 2/2] staging: rtl8188eu: add missing delay in polling loops.

Previously the code could exit with failure too early. Signed-off-by: Rémy Oudompheng --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c

[PATCH 1/2] staging: rtl8188eu: jiffies are unsigned long

Remove rtw_get_passing_time_ms function and adjust type of relevant variables. Signed-off-by: Rémy Oudompheng --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 4 +-- drivers/staging/rtl8188eu/core/rtw_mlme.c | 13 ---

[PATCH 3/7] staging: sm750fb: return -ENOMEM if allocation fails

In lynxfb_pci_probe return -ENOMEM rather than -ENODEV in case allocation of sm750_dev fails. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.c

[PATCH 2/7] staging: sm750fb: remove needless goto statements and lables

In lynxfb_pci_probe return error immediately in cases no cleanup is required. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c

[PATCH 7/7] staging: sm750fb: introduce sm750fb_frambuffer_alloc

Split framebuffer allocation and registration into a dedicated function to simplify lynxfb_pci_probe Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 109 +++- 1 file changed, 51 insertions(+), 58 deletions(-) diff

[PATCH 1/7] staging: sm750fb: remove unused modedb.h

The modedb.h defines unused set of videomodes and can be removed Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/modedb.h | 233 --- drivers/staging/sm750fb/sm750.c | 2 - 2 files changed, 235 deletions(-) delete mode

[PATCH 4/7] staging: sm750fb: lynxfb_pci_remove: remove unused variable

The par variable in lynxfb_pci_remove is only assigned a value and never used afterwards. Remove it. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c

[PATCH 6/7] staging: sm750fb: introduce sm750fb_frambuffer_release

Use a function to unregister framebuffer info and release its resources. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c

[PATCH 5/7] staging: sm750fb: replace dual member of sm750_dev with fb_count

Will be used in futher refactoring of driver _probe and _remove methods. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 24 +--- drivers/staging/sm750fb/sm750.h | 2 +- 2 files changed, 14 insertions(+), 12 deletions(-) diff

[PATCH 0/7] staging: sm750fb: refactor lynxfb_pci_probe

Hi, These patches refactor the lynxfb_pci_probe along with some minor cleanups Mike Rapoport (7): staging: sm750fb: remove unused modedb.h staging: sm750fb: remove needless goto statements and lables staging: sm750fb: return -ENOMEM if allocation fails staging: sm750fb:

Re: [PATCH 2/2] staging: rtl8188eu: add missing delay in polling loops.

On 11/01/2015 04:30 AM, =?UTF-8?q?R=C3=A9my=20Oudompheng?= wrote: Previously the code could exit with failure too early. Your mailer is broken. The above line is what shows as the return address. Larry ___ devel mailing list

Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote: > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > > BIT macro is used for defining bit location instead of shifting > > operator - coding style issue > > > #define APCI1032_CTRL_INT_OR (0 << 1)

Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

On Sun, Nov 01, 2015 at 10:10:59AM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote: > > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > > > BIT macro is used for defining bit location instead of shifting > > > operator -

[PATCH] drivers:staging:gdm72xx Fix all spacing preferred messages

This fixes all spacing preferred around that... mesages from checkpatch.pl Signed-off-by: Bogicevic Sasa --- drivers/staging/gdm72xx/gdm_qos.c | 54 +++ 1 file changed, 27 insertions(+), 27 deletions(-) diff --git

RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

>On Thu, Oct 29, 2015 at 07:28:21PM -0400, James Simmons wrote: >> With nidstring now having the latest fixes we can >> now clean up all the remaining checkpatch errors >> for nidstring.c. > >Please be specific as to exactly what you changed, and break it up into >one-patch-per-thing. And no,

About the patch "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

Hi Shivani Bhardwaj, Thank you for the patches. I am writing this new mail thread since I didn't received about following patch which is applied recently. https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/patch/drivers/staging/wilc1000?id=d4622f68db8095dd54179e3134e97812727f6b89

Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

I suspect you're over-thinking it. The maintainers appear to be reacting to the different types of style changes - "checkpatch cleanups" is an awfully broad commit message. I'd suggest breaking this patch (and any others like it) into two pieces; one with whitespace cleanups, and one with the

[PATCH] Staging: rtl8188eu: checkpatch cleanup for core/rtw_xmit.c

This patch will remove the error reported by checkpatch.pl script Signed-off-by: Abdul Hussain --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c