[PATCH V2] Revert "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

The addresses are not properly aglined for using ether_addr_copy function. I revert this as author agree to drop this patch. This reverts commit d4622f68db8095dd54179e3134e97812727f6b89. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/coreconfigurator.c | 48 +++--

Re: [PATCH 2/7] staging: sm750fb: remove needless goto statements and lables

On Sun, Nov 01, 2015 at 10:55:48AM +0200, Mike Rapoport wrote: > In lynxfb_pci_probe return error immediately in cases no cleanup is > required. > > Signed-off-by: Mike Rapoport > --- NACK. It should be: diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index c78421

Re: [PATCH] Staging: comedi: ssc_dnp: fixed a comment style

On Fri, Oct 30, 2015 at 06:46:20PM +0100, Philippe Loctaux wrote: > Fixed a comment issue. > > Signed-off-by: Philippe Loctaux > --- > drivers/staging/comedi/drivers/ssv_dnp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c >

Re: [PATCH v2 1/7] staging: lustre: remove white space in libcfs_hash.h

On Mon, Nov 02, 2015 at 12:22:07PM -0500, James Simmons wrote: > Cleanup all the unneeded white space in libcfs_hash.h. > > Signed-off-by: James Simmons > --- > .../lustre/include/linux/libcfs/libcfs_hash.h | 135 > ++-- > 1 files changed, 70 insertions(+), 65 deletions(-)

[PATCH 09/11] staging: rtl8188eu: fwlen renamed to i

This variable used as a loop counter. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 3cd684a..981641b 100644 --- a/driver

[PATCH 00/11] staging: rtl8188eu: _rtl88e_fill_dummy refactoring

This patchset includes a set of small changes in the function _rtl88e_fill_dummy. Ivan Safonov (11): staging: rtl8188eu: new temporary variable added to _rtl88e_fill_dummy staging: rtl8188eu: for loop instead of while loop used staging: rtl8188eu: traversal order of the 'remain' variable val

[PATCH 06/11] staging: rtl8188eu: (*pfwlen + n) replaced by roundup(*pfwlen, 4)

This can be proved rigorously, but get long. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index f153387..70011bd 100644 --- a/drivers

[PATCH 02/11] staging: rtl8188eu: for loop instead of while loop used

All loop controls is contained in the loop header. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index d502606..6d6dd15 100644 ---

[PATCH 05/11] staging: rtl8188eu: (*pfwlen + remain) replaced by fwlen

Also a 'remain' variable removed from the loop. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index c880ba1..f153387 100644 --- a/driv

[PATCH 01/11] staging: rtl8188eu: new temporary variable added to _rtl88e_fill_dummy

It makes easier to understand the transition to a simpler function form. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 23aa6d3

[PATCH 11/11] staging: rtl8188eu: return value and argument types changed in _rtl88e_write_fw function

Ideally the function should not change the variables outside of its body. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index

[PATCH 08/11] staging: rtl8188eu: initialization of the loop counter moved to the header of the loop

It is the canonical form of the for loop. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index d0fa803..3cd684a 100644 --- a/driver

[PATCH 04/11] staging: rtl8188eu: constant in both sides of loop condition added

Now it is possible to replace (*pfwlen + remain) to fwlen and (*pfwlen + n) to roundup(pfwlen, 4). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188e

[PATCH 03/11] staging: rtl8188eu: traversal order of the 'remain' variable values inverted

The number of the loop passes has not changed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 6d6dd15..9cd898c 100644 --- a/drive

[PATCH 10/11] staging: rtl8188eu: unnessesary braces removed in _rtl88e_fill_dummy function

There is no need in these braces. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 981641b..c6cdca3 100644 --- a/drivers/staging/

[PATCH 07/11] staging: rtl8188eu: unused variables n and remain removed

These variables do nothing. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 70011bd..d0fa803 100644 --- a/drivers/staging/rtl

Re: [lustre-devel] [patch] staging: lustre: remove unused variable

On 2015/11/03, 15:38, "Simmons, James A." wrote: >>The "->lr_lvb_data" struct member is never used. Delete it. >> >>Signed-off-by: Dan Carpenter >>--- >>I have compile tested this. I looked through the history and it seems >>to never have been used. I wonder if we can remove the locking as we

Re: [patch] staging: lustre: remove unused variable

On Tue, Nov 03, 2015 at 10:38:15PM +, Simmons, James A. wrote: > > >The "->lr_lvb_data" struct member is never used. Delete it. > > > >Signed-off-by: Dan Carpenter > >--- > >I have compile tested this. I looked through the history and it seems > >to never have been used. I wonder if we can

RE: [PATCH] staging:lustre: Prevent duplicate CT registrations

>On Fri, Oct 23, 2015 at 03:59:14PM -0400, James Simmons wrote: >> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> b/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> index 635a93c..d6d70d8 100644 >> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c >> +++ b/drivers/staging/lustre/lustre/

Re: [patch] staging: lustre: potential underflow in libcfs_kkuc_group_add()

On 11/03/2015 05:28 PM, Simmons, James A. wrote: My static checker says that "group" is a user controlled number that can be negative leading to an array underflow. I have looked at it, and I'm not an expert enough in lustre to say for sure if it is really a bug. Anyway, it's simple enough to

RE: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

>Yeah. That is often the fastest way to fix all the checkpatch warnings. > >Checkpatch warnings are pretty mechanical. Just send like 100 patches >at a time until everything is fixed. Don't overthink. Say your patch >breaks the alignment then you have to fix that, but otherwise only fix >one th

RE: [patch] staging: lustre: potential underflow in libcfs_kkuc_group_add()

>My static checker says that "group" is a user controlled number that can >be negative leading to an array underflow. I have looked at it, and I'm >not an expert enough in lustre to say for sure if it is really a bug. >Anyway, it's simple enough to make the variable unsigned which pleases >the st

RE: staging: lustre: provide separate buffers for libcfs_*2str()

>Hello Dmitry Eremin, > >This is a semi-automatic email about new static checker warnings. > >The patch 80feb1ef349e: "staging: lustre: provide separate buffers >for libcfs_*2str()" from Oct 21, 2015, leads to the following Smatch >complaint: I created a ticket for this at https://jira.hpdd.inte

RE: [patch] staging: lustre: remove unused variable

>The "->lr_lvb_data" struct member is never used. Delete it. > >Signed-off-by: Dan Carpenter >--- >I have compile tested this. I looked through the history and it seems >to never have been used. I wonder if we can remove the locking as well. This is used by the quota and ofd layer which are b

[patch] staging: lustre: remove unused variable

The "->lr_lvb_data" struct member is never used. Delete it. Signed-off-by: Dan Carpenter --- I have compile tested this. I looked through the history and it seems to never have been used. I wonder if we can remove the locking as well. diff --git a/drivers/staging/lustre/lustre/include/lustre_

Re: [PATCH] Revert "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

On Tue, Nov 03, 2015 at 07:05:11PM +0900, Glen Lee wrote: > The addresses are not properly aglined for using ether_addr_copy function. > I revert this as author agree to drop this patch. > > This reverts commit d4622f68db8095dd54179e3134e97812727f6b89. > --- > drivers/staging/wilc1000/coreconfigu

re: staging: lustre: provide separate buffers for libcfs_*2str()

Hello Dmitry Eremin, This is a semi-automatic email about new static checker warnings. The patch 80feb1ef349e: "staging: lustre: provide separate buffers for libcfs_*2str()" from Oct 21, 2015, leads to the following Smatch complaint: drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:676

re: staging: wilc1000: GetIfHandler: add argument struct wilc and use it

Hello Glen Lee, This is a semi-automatic email about new static checker warnings. The patch 4ad81fd6125f: "staging: wilc1000: GetIfHandler: add argument struct wilc and use it" from Oct 27, 2015, leads to the following Smatch complaint: drivers/staging/wilc1000/linux_wlan.c:1590 frmw_to_linux(

[PATCH 01/14] staging: rtl8188eu: *(ptr + i) replaced by ptr[i] in _rtl88e_fw_block_write

It is better to read. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 23aa6d3..af93697 100644 --- a/drivers/staging/rtl8188eu/

[PATCH 08/14] staging: rtl8188eu: buf_ptr variable completely defined in a single line

It is simpler. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 3cfd2b2..4f1c3a2 100644 --- a/drivers/staging/rtl8188eu/hal/fw.c ++

[PATCH 10/14] staging: rtl8188eu: unnecessary initialization removed

It is superfluous. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 8eafd7e..b48f444 100644 --- a/drivers/staging/rtl8188eu/hal/fw.

[PATCH 05/14] staging: rtl8188eu: unnecessary variable override removed

Variable value calculated in the previous loop. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 9673686..39c5a05 100644 --- a/d

[PATCH 11/14] staging: rtl8188eu: unnessesary braces for single statement block removed

checkpatch fix: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c i

[PATCH 04/14] staging: rtl8188eu: offset variable replaced by its value

It is now possible to get rid of re-initializing the offset variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 99dd1f0..967

[PATCH 06/14] staging: rtl8188eu: unnecessary branching removed

If the 'remain' is zero, the loop is not executed at all. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 39c5a05..44e8078

[PATCH 14/14] staging: rtl8188eu: offset renamed to write_address

This name is better suited for this variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 059e7ee..8c02301 100644

[PATCH 03/14] staging: rtl8188eu: initial value placed in the variable

Line become shorter. After the loop offset variable points to the location following insertion. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl818

[PATCH] Revert "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

The addresses are not properly aglined for using ether_addr_copy function. I revert this as author agree to drop this patch. This reverts commit d4622f68db8095dd54179e3134e97812727f6b89. --- drivers/staging/wilc1000/coreconfigurator.c | 48 +++-- 1 file changed, 25 inserti

[PATCH 13/14] staging: rtl8188eu: pu4BytePtr renamed to dword_buffer

This name is better suited for this variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index f8f212f..059e7ee 100644 --- a/dr

[PATCH 02/14] staging: rtl8188eu: assigning a value to the variable is replaced by the increment

It is made to the initial value could be placed in the offset variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index af93697

[PATCH 07/14] staging: rtl8188eu: offset increment placed into for loop header

It makes the code little easier. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 44e8078..3cfd2b2 100644 --- a/drivers/stag

[PATCH 09/14] staging: rtl8188eu: types of local variables conformed with types of function arguments

The array should not change in any case. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 4f1c3a2..8eafd7e 100644 --- a/drivers

[PATCH 00/14] _rtl88e_fw_block_write refactoring

This patchset includes a set of small changes in the function _rtl88e_fw_block_write. Ivan Safonov (14): staging: rtl8188eu: *(ptr + i) replaced by ptr[i] in _rtl88e_fw_block_write staging: rtl8188eu: assigning a value to the variable is replaced by the increment staging: rtl8188eu:

[PATCH 12/14] staging: rtl8188eu: buf_ptr renamed to byte_buffer

This name is better suited for this variable. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/fw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c index 04ae583..f8f212f 100644 --- a/

Re: About the patch "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

Hi Shivani, I will revert as you said, I always appreciate all the effort and your time to help. Regards, glen lee. On 2015년 11월 03일 17:26, Shivani Bhardwaj wrote: On Mon, Nov 2, 2015 at 7:13 AM, glen lee wrote: Hi Shivani Bhardwaj, Thank you for the patches. I am writing this new mail t

Re: About the patch "Staging: wilc1000: coreconfigurator: Drop unneeded wrapper functions"

On Mon, Nov 2, 2015 at 7:13 AM, glen lee wrote: > Hi Shivani Bhardwaj, > > Thank you for the patches. > > I am writing this new mail thread since I didn't received about following > patch which is applied recently. > > https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/patch/drivers/s