Re: [PATCH] staging: wilc1000: remove new line around else and braces

2015-11-13 Thread Panayiotis Tembriotis
On Sat, Nov 14, 2015 at 12:22:29PM +0530, Sudip Mukherjee wrote: > On Fri, Nov 13, 2015 at 11:59:47PM +0200, Panayiotis Tembriotis wrote: > > Remove excess new line characters as suggested by checkpatch.pl: > > ERROR: else should follow close brace '}' > > ERROR: that open brace { should be on the

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Sudip Mukherjee
On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > > This patch fixes the checkpatch issue: > > > CHECK: Prefer using the BIT macro > > > > > > Reviewed-b

Re: [PATCH] staging: most: aim-cdev: Used "==" instead of assignment

2015-11-13 Thread Sudip Mukherjee
On Sat, Nov 14, 2015 at 09:57:10AM +0530, Anjali Menon wrote: > Used double equal sign instead of equal to sign in the if condition > to remove the error detected by checkpatch.pl. > > ERROR: do not use assignment in if condition > > Signed-off-by: Anjali Menon > --- > drivers/staging/staging/d

Re: [PATCH] staging: wilc1000: remove new line around else and braces

2015-11-13 Thread Sudip Mukherjee
On Fri, Nov 13, 2015 at 11:59:47PM +0200, Panayiotis Tembriotis wrote: > Remove excess new line characters as suggested by checkpatch.pl: > ERROR: else should follow close brace '}' > ERROR: that open brace { should be on the previous line > > Signed-off-by: Panayiotis Tembriotis > --- This has

Re: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement

2015-11-13 Thread Sudip Mukherjee
On Fri, Nov 13, 2015 at 09:03:56PM +0530, Nizam Haider wrote: > Fix Checlpatch warning > HECK: braces {} should be used on all arms of this statement > > Signed-off-by: Nizam Haider > --- > drivers/staging/dgnc/dgnc_neo.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --g

[PATCH] staging: most: aim-cdev: Used "==" instead of assignment

2015-11-13 Thread Anjali Menon
Used double equal sign instead of equal to sign in the if condition to remove the error detected by checkpatch.pl. ERROR: do not use assignment in if condition Signed-off-by: Anjali Menon --- drivers/staging/staging/drivers/staging/most/aim-cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 10/18] staging/rdma/hfi1: Adds software counters for bitfields within various error status fields

2015-11-13 Thread Jubin John
From: Joel Rosenzweig Provides error status counters for CceErrStatus, Send*ErrStatus, RcvErrStatus and MISC_ERR_STATUS Reviewed-by: Mitko Haralanov Reviewed-by: Mike Marciniszyn Signed-off-by: Joel Rosenzweig Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 3185 +++

[PATCH 17/18] staging/rdma/hfi1: Adding counter resolutions for DataPortCounters

2015-11-13 Thread Jubin John
From: Andrea Lowe Changing the 32-bit reserved field in opa_port_data_counters_msg to the new 'resolution' field. PMA will use resolutions to right- shift values for LocalLinkIntegrity and LinkErrorRecovery when computing the ErrorCounterSummary for a DataPortCounters request. Reviewed-by: Mike

[PATCH 15/18] staging/rdma/hfi1: Consider VL15 MTU also when calculating the maximum VL MTU

2015-11-13 Thread Jubin John
From: Harish Chegondi Currently, only MTUs of VLs 0-7 are checked when calculating the maximum VL MTU which is used to set the port MTU capability in DCC_CFG_PORT_CONFIG CSR This can cause a port MTU capability to be set to 0 if MTUs of VLs 0-7 is 0 This would affect the VL15 traffic. Reviewed-b

[PATCH 12/18] staging/rdma/hfi1: Unexpected link up pkey values are not an error

2015-11-13 Thread Jubin John
From: Dean Luick Only warn when link up pkeys are not what we expect. Also, allow for the pkey to already be initialized. Reviewed-by: Arthur Kepner Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |8 1 files changed, 4 insertions(+), 4

[PATCH 14/18] staging/rdma/hfi1: unknown frame messages are not errors

2015-11-13 Thread Jubin John
From: Dean Luick Change reported unknown frame messages into a counter. These are informational, no errors. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 18 ++ drivers/staging/rdma/hfi1/chip.h |

[PATCH 09/18] staging/rdma/hfi1: Correctly limit VLs against SDMA engines

2015-11-13 Thread Jubin John
From: Dean Luick Correctly reduce the number of VLs when limited by the number of SDMA engines. Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 08/18] staging/rdma/hfi1: Add a credit push on diagpkt allocate fail

2015-11-13 Thread Jubin John
From: Dean Luick When sending a diagnostic packet, if the send context does not have enough room, force a credit return and try again. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/diag.c |8 1 files changed, 8

[PATCH 07/18] staging/rdma/hfi1: Extend quiet timeout

2015-11-13 Thread Jubin John
From: Dean Luick The longest quiet timeout is now 6s. Extend the driver wait. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue

2015-11-13 Thread Jubin John
Enabling CONFIG_SDMA_VERBOSITY exposes a timing issue in the driver/DC firmware. Removing the CCE_INT_* CSR reads from sdma_dumpstate and a sdma_dumpstate call from the sdma_sendctrl() works around the issue Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/s

[PATCH 13/18] staging/rdma/hfi1: remove SPC freeze error messages

2015-11-13 Thread Jubin John
From: Dean Luick An SPC freeze is not an error. Remove the messages. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma/hfi1/c

[PATCH 16/18] staging/rdma/hfi1: Fix Xmit Wait calculation

2015-11-13 Thread Jubin John
From: Ira Weiny Total XMIT wait needs to sum the xmit wait values of all the VLs not just those requested in the query. Also, make the algorithm used for both PortStatus and PortDataCounters the same. Reviewed-by: Arthur Kepner Reviewed-by: Breyer, Scott J Signed-off-by: Ira Weiny Signed-off

[PATCH 11/18] staging/rdma/hfi1: Destroy workqueues if hfi1_register_ib_device() call returns error

2015-11-13 Thread Jubin John
From: Harish Chegondi Currently, if hfi1_register_ib_device() call is unsuccessful, workqueues are not being destroyed before bailing out. This patch fixes this issue. Reviewed-by: Dennis Dalessandro Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/init.

[PATCH 02/18] staging/rdma/hfi1: Decode CNP opcode

2015-11-13 Thread Jubin John
From: Dean Luick Add CNP opcode decode Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/trace.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rdma/hfi1/trace.h b/drivers/staging/rdma/

[PATCH 06/18] staging/rdma/hfi: Add one-time LCB reset

2015-11-13 Thread Jubin John
From: Dean Luick Add one-time LCB reset on driver load to pre-emptively work around any LCB power cycle issues. Reviewed-by: Easwar Hariharan Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 20 drivers/staging/rdma/h

[PATCH 05/18] staging/rdma/hfi1: Clean up comments

2015-11-13 Thread Jubin John
From: Edward Mascarenhas Clean up comments Reviewed-by: Mike Marciniszyn Signed-off-by: Edward Mascarenhas Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |1 - drivers/staging/rdma/hfi1/driver.c |2 +- drivers/staging/rdma/hfi1/hfi.h|4 ++-- drivers/staging/

[PATCH 04/18] staging/rdma/hfi1: Fix qp.h comments

2015-11-13 Thread Jubin John
From: Kaike Wan This patch fixes a few qp.h comments. Reviewed-by: Mike Marciniszyn Signed-off-by: Kaike Wan Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/qp.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/hfi1/qp.h b/drivers/s

[PATCH 01/18] staging/rdma/hfi1: Support alternate firmware names

2015-11-13 Thread Jubin John
From: Dean Luick Add support for an automatic fallback for firmware names. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/firmware.c | 189 -- 1 files changed, 157 insertions(+), 32 deletions(

[PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

2015-11-13 Thread Jubin John
From: Dean Luick Add aeth name syndrome decode Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/trace.c | 29 ++--- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rdma/hf

[PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area

2015-11-13 Thread Nizam Haider
Fix simple typo in comments Signed-off-by: Nizam Haider --- drivers/staging/iio/iio_simple_dummy_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c index cf44a6f..c8f889b 1006

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Nov 2015 22:31:15 +0100 Arnd Bergmann escreveu: > On Friday 13 November 2015 17:13:41 Mauro Carvalho Chehab wrote: > > Em Wed, 11 Nov 2015 21:26:31 +0100 > > Arnd Bergmann escreveu: > > > > > include/media/{ => drv-intf}/cx2341x.h | 0 > > include/media/{ => drv-i

[PATCH] staging: wilc1000: remove new line around else and braces

2015-11-13 Thread Panayiotis Tembriotis
Remove excess new line characters as suggested by checkpatch.pl: ERROR: else should follow close brace '}' ERROR: that open brace { should be on the previous line Signed-off-by: Panayiotis Tembriotis --- drivers/staging/wilc1000/wilc_wlan.c | 10 +++--- 1 file changed, 3 insertions(+), 7 del

RE: [PATCH] staging: comedi: adv_pci_dio: separate out PCI-1760 support

2015-11-13 Thread Hartley Sweeten
On Friday, November 13, 2015 2:39 PM, kbuild test robot wrote: > Hi Hartley, > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.3 next-20151113] > > url: > https://github.com/0day-ci/linux/commits/H-Hartley-Sweeten/staging-comedi-adv_pci

RE: [PATCH] staging: comedi: adv_pci_dio: separate out PCI-1760 support

2015-11-13 Thread Hartley Sweeten
On Friday, November 13, 2015 2:39 PM, kbuild test robot wrote: > Hi Hartley, > > [auto build test ERROR on staging/staging-testing] > [also build test ERROR on v4.3 next-20151113] > > url: > https://github.com/0day-ci/linux/commits/H-Hartley-Sweeten/staging-comedi-adv_pci

Re: [PATCH] staging: comedi: adv_pci_dio: separate out PCI-1760 support

2015-11-13 Thread kbuild test robot
Hi Hartley, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.3 next-20151113] url: https://github.com/0day-ci/linux/commits/H-Hartley-Sweeten/staging-comedi-adv_pci_dio-separate-out-PCI-1760-support/20151113-063034 config: microblaze-allmodconfig (attached as

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Arnd Bergmann
On Friday 13 November 2015 17:13:41 Mauro Carvalho Chehab wrote: > Em Wed, 11 Nov 2015 21:26:31 +0100 > Arnd Bergmann escreveu: > > include/media/{ => drv-intf}/cx2341x.h | 0 > include/media/{ => drv-intf}/cx25840.h | 0 > include/media/{ => drv-intf}/exynos

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Geert Uytterhoeven
On Fri, Nov 13, 2015 at 8:13 PM, Mauro Carvalho Chehab wrote: >> I think the latter should go into include/linux/platform_data/media/*.h >> instead. > > Agreed. > > Please see the enclosed patch: > > > Subject: [PATCH] [media] include/media: move platform driver headers to a > separate dirs > >

[PATCH v2] staging: comedi: adv_pci_dio: separate out PCI-1760 support

2015-11-13 Thread H Hartley Sweeten
The PCI-1760 is board unique. It uses an outgoing/incoming mailbox programming sequence to access the hardware. The other boards supported by this driver use simple register mapping. Including support for the PCI-1760 in this driver just makes it harder to understand. Separate out the PCI-1760 sup

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Mauro Carvalho Chehab
Em Wed, 11 Nov 2015 21:26:31 +0100 Arnd Bergmann escreveu: > On Wednesday 11 November 2015 15:14:48 Mauro Carvalho Chehab wrote: > > rename include/media/{ => platform}/exynos-fimc.h (100%) > > rename include/media/{ => platform}/mmp-camera.h (100%) > > rename include/media/{ => platform}/omap

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Jubin John
On Fri, Nov 13, 2015 at 01:03:44PM -0500, Jubin John wrote: > On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > > > This patch fixes the checkpatch is

[PATCH v2 19/23] staging: comedi: adv_pci1710: tidy up pci1710_reset()

2015-11-13 Thread H Hartley Sweeten
Change the return type to void, this function always succeeds and the caller does not check the return value anyway. Fix the initial programming of the control register. The SW bit enables the software trigger and should not be set here. Setting CNT0 selects the external clock source for counter 0

[PATCH v2 18/23] staging: comedi: adv_pci1710: ai (*cancel) should not enable software trigger

2015-11-13 Thread H Hartley Sweeten
The (*cancel) operation should do just that. Remove the setting of the SW bit which enables the software trigger. For aesthetics, rename the function so it has namespace associated with the driver and add a couple comments. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH v2 06/23] staging: comedi: adv_pci1710: remove 'n_aichan' boardinfo

2015-11-13 Thread H Hartley Sweeten
This member of the boardinfo isn't really necessary. All the boards have analog inputs, the pci1713 has 32 channels the rest have 16 channels. There is already a 'is_pci1713' member in the boardinfo so that can be used to determine the number of channels for the analog input subdevice. Signed-off

[PATCH 05/23] staging: comedi: adv_pci1710: define the mux control register bits

2015-11-13 Thread H Hartley Sweeten
For aesthetics, define some macros to set the bits in the mux control register. Also, rename the 'mux_ext' member of the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 14 +- 1 file changed, 9

[PATCH v2 07/23] staging: comedi: adv_pci1710: remove 'has_di_do' boardinfo

2015-11-13 Thread H Hartley Sweeten
This member of the boardinfo isn't really necessary. All the boards except the pci1713 have 16 digital inputs and 16 digital outputs. There is already a 'is_pci1713' member in the boardinfo so that can be used to determine the subdevices for the digital inputs and outputs need to be allocated and

[PATCH v2 02/23] staging: comedi: adv_pci1710: remove 'has_counter' boardinfo

2015-11-13 Thread H Hartley Sweeten
All the boards supported by this driver have a 8254 counter. Channels 1 and 2 are used to create the cascaded 32-bit analog input pacer. Counter 0 is available for the user on all the boards except the PCI-1713. Remove the 'has_counter' boardinfo and use the 'is_pci1713' boardinfo to determine if

[PATCH v2 15/23] staging: comedi: adv_pci1710: tidy up analog output subdev_flags

2015-11-13 Thread H Hartley Sweeten
Remove the SDF_COMMON flag, the analog reference is not programmable and the default aref (AREF_GROUND -> SDF_GROUND) provides adequate information about the reference. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 3 +

[PATCH v2 16/23] staging: comedi: adv_pci1710: tidy up analog input subdev_flags

2015-11-13 Thread H Hartley Sweeten
Remove the SDF_COMMON flag, the analog reference is not programmable and the default aref (AREF_GROUND -> SDF_GROUND) provides adequate information about the reference. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 2 +

[PATCH v2 23/23] staging: comedi: adv_pci1710: rename pci171x_ai_*()

2015-11-13 Thread H Hartley Sweeten
Rename these functions so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH v2 04/23] staging: comedi: adv_pci1710: refactor ai range programming

2015-11-13 Thread H Hartley Sweeten
The gain codes used to program the analog output range are currently stored in const char arrays. The values look a bit "magic" and it's not clear how they associate with the comedi_lrange without looking through user manuals. Refactor the ai range programming to clarify the driver and remove the

[PATCH v2 12/23] staging: comedi: adv_pci1710: rename pci171x_d[io]_insn_bits

2015-11-13 Thread H Hartley Sweeten
Rename these functions so they have namespace associated with the driver. For aesthetics, move the functions so they are not located in the middle of the analog input/output support functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/dr

[PATCH v2 09/23] staging: comedi: adv_pci1710: tidy up boardinfo definition

2015-11-13 Thread H Hartley Sweeten
Remove the unnecessary comments and rename the 'rangelist_ai' member for aesthetics. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/driv

[PATCH v2 14/23] staging: comedi: adv_pci1710: support external analog output reference

2015-11-13 Thread H Hartley Sweeten
The analog outputs can use an external reference to create the D/A output range. Add an entry to the comedi_lrange table for it and modify the (*insn_write) to support it. Note that the D/A output range is 0 to +Vref with a -Vref. The comedi_lrange does not include the sign of the range. It simmpl

[PATCH v2 17/23] staging: comedi: adv_pci1710: post increment 'subdev' in (*auto_attach)

2015-11-13 Thread H Hartley Sweeten
For aesthetics, post-increment the 'subdev' index when used to get a comedi_subdevice pointer instead of incrementing it after the subdevice is initialized. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 18 +---

[PATCH v2 20/23] staging: comedi: adv_pci1710: fix counter 0 internal clock source

2015-11-13 Thread H Hartley Sweeten
There are a number of descrepencies in the various manuals for the boards that this driver supports. Some show a 10 MHz clock for counters 1 and 2 others show a 1 MHz clock. Counter 0 can use either a div 10 of that clock or an external clock (up to 10 MHz). Currently this driver initializes count

[PATCH v2 21/23] staging: comedi: adv_pci1710: fix ai (*insn_read)

2015-11-13 Thread H Hartley Sweeten
An (*insn_read) can only happen if the subdevice is in a non-busy state, i.e. an async command is not running. The board reset and subdevice (*cancel) will ensure that the control bits (devpriv->ctrl) are already cleared. The (*insn_read) only needs to enable the software trigger before reading sa

[PATCH v2 22/23] staging: comedi: adv_pci1710: rename pci171x_ai_{cmd, cmdtest}()

2015-11-13 Thread H Hartley Sweeten
Rename these functions so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH v2 01/23] staging: comedi: adv_pci1710: remove 'has_irq' boardinfo

2015-11-13 Thread H Hartley Sweeten
All the boards supported by this driver can use an interrupt. Remove the unnecessary boardinfo. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/dri

[PATCH v2 08/23] staging: comedi: adv_pci1710: remove 'has_large_fifo' and 'has_diff_ai' boardinfo

2015-11-13 Thread H Hartley Sweeten
The pci1711/31 boards are the only ones that have a smaller FIFO (1K vs 4K) and single-ended analog inputs (no differential). Replace the 'has_large_fifo' and 'has_diff_ai' members of the boardinfo with 'is_pci1711' and use that to determine how to initialize the analog input subdev_flags as well

[PATCH v2 13/23] staging: comedi: adv_pci1710: rename pci171x_ao_insn_write()

2015-11-13 Thread H Hartley Sweeten
Rename this function so it has namespace associated with the driver. For aesthetics, move the function so it is located in the middle of the analog input support functions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c

[PATCH v2 03/23] staging: comedi: adv_pci1710: don't "reset" board when detaching

2015-11-13 Thread H Hartley Sweeten
Currently this driver calls pci1710_reset() during the (*detach) of the driver. That function does the following: 1) program the control register to stop any operations 2) clears the analog input FIFO 3) clears any pending interrupts 4) sets all the analog output channels to unipolar 5V ra

[PATCH v2 00/23] staging: comedi: adv_pci1710: tidy up driver

2015-11-13 Thread H Hartley Sweeten
Now that the PCI-1720 support has been moved to a separate driver, remove some unnecessary boardinfo in this driver and tidy it up a bit. v2: address some issues pointed out by Ian Abbott with the patches that support external analog output reference tidy up analog output subdev_flags

[PATCH v2 10/23] staging: comedi: adv_pci1710: rename interrupt_service_pci1710()

2015-11-13 Thread H Hartley Sweeten
Rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

[PATCH v2 11/23] staging: comedi: adv_pci1710: rename pci171x_insn_counter_config()

2015-11-13 Thread H Hartley Sweeten
Rename this function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ad

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Jubin John
On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > > This patch fixes the checkpatch issue: > > > CHECK: Prefer using the BIT macro > > > > > > Reviewed-b

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Jubin John
On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > This patch fixes the checkpatch issue: > > CHECK: Prefer using the BIT macro > > > > Reviewed-by: Dean Luick > > Reviewed-by: Ira Weiny > > Reviewed-by: Mike Marcini

[PATCH v2 5/5] Staging: dgnc: dgnc_tty: Typo error dgnc_wmove comment

2015-11-13 Thread Nizam Haider
Fix Typo errror in the comment of dgnc_wmove Signed-off-by: Nizam Haider --- drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 48e4b90..b79eab0 100644 --- a/drivers/staging/d

[PATCH v2 3/5] Staging: dgnc: dgnc_neo.c: Spaces preferred around operators

2015-11-13 Thread Nizam Haider
Fix Checkpatch warning CHECK: spaces preferred around that ' ' Signed-off-by: Nizam Haider --- drivers/staging/dgnc/dgnc_neo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 51462f9..e980150 100644

[PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement

2015-11-13 Thread Nizam Haider
Fix Checlpatch warning HECK: braces {} should be used on all arms of this statement Signed-off-by: Nizam Haider --- drivers/staging/dgnc/dgnc_neo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index e98

[PATCH v2 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line

2015-11-13 Thread Nizam Haider
Fix Checkpatch warning CHECK: Logical continuations should be on the previous line Signed-off-by: Nizam Haider --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c inde

[PATCH v2 1/5] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay

2015-11-13 Thread Nizam Haider
Fix ceckpatch warning Signed-off-by: Nizam Haider --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 8106f52..cf5bfc7 100644 --- a/drivers/staging/dgnc/dgnc_neo

Re: [PATCHv5 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-11-13 Thread Enric Balletbo Serra
Hi Rob, 2015-11-13 15:38 GMT+01:00 Rob Herring : > On Fri, Nov 13, 2015 at 01:01:02PM +0100, Enric Balletbo i Serra wrote: >> Analogix Semiconductor develops analog and mixed-signal devices for digital >> media and communications interconnect applications. >> >> Signed-off-by: Enric Balletbo i Ser

Re: [PATCHv5 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-11-13 Thread Rob Herring
On Fri, Nov 13, 2015 at 01:01:02PM +0100, Enric Balletbo i Serra wrote: > Analogix Semiconductor develops analog and mixed-signal devices for digital > media and communications interconnect applications. > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Rob Herring > --- > Documentation/dev

Re: [PATCHv5 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-11-13 Thread Rob Herring
On Fri, Nov 13, 2015 at 01:01:03PM +0100, Enric Balletbo i Serra wrote: > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > You can add support to your board with current binding. > > Example: > > anx7814: anx7814@38 { >

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

2015-11-13 Thread Sudip Mukherjee
On Mon, Nov 09, 2015 at 08:09:36PM +0530, punit vara wrote: > On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee > wrote: > > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: > >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > >> > > >> > > >> > On 2015년 11월 09일 18:05, punit vara wrote

[PATCH] driver:staging:dgnc Fix spaces preferred around that ...

2015-11-13 Thread Bogicevic Sasa
This fixes all "spaces preferred around that ..." messages from checkpatch.pl Signed-off-by: Bogicevic Sasa --- drivers/staging/dgnc/dgnc_neo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 8106f5

[PATCH] drivers:staging:fwserial Fix No space is necessary after a cast

2015-11-13 Thread Bogicevic Sasa
This fixes all "No space is necessary after a cast" messages Signed-off-by: Bogicevic Sasa --- drivers/staging/fwserial/fwserial.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index b

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Sudip Mukherjee
On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > This patch fixes the checkpatch issue: > CHECK: Prefer using the BIT macro > > Reviewed-by: Dean Luick > Reviewed-by: Ira Weiny > Reviewed-by: Mike Marciniszyn > Signed-off-by: Jubin John > --- > > diff --git a/drivers/staging/rd

Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

2015-11-13 Thread Shivani Bhardwaj
On Fri, Nov 13, 2015 at 6:33 PM, Sudip Mukherjee wrote: > > On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote: > > On Wed, Nov 11, 2015 at 11:01 PM, Greg KH > > wrote: > > > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote: > > >> On Wed, Nov 11, 2015 at 4:24 PM, k

Re: [PATCH] staging: lustre: cl_lock: Remove cl_lock_lockdep_init wrapper

2015-11-13 Thread Sudip Mukherjee
On Wed, Nov 11, 2015 at 11:03:34PM +0530, Shivani Bhardwaj wrote: > On Wed, Nov 11, 2015 at 11:01 PM, Greg KH wrote: > > On Wed, Nov 11, 2015 at 10:51:36PM +0530, Shivani Bhardwaj wrote: > >> On Wed, Nov 11, 2015 at 4:24 PM, kbuild test robot wrote: > >> > >> I'm not getting any of these errors

Re: [PATCH 2/2] Staging: dgnc: dgnc_neo.c: checkpatch cleanup

2015-11-13 Thread Sudip Mukherjee
On Fri, Nov 13, 2015 at 04:48:11PM +0530, Nizam Haider wrote: > This patch fixes several warning during checkpatch > > 355: CHECK: Logical continuations should be on the previous line > : CHECK: braces {} should be used on all arms of this statement > 1631: CHECK: spaces preferred around that

[PATCHv5 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-11-13 Thread Enric Balletbo i Serra
The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. You can add support to your board with current binding. Example: anx7814: anx7814@38 { compatible = "analogix,anx7814"; reg = <0x38>; pd

[PATCHv5 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-11-13 Thread Enric Balletbo i Serra
At the moment it only supports ANX7814. The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. This driver adds initial support and supports HDMI to DP pass-through mode. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/Kconfig

[PATCHv5 0/3] Add initial support for slimport anx78xx

2015-11-13 Thread Enric Balletbo i Serra
Hi all, This is the fifth version of patch set. Any comments are welcome. See the changelog below for details. The following series add initial support for the Slimport ANX7814 transmitter, a ultra-low power Full-HD (1080p60) transmitter designed for portable device. The driver was originally c

[PATCHv5 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-11-13 Thread Enric Balletbo i Serra
Analogix Semiconductor develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/2] Staging: dgnc: dgnc_neo.c: checkpatch cleanup

2015-11-13 Thread Nizam Haider
This patch fixes several warning during checkpatch 355: CHECK: Logical continuations should be on the previous line : CHECK: braces {} should be used on all arms of this statement 1631: CHECK: spaces preferred around that '|' (ctx:VxV) 1782: CHECK: spaces preferred around that '*' (ctx:VxV) 17

[PATCH 1/2] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay

2015-11-13 Thread Nizam Haider
removed heckpatch warning Signed-off-by: Nizam Haider --- drivers/staging/dgnc/dgnc_neo.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 8106f52..cf5bfc7 100644 --- a/drivers/staging/dgnc/dgnc

Re: [PATCH] staging: comedi: adv_pci_dio: separate out PCI-1760 support

2015-11-13 Thread Ian Abbott
On 12/11/15 22:28, H Hartley Sweeten wrote: The PCI-1760 board unique. It uses a outgoing/incoming mailbox programming I wouldn't normally complain, but if you're going to repost, the word "is" is missing in the first sentence. sequence to access the hardware. The other boards supported by

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

2015-11-13 Thread Arnd Bergmann
On Friday 13 November 2015 16:49:22 glen lee wrote: > > Hi arnd, > > I found this. These should be like this. It works fine. > + .hif_block_tx_ext = sdio_write, > + .hif_block_rx_ext = sdio_read, > > also, wilc_hif_spi need to be fixed together like this. > + .hif_block_tx_ext