From: Shailendra Verma
The module end was not aligned as of module start and boundary
check for module end is not proper.This out of bound value of
module end can produce undesired results.
Reported-by: Hillf Danton
Signed-off-by: Shailendra Verma
Reviewed-by: Ravikant Bijendra Sharma
---
li
From: Shailendra Verma
The module end was not aligned as of module start, so
aligning end also.
Signed-off-by: Shailendra Verma
Reviewed-by: Ravikant Bijendra Sharma
---
linux-4.3-rc6/arch/arm64/mm/pageattr.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/linux-4.
On Mon, Nov 16, 2015 at 04:57:34PM -0800, Laura Abbott wrote:
> + for_each_available_child_of_node(dt_node, node) {
> + struct platform_device *heap_pdev;
> +
> + ret = ion_parse_dt_heap_common(node, &heaps[i], compatible);
> + if (ret)
> +
On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote:
> Now that all drivers are using the mtd instance embedded in the nand_chip
Do you have a script that verifies this? I thought you did at some
point, and it'd be nice to note it, so I can also use it to verify
things once it gets app
From: Mike Marciniszyn
The current is_bx() will incorrectly match on other steppings.
is_a0() is removed in favor of is_ax().
Reviewed-by: Mark Debbage
Signed-off-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 44 ++---
Change the default number of krcvqs to number of numa nodes + 1
based on the performance data collected.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rdma/hf
From: Dean Luick
Add a new EPROM partition, adjusting partition placement.
Add EPROM range commands as a supserset of the partition
commands. Remove old partition commands.
Enhance EPROM erase, creating a range function and using the
largest erase (sub) commands when possible.
Reviewed-by: De
Hi Boris,
On Mon, Nov 16, 2015 at 02:37:47PM +0100, Boris Brezillon wrote:
> struct nand_chip now embeds an mtd device. Patch all drivers to make use
> of this mtd instance instead of using the instance embedded in their
> private struct or dynamically allocated.
>
> Signed-off-by: Boris Brezillo
From: Vennila Megavannan
Added the following per sdma engine stats:
- SendDmaDescFetchedCnt
- software maintained count of SDMA interrupts
(SDmaInt, SDmaIdleInt, SDmaProgressInt)
- software maintained counts of SDMA error cases
Reviewed-by: Dennis Dalessandro
Signed-off-by: Mike
From: Dean Luick
Read an EFI variable for the device description. Create the
infrastructure for additional variable reads.
Reviewed-by: Easwar Hariharan
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/Makefile |2 +-
drivers/staging/rdma/hfi1/chip.c |
From: Dean Luick
The variable "index" increments the same as dd->ndevcntrs.
Just use the later. Remove uneeded usage of "index" in the
fill loop - it is not used there or later in the function.
Reviewed-by: Dennis Dalessandro
Signed-off-by: Dean Luick
Signed-off-by: Jubin John
---
drivers/s
Space between concantenated string elements is more human
readable and fixes the checkpatch issue:
CHECK: Concatenated strings should use spaces between elements
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c | 10 +-
drivers/staging/rdm
From: Ira Weiny
Rcv bubbles were improperly calculated for HFIs, fix that here.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Arthur Kepner
Signed-off-by: Ira Weiny
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/mad.c | 64 +-
1 files changed, 2 i
From: Harish Chegondi
This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send
function when invoked from post_send thereby improving performance of
post_send.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Harish Chegondi
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/ve
From: Vennila Megavannan
Removed the RxCtxRHQS counter being dumped into dev_cntrs
Reviewed-by: Dennis Dalessandro
Signed-off-by: Vennila Megavannan
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/chip.c |2 --
drivers/staging/rdma/hfi1/chip.h |1 -
driver
This patch fixes the checkpatch issue:
CHECK: Prefer using the BIT macro
Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in
format specifier for error message in init.c in order to avoid a
build warning.
Reviewed-by: Dean Luick
Reviewed-by: Ira Weiny
Reviewed-by: Mike Marciniszyn
From: Dean Luick
A link downgrade can race with link up. Avoid the race
in two ways. First, by having the downgrade application logic
take the link state mutex for all of its checking. Second, by
waiting for the link to move out of the going up state.
Reviewed-by: Dennis Dalessandro
Signed-off-
From: Mark F. Brown
The krcvqs parameter is displayed incorrectly in sysfs.
The workaround is to set the param type as uint.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Mark F. Brown
Signed-off-by: Jubin John
---
drivers/staging/rdma/hfi1/hfi.h |2 +-
driv
Rebased this series on top of latest staging-next branch
Changes in v2:
01/13: Updated commit message with more information about changes in patch
04/13: Updated patch subject with "hfi1" instead of "hfi"
07/13: Refreshed patch based on new hfi patches in staging-next
12/13: Changed logic based on
Small sample driver to show what setup would look like with the dt
bindings
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/Kconfig | 6 ++
drivers/staging/android/ion/Makefile| 1 +
drivers/staging/android/ion/ion_of_sample.c | 96 +
3
Devicetree is the preferred mechanism for platform definition
these days. Add a set of files for supporting Ion with devicetree.
This is a set of functions for drivers to call to parse the Ion
devicetree along with definitons for defining heaps.
Signed-off-by: Laura Abbott
---
drivers/staging/
Hi,
This is another attempt at devicetree bindings for Ion. The big complaint from
v1 was that too much unnecessary data was being pushed into devicetree.
v2 takes a different approach of using just compatbile strings for the heaps.
This gets closer to the devicetree philosophy of describing jus
This adds a base set of devicetree bindings for the Ion memory
manager. This supports setting up the generic set of heaps and
their properties.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/devicetree.txt | 50 ++
1 file changed, 50 insertions(+)
creat
FROM THE DESK OF MR. WALI IBRAHIM
INTERNATIONAL MONETARY FUND AGENCY
INTERNATIONAL OPERATION DEPT
VICTORIA ISLAND
LAGOS-NIGERIA.
RE-OUTSTANDING PAYMENT
This is to inform you of your long overdue Payment outstanding our Banking
records. I saw your name in the Central Computer among list of unpaid
From: Dennis Dalessandro
Now that the spinlock is not taken throughout hfi1_ioctl it is safe to return
early rather than setting a variable and falling through the switch.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
Changes from V1:
Sq
From: Ira Weiny
Rather than have a switch in a large else clause make the parameter checks
return immediately.
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 348 +++
1 file changed, 173 insertions(+), 175
From: Dennis Dalessandro
This patch avoids issues while calling into copy from/to user while holding the
lock by only taking the lock when it is absolutely required.
The only commands which require the snoop lock are: *Set Filter *Clear Filter
*Clear Queue
Reviewed-by: Mike Marciniszyn
Signed-
From: Ira Weiny
Set link state is not supported remove from the switch statement and allow the
default to return -ENOTTY
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
Changes from v1:
Just remove the check for SETLINKSTATE and allow the switch to default
to -E
From: Ira Weiny
Final clean up of the if/then/else clause for the parameter checks of
hfi1_ioctl
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
Changes from v1:
SETLINKSTATE is removed
drivers/staging/rdma/hfi1/diag.c | 23 +--
1 file changed, 13
From: Ira Weiny
It was identified that hfi1_ioctl may sleep with a spin lock held.
This was identified publicly here:
http://www.spinics.net/lists/linux-rdma/msg29926.html
As well as by our internal development.
This series cleans up the code and parameter checks, as well as fixing the
lockin
From: Jubin John
Correct the checks on diag.c with the latest checkpatch
Reviewed-by: Dennis Dalessandro
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 81 ++--
1 file changed, 37 in
From: Ira Weiny
physState, linkState, and devState should be phys_state, link_state, and
dev_state
Signed-off-by: Dennis Dalessandro
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/diag.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/dri
Cleanup errors from checkpatch.pl.
Signed-off-by: Othmar Pasteka
---
drivers/staging/vt6656/baseband.c | 4
drivers/staging/vt6656/baseband.h | 4
drivers/staging/vt6656/card.c | 3 ---
drivers/staging/vt6656/card.h | 3 ---
drivers/staging/vt6656/channel.c | 4
drivers/s
From: Dean Luick
Correctly set half-swing for integrated devices. A0 needs all fields set for
CcePcieCtrl. B0 and later only need a few fields set.
Reviewed-by: Stuart Summers
Signed-off-by: Dean Luick
Signed-off-by: Ira Weiny
---
Changes from V1:
Add comments concerning the very l
On Wed, Nov 11, 2015 at 11:22:15AM +0300, Dan Carpenter wrote:
> On Wed, Nov 11, 2015 at 02:33:30AM -0500, Jubin John wrote:
> > @@ -8288,6 +8367,21 @@ static int init_cntrs(struct hfi1_devdata *dd)
> > dd->ndevcntrs++;
> > index++;
> >
On Sat, Nov 14, 2015 at 12:41:02PM +0530, Sudip Mukherjee wrote:
> On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote:
> > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote:
> > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote:
> > > > This patch fixes the checkpat
From: Tim Sell
Whenever the absolute x,y resolution of the video (and mouse) changes, the
back-end sends an inputaction_set_max_xy message indicating the new
resolution. This commit adds the infrastructure to detect and correctly
respond to that message.
There were several reasons this wasn't a
This patch series fixes visorinput to remove the dependency on FB and
add dependency to INPUT, cleans up some formatting issues found with
checkpatch.pl, and adds the capability to change screen resolutions
without breaking mouse functionality.
This is a resubmission of the series.
Tim Sell (7):
From: Tim Sell
This was an obvious omission, as visorinput is an input-class driver.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/staging/unisys/visorinput/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
From: Tim Sell
Ensure we properly lock between visorinput_channel_interrupt() and
devdata_create(). We now guarantee that interrupts will be disabled and
we will be holding lock_visor_dev at the time input_register_device() is
called (from register_client_keyboard() or register_client_mouse()),
From: Tim Sell
Previously, we used a hack to determine the max x,y resolution of the
visor virtual mouse: we just looked at the resolution of the
first-registered framebuffer device, using the currently-valid assumption
that in a Unisys s-Par guest environment the video will be provided by an
efi
From: Tim Sell
The dev_info() messages at init time are particularly useful for mapping
visor devices to input devices.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/staging/unisys/visorinput/visorinput.c | 11 +++
1 file changed
From: Tim Sell
This is NOT technically required for the code as it stands now, but will
be needed for subsequent patches.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: resources are released in the reverse order they were acquired, as per
Dan Carpenter's comment.
---
driv
From: Tim Sell
This commit sanity checks so that if a change resolution request is ever
received for a non-mouse device, that an error message will be logged and
the message will be ignored.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
v2: the patch was resubmitted.
---
drivers/
Dan Carpenter writes:
> On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote:
>> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const
>> char __user *buf,
>> return PTR_ERR(inmsg);
>>
>> if (hvt->on_msg(inmsg, count))
>> -return -EF
On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
> drivers/staging/comedi/drivers/dmm32at.c |4 +
Added a blank line after declarations to remove the coding
style error detected by the checkpatch.pl.
WARNING: Missing a blank line after declarations
Signed-off-by: Anjali Menon
---
drivers/staging/rdma/ehca/ehca_av.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rdma/
BIT macro is used for defining BIT location instead of
shifting operator, usleep_range is preferred over
udelay - coding style issue
Signed-off-by: Ranjith Thangavel
---
drivers/staging/comedi/drivers/dmm32at.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/st
BIT macro is used for defining BIT location instead of
shifting operator, usleep_range is preferred over
udelay - coding style issue
Signed-off-by: Ranjith Thangavel
---
drivers/staging/comedi/drivers/dmm32at.c | 100 +++---
1 file changed, 50 insertions(+), 50 deletions
On Mon, Nov 16, 2015 at 12:02:51PM -0500, ira.weiny wrote:
> On Mon, Nov 16, 2015 at 07:29:46PM +0300, Dan Carpenter wrote:
> > Ville Syrjälä already posted the answer but his email had no text just a
> > link inside 300+ lines of quoted output so you may have missed it.
>
> AFAICS I have not rece
BIT macro is used for defining BIT location instead of
shifting operator, usleep_range is preferred over
udelay - coding style issue
Signed-off-by: Ranjith Thangavel
---
drivers/staging/comedi/drivers/dmm32at.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/st
On Mon, Nov 16, 2015 at 07:29:46PM +0300, Dan Carpenter wrote:
> Ville Syrjälä already posted the answer but his email had no text just a
> link inside 300+ lines of quoted output so you may have missed it.
AFAICS I have not received anything from Ville.
Thanks for the heads up,
Ira
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue
Signed-off-by: Ranjith Thangavel
---
drivers/staging/comedi/drivers/ni_6527.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/driv
On Mon, Nov 16, 2015 at 11:12:24AM -0500, ira.weiny wrote:
> On Mon, Nov 16, 2015 at 10:00:04AM -0500, ira. weiny wrote:
> > On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote:
> > > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote:
> > > > With the latest staging-testing and staging-
Ville Syrjälä already posted the answer but his email had no text just a
link inside 300+ lines of quoted output so you may have missed it.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.or
On Mon, Nov 16, 2015 at 10:00:04AM -0500, ira. weiny wrote:
> On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote:
> > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote:
> > > With the latest staging-testing and staging-next[*] I am getting the
> > > following panic.
> > >
> > > [*] g
On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote:
> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char
> __user *buf,
> return PTR_ERR(inmsg);
>
> if (hvt->on_msg(inmsg, count))
> - return -EFAULT;
> + ret = -
Hi Glen,
It's probably a bug fix that unveils the link errors.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 4811789503d16510a8a6610fb6c4097e1efa6312
commit: b22fa80cdbf4ff1056ecddb4efdcc0ede5f5f422 [203/404] staging: wilc1000:
fix kbuild tes
On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote:
> On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote:
> > With the latest staging-testing and staging-next[*] I am getting the
> > following panic.
> >
> > [*] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> So
On Sat, Nov 14, 2015 at 09:17:56PM +0300, Alexey Khoroshilov wrote:
> Commit af8a819a2513 ("[media] lirc_imon: simplify error handling code")
> lost mutex_unlock(&context->ctx_lock), so imon_probe() exits with
> the context->ctx_lock mutex acquired.
>
> The patch adds mutex_unlock(&context->ctx_lo
In case of error we are jumping to err_del_scsipending_ent and always
returning SCSI_MLQUEUE_DEVICE_BUSY from error path. We donot need a
variable to return a fixed error value, it can be returned directly.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorhba/visorhba_main.c | 12 +
The variables op, sd and zmotion were never being used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorhba/visorhba_main.c | 4
drivers/staging/unisys/visorinput/visorinput.c | 4 +---
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/viso
This one is buggy. For example:
> -#define DMM32AT_FIFO_STATUS_PAGE_MASK(3 << 0)
> +#define DMM32AT_FIFO_STATUS_PAGE_MASK0
There are other bugs as well. Please, be more careful.
regards,
dan carpenter
___
devel mailing list
de...@linu
On Sat, Nov 14, 2015 at 06:43:23PM +0530, Ranjith Thangavel wrote:
> @@ -221,11 +223,11 @@ static int ni6527_intr_cmdtest(struct comedi_device
> *dev,
>
> /* Step 1 : check if triggers are trivially valid */
>
> - err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW);
> - er
struct wilc has two pointers to store the device, one for sdio_func
and one for spi_device. By changing the pointer to a 'struct device',
we can simplify the logic and avoid a few #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 25 +++-
d
As a preparation for turning the SDIO side of wilc1000 into a separate
module, this removes the last direct caller from the core module into
the sdio specific portion. All calls to wilc_sdio_enable_interrupt()
and wilc_sdio_disable_interrupt() now go through a function pointer
in wilc_hif_func. We
So far, my patches tried to do equivalent conversions of the
existing code. This one goes beyond that by restructuring
how the devices get probed. In particular, the spi driver
no longer creates the netdev until the device is probed,
and I've removed the global wilc_sdio_func and wilc_spi_dev
vari
Whether the SDIO function uses an internal or external interrupt
should not be a compiletime decision but be determined at runtime.
This changes the code to pass a GPIO number from the init code
as early as possible, and leaves just one #ifdef WILC_SDIO_IRQ_GPIO
to preserve the previous behavior.
We want to get rid of all global variables in this driver, and
instead pass device structures from one function to another.
This changes the linux_wlan.c and wilc_wlan.c to do this
for the most part. There are a few exceptions where these
functions are themselves called from another part of the dri
The wilc_hif_spi and wilc_hif_sdio structures are part of
the bus specific code, and the generic code should have no knowledge
of their addresses.
This changes the code to reference them only from the bus
specific initialization code, which we can then use to split
up the driver into separate modu
In order to avoid some of the #ifdefs, this passes the io_type
and device pointer as an argument to wilc_netdev_init.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 18 --
drivers/staging/wilc1000/linux_wlan_sdio.c| 4 ++--
drivers/staging/w
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so
this is where the init and exit functions should be. Splitting this up
enables further cleanups, including eventually allowing both modules
to be built together.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linu
The last remaining user of WILC_SDIO macro checks for the correct
time to wait in an interrupt for the PLL to settle. We can
replace this with a runtime check and remove both WILC_SDIO and
WILC_SPI, as we no longer need conditional compilation based on
the hardware type.
Signed-off-by: Arnd Bergma
As suggested by Glen Lee, I'm sending the patches once more with the
two one-line fixes in "staging/wilc1000: pass hif operations through
initialization".
I have rebased on top of today's staging-testing, but no other changes
were necessary, so this is otherwise identical to the version that
Glen
The driver provides an interface for custom power management
and detection that is meant to be filled by people customizing
the driver. The default implementation of this is empty, and
we don't actually want people to have to modify the source code.
If anybody needs this, they need to describe the
On Monday 16 November 2015 10:36:47 glen lee wrote:
> On 2015년 11월 13일 18:17, Arnd Bergmann wrote:
> > On Friday 13 November 2015 16:49:22 glen lee wrote:
> >> Hi arnd,
> >>
> >> I found this. These should be like this. It works fine.
> >> + .hif_block_tx_ext = sdio_write,
> >> + .hif_b
The wilc_wfi_cfgoperations.h header defines the ieee80211_txrx_stypes
and cipher_suites variables that are only used in wilc_wfi_cfgoperations.c
and should not be shared in a header file.
This moves over all that data into the .c file, and also moves all
the macro definitions from the file that ar
There are many global symbols in the wilc1000 driver, some of them
with names like "DEBUG_LEVEL" or "probe" that are not acceptable
for globals in the linux kernel as they may easily conflict with other
(equally broken) drivers.
This renames all the globals that do not already start with
wilc or a
A number of symbols in the wilc1000 driver are completely unused
and can be removed.
This includes two variables that are only written but not read.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c | 295 --
drivers/staging/wilc1000/host_inte
The SPI and SDIO specific code is now separate enough that
we just need to restructure the Makefile and Kconfig logic
a bit and export a couple of symbols from the common module
to have separate bus glue drivers.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Kconfig| 66 +
wilc_create_wiphy tries to get a pointer to a device from the
global wilc_sdio_func variable. This is a layering violation
and we can use the wilc_dev->dev pointer instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/linux_w
'extern' declarations belong into a header file rather than
a .c file, to ensure that the definition matches the declaration.
This moves all declarations into a header file that seems
most appropriate for it.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/host_interface.c |
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c
to have knowledge of the specific sdio and spi front-ends. This
removes the structure and places io_type directly inside the struct wilc.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 21 ++
The linux_wlan.c file uses a set of enums from wilc_wlan_if.h,
with the exception of the NO_ENCRYPT that comes from
wilc_wfi_cfgoperations.h. The two sets of enums clearly have
the same intention but are defined a bit different.
To prepare to clean up the ones in wilc_wfi_cfgoperations.h, this
fir
All symbols that are only referenced in the file that defines
them can be declared 'static' to avoid namespace pollution,
to produce better object code, and to make the source more
readable.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 3 +-
drivers/stagi
Simplify the code with list_first_entry_or_null().
Signed-off-by: Geliang Tang
---
drivers/staging/emxx_udc/emxx_udc.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
in
New helpers have been added to avoid directly accessing chip->field. Use
them where appropriate.
Signed-off-by: Boris Brezillon
---
arch/arm/mach-ixp4xx/ixdp425-setup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-ixp4xx/ixdp425-setup.c
b/arch/arm/mach-i
New helpers have been added to avoid directly accessing chip->field. Use
them where appropriate.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/ams-delta.c | 6 +--
drivers/mtd/nand/atmel_nand.c| 54 ++---
drivers/mtd/nand/bcm47xxnflash/main.
struct nand_chip now embeds an mtd device. Patch all drivers to make use
of this mtd instance instead of using the instance embedded in their
private struct or dynamically allocated.
Signed-off-by: Boris Brezillon
Cc: Julia Lawall
---
Most of those changes were generate with this coccinelle scri
Add two helpers to access the field reserved for private controller data.
This makes it clearer what this field is reserved for and ease future
refactoring.
Signed-off-by: Boris Brezillon
---
include/linux/mtd/nand.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/linux/m
New helpers have been added to avoid directly accessing chip->field. Use
them where appropriate.
Signed-off-by: Boris Brezillon
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spi
struct nand_chip now embeds an mtd device. Patch all drivers to make use
of this mtd instance instead of using the instance embedded in their
private struct or dynamically allocated.
Signed-off-by: Boris Brezillon
---
Most of those changes were generate with this coccinelle script:
http://code.bu
nand_dt_init() function requires 3 arguments where it actually needs one
(dn and mtd can both be retrieved from chip). Drop these parameters.
Testing for dn != NULL inside nand_dt_init() also helps simplifying the
caller code.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/nand_base.c | 21
struct nand_chip now embeds an mtd device, use it instead of allocating
a new one.
Signed-off-by: Boris Brezillon
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c
b/drivers/stag
Now that the nand_chip struct directly embeds an mtd_info struct we can
get rid of the ->flash_node field and forward set/get_flash_node requests
to the MTD layer.
As a side effect, we no longer need the mtd_set_of_node() call done in
nand_dt_init().
Signed-off-by: Boris Brezillon
---
drivers/m
mtd_to_nand_chip() now uses the container_of() approach to transform an
mtd_info pointer into a nand_chip one. Drop useless mtd->priv
assignments from NAND controller drivers.
Signed-off-by: Boris Brezillon
---
Patch generated with the following coccinelle script:
---8<
virtual patch
@@
str
mtd_to_nand() was recently introduced to avoid direct accesses to the
mtd->priv field. Update all NAND drivers to use it.
Signed-off-by: Boris Brezillon
---
drivers/mtd/nand/ams-delta.c | 4 +-
drivers/mtd/nand/atmel_nand.c| 50 ++---
drivers/mtd/
Now that all drivers are using the mtd instance embedded in the nand_chip
struct we can safely update the mtd_to_nand_chip() implementation to use
the container_of macro instead of returning the content of mtd->priv.
This will allow us to remove mtd->priv = chip assignments done in all
NAND control
mtd_to_nand_chip() now uses the container_of() approach to transform an
mtd_info pointer into a nand_chip one. Drop useless mtd->priv
assignments from NAND controller drivers.
Signed-off-by: Boris Brezillon
---
Patch generated with the following coccinelle script:
---8<
virtual patch
@@
str
The MTD device is now directly embedded in the nand_chip struct. Update the
mtdnand documentation to mention this aspect and fix the different
examples.
Signed-off-by: Boris Brezillon
---
Documentation/DocBook/mtdnand.tmpl | 31 +++
1 file changed, 15 insertions(+), 1
1 - 100 of 138 matches
Mail list logo
