ATTENTION

2015-11-24 Thread Dr. Godwin Emefiele
FROM THE DESK OF Dr GODWIN EMEFIELE CENTRAL BANK GOVERNOR (CBN) Federal Republic of Nigeria ATTN:SIR/MADAM I am Dr GODWIN EMEFIELE, the CENTRAL BANK GOVERNOR (CBN) I decided to contact you because of the prevailing security report reaching my office and the intense nature of polity in Nige

ATTENTION

2015-11-24 Thread Dr. Godwin Emefiele
FROM THE DESK OF Dr GODWIN EMEFIELE CENTRAL BANK GOVERNOR (CBN) Federal Republic of Nigeria ATTN:SIR/MADAM I am Dr GODWIN EMEFIELE, the CENTRAL BANK GOVERNOR (CBN) I decided to contact you because of the prevailing security report reaching my office and the intense nature of polity in Nige

[PATCH 09/10] staging: wilc1000: change if with else if

2015-11-24 Thread Glen Lee
From: Leo Kim The if statement should be else if since it is part of whole if condition. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/host_i

[PATCH 07/10] staging: wilc1000: wilc_deinit(): fixes inconsistent returns

2015-11-24 Thread Glen Lee
From: Leo Kim This patch fixes the warning reported by smatch. - wilc_deinit() warn: inconsistent returns 'sem:&hif_drv->sem_cfg_values' This semaphore protect a cfg_values variable but cfg_values variables was not used here. So, just remove this line. Signed-off-by: Leo Kim Signed-off-by: Gl

[PATCH 10/10] staging: wilc1000: Handle_SetMulticastFilter(): fixes right shifting more than type allows

2015-11-24 Thread Glen Lee
From: Leo Kim This patch fixes the warning reported by smatch. - Handle_SetMulticastFilter() warn: right shifting more than type allows That is unnecessary action of boolean type. just assign 0. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 6

[PATCH 08/10] staging: wilc1000: Handle_AddBASession: remove unused function

2015-11-24 Thread Glen Lee
From: Leo Kim This patch removes unused a function Handle_AddBASession. And, removes the relation define. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 69 --- 1 file changed, 69 deletions(-) diff --git a/drivers/st

[PATCH 06/10] staging: wilc1000: wilc_init(): fixes inconsistent returns

2015-11-24 Thread Glen Lee
From: Leo Kim This patch fixes the warning reported by smatch. - wilc_init() warn: inconsistent returns 'sem:&hif_drv->sem_cfg_values' No need to up the sema here since down was not called before get here. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_inte

[PATCH 04/10] staging: wilc1000: replace explicit NULL comparisons with !

2015-11-24 Thread Glen Lee
From: Leo Kim This patch replace explicit NULL comparison with ! operator to simplify code. Reported by checkpatch.pl for Comparison to NULL could be written !XXX" or "XXX". Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 31

[PATCH 05/10] staging: wilc1000: fixes potential null dereference 'wid.val'

2015-11-24 Thread Glen Lee
From: Leo Kim This patch fixes the error reported by smatch. - Handle_ListenStateExpired() error: potential null dereference 'wid.val' If kmalloc failed, referenced to a NULL pointer. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/host_interface.c | 4 +++- 1 fil

[PATCH 02/10] staging: wilc1000: wilc_wfi_cfgoperations.c: remove over-commenting

2015-11-24 Thread Glen Lee
From: Leo Kim There are over-commenting in the wilc_wfi_cfgoperations.c file and most of them are not helpful to explain what the code does and generate 80 ending line over warnings. So, all of comments are removed in this patch and the comments will later be added if necessary with the preferred

[PATCH 03/10] staging: wilc1000: fixes blank lines aren't necessary brace

2015-11-24 Thread Glen Lee
From: Leo Kim This patch fixes the checks reported by checkpatch.pl for Blank lines aren't necessary after an open brace '{' and Blank lines aren't necessary before a close brace '}'. Signed-off-by: Leo Kim Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 50 ---

[PATCH 01/10] staging: wilc1000: fix rmmod failure

2015-11-24 Thread Glen Lee
This patch fixes rmmod failure. wilc->firmware needs to be set to NULL because it is used again to check firmware is released when module exit. Fixes: 8b8ad7bc90bc ("staging: wilc1000: rename wilc_firmware in the struct wilc") Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c |

[PATCH RESEND v3 10/11] staging: fsl-mc: Added DPRC interrupt handler

2015-11-24 Thread J. German Rivera
The interrupt handler for DPRC IRQs is added. DPRC IRQs are generated for hot plug events related to DPAA2 objects in a given DPRC. These events include, creating/destroying DPAA2 objects in the DPRC, changing the "plugged" state of DPAA2 objects and moving objects between DPRCs. Signed-off-by: J.

[PATCH RESEND v3 01/11] irqdomain: Added domain bus token DOMAIN_BUS_FSL_MC_MSI

2015-11-24 Thread J. German Rivera
Since an FSL-MC bus is a new bus type that is neither PCI nor PLATFORM, we need a new domain bus token to disambiguate the IRQ domain for FSL-MC MSIs. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: none include/linux/irqdomain.h | 1 + 1 file changed, 1

[PATCH RESEND v3 04/11] staging: fsl-mc: Added GICv3-ITS support for FSL-MC MSIs

2015-11-24 Thread J. German Rivera
Added platform-specific MSI support layer for FSL-MC devices. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: none drivers/staging/fsl-mc/bus/Makefile| 1 + .../staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 127 +

[PATCH RESEND v3 07/11] staging: fsl-mc: Populate the IRQ pool for an MC bus instance

2015-11-24 Thread J. German Rivera
Scan the corresponding DPRC container to get total count of IRQs needed by all its child DPAA2 objects. Then, preallocate a set of MSI IRQs with the DPRC's ICID (GIT-ITS device Id) to populate the the DPRC's IRQ pool. Each child DPAA2 object in the DPRC and the DPRC object itself will allocate thei

[PATCH RESEND v3 11/11] staging: fsl-mc: Added MSI support to the MC bus driver

2015-11-24 Thread J. German Rivera
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver init/exit time. Associate an MSI domain with each DPAA2 child device. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: none drivers/staging/fsl-mc/bus/mc-bus.c | 12 1 file cha

[PATCH RESEND v3 08/11] staging: fsl-mc: set MSI domain for DPRC objects

2015-11-24 Thread J. German Rivera
THE MSI domain associated with a root DPRC object is obtained form the device tree. Child DPRCs inherit the parent DPRC MSI domain. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: none drivers/staging/fsl-mc/bus/dprc-driver.c | 39

[PATCH RESEND v3 03/11] staging: fsl-mc: Added generic MSI support for FSL-MC devices

2015-11-24 Thread J. German Rivera
Created an MSI domain for the fsl-mc bus-- including functions to create a domain, find a domain, alloc/free domain irqs, and bus specific overrides for domain and irq_chip ops. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: - Addressed comments from Marc Zyngier: * Added WA

[PATCH RESEND v3 06/11] staging: fsl-mc: Changed DPRC built-in portal's mc_io to be atomic

2015-11-24 Thread J. German Rivera
The DPRC built-in portal's mc_io is used to send commands to the MC to program MSIs for MC objects. This is done by the fsl_mc_msi_write_msg() callback, which is invoked by the generic MSI layer with interrupts disabled. As a result, the mc_io used in fsl_mc_msi_write_msg needs to be an atomic mc_i

[PATCH RESEND v3 00/11] staging: fsl-mc: MC bus MSI support

2015-11-24 Thread J. German Rivera
*** This is a resend of the last iteration of this patch series *** This patch series addresses the following item from the TODO list for the MC bus driver to exit staging: * Interrupt support. For meaningful driver support we need interrupts, and thus need message interrupt support by the bus

[PATCH RESEND v3 09/11] staging: fsl-mc: Fixed bug in dprc_probe() error path

2015-11-24 Thread J. German Rivera
Destroy mc_io in error path in dprc_probe() only if the mc_io was created in this function. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: - Addressed comment from Dan Carpenter: * Renamed goto error labels to indicate what the goto does drivers/stagin

[PATCH RESEND v3 02/11] fsl-mc: msi: Added FSL-MC-specific member to the msi_desc's union

2015-11-24 Thread J. German Rivera
FSL-MC is a bus type different from PCI and platform, so it needs its own member in the msi_desc's union. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v3: none Changes in v2: - Addressed comment from Jiang Liu * Added a dedicated structure for FSL-MC in struct msi_desc incl

[PATCH RESEND v3 05/11] staging: fsl-mc: Extended MC bus allocator to include IRQs

2015-11-24 Thread J. German Rivera
All the IRQs for DPAA2 objects in the same DPRC must use the ICID of that DPRC, as their device Id in the GIC-ITS. Thus, all these IRQs must share the same ITT table in the GIC. As a result, a pool of IRQs with the same device Id must be preallocated per DPRC (fsl-mc bus instance). So, the fsl-mc b

[PATCH] staging: dgnc: dgnc_cls.c: Replaced udelay by usleep_range

2015-11-24 Thread Jitendra Kumar Khasdev
This patch is to file dgnc_cls.c that fixes up udelay function by usleep_range. It is safe to use according to the following documentation Documentation/timers/timers-howto.txt. So that is why I have given an appropriate time range. Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/dgnc/

[PATCH] staging: olpc_dcon: Added a space

2015-11-24 Thread Anjali Menon
Added a space around '/' to remove the check detected by the checkpatch.pl. CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by: Anjali Menon --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/olpc_dcon/olpc_

RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

2015-11-24 Thread KY Srinivasan
> -Original Message- > From: Florian Westphal [mailto:f...@strlen.de] > Sent: Tuesday, November 24, 2015 12:56 AM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; ja

RE: [PATCH net-next 01/10] hv_netvsc: Resize some of the variables in hv_netvsc_packet

2015-11-24 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, November 24, 2015 12:48 AM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.co

RE: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

2015-11-24 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, November 24, 2015 12:56 AM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.co

Re: [PATCH 1/4] staging: rtl8712: Remove casts between void * and type *

2015-11-24 Thread Mauro Dreissig
On 24-11-2015 11:07, Dan Carpenter wrote: > On Tue, Nov 24, 2015 at 10:19:39AM -0200, Mauro Dreissig wrote: >> Cleaning rtl871x_ioctl_rtl.c. >> > > It's better if you think about the header and the body as two different > things. Just repeat the title but with more information. > > regards, > da

[PATCH] staging: unisys: better config switch comments

2015-11-24 Thread Benjamin Romer
We should provide more information in the Kconfig help for visorbus and visorinput. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/Kconfig | 7 ++- drivers/staging/unisys/visorinput/Kconfig | 7 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/driv

Re: [PATCH 1/4] staging: rtl8712: Remove casts between void * and type *

2015-11-24 Thread Dan Carpenter
On Tue, Nov 24, 2015 at 10:19:39AM -0200, Mauro Dreissig wrote: > Cleaning rtl871x_ioctl_rtl.c. > It's better if you think about the header and the body as two different things. Just repeat the title but with more information. regards, dan carpenter

Re: [PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments

2015-11-24 Thread Ian Abbott
On 24/11/15 12:22, Jitendra Kumar Khasdev wrote: This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines. Apart from it I have remove header file path by base file name as suggested by community. Signed-off-by: J

[PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments

2015-11-24 Thread Jitendra Kumar Khasdev
This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines. Apart from it I have remove header file path by base file name as suggested by community. Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/comedi/

[PATCH 4/4] staging: rtl8712: Rename local variable

2015-11-24 Thread Mauro Dreissig
Make all instances of struct oid_par_priv be called oid in rtl871x_ioctl_rtl.c and rtl871x_ioctl_rtl.h. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 287 +--- drivers/staging/rtl8712/rtl871x_ioctl_rtl.h | 123 2 files change

[PATCH 2/4] staging: rtl8712: Rename local variable

2015-11-24 Thread Mauro Dreissig
Make all instances of struct _adapter be called adapter in rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 ++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_

[PATCH 3/4] staging: rtl8712: Make error handling check for failure

2015-11-24 Thread Mauro Dreissig
Some error handling paths are checking for success instead of error on rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 ++-- 1 file changed, 121 insertions(+), 118 deletions(-) diff --git a/drivers/staging/rtl8712/

[PATCH 1/4] staging: rtl8712: Remove casts between void * and type *

2015-11-24 Thread Mauro Dreissig
Cleaning rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c b/drivers/staging/rtl8712/rtl871x_ioctl_rtl

[PATCH 0/4] staging: rtl8712: Cleanups for rtl871x_ioctl_rtl

2015-11-24 Thread Mauro Dreissig
This applies some janitorial work. Mauro Dreissig (4): staging: rtl8712: Remove casts between void * and type * staging: rtl8712: Rename local variable staging: rtl8712: Make error handling check for failure staging: rtl8712: Rename local variable drivers/staging/rtl8712/rtl871x_ioctl_rt

Re: [PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments

2015-11-24 Thread Andy Shevchenko
On Tue, Nov 24, 2015 at 5:12 AM, Jitendra Kumar Khasdev wrote: > This patch is to comedilib.h file that fixes up following warnings > reported by checkpatch.pl : > I) Block comments use * on subsequent lines > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/comedi/comedilib.h | 3

Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

2015-11-24 Thread Florian Westphal
K. Y. Srinivasan wrote: > The rndis header is 116 bytes big and can be placed in the default > head room that will be available in the skb. Since the netvsc packet > is less than 48 bytes, we can use the skb control buffer > for the netvsc packet. With these changes we don't need to > ask for addi

Re: [PATCH net-next 08/10] hv_netvsc: Don't ask for additional head room in the skb

2015-11-24 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > The rndis header is 116 bytes big and can be placed in the default > head room that will be available in the skb. We have the following in include/linux/netdevice.h: #if defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25) # if defined(CONFIG_MAC80211_MESH) # define LL_

Re: [PATCH net-next 01/10] hv_netvsc: Resize some of the variables in hv_netvsc_packet

2015-11-24 Thread Vitaly Kuznetsov
"K. Y. Srinivasan" writes: > As part of reducing the size of the hv_netvsc_packet, resize some of the > variables based on their usage. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > --- > drivers/net/hyperv/hyperv_net.h | 14 +++--- > 1 files changed, 7 insertion