Re: [PATCH] staging: speakup: kobjects.c: fix char argument to %02x

2015-12-06 Thread Joe Perches
On Sun, 2015-12-06 at 01:21 +0100, Rasmus Villemoes wrote: > On Sun, Dec 06 2015, Joe Perches wrote: > > > On Sun, 2015-12-06 at 01:05 +0100, Rasmus Villemoes wrote: > > > If char is signed and ch happens to be negative, printing ch with > > > "%02x" will not do as intended

CALL FOR CONFIRMATION.

2015-12-06 Thread Mrs. Susan Console
LOTTO.NL, 2391 Beds 152 Koningin Julianaplein 21 , Den Haag, The Netherlands. (Lotto affiliate with Subscriber Agents). From: Susan Console (Lottery Coordinator) Website: www.lotto.nl Sir/adam, CONGRATULATIONS!!! We are pleased to inform you of the result of the Lotto NL Winners International

Re: [PATCH RESEND] staging/slicoss: Use ethtool_ops instead of module_param.

2015-12-06 Thread Sudip Mukherjee
On Fri, Dec 04, 2015 at 08:54:16AM -0800, Kevin Wern wrote: > ethtool_ops has attributes in sub struct ethool_coalesce that > correspond to the parameters intagg_delay and dynamic_intagg. It is > preferable to set these properties with ethtool rather than > module_param, so create these attributes

Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header

2015-12-06 Thread Sudip Mukherjee
On Sat, Dec 05, 2015 at 10:25:16PM -0500, Sanidhya Solanki wrote: > I disagree with the output of the automaton. Included below are my > compile checks before and after the patch. Build fails with: skein_block.c: multiple definition of 'skein_256_process_block' And you moved

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Saurabh Sengar
On 7 December 2015 at 12:18, Dan Carpenter wrote: > On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: >> Inorder to notify the user that value is not successfuly set in sys >> entry, error should be returned from store function instead of count >> >>

Re: [PATCH] Staging: Skein: Patch adds the test vectors

2015-12-06 Thread Sudip Mukherjee
On Sat, Dec 05, 2015 at 06:44:10AM -0500, Sanidhya Solanki wrote: > The patch is included below. > I would like to apologize for the past few emails. It turns out the > documentation included in the eMail clients file is woefully out of > date. I have checked the patches for errors using the

Re: [PATCH] Staging: Skein: Patch adds the test vectors

2015-12-06 Thread Dan Carpenter
The patch is still corrupt. Read Documentation/email-clients.txt and test it as described. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller

2015-12-06 Thread Dan Carpenter
On Fri, Dec 04, 2015 at 08:12:33PM +0530, Saurabh Sengar wrote: > Inorder to notify the user that value is not successfuly set in sys > entry, error should be returned from store function instead of count > > Signed-off-by: Saurabh Sengar > --- >