Re: On Lindent shortcomings and massive style fixing

Em Mon, 28 Dec 2015 07:33:32 -0800 Greg KH escreveu: > On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > > After some iterations of checkpatch.pl, on a new developed driver > > (tw5864), now I have the following: > > > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq

RE: [PATCH RESEND v2 1/1] fix a dead loop when in heavy low memory

> However, it appears that the same process, dTi-lm, is still chosen for oom > kill > because lowmem_deathpending_timeout has expired. > > So this looks like a problem if the constantly chosen process cannot exit. > It would have been helpful to have the stack of pid 27289 in the log to see > whe

[PATCH RESEND] staging/slicoss: Use ethtool_ops instead of module_param.

ethtool_ops has attributes in sub struct ethtool_coalesce that correspond to the parameters intagg_delay and dynamic_intagg. It is preferable to set these properties with ethtool rather than module_param, so create these attributes in adapter and set them using ethtool_coalesce's rx_coalesce_usecs

Re: [PATCH] staging: lustre: fix lock imbalance

[if your patch is applied to the wrong git tree, please drop us a note to help improving the system] Hi Joshua, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.4-rc6 next-20151223] url: https://github.com/0day-ci/linux/commits/Joshua-Clayton/staging-lustre

RE: [PATCH RESEND v2 1/1] fix a dead loop when in heavy low memory

> > > > Signed-off-by: Figo Zhang > > As you ignored my instructions to you, I'm going to just ignore this patch, > sorry. Now discarded. > I am no at intel kernel group (SSG OTC), I am at CCG CCE. I will involve the intel open source guys if they like to help. Hi fengguang: Would you like

[PATCH 2/2] staging: wilc1000: wilc_parse_network_info refactoring

1) Return value of this function does not used; 2) wilc_parse_network_info has no reasons to return an error; 3) kfree does not free memory if argument is NULL. Signed-off-by: Ivan Safonov --- drivers/staging/wilc1000/coreconfigurator.c | 27 +-- drivers/staging/wilc1000/

Re: [PATCH v2 1/1] fix a dead loop when in heavy low memory

Greg KH [2015-12-26 19:12]: > I need a "full" name here, not a "short" name, sorry, before I can do > anything with this patch. I don't know if that is the case here, but: You know, of course, that there are societies in this world where only one name is used? -- Hilsen Harald

[PATCH 08/10] staging: fbtft: use to_platform_device()

Use to_platform_device() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 071f79b..50d5735 100644

Re: [PATCH RESEND v2 1/1] fix a dead loop when in heavy low memory

On Sun, Dec 27, 2015 at 04:34:56PM +0800, Figo.zhang wrote: > From: Figo This doesn't match your signed-off-by name :( > Signed-off-by: Figo.zhang I doubt that you have a '.' in your name :( Again, please consult the Intel Linux kernel group for how to do this correctly, I will not accept th

[PATCH 2/2] staging: wilc1000: wilc_parse_network_info refactoring

1. Return value of this function does not used; 2. wilc_parse_network_info has no reasons to return an error; 3. kfree does not free memory if argument is NULL. Signed-off-by: Ivan Safonov --- drivers/staging/wilc1000/coreconfigurator.c | 27 +-- drivers/staging/wilc1000/

[PATCH 0/2] Staging: panel: Fix checkpatch warnings

Fix checkpatch.pl warnings in panel.c Signed-off-by: Ksenija Stanojevic Ksenija Stanojevic (2): Staging: panel: Fix line over 80 characters Staging: panel: Remove space drivers/staging/panel/panel.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 1.9.1 _

[PATCH 1/2] Staging: goldfish: Add space around that "+"

From: Shraddha Barke Fix checkpatch warning of adding space around + in accordance with kernel coding style. Signed-off-by: Shraddha Barke --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c

[PATCH 2/3] staging: rtl8192u: use to_delayed_work

Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 +++--- drivers/staging/rtl8192u/r8192U_core.c | 3 +-- drivers/staging/rtl8192u/r8192U_dm.c | 4 ++-- drivers/staging/rtl

[PATCH 2/2] staging: wilc1000: wilc_parse_network_info refactoring

1) Return value of this function does not used; 2) wilc_parse_network_info has no reasons to return an error; 3) kfree does not free memory if argument is NULL. Signed-off-by: Ivan Safonov --- drivers/staging/wilc1000/coreconfigurator.c | 27 +-- drivers/staging/wilc1000/

Cleaning dgnc driver

Hi, Is it useful to clean staging/dgnc, since it supports the same adapters that those of serial/jsm ? best regards, salah triki ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de

[PATCH 3/3] staging: rtl8192e: use to_delayed_work

Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/staging/rtl8192e/rtllib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 563ac12..d99240e 100644 --- a/driver

Cordial greeting

Cordial greeting message from Eva Zahra, I am seeking for your help,I will be very glad if you do assist me to relocate a sum of (US$4 Million Dollars)into your Bank account in your country for the benefit of both of us i want to use this money for investment. I will give you more details as you

RE: [PATCH v2 1/1] fix a dead loop when in heavy low memory

> > Android System UI hang when run heavy monkey stress test. > > What changed from v1 of this patch? Please describe that below the --- > line. V2，I just modify my comments. > > > > > Signed-off-by: Figo > > I need a "full" name here, not a "short" name, sorry, before I can do anything > wit

[PATCH 2/2] Staging: goldfish: Remove explicit NULL comparison

From: Shraddha Barke Remove explicit NULL comparison and write it in its simpler form. Signed-off-by: Shraddha Barke --- drivers/staging/goldfish/goldfish_audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/stag

[PATCH 4/6] Staging: gdm72xx: Remove space after cast

From: Shraddha Barke Fix the checkpatch warning "No space is necessary after cast" Signed-off-by: Shraddha Barke --- drivers/staging/gdm72xx/netlink_k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/netlink_k.c b/drivers/staging/gdm72xx/netlink_k.

Cordial greeting

Cordial greeting message from Eva Zahra, I am seeking for your help,I will be very glad if you do assist me to relocate a sum of (US$4 Million Dollars)into your Bank account in your country for the benefit of both of us i want to use this money for investment. I will give you more details as you

Re: Move panel driver out of staging?

Hi Dan, Thanks for your review, I'm adding a few extra comments below. On Mon, Dec 28, 2015 at 06:27:36PM +0300, Dan Carpenter wrote: > On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojevi?? wrote: > > Hi Willy, > > > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed t

Re: On Lindent shortcomings and massive style fixing

On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > After some iterations of checkpatch.pl, on a new developed driver > (tw5864), now I have the following: > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c > 31 ERROR: do not use C99 // comments > 147 WARNING

Re: Move panel driver out of staging?

On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojević wrote: > Hi Willy, > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > panel driver is maybe ready to be moved to drivers/misc. Are there any > TODO tasks left to do? I already sent checkpatch clean-up patches.

On Lindent shortcomings and massive style fixing

After some iterations of checkpatch.pl, on a new developed driver (tw5864), now I have the following: $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c 31 ERROR: do not use C99 // comments 147 WARNING: Block comments use a trailing */ on a separate line 144 WARNING: Blo

Re: Move panel driver out of staging?

Hi Ksenija, On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojevi?? wrote: > Hi Willy, > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > panel driver is maybe ready to be moved to drivers/misc. I think so as well, we discussed this with Greg 6 months ago or so

Re: [PATCH V4 2/4] scsi: storvsc: Properly support Fibre Channel devices

On 12/23/2015 10:15 PM, K. Y. Srinivasan wrote: For FC devices managed by this driver, atttach the appropriate transport template. This will allow us to create the appropriate sysfs files for these devices. With this we can publish the wwn for both the port and the node. Signed-off-by: K. Y. Sri

Move panel driver out of staging?

Hi Willy, I'm helping Greg do a bit of cleanup in the staging tree, I noticed that panel driver is maybe ready to be moved to drivers/misc. Are there any TODO tasks left to do? I already sent checkpatch clean-up patches. Thanks, Ksenija ___ devel mailin

[PATCHv2] staging: most: replace multiple if..else with table lookup

From: Hari Prasath Gujulan Elango Replace multiple if..else if..statements with simple table lookup in two functions. Signed-off-by: Hari Prasath Gujulan Elango --- drivers/staging/most/mostcore/core.c | 41 +--- 1 file changed, 24 insertions(+), 17 deletions(-)