Re: [RFC PATCH v0] Add tw5864 driver

2016-01-02 Thread Joe Perches
On Sun, 2016-01-03 at 03:41 +0200, Andrey Utkin wrote: > (Disclaimer up to scissors mark) > > Please be so kind to take a look at a new driver. trivial comments only: > diff --git a/drivers/staging/media/tw5864/tw5864-bs.h > b/drivers/staging/media/tw5864/tw5864-bs.h [] > +static inline int bs_p

Re: [RFC PATCH v0] Add tw5864 driver

2016-01-02 Thread Leon Romanovsky
On Sun, Jan 03, 2016 at 03:41:42AM +0200, Andrey Utkin wrote: > +/* > + * TW5864 driver - Exp-Golomb code functions > + * > + * Copyright (C) 2015 Bluecherry, LLC > + * Copyright (C) 2015 Andrey Utkin I doubt that you have contract with your employer which permits you to claim copyright

[PATCH] staging: xgifb: Don't use multiple blank lines

2016-01-02 Thread Benoit Hiller
Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines" Signed-off-by: Benoit Hiller --- drivers/staging/xgifb/XGI_main_26.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI

Seeking a bit of advice from the community

2016-01-02 Thread Mario J. Rugiero
Hello, my name is Mario Rugiero, and I'm in the process of resurrecting the attempts to get the via driver in shape, and had a few questions on the proper etiquette for such a thing. As some may know, there are talks about removing dri1 support on X.org, so we (the users interested) should updat

[PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse

2016-01-02 Thread Niranjan Dighe
Added annotation '__must_hold' to function ksocknal_send_keepalive_locked which unlocks the lock ksocknal_data.ksnd_global_lock. As this lock is not acquired in the current function, sparse warns about context imbalance Signed-off-by: Niranjan Dighe --- drivers/staging/lustre/lnet/klnds/socklnd/

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread covici
Well, OK with me, I will use yours instead because I don't know if they will backport the thing, thanks so much for doing this. Samuel Thibault wrote: > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it >

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > I had a patch which also worked, but yours may be better -- I enclose it > here for your information. Well, it's not up to serialio.h to include things for serialio.c. That however makes me realize that the culprit is actually f79b

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread covici
I had a patch which also worked, but yours may be better -- I enclose it here for your information. --- drivers/staging/speakup/serialio.h.old 2015-08-30 14:34:09.0 -0400 +++ drivers/staging/speakup/serialio.h 2015-10-07 06:27:04.880829874 -0400 @@ -1,22 +1,24 @@ #ifndef _SPEAKUP_S

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
Samuel Thibault, on Sun 03 Jan 2016 00:25:29 +0100, wrote: > 5e6dc54 broke the port information in the speakup driver: > SERIAL_PORT_DFNS only gets defined if asm/serial.h is included. > > Along the way, make sure that we do have information for the requested > serial port number (index) (It'd be

[PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
5e6dc54 broke the port information in the speakup driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included. Along the way, make sure that we do have information for the requested serial port number (index) Signed-off-by: Samuel Thibault --- a/drivers/staging/speakup/serialio.c +++

[PATCH v2] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Hugo Camboulive
This removes a few Sparse warnings. Signed-off-by: Hugo Camboulive --- drivers/staging/most/hdm-dim2/dim2_hal.c | 4 ++-- drivers/staging/most/hdm-dim2/dim2_hal.h | 7 --- drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hdm.h | 2 +- 4 files changed, 1

Re: [PATCH] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Hugo Camboulive
On Saturday 02 Jan 2016 20:33:23 (+), Al Viro wrote: > On Sat, Jan 02, 2016 at 08:30:21PM +, Hugo Camboulive wrote: > > This removes a few Sparse warnings. > > > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address; > > > -u8 dim_startup(void *dim_base_address, u32 mlb_clock); > > +u

Re: [PATCH] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Al Viro
On Sat, Jan 02, 2016 at 08:30:21PM +, Hugo Camboulive wrote: > This removes a few Sparse warnings. > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address; > -u8 dim_startup(void *dim_base_address, u32 mlb_clock); > +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock); Umm...

[PATCH] staging: most: add __iomem for io_base and registers

2016-01-02 Thread Hugo Camboulive
This removes a few Sparse warnings. Signed-off-by: Hugo Camboulive --- drivers/staging/most/hdm-dim2/dim2_hal.c | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hal.h | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hdm.c | 6 +++--- drivers/staging/most/hdm-dim2/dim2_hdm.h | 2 +- 4 files changed,

Foreign Partner Request

2016-01-02 Thread Mr. N Uddin
Dear Sir/Madam,Re. Foreign Partner Request I sincerely apologies for intruding into your privacy. I am compelled to contact you due to the nature of my proposition. I am Mr. N. Uddin, Bangladesh national and CEO Of AUM International (https://www.gmdu.n