Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

On Sat, 2016-01-30 at 12:23 +0530, Bhakti Priya wrote: > I will be happy to extend checkpatch.pl. As suggested by you, I am > trying to detect such blank lines in a line removal patch by checking > if the line above the deleted line was a blank line and the line > following the deleted line had a c

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Hi, Thank you for your reply. I've just sent version 2 of the patch with the blank lines removed. I will be happy to extend checkpatch.pl. As suggested by you, I am trying to detect such blank lines in a line removal patch by checking if the line above the deleted line was a blank line and the lin

[PATCH v2] staging: rtl8723au: Fixes unnecessary return warning

This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. WARNING: void function return statements are not generally useful Signed-off-by: Bhaktipriya Shridhar --- Changes in v2: - Removed the unnecessary blank lines. drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 20 --

Re: [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

On Fri, 2016-01-29 at 19:36 -0800, K. Y. Srinivasan wrote: > tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli > nux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3 > 2796ec3c%7c72f988bf86f

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

On Sat, 2016-01-30 at 14:09 +1100, Julian Calaby wrote: > Hi Joe, Hello Julian. > On Sat, Jan 30, 2016 at 12:28 PM, Joe Perches > wrote: > > On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: > > > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen > > t.com> wrote: > > > > Bhaktipriya Shridhar

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Hi Joe, On Sat, Jan 30, 2016 at 12:28 PM, Joe Perches wrote: > On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: >> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen >> wrote: >> > Bhaktipriya Shridhar writes: >> > > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. >> > > WARNI

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen wrote: > > Bhaktipriya Shridhar writes: > > > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > > > WARNING: void function return statements are not generally useful [] > > > dif

[PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2flinux.git&data=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d32796ec3c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ubr4GbBaNS%2ftOz%2buJBk0CL9N0UNG9x2Ti

Staging: board: Blank lines aren't necessary before a close brace

Fix checkpatch.pl issue CHECK: Blank lines aren't necessary before a close brace Signed-off-by: SirnamSwetha --- drivers/staging/board/board.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c index 3eb5eb8..14427e8 100644 --- a/dr

Staging: board: Fix checkpatch.pl issue

This patch fixes the checkpatch issue. CHECK: Please don't use multiple blank lines Signed-off-by: SirnamSwetha --- drivers/staging/board/armadillo800eva.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/board/armadillo800eva.c b/drivers/staging/board/armadillo800eva.c index

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Hi Bhaktipriya, On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen wrote: > Bhaktipriya Shridhar writes: >> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. >> WARNING: void function return statements are not generally useful >> >> Signed-off-by: Bhaktipriya Shridhar >> --- >> drivers

[PATCH 10/10] staging/android: remove redundant comments on sync_merge_data

From: Gustavo Padovan struct sync_merge_data already have documentation on top of the struct definition. No need to duplicate it. Signed-off-by: Gustavo Padovan --- drivers/staging/android/uapi/sync.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/and

[PATCH 04/10] staging/android: remove driver_data from struct fence_info

From: Gustavo Padovan It is unclear in what situations driver_data should be used thus better do not upstream it for now. If a need arises in the future a discussion can be started to re-add it. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sw_sync.c | 14 -- drivers

[PATCH 05/10] staging/android: remove len field from struct fence_info

From: Gustavo Padovan After removing driver_data struct fence_info has now a fixed size, thus it doesn't need any field to tell its size, it is already known. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 4 +--- drivers/staging/android/uapi/sync.h | 2 -- 2 files ch

[PATCH 08/10] staging/android: rename SYNC_IOC_FENCE_INFO

From: Gustavo Padovan We don't use the 'fence' name to refer to sync_file anymore. So rename it to SYNC_IOC_FILE_INFO. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 2 +- drivers/staging/android/uapi/sync.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) di

[PATCH 06/10] staging/android: turn fence_info into a __64 pointer

From: Gustavo Padovan Making fence_info a pointer enables us to extend the struct in the future without breaking the ABI. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 2 +- drivers/staging/android/uapi/sync.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 09/10] staging/android: add flags member to sync ioctl structs

From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. Signed-off-by: Gustavo Padovan --- drivers/staging/android/uapi/sync.h | 6 ++ 1 file changed, 6 insertions(+) d

[PATCH 07/10] staging/android: add num_fences field to struct sync_file_info

From: Gustavo Padovan Inform the users how many fences are in the fence_info field. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 2 ++ drivers/staging/android/uapi/sync.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/staging/android/sync.c b/drivers

[PATCH 03/10] staging/android: rename sync_file_info_data to sync_file_info

From: Gustavo Padovan info_data is a bit redundant, let's keep it as only sync_file_info. It is also smaller. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 26 +- drivers/staging/android/uapi/sync.h | 9 - 2 files changed, 17 insertio

[PATCH 02/10] staging/android: rename sync_pt_info to fence_info

From: Gustavo Padovan As struct sync_pt doesn't exist anymore it is a good idea remove any reference to it in the sync_framework. sync_pts were replaced directly by fences. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c | 8 drivers/staging/android/uapi/sync.h

[PATCH 01/10] staging/android: remove SYNC_WAIT ioctl

From: Gustavo Padovan This ioctl is replicating the work of poll() syscall so let's take the opportunity that this is still on staging tree and remove the duplication and force new users to use the poll() standard interface. Signed-off-by: Gustavo Padovan --- drivers/staging/android/sync.c

[PATCH 00/10] android sync framework: clean up IOCTLs and ABI.

From: Gustavo Padovan Hi, This patch series clean up IOCTLs and abi of sync framework and it is a follow up on the clean up series I've sent on Jan 21: http://thread.gmane.org/gmane.comp.video.dri.devel/145509 The main changes here are: * remove of SYNC_WAIT ioctl, poll() should be used inst

Re: Move wlan-ng out of staging?

On Fri, Jan 29, 2016 at 05:11:04PM +0100, Xose Vazquez Perez wrote: > >> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > >> wlan-ng driver is maybe ready to be moved out of staging. Are there > >> any TODO tasks left to do beside checkpatch.pl clean-up? > > > > Its FAQ w

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Bhaktipriya Shridhar writes: > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > WARNING: void function return statements are not generally useful > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 -- > 1 file changed, 10 de

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote: > From: Bijosh Thykkoottathil You do not need this From: line here. The email From: header is sufficient. > > Fixes following coading style issues reported by the check patch script. > - ERROR: Macros with complex values

[PATCH] staging: rtl8723au: Fixes unnecessary return warning

This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. WARNING: void function return statements are not generally useful Signed-off-by: Bhaktipriya Shridhar --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rt

Re: [v2 PATCH 9/26] eCryptfs: Use skcipher and shash

On 2016-01-25 10:29:33, Herbert Xu wrote: > On Sun, Jan 24, 2016 at 07:10:50PM +0100, Julia Lawall wrote: > > Maybe the goto on line 1726 needs a preceding mutex_unlock? > > Good catch! Thanks. > > ---8<--- > This patch replaces uses of ablkcipher and blkcipher with skcipher, > and the long obsol

Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up

On Fri, Jan 29, 2016 at 12:47:20PM -0200, Gustavo Padovan wrote: > Hi, > > 2016-01-25 Maarten Lankhorst : > > > Hey, > > > > Op 21-01-16 om 13:49 schreef Gustavo Padovan: > > > From: Gustavo Padovan > > > > > > Hi, > > > > > > The following patches are some clean ups on the sync framework befor

Re: Move wlan-ng out of staging?

On 01/29/2016 05:00 PM, Xose Vazquez Perez wrote: > Ksenija wrote: > >> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that >> wlan-ng driver is maybe ready to be moved out of staging. Are there >> any TODO tasks left to do beside checkpatch.pl clean-up? > > Its FAQ was very

Re: Move wlan-ng out of staging?

On Fri, Jan 29, 2016 at 05:00:16PM +0100, Xose Vazquez Perez wrote: > Ksenija wrote: > > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > > wlan-ng driver is maybe ready to be moved out of staging. Are there > > any TODO tasks left to do beside checkpatch.pl clean-up? >

Re: Move wlan-ng out of staging?

Ksenija wrote: > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > wlan-ng driver is maybe ready to be moved out of staging. Are there > any TODO tasks left to do beside checkpatch.pl clean-up? Its FAQ was very clear: ftp://ftp.linux-wlan.org/pub/linux-wlan-ng/FAQ [archiv

[PATCH 02/16] staging: unisys: fix comments for controlvmchannel.h

From: Erik Arfvidson This patch simply fixes all trailing */ by modifying the comments structures while trying to reduce the total number of lines Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/controlvmchannel.h | 237 +++-- 1

[PATCH 16/16] staging: unisys: fix parenthesis in toolaction_show()

Fix the only fixable parenthesis alignment issue in visorchipset.c. The rest are unworkable because of the length of the symbol names used. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 11/16] staging: unisys: fix block comments in ultrainputreport.h

From: Erik Arfvidson This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../staging/unisys/visorinput/ultrainputreport.h |

[PATCH 13/16] staging: unisys: fix else statement in visornic_main.c

From: Erik Arfvidson This patch fixes the following types of check patch warnings: else is not generally useful after a break or return Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 05/16] staging: unisys: fix comments in visorchipset

From: Erik Arfvidson This patch fixes all the Block comments by using a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff -

[PATCH 08/16] staging: unisys: fix blank lines in visorchipset.c

From: Erik Arfvidson this patch removes the following checkpatch warnings: please use a blank line after … Please don’t use multiple blank lines Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 3 +-- 1 file chang

[PATCH 09/16] staging: unisys: fix spaces after cast visorchipset.c

From: Erik Arfvidson This patch fixes checkpatch's no space is necessary after a cast Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys

[PATCH 03/16] staging: unisys: Fix NULL comparison vbusdeviceinfo.h

From: Erik Arfvidson This patches resolves the NULL comparison checkpatch warnings Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/unisys/vi

[PATCH 04/16] staging: unisys: fix trailing comment in vbusdeviceinfo.h

From: Erik Arfvidson Fixes checkpatch trailing */ comment in vbusdeviceinfo.h Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/vbusdeviceinfo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/

[PATCH 14/16] staging: unisys: fix alignment in visornic_main.c

From: Erik Arfvidson This patch fixes the following types of check patch warnings: Alignment should match open parenthesis Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visornic_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deleti

[PATCH 07/16] staging: unisys: fix comparison to NULL in visorchipset.c

From: Erik Arfvidson This patch fixes the following type of check patch warnings: Comparison to NULL could be written Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(

[PATCH 10/16] staging: unisys: fix comments in visorbus_main.c

From: Erik Arfvidson This patch fixes the following types of check patch warnings: Block comments use a trailing */ on a separate line Comment alignments Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---

[PATCH 06/16] staging: unisys: fix spacing in visorchipset.c

From: Erik Arfvidson This patch fixes the following checkpatch warning: spaces preferred around that ‘*’ or ‘|’ Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff -

[PATCH 15/16] staging: unisys: remove unnecessary goto

parser_param_start() had a goto Away, which went to nothing but a return statement. Remove the goto, the CamelCased label, and just return directly. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorbus/visorchipset.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 00/16] staging: unisys: cleanup series

This patch series cleans up all the remaining issues reported by checkpatch.pl that can be fixed. The series was rebased against the current contents of staging-next. Benjamin Romer (2): staging: unisys: remove unnecessary goto staging: unisys: fix parenthesis in toolaction_show() Erik Arfvid

[PATCH 12/16] staging: unisys: fix comments in visornic_main.c

From: Erik Arfvidson This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visornic/visor

[PATCH 01/16] staging: unisys: Fix guestlinuxdebug.h comments

From: Erik Arfvidson This patch simply cleans up all checkpatch comment issues Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/guestlinuxdebug.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/uni

[PATCH 1/2] staging: wilc1000: wilc_msgqueue: use standard struct list_head

This patch uses standard struct list_head in struct message and message_queue instead of custom linked list. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 32 drivers/staging/wilc1000/wilc_msgqueue.h | 5 +++-- 2 files changed, 15 in

[PATCH 2/2] staging: wilc1000: wilc_msgqueue: release semaphore in error path

It should be called up(&mq->sem) to release semaphore before returning error codes as -EFAULT when list is empty. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/stagi

Re: [PATCH 00/11] sync framework de-staging: part 1 - clean up

Hi, 2016-01-25 Maarten Lankhorst : > Hey, > > Op 21-01-16 om 13:49 schreef Gustavo Padovan: > > From: Gustavo Padovan > > > > Hi, > > > > The following patches are some clean ups on the sync framework before > > we start the actual de-staging. The main changes here are the move of > > SW_SYNC_U

Yours Truely Mrs Machiko Kumiko

Hi Dear, I am Mrs Machiko Kumiko, from Japan, I Have Been Diagnosed with esophageal Cancer. I Have Chosen you to distribute my Funds to Charities homes in your Country, so if you wish to Carry out this humanitarian Work kindly Get back to me for FURTHER details. Yours Truely Mrs Machiko Kum

[PATCH] Staging:lustre:lclient:Remove unused function

Discard the function ccc_vmpage_page_transient as it is not used anywhere in the kernel. Used grep to find occurences. Problem found using sparse. Signed-off-by: Bhumika Goyal --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/d