Re: [PATCH 1/8] rtlwifi: rtl8723be: Fix module parameter initialization

On Mon, Dec 14, 2015 at 04:34:31PM -0600, Larry Finger wrote: > This driver has a number of errors in the module initialization. These > include the following: > > Parameter msi_support is stored in two places - one is removed. > Paramters sw_crypto and disable_watchdog were never stored in the fi

Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

On Mon, Feb 01, 2016 at 09:06:03AM +0100, Samuel Thibault wrote: > mn10300 uses an mmio-driven uart. This is not supported by speakup, so > prevent from enabling it. > > Signed-off-by: Samuel Thibault > > --- a/drivers/staging/speakup/Kconfig > +++ b/drivers/staging/speakup/Kconfig > @@ -1,7 +1,

[RESEND PATCH] Staging:speakup:add space around '|'

Fix checkpatch.pl check:CHECK: spaces preferred around that '|'. Add spaces around operands to fix these warnings. Signed-off-by: Bhumika Goyal --- drivers/staging/speakup/speakup_decext.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/stag

[PATCH] rtlwifi: Fix warning from ieee80211_get_tx_rates() when using 5G

When using a 5G-capable device with VHT rates enabled, the following warning results: WARNING: CPU: 3 PID: 2253 at net/mac80211/rate.c:625 ieee80211_get_tx_rates+0x22e/0x620 [mac80211]() Modules linked in: rtl8821ae btcoexist rtl_pci rtlwifi fuse drbg ansi_cprng ctr ccm bnep bluetooth af_packet

Re: [PATCH 06/10] staging/android: turn fence_info into a __64 pointer

Hi Maarten, 2016-02-01 Maarten Lankhorst : > Op 29-01-16 om 22:20 schreef Gustavo Padovan: > > From: Gustavo Padovan > > > > Making fence_info a pointer enables us to extend the struct in the future > > without breaking the ABI. > > > > Signed-off-by: Gustavo Padovan > > --- > > drivers/stagin

[PATCH] staging: amso1100: fix format string for 64-bit phys_addr

The amso1100 driver prints a phys_addr_t by casting it to a pointer, which causes a warning when phys_addr_t is 64-bit and pointers are 32-bit: drivers/staging/rdma/amso1100/c2.c: In function 'c2_rx_error': drivers/staging/rdma/amso1100/c2.c:430:4: warning: cast to pointer from integer of differe

Re: [PATCH] staging: goldfish: use div64_s64 instead of do_div

On Monday 01 February 2016 14:54:57 One Thousand Gnomes wrote: > On Mon, 01 Feb 2016 11:33 +0100 > Arnd Bergmann wrote: > > > The goldfish nand driver divides a signed 64-bit number (loff_t) > > in multiple places using the do_div() function. This has always > > been unreliable but now produces a

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

Joe Perches writes: > On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote: >> Joe Perches writes: > [] >> > so this could be transformed into something like: >> > >> > int rtw_get_bit_value_from_ieee_value23a(u8 val) >> > { >> >int i; >> >static const u8 dot11_rate_table[] = { >> >

[PATCH] staging: rtl8712: use list_first_entry_or_null()

Use list_first_entry_or_null() instead of list_empty() + LIST_CONTAINOR() to simplify the code. Signed-off-by: Geliang Tang --- drivers/staging/rtl8712/rtl871x_cmd.c | 13 +--- drivers/staging/rtl8712/rtl871x_mlme.c| 15 +++--- drivers/staging/rtl8712/rtl871x_recv.c|

Re: [PATCH] staging: goldfish: use div64_s64 instead of do_div

On Mon, 01 Feb 2016 11:33 +0100 Arnd Bergmann wrote: > The goldfish nand driver divides a signed 64-bit number (loff_t) > in multiple places using the do_div() function. This has always > been unreliable but now produces a compiler warning (since 4.5-rc1): > > goldfish/goldfish_nand.c: In functi

[PATCH] staging: rtl8188eu: use list_first_entry_or_null()

Use list_first_entry_or_null() instead of list_empty() + container_of() to simplify the code. Signed-off-by: Geliang Tang --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 12 +--- drivers/staging/rtl8188eu/core/rtw_mlme.c| 19 +++ drivers/staging/rtl8188eu/core/rtw_recv.c| 15 ++---

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

On Mon, 2016-02-01 at 07:29 -0500, Jes Sorensen wrote: > Joe Perches writes: [] > > so this could be transformed into something like: > > > > int rtw_get_bit_value_from_ieee_value23a(u8 val) > > { > > int i; > > static const u8 dot11_rate_table[] = { > > 2, 4, 11, 22, 12, 18,

[PATCH v2] staging: rtl8723au: use list_for_each_entry*()

Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- Changes in v2: - drop the coding style fixing in v1. --- drivers/staging/rtl8723au/core/rtw_ap.c | 92 ++- drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 5/6] staging: lustre: Use ahash

This patch replaces uses of the long obsolete hash interface with ahash. Signed-off-by: Herbert Xu --- drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c | 92 +++--- 1 file changed, 52 insertions(+), 40 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linu

Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

2016-01-30 Emil Velikov : > Hi Gustavo, > > > @@ -54,6 +59,7 @@ struct sync_file_info { > > __u32 len; > As mentioned previously - can we rework this variable to indicate the > total length (or the number) of fence_info struct instances. It seems > to be the more common approach afaict.

[PATCH] Staging: Android: memory allocation style change in ion_page_pool.c

This is a patch to ion_page_pool.c that changes a memory allocation style issue as found by checkpatch.pl. Signed-off-by: Ben Marsh --- drivers/staging/android/ion/ion_page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_pool.c

Re: [PATCH 3/3] Staging: rtl8723au: core: rtw_ieee80211: Fixed space and brace coding style issue.

Joe Perches writes: > On Sun, 2016-01-31 at 09:36 -0500, Jes Sorensen wrote: >> Rakhi Sharma writes: >> > Fixed the space and brace coding style error. >> > ERROR: space required before that '=' >> > ERROR: that open brace { should be on the previous line. >> > >> > Signed-off-by: Rakhi Sharma

[PATCH 02/11] staging: wilc1000: linux_mon: remove blank lines after open brace '{'

This patch remove blank lines after open brace found by checkpatch.pl CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/d

[PATCH 06/11] staging: wilc1000: linux_mon: remove space after a cast

This patch removes space after a type cast found by checkpatch.pl CHECK: No space is necessary after a cast Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drive

[PATCH 05/11] staging: wilc1000: linux_mon: fix NULL comparison style

This patch fixes NULL comparsion style found by checkpatch.pl CHECK: Comparison to NULL could be written "!wilc_wfi_mon" CHECK: Comparison to NULL could be written "!skb" CHECK: Comparison to NULL could be written "!skb" CHECK: Comparison to NULL could be written "!dev" CHECK: Comparison to NULL c

[PATCH 07/11] staging: wilc1000: linux_mon: insert blank line after a function

This patch inserts a blank line afer function found by checkpatch.pl CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wilc1000/linu

[PATCH 04/11] staging: wilc1000: linux_mon: remove multiple blank lines

This patch removes multiple blank lines found by checkpatch.pl CHECK: Please don't use multiple blank lines Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/

[PATCH 08/11] staging: wilc1000: linux_mon: add braces on all arms of if statement

This patch adds braces on all arms of if statement found by checkpatch.pl CHECK: braces {} should be used on all arms of this statement Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1

[PATCH 09/11] staging: wilc1000: linux_mon: fix coding style of kmalloc usage

This patch fixes coding style of kmalloc usage found by checkpatch.pl CHECK: Prefer kmalloc(sizeof(*mgmt_tx)...) over kmalloc(sizeof(struct tx_complete_mon_data)...) Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 11/11] staging: wilc1000: linux_mon: remove debug message of kmalloc failure

There is no need to print debug message when kmalloc is failed. This message is redundant. The code already show us that kmalloc is failed. The braces of first if statement is remove as well because if statement has a single statement. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/lin

[PATCH 03/11] staging: wilc1000: linux_mon: remove blank line before a close brace '}'

This patch removes blank lines before a close brace found by checkpatch.pl CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon

[PATCH 10/11] staging: wilc1000: linux_mon: fix error code of kmalloc

This patch fixes error codes as -ENOMEM instead of using -EFAULT if kmalloc is failed. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/lin

[PATCH 01/11] staging: wilc1000: linux_mon: use __packed instead of __attribute__((packed))

This patch fixes the following checkpatch warning: WARNING: __packed is preferred over __attribute__((packed)) Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/linux_mon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/driv

Re: [PATCH] Staging: Android: fixes a memory allocation issue in ion_page_pool.c

On Mon, Feb 01, 2016 at 12:28:30PM +0100, Ben Marsh wrote: > This is a patch to the ion_page_pool.c file that fixes a memory > allocation warning foudn by checkpatch.pl. > "found". Normally, I don't get too wound up about changelogs but this doesn't "fix" anything, it's just a checkpatch cleanup

[PATCH] Staging: Android: fixes a memory allocation issue in ion_page_pool.c

This is a patch to the ion_page_pool.c file that fixes a memory allocation warning foudn by checkpatch.pl. Signed-off-by: Ben Marsh --- drivers/staging/android/ion/ion_page_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_pool.c

[PATCH] Staging: gs_fpgaboot: fix data types in gs_fpgaboot.c

This is a patch to gs_fpgaboot.c to convert data types to kernel types as identified by checkpatch.pl. Signed-off-by: Ben Marsh --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drive

[PATCH] Staging: gs_fpgaboot: fix memory allocation in gs_fpgaboot.c

This is a patch for gs_fpgaboot.c that fixes a memory allocation problem identified by checkpatch.pl. Signed-off-by: Ben Marsh --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/st

[PATCH] staging: goldfish: use div64_s64 instead of do_div

The goldfish nand driver divides a signed 64-bit number (loff_t) in multiple places using the do_div() function. This has always been unreliable but now produces a compiler warning (since 4.5-rc1): goldfish/goldfish_nand.c: In function 'goldfish_nand_erase': goldfish/goldfish_nand.c:107:91: error:

Re: [PATCH] Staging: gs_fpgaboot: fixed coding style issues in gs_fpgaboot.c

On Sun, Jan 31, 2016 at 09:06:31PM +0100, Ben Marsh wrote: > Signed-off-by: Ben Marsh > --- You have not given any commit message. Please mention which coding style issue you have fixed. On first look, you have done multiple types of changes. Please only do one type of change in a single patch.

Re: [PATCH 1/2] staging: xgifb: XGI_main_26.c fixed spacing to match coding style

On Sat, Jan 30, 2016 at 12:52:45PM -0800, Santosh Madiraju wrote: > From: madiraju You do not need this extra From: line here. Even if you need to give it for some reason then the name should match the name as given in your Signed-off-by: name. > > Removed unnecessary spaces to match coding sty

Re: [PATCH 06/10] staging/android: turn fence_info into a __64 pointer

Op 29-01-16 om 22:20 schreef Gustavo Padovan: > From: Gustavo Padovan > > Making fence_info a pointer enables us to extend the struct in the future > without breaking the ABI. > > Signed-off-by: Gustavo Padovan > --- > drivers/staging/android/sync.c | 2 +- > drivers/staging/android/uapi/sy

Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

Op 29-01-16 om 22:20 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > This only helps if you reject flags != 0 in the ioctl, else whe

[PATCH] Staging: speakup: Fix allyesconfig build on mn10300

mn10300 uses an mmio-driven uart. This is not supported by speakup, so prevent from enabling it. Signed-off-by: Samuel Thibault --- a/drivers/staging/speakup/Kconfig +++ b/drivers/staging/speakup/Kconfig @@ -1,7 +1,7 @@ menu "Speakup console speech" config SPEAKUP - depends on VT +