[PATCH 0/2] Staging:iio:adc:Prefer using BIT macro

2016-02-07 Thread Bhumika Goyal
This patchset replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ int g; @@ -(1 << g) +BIT(g) Bhumika Goyal (2): Staging:iio:Prefer using BIT macro Staging: iio: adc: Prefer using the BIT macro drivers/staging/iio/adc/ad7280a.c | 4 ++-- drivers/staging/iio/

[PATCH 1/2] Staging:iio:Prefer using BIT macro

2016-02-07 Thread Bhumika Goyal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ int g; @@ -(1 << g) +BIT(g) Signed-off-by: Bhumika Goyal --- drivers/staging/iio/adc/ad7816.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/dri

[PATCH 2/2] Staging: iio: adc: Prefer using the BIT macro

2016-02-07 Thread Bhumika Goyal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ int g; @@ -(1 << g) +BIT(g) Signed-off-by: Bhumika Goyal --- drivers/staging/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7280a

[PATCHv2] staging: dgnc: convert to wait_event_interruptible_timeout

2016-02-07 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango This patch makes use of wait_event_interruptible_timeout to achieve timeout functionality.This is a TODO mentiond in the comment which is also removed.It also aligns with what the function is supposed to do as in the comments. Signed-off-by: Hari Prasath Gujulan

Re: drivres/hv

2016-02-07 Thread Greg KH
On Mon, Nov 30, 2015 at 01:15:32PM -0800, K. Y. Srinivasan wrote: > > Greg, over the last month or more we have sent numerous Hyper-V patches and > these are yet to be comitted (all review comments have been addressed > for these patches). Please let me know if I should resend these patches. All

patch "staging: sm750fb, fix typos" added to staging-next

2016-02-07 Thread gregkh
This is a note to let you know that I've just added the patch titled staging: sm750fb, fix typos to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. The patch will show up in the next release of the li

Re: [PATCH V2 06/13] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

2016-02-07 Thread Greg KH
On Wed, Jan 27, 2016 at 10:29:38PM -0800, K. Y. Srinivasan wrote: > From: Dexuan Cui > > A helper function is also added. > > Signed-off-by: Dexuan Cui > Signed-off-by: K. Y. Srinivasan > --- > include/linux/hyperv.h |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff

[PATCHv2] staging: rtl8192e: prefer using eth_broadcast_addr()

2016-02-07 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango Prefer using the eth_broadcast_addr() instead of memset to broadcast address 0xFF to the array. Signed-off-by: Hari Prasath Gujulan Elango --- v2: From email address was missing as pointed by Greg. --- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--

Re: [PATCH] Staging: xgifb: vgatypes.h: Coding style warning fix for block comments

2016-02-07 Thread Kroah-Hartman
On Fri, Jan 15, 2016 at 05:30:02PM +0800, YU Bo wrote: > This patch is to vgatypes.h file that fixes up following warnings > reported by checkpatch.pl tool > > Signed-off-by: YU Bo > --- > drivers/staging/xgifb/vgatypes.h | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) No

Re: [PATCH] drivers: staging: xgifb: vgatypes.h: fixed coding style warnings

2016-02-07 Thread Greg KH
On Wed, Jan 13, 2016 at 05:11:56PM +0530, Saatvik Arya wrote: > fixed warnings about comment block coding style > > Signed-off-by: Saatvik Arya > --- > drivers/staging/xgifb/vgatypes.h | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Why did you resend this without saying why y

Re: [PATCH] staging: dgnc: convert to wait_event_interruptible_timeout

2016-02-07 Thread gre...@linuxfoundation.org
On Thu, Dec 24, 2015 at 01:54:12PM +, Gujulan Elango, Hari Prasath (H.) wrote: > This patch makes use of wait_event_interruptible_timeout to achieve timeout > functionality.This is a TODO mentiond in the comment which is also removed. > It also aligns with what the function is supposed to do a

Re: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with !

2016-02-07 Thread Greg Kroah-Hartman
On Sat, Dec 12, 2015 at 06:45:59AM -0800, Benjamin Young wrote: > Fixed coding style for null comparisons in netlogic driver to be more > consistant > with the rest of the kernel coding style > > Signed-off-by: Benjamin Young > --- > drivers/staging/netlogic/xlr_net.c | 8 > 1 file cha

Re: [PATCH] staging: netlogic: Coding Style Alignment should match open parenthesis

2016-02-07 Thread Greg KH
On Sat, Dec 12, 2015 at 09:49:37PM -0800, Benjamin Young wrote: > Fixed alignment issues with parenthesis so the code is easier to read. > > Signed-off-by: Benjamin Young > --- > drivers/staging/netlogic/platform_net.c | 12 +-- > drivers/staging/netlogic/xlr_net.c | 159 > +++

Re: [PATCH 172/182] staging: vme: use gpiochip data pointer

2016-02-07 Thread Greg Kroah-Hartman
On Wed, Dec 09, 2015 at 02:50:05PM +0100, Linus Walleij wrote: > This makes the driver use the data pointer added to the gpio_chip > to store a pointer to the state container instead of relying on > container_of(). > > Cc: Greg Kroah-Hartman > Cc: Martyn Welch > Cc: Manohar Vanga > Cc: de...@dr

Re: [PATCH] staging: clocking-wizard: add blank line after struct declaration.

2016-02-07 Thread Greg KH
On Sun, Feb 07, 2016 at 08:06:16PM -0800, Greg KH wrote: > On Tue, Dec 01, 2015 at 01:56:01PM +0100, Christian Colic wrote: > > Add blank line after struct declaration to fix checkpatch check. > > > > Signed-off-by: Christian Colic > > Reviewed-by: Soren Brinkmann > > > > --- > > drivers/stagi

VERY URGENT

2016-02-07 Thread Andrew Smith
Dr.Richard Anderson, No 15 Alfateh St Damascus Syria Hello Friend, My name is Dr.Richard Anderson, a citizen of France a doctor and personal adviser to the Syrian deputy defense minister, late Assef Shawkat; who was killed on the 18th of July 2012, we are all moving our money out of Syria I need

Re: [PATCH] staging: clocking-wizard: add blank line after struct declaration.

2016-02-07 Thread Greg KH
On Tue, Dec 01, 2015 at 01:56:01PM +0100, Christian Colic wrote: > Add blank line after struct declaration to fix checkpatch check. > > Signed-off-by: Christian Colic > Reviewed-by: Soren Brinkmann > > --- > drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + > 1 file changed, 1 ins

Re: [PATCH] staging: olpc_dcon: Added a space

2016-02-07 Thread Greg KH
On Tue, Nov 24, 2015 at 10:41:03PM +0530, Anjali Menon wrote: > Added a space around '/' to remove the check detected by > the checkpatch.pl. > > CHECK: spaces preferred around that '/' (ctx:VxV) > > Signed-off-by: Anjali Menon > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- > 1 file chan

Re: [PATCH 2/2] Staging: rts5208: Add missing dma_mapping_error

2016-02-07 Thread Greg KH
On Mon, Jan 25, 2016 at 06:27:28PM -0800, Shaun Ren wrote: > Signed-off-by: Shaun Ren > --- I can't take a patch without a changelog entry, sorry. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listi

Re: [PATCH 1/2] Staging: rts5208: Cleanup rtsx_transport.c

2016-02-07 Thread Greg KH
On Mon, Jan 25, 2016 at 06:27:27PM -0800, Shaun Ren wrote: > This patch fixes coding style issues in rtsx_transport.c. > > Signed-off-by: Shaun Ren > --- > drivers/staging/rts5208/rtsx_transport.c | 115 > +-- > 1 file changed, 65 insertions(+), 50 deletions(-) What

Re: [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr()

2016-02-07 Thread gre...@linuxfoundation.org
On Wed, Jan 20, 2016 at 01:06:13PM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango When you do this, you need an email address after the name, otherwise git complains and refuses to apply the patch. Please fix up and resend. thanks, greg k-h

Re: [PATCH v2] staging/dgap: move duplicated code from the dgap_cm.* functions

2016-02-07 Thread Greg Kroah-Hartman
On Wed, Nov 25, 2015 at 11:51:21PM +0600, Alexander Kuleshov wrote: > The dgap driver contains three functions: dgap_cmdb(), dgap_cmdw() > and dgap_cmdw_exit which are contain duplicated code which waits > if necessary before updating the pointer to limit outstanding > commands. This patch introduc

Re: [PATCH 4/4] staging: rtl8192u: r8192U_core: use kmalloc_array instead of kmalloc

2016-02-07 Thread Greg Kroah-Hartman
On Sun, Nov 08, 2015 at 10:17:54PM +0800, Geliang Tang wrote: > Use kmalloc_array instead of kmalloc to allocate memory for an array. > > Signed-off-by: Geliang Tang > --- > drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drive

Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning.

2016-02-07 Thread Greg Kroah-Hartman
On Sat, Feb 06, 2016 at 08:11:11PM +0530, Pinkesh Badjatiya wrote: > Fix Comparisons with constant on the left side of the test. > Checkpatch.pl warning. > -- > WARNING: Comparisons should place the constant on the right side of the > test > 296: FILE: ./rtl8712_cmd.c:296: > while ((0 != r871

Re: [PATCH v2 2/4] staging: rtl8712: Rename local variable

2016-02-07 Thread Greg KH
On Wed, Nov 25, 2015 at 03:42:40PM -0200, Mauro Dreissig wrote: > Renames all instances of struct _adapter to adapter in rtl871x_ioctl_rtl.c, > avoiding camel case. > > Signed-off-by: Mauro Dreissig > --- > drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 > ++--- > 1 fi

Re: [PATCH] staging: rtl8712: Fix typos and checkpatch warnings.

2016-02-07 Thread Greg KH
On Tue, Nov 17, 2015 at 01:23:54PM +0100, Christian Colic wrote: > Fix typo SUCESS -> SUCCESS and multiple > checkpatch checks (blank line, indentation). That's multiple different things, please break this into multiple patches, each one only doing one thing. thanks, greg k-h ___

Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

2016-02-07 Thread Greg KH
On Wed, Nov 25, 2015 at 01:04:14PM -0200, Mauro Dreissig wrote: > On 25-11-2015 12:56, Mauro Dreissig wrote: > > On 25-11-2015 09:44, Sudip Mukherjee wrote: > >> On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote: > >>> Some error handling paths are checking for success > >>> instead of

Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning.

2016-02-07 Thread Greg Kroah-Hartman
On Sat, Feb 06, 2016 at 08:53:57AM -0600, Larry Finger wrote: > On 02/06/2016 08:41 AM, Pinkesh Badjatiya wrote: > >Fix Comparisons with constant on the left side of the test. > >Checkpatch.pl warning. > >-- > >WARNING: Comparisons should place the constant on the right side of the > >test > >296:

Re: [PATCH] staging: fbtft: Use monotonic clock

2016-02-07 Thread Greg KH
On Sun, Jan 31, 2016 at 11:29:05PM -0500, Abhilash Jindal wrote: > Wall time obtained from getnstimeofday is susceptible to sudden jumps due to > user setting the time or due to NTP. Monotonic time is constantly increasing > time better suited for comparing two timestamps > > Signed-off-by: Abhila

Re: [PATCH 13/13] staging: fbtft: Remove unused and duplicated defines

2016-02-07 Thread Greg Kroah-Hartman
On Sun, Feb 07, 2016 at 07:40:06PM -0800, Greg Kroah-Hartman wrote: > On Sun, Dec 20, 2015 at 08:36:07PM +0200, Priit Laes wrote: > > This patch makes use of the standard MIPI Display Command Set to remove > > some of duplicate defines from the headers. > > > > Signed-off-by: Priit Laes > > --- >

Re: [PATCH 13/13] staging: fbtft: Remove unused and duplicated defines

2016-02-07 Thread Greg Kroah-Hartman
On Sun, Dec 20, 2015 at 08:36:07PM +0200, Priit Laes wrote: > This patch makes use of the standard MIPI Display Command Set to remove > some of duplicate defines from the headers. > > Signed-off-by: Priit Laes > --- > drivers/staging/fbtft/fb_hx8357d.h | 32 > dr

Re: [PATCH v2 1/2] staging: fwserial: Fix pointer comparison to NULL checkpatch problem

2016-02-07 Thread Greg KH
On Tue, Dec 01, 2015 at 03:18:11PM +0530, Rajan Vaja wrote: > Fix pointer comparison to NULL problem reported by checkpatch. > > Signed-off-by: Rajan Vaja > --- > drivers/staging/fwserial/dma_fifo.c | 10 +- > drivers/staging/fwserial/fwserial.c |4 ++-- > 2 files changed, 7 insert

Re: [PATCH RESEND v2 1/8] staging: fsl-mc: static inline function to differentiate root dprc

2016-02-07 Thread Greg KH
On Fri, Dec 11, 2015 at 01:25:47PM -0600, Lijun Pan wrote: > Define a static inline function is_root_dprc(dev) to tell whether > a device is root dprc or not via platform_bus_type. > Remove fsl_mc_is_root_dprc() because is_root_dprc() is simpler > and easier to understand. > > Signed-off-by: Lijun

Re: [PATCH] Staging: wlan-ng: prism2mgmt.h: Coding style warning fix for block comments

2016-02-07 Thread Kroah-Hartman
On Sun, Jan 17, 2016 at 05:48:49AM +0800, YU Bo wrote: > This patch is to prism2mgmt.h file that fixes up following warnings > reported by checkpatch.pl: > A): Block comments use a trailing */ on a separate line > > Signed-off-by: YU BO > --- > drivers/staging/wlan-ng/prism2mgmt.h |8 ---

Re: [PATCH] staging: vt6655: rf.c: checkpatch fixes

2016-02-07 Thread Greg Kroah-Hartman
On Mon, Jan 11, 2016 at 11:16:08PM +, Lewis Eason wrote: > This patch fixes "spaces preferred around that $operator" checks. > > Signed-off-by: Lewis Eason > --- > drivers/staging/vt6655/rf.c | 638 > ++-- > 1 file changed, 319 insertions(+), 319 dele

Re: [PATCH 1/6] staging: rtl8188eu: add spaces around binary '*'

2016-02-07 Thread Greg Kroah-Hartman
On Wed, Dec 02, 2015 at 10:54:00PM +0100, Luca Ceresoli wrote: > Fix checkpatch issue: > CHECK: spaces preferred around that '*' (ctx:VxV) > > Signed-off-by: Luca Ceresoli > Cc: Larry Finger > Cc: Greg Kroah-Hartman Odd, I don't think I've ever used gre...@linux.com anywhere, where did you f

Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

2016-02-07 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2015 at 05:17:50PM +0700, Ivan Safonov wrote: > On 11/11/2015 04:43 PM, Dan Carpenter wrote: > >On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote: > >>_rtl88e_fill_dummy fills the array elemets with zeros if necessary. > >> > >_rtl88e_fill_dummy() fills the last sizeof(u3

patch "staging: sm750fb, fix typos" added to staging-testing

2016-02-07 Thread gregkh
This is a note to let you know that I've just added the patch titled staging: sm750fb, fix typos to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-testing branch. The patch will show up in the next release of the

Re: [PATCH] staging: sm750fb: Fix comments style

2016-02-07 Thread Greg Kroah-Hartman
On Wed, Dec 02, 2015 at 08:18:11PM +0100, sebastian.lawnic...@yahoo.com wrote: > From: Sebastian Lawniczak > > Fix warnings reported by checkpatch.pl in block comments. > > Signed-off-by: Sebastian Lawniczak > --- > drivers/staging/sm750fb/ddk750_chip.c | 70 > +++-

Re: [PATCH RESEND 00/18] staging: sm750fb: change some register fields defines

2016-02-07 Thread Greg Kroah-Hartman
On Sun, Jan 17, 2016 at 08:04:13PM +0200, Mike Rapoport wrote: > Hi, > > This is the first set of patches that aim to replace custom defines for > register fields. The ultimate goal is to have MSB:LSB notation for register > fields and FIELD_* macros removed. For some reason you resent this, and

Re: [PATCH] Staging: comedi.h: Fix coding style issue in comedi.h

2016-02-07 Thread Kroah-Hartman
On Thu, Jan 14, 2016 at 11:06:25PM +0800, YU Bo wrote: > This is a patch to the comedi.h file that fixes up warnings found by the > checkpatch.pl tool > > Signed-off-by: YU Bo > --- > drivers/staging/comedi/comedi.h | 260 > +++ > 1 个文件被修改,插入 154 行(+),删除 106

Re: [PATCH] Staging: comedi: fix more characters coding style issue in comedi_pcmcia.h

2016-02-07 Thread Kroah-Hartman
On Thu, Jan 14, 2016 at 09:46:57PM +0800, YU Bo wrote: > This is a patch to the comedi_pcmcia.h file that fixes up a "line over > 80 characters" warning found by the checkpatch.pl tool > > Signed-off-by: YU Bo > --- > drivers/staging/comedi/comedi_pcmcia.h |3 ++- > 1 个文件被修改,插入 2 行(+),删除 1

Re: [PATCH] Staging: comedi: fix coding style issue in comedilib.h

2016-02-07 Thread Greg KH
On Thu, Jan 14, 2016 at 09:40:14AM +0800, Bo YU wrote: > This is a patch to the comedilib.h file that fixes "bloch comment use > * on subsequent lines" warning found by the checkpatch.pl tool > > Signed-off-by: YU Bo > --- > drivers/staging/comedi/comedilib.h | 32

Re: [PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could be written "!r"

2016-02-07 Thread Greg KH
On Fri, Dec 11, 2015 at 04:39:26PM -0500, Benjamin Young wrote: > Fixed coding style for null comparisons in goldfish_audio.c to be more > consistant > with the rest of the kernel coding style > > Signed-off-by: Benjamin Young > --- > drivers/staging/goldfish/goldfish_audio.c | 6 +++--- > 1 fi

Re: [PATCH v2 0/2] Staging: goldfish: Checkpatch cleanups

2016-02-07 Thread Greg Kroah-Hartman
On Thu, Jan 07, 2016 at 11:08:36PM +0530, Shraddha Barke wrote: > These patches remove the last few checkpatch warnings in staging/goldfish > directory > > Shraddha Barke (2): > Staging: goldfish: Add space around + > Staging: goldfish: Remove explicit NULL comparison > > drivers/staging/go

Re: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around that '+'

2016-02-07 Thread Greg KH
On Fri, Dec 11, 2015 at 04:38:59PM -0500, Benjamin Young wrote: > Helped improve coding style to make arithemethic easier to read > > Signed-off-by: Benjamin Young > --- > drivers/staging/goldfish/goldfish_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH 0/2] Lustre debugfs fixes

2016-02-07 Thread Greg Kroah-Hartman
On Sun, Feb 07, 2016 at 06:51:09PM -0500, Oleg Drokin wrote: > > On Feb 7, 2016, at 4:39 PM, Greg Kroah-Hartman wrote: > > > On Sat, Feb 06, 2016 at 02:01:49AM -0500, gr...@linuxhacker.ru wrote: > >> From: Oleg Drokin > >> > >> These two patches tie some loose ends from the Lustre debugfs conve

Re: [PATCH 0/2] Lustre debugfs fixes

2016-02-07 Thread Oleg Drokin
On Feb 7, 2016, at 4:39 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 06, 2016 at 02:01:49AM -0500, gr...@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> These two patches tie some loose ends from the Lustre debugfs conversion, >> but while investigating them I also accumulated some questions >>

Re: [PATCH] Staging: android: Fix brace coding style warning in sync_debug.c

2016-02-07 Thread Greg KH
On Tue, Jan 26, 2016 at 05:31:33PM -0800, Bopamo Osaisai wrote: > This is a patch to the sync_debug.c file that rectifies a brace warning > that was found with the checkpatch.pl tool > > Signed-off-by: Bopamo Osaisai > --- > drivers/staging/android/sync_debug.c | 3 +-- > 1 file changed, 1 inser

Re: [PATCH] staging: android: sync_debug: Fixed braces related coding style issue

2016-02-07 Thread Greg KH
On Sun, Jan 24, 2016 at 03:51:32PM +0530, Tapan Prakash T wrote: > This patch fixes checkpatch.pl warning in file sync_debug > WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Tapan Prakash T > --- > drivers/staging/android/sync_debug.c | 3 +-- > 1 file change

Re: [PATCH RESEND] staging: android: sync_debug.c: remove unnecessary braces

2016-02-07 Thread Greg KH
On Tue, Jan 19, 2016 at 12:29:41PM +0100, Robin Krahl wrote: > Remove unnecessary braces {} around a single statement within a for loop. > Indicated by checkpatch. > > Signed-off-by: Robin Krahl > --- > drivers/staging/android/sync_debug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-

Re: [PATCH] staging: android: sync_debug.c: remove unnecessary braces

2016-02-07 Thread Greg KH
On Wed, Jan 06, 2016 at 10:36:46PM +0100, Robin Krahl wrote: > Remove unnecessary braces {} around a single statement within a for loop. > Indicated by checkpatch. > > Signed-off-by: Robin Krahl > --- > drivers/staging/android/sync_debug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-

Re: [PATCH] android/binder: fix fput comment

2016-02-07 Thread Greg Kroah-Hartman
On Fri, Dec 25, 2015 at 09:47:17PM +0100, Jann Horn wrote: > Just something I noticed while looking at FD-passing code. > Didn't test the change. > > BUG_ON is intentional, if someone rewrites the code to hit > that, it can be a security issue. Never add BUG to the kernel, you just crashed the ma

Re: [PATCH] staging: android: sync.c: Changed the ways nullptrs were being checked

2016-02-07 Thread Greg Kroah-Hartman
On Thu, Dec 31, 2015 at 11:47:15PM -0800, Chase Metzger wrote: > Removed all checkpatch.pl CHECKs that suggested to check NULL by > !obj instead of obj == NULL. > > Signed-off-by: Chase Metzger > --- > drivers/staging/android/sync.c | 18 +- > 1 file changed, 9 insertions(+), 9 d

[PATCH 4/5] iio: hmc5843: Fix comment style warnings

2016-02-07 Thread Cristina Moraru
Fix comment style warnings in order to comply with Coding Style standard provided by Documentation/CodingStyle. This patch solves following issue found with checkpatch: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Cristina Moraru --- drivers/staging/iio/magnetomet

[PATCH 5/5] iio: hmc5843: Move hmc5843 out of staging

2016-02-07 Thread Cristina Moraru
This patch moves hmc5843 driver from staging/iio/magnetometer to iio/magnetometer, updates the corresponding Makefiles and moves the hmc5843* entries to the 'Industrial I/O support -> Magnetometer sensors' menu. Signed-off-by: Cristina Moraru --- drivers/iio/magnetometer/Kconfig|

[PATCH 1/5] iio: hmc5843: Add attribute for available measurement config

2016-02-07 Thread Cristina Moraru
Add static attribute meas_conf_available to show available configurations for the bias current. API for setting bias measurement configuration: 0 - Normal measurement configuration (default): In normal measurement configuration the device follows normal measurement flow. Pins BP and BN ar

[PATCH 2/5] iio: hmc5843: Swap suspend and resume implementations

2016-02-07 Thread Cristina Moraru
Swap implementations of hmc5843_common_suspend and hmc5843_common_resume functions for they have been inversed. Device should go on SLEEP mode on suspend and on CONTINUOUS mode on resume. Signed-off-by: Cristina Moraru --- drivers/staging/iio/magnetometer/hmc5843_core.c | 4 ++-- 1 file changed,

[PATCH 0/5] iio: hmc5843: Fix issues and move out of staging

2016-02-07 Thread Cristina Moraru
Fix driver issues and add completions. Add custom attribute to display available values for bias current, add documentation for undocumented custom attributes, swap implementation of two functions that have been inversed, fix checkpatch warnings and, move the driver from the staging directory to dr

[PATCH 3/5] iio: hmc5843: Add ABI documentation file for hmc5843

2016-02-07 Thread Cristina Moraru
Add ABI file documenting hmc5843 non-standard attributes meas_conf and meas_conf_available for bias current configuration. Signed-off-by: Cristina Moraru --- .../ABI/testing/sysfs-bus-iio-magnetometer-hmc5843| 15 +++ 1 file changed, 15 insertions(+) create mode 100644 Docum

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

2016-02-07 Thread Greg KH
On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote: > Fixes following coding style issues reported by the check patch script. > - ERROR: Macros with complex values should be enclosed in parentheses > > Moving static storage class to the beginning of declaration fixes the

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

2016-02-07 Thread Julian Calaby
Hi Geliang, On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote: > This patch cleans whitespaces and blank lines surrounding > list_for_each_entry*(). It does a lot more than this, including: - Removing some unnecessary brackets - Whitespace changes well away from the list_for_each_entry*() cal

Re: [PATCH 1/2] staging: most: return error value

2016-02-07 Thread Greg Kroah-Hartman
On Fri, Nov 27, 2015 at 01:07:49PM +0530, Sudip Mukherjee wrote: > On error we were returning retval, but retval is not having the error > value. We will get the error value using PTR_ERR. > > Signed-off-by: Sudip Mukherjee > --- > > This series doesnot depend on my earlier pending series. > >

Re: [PATCH 2/3] staging: most: return proper error

2016-02-07 Thread Greg Kroah-Hartman
On Sun, Nov 22, 2015 at 10:30:55PM +0530, Sudip Mukherjee wrote: > We were returning ENOMEM on all types of errors. Lets return the actual > error code. At the same time remove the label which became unused as a > result of this patch. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/m

Re: [PATCH] staging: unisys: remove unnecessary goto

2016-02-07 Thread Greg KH
On Mon, Dec 07, 2015 at 10:58:36AM -0500, Benjamin Romer wrote: > parser_param_start() had a goto Away, which went to nothing but > a return statement. Remove the goto, the CamelCased label, and > just return directly. > > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/visorbus/vis

Re: [PATCH 00/16] staging: unisys: cleanup series

2016-02-07 Thread Greg KH
On Fri, Jan 29, 2016 at 10:21:26AM -0500, Benjamin Romer wrote: > This patch series cleans up all the remaining issues reported by > checkpatch.pl that can be fixed. The series was rebased against > the current contents of staging-next. As this was a 'v2' series of patches, you should have said so

Re: [PATCH v2] staging: unisys: use common return path

2016-02-07 Thread Greg Kroah-Hartman
On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote: > The success path and the error path both are first doing > spin_unlock_irqrestore() before returning. Use that in the common path > and return the success/error value. > > Signed-off-by: Sudip Mukherjee > --- > > v2: changed labe

Re: [PATCH 5/8] staging: wilc1000: fix return type of wilc_send_config_pkt

2016-02-07 Thread Greg KH
On Fri, Feb 05, 2016 at 10:35:15AM +0900, Chaehyun Lim wrote: > wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return > value of wilc_wlan_cfg_get or wilc_wlan_cfg_set. > It is better to use int type to represent linux standard error code. > > Signed-off-by: Chaehyun Lim > --- > d

Re: [PATCH RESEND 40/70] staging: wilc1000: wilc_wlan.c: replaces PRINT_ER with netdev_err

2016-02-07 Thread Greg KH
On Thu, Feb 04, 2016 at 06:24:01PM +0900, Glen Lee wrote: > From: Leo Kim > > This patches replaces PRINT_ER with netdev_err. No, that's not what this patch does :( > Removes unnecessary debug logs as well. That's what this patch does. Please be more careful. I'm not going to apply this patc

Re: [PATCH RESEND 41/70] staging: wilc1000: linux_mon.c: replaces PRINT_ER with netdev_err

2016-02-07 Thread Greg KH
On Thu, Feb 04, 2016 at 06:24:02PM +0900, Glen Lee wrote: > From: Leo Kim > > This patches replaces PRINT_ER with netdev_err. It also does more than that: > @@ -273,7 +266,9 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb, > /* if source address and bssid fields are equal>>Mac

Re: [PATCH 0/2] Lustre debugfs fixes

2016-02-07 Thread Greg Kroah-Hartman
On Sat, Feb 06, 2016 at 02:01:49AM -0500, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > These two patches tie some loose ends from the Lustre debugfs conversion, > but while investigating them I also accumulated some questions > that would be good to get answers for. > > 1. Unlike procfs,

Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

2016-02-07 Thread Samuel Thibault
Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote: > I guess there are many other platforms where the UART is MMIO-driven... Actually they can't ever get to be exposed to speakup's serialio.c: their SERIAL_PORT_DFNS would set SERIAL_IO_MEM in the io_type field, but that field doesn't ev

Re: [PATCH] [media] media: davinci_vpfe: fix missing unlock on error in vpfe_prepare_pipeline()

2016-02-07 Thread Sakari Ailus
Hi Wei, On Fri, Feb 05, 2016 at 09:52:00PM +0800, weiyj...@163.com wrote: > From: Wei Yongjun > > Add the missing unlock before return from function > vpfe_prepare_pipeline() in the error handling case. > > video->lock is lock/unlock in function vpfe_open(), > and no need to unlock it here, so

Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

2016-02-07 Thread Samuel Thibault
Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote: > On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault > wrote: > > mn10300 uses an mmio-driven uart. This is not supported by speakup, so > > prevent from enabling it. > > Just wondering, what are the symptoms of the failure? It'll try to

Re: [PATCH RESEND 3/3] PCI: hv: New paravirtual PCI front-end for Hyper-V VMs

2016-02-07 Thread kbuild test robot
Hi Jake, [auto build test ERROR on pci/next] [also build test ERROR on v4.5-rc2 next-20160205] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/jakeo-microsoft-com/PCI-hv-New-paravirtual-PCI-fro

Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

2016-02-07 Thread Geert Uytterhoeven
Hi Samuel, On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault wrote: > mn10300 uses an mmio-driven uart. This is not supported by speakup, so > prevent from enabling it. Just wondering, what are the symptoms of the failure? Is it a compile-time or run-time failure? Is this about drivers/staging/sp

Re: [PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse

2016-02-07 Thread Niranjan Dighe
On Thu, Feb 4, 2016 at 3:53 AM, Greg Kroah-Hartman wrote: > On Sun, Jan 03, 2016 at 08:27:04AM +0530, Niranjan Dighe wrote: >> Added annotation '__must_hold' to function ksocknal_send_keepalive_locked >> which unlocks the lock ksocknal_data.ksnd_global_lock. As this lock is >> not acquired in the