Re: [PATCH] staging: dgap: dgap.c: fixed whitespace error caused by my patch

On Sat, Mar 12, 2016 at 05:10:29PM -0800, Gavin O'Leary wrote: > Signed-off-by: Gavin O'Leary > --- > drivers/staging/dgap/dgap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c > index 9e07a39..7845516 100644 > -

Re: [PATCH] staging: dgap: dgap.c: Fixed a comment warning

On Sat, Mar 12, 2016 at 05:03:01PM -0800, Gavin O'Leary wrote: > Signed-off-by: Gavin O'Leary I can't take a patch without a changelog entry. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/l

[PATCH v3 0/5] staging: unisys: visorbus: cleanup gotos in visorbus_main.c

This patchset cleans up the gotos found in visorbus_main.c v3 changes: - Fixed compile bug in rename create_visor_device gotos by changing rc to err v2 changes: - Added patch from Tim Sell that remove sysfs devmajorminor, which allowed us to remove two different patches from original patchse

[PATCH v3 2/5] staging: unisys: visorbus: remove unused sysfs attribute devmajorminor/*

From: Tim Sell The sysfs attribute directory at: /sys/bus/visorbus/devices/vbus:dev/devmajorminor/* or /sys/devices/visorbus/vbus:dev/devmajorminor/* previously provided a location where a visorbus function driver could publish information (for usermode use) about possibly-multiple ma

[PATCH v3 4/5] staging: unisys: visorbus: Remove gotos in visorbus_match

Gotos in visorbus_match are not needed. Signed-off-by: David Kershner Signed-off-by: Timothy Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b

[PATCH v3 5/5] staging: unisys: visorbus: rename create_visor_device gotos

Away is ambiguous when specifying error vs success. Make return labels more meaningful by marking them as error paths. Signed-off-by: David Kershner Signed-off-by: Timothy Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 18 +- 1 file changed, 9 insertions(+), 9 deleti

[PATCH v3 3/5] staging: unisys: visorbus: fix up gotos in visorbus_init

This patch fixes the gotos in visorbus_init Signed-off-by: David Kershner Signed-off-by: Timothy Sell --- drivers/staging/unisys/visorbus/visorbus_main.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.

[PATCH v3 1/5] staging: unisys: visorbus: Fix up visordriver_probe

Fixup the visordriver_probe function. Rearrange the function to avoid needing gotos and removed unnecessary wmb(). Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/visorbus_main.c | 32 ++--- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/dri

[PATCH] media: add GFP flag to media_*() that could get called in atomic context

Add GFP flags to media_create_pad_link(), media_create_intf_link(), media_devnode_create(), and media_add_link() that could get called in atomic context to allow callers to pass in the right flags for memory allocation. tree-wide driver changes for media_*() GFP flags change: Change drivers to add

[PATCH] staging: dgap: dgap.c: fixed whitespace error caused by my patch

Signed-off-by: Gavin O'Leary --- drivers/staging/dgap/dgap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 9e07a39..7845516 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -4819,7 +

[PATCH] staging: dgap: dgap.c: Fixed a comment warning

Signed-off-by: Gavin O'Leary --- drivers/staging/dgap/dgap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index bad3551..9e07a39 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -4819,7 +

Re: [PATCH 1/6] staging: lustre: Correct missing newline for CERROR call in sfw_handle_server_rpc

On Sat, 2016-03-12 at 19:17 +, Drokin, Oleg wrote: > On Mar 12, 2016, at 1:56 PM, Joe Perches wrote: > > On Sat, 2016-03-12 at 18:32 +, Drokin, Oleg wrote: > > > On Mar 12, 2016, at 1:23 PM, Joe Perches wrote: > > > > On Sat, 2016-03-12 at 13:00 -0500, James Simmons wrote: > > > > > From: J

[PATCH 1/1] scsi: storvsc: Support manual scan of FC hosts on Hyper-V

The default user scan function associated with FC (fc_user_scan) is not suitable for FC hosts on Hyper-V since we don't have an rport associated with FC host on Hyper-V . Set it to NULL so we can support manual scan of FC targets on Hyper-V. Signed-off-by: K. Y. Srinivasan Tested-by: Long Li Rev

[PATCHv2] staging: rtl8723au: Fix line longer than 80 columns.

This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Edward Lipinsky --- Change in v2: - Break the line after the format string, as suggested by Joe Perches . drivers/staging/rtl8723au/core/rtw_ap.c |3 ++- 1 file changed, 2 insertio

Re: [PATCH 1/6] staging: lustre: Correct missing newline for CERROR call in sfw_handle_server_rpc

On Sat, 2016-03-12 at 18:32 +, Drokin, Oleg wrote: > On Mar 12, 2016, at 1:23 PM, Joe Perches wrote: > > On Sat, 2016-03-12 at 13:00 -0500, James Simmons wrote: > > > From: James Nunez > > > > > > This is one of the fixes broken out of patch 1 that was > > > missed in the merger. With thi

Re: [PATCH 1/6] staging: lustre: Correct missing newline for CERROR call in sfw_handle_server_rpc

On Mar 12, 2016, at 1:56 PM, Joe Perches wrote: > On Sat, 2016-03-12 at 18:32 +, Drokin, Oleg wrote: >> On Mar 12, 2016, at 1:23 PM, Joe Perches wrote: >>> On Sat, 2016-03-12 at 13:00 -0500, James Simmons wrote: From: James Nunez This is one of the fixes broken out of patch 1

Re: [PATCH 1/6] staging: lustre: Correct missing newline for CERROR call in sfw_handle_server_rpc

On Sat, 2016-03-12 at 13:00 -0500, James Simmons wrote: > From: James Nunez > > This is one of the fixes broken out of patch 1 that was > missed in the merger. With this fix the CERROR called in > sfw_handle_server_rpc will print out correctly. Speaking of CERROR and logging, it it really us

Re: [PATCH 1/6] staging: lustre: Correct missing newline for CERROR call in sfw_handle_server_rpc

On Mar 12, 2016, at 1:23 PM, Joe Perches wrote: > On Sat, 2016-03-12 at 13:00 -0500, James Simmons wrote: >> From: James Nunez >> >> This is one of the fixes broken out of patch 1 that was >> missed in the merger. With this fix the CERROR called in >> sfw_handle_server_rpc will print out co

[PATCH 2/6] staging: lustre: add missing buffer overflow fix for console.c

From: Dmitry Eremin Patch 9389 change a strncpy call into a strlcpy call. This was missed in the merger into the upstream client. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-on: http://review.whamcloud.com/9389 Reviewed-by: Andreas Dilger Revi

[PATCH 6/6] staging: lustre: cleanup comment style for lnet selftest

Apply a consistent style for comments in the lnet selftest code. Realign some of the comments to make it easier to read. This also fixes a few checkpatch issues as well. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |2 +- drivers/staging/lustre/lnet/selft

[PATCH 5/6] staging: lustre: realign some code in lnet selftest so its readable

Two places to align the code so it is easier to read. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/console.c |2 +- drivers/staging/lustre/lnet/selftest/ping_test.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/l

[PATCH 4/6] staging: lustre: remove excess blank lines in lnet selftest code

Remove extra blank lines missed by checkpatch. Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/brw_test.c |2 -- drivers/staging/lustre/lnet/selftest/conrpc.c |2 -- drivers/staging/lustre/lnet/selftest/console.c |2 -- 3 files changed, 0 insertions(+), 6 del

[PATCH 0/6] Last batch of lnet selftest cleanup

Some fixes from two earlier patches got dropped so we add them to this batch. Last of the style cleanups for LNet selftest. Redid the comment style patch to format the comments correctly. Dmitry Eremin (1): staging: lustre: add missing buffer overflow fix for console.c James Nunez (1): stagin

[PATCH 1/6] staging: lustre: Correct missing newline for CERROR call in sfw_handle_server_rpc

From: James Nunez This is one of the fixes broken out of patch 1 that was missed in the merger. With this fix the CERROR called in sfw_handle_server_rpc will print out correctly. Signed-off-by: James Nunez Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4871 Reviewed-on: http://review.w

[PATCH 3/6] staging: lustre: handle error returned from wait_event_timeout seltest timer

The function wait_event_timeout can fail and return an error. Handle this case in stt_timer_main(). Signed-off-by: James Simmons --- drivers/staging/lustre/lnet/selftest/timer.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest

Re: [PATCH] staging/android: change IOCTLs opcode after ABI change

On Fri, Mar 11, 2016 at 5:00 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 07:42:43PM -0300, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Burn the old opcode to avoid any potential old userspace running the old >> API to get weird errors. Changing the opcodes will make them fai

[staging:staging-testing 1317/1582] warning: (LUSTRE_FS) selects LNET which has unmet direct dependencies (STAGING && ..)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 2df122bdebaba1daad3a8087b89a5e3456474538 commit: b08bb6bb5af5d1df8f41399f931efa1673fac1ac [1317/1582] staging: lustre: make lustre dependent on LNet config: x86_64-randconfig-b0-03122341 (attached a

[PATCH] Staging: rtl8192e: Fix warning exceeding characters per line

This patch fixes the checkpatch.pl warning regarding the exceeding 80 characters on line 36. This patch add a newline after function statement on line 52 Signed-off-by: Adonis Settouf --- drivers/staging/rtl8192e/dot11d.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

Re: [RFC PATCH v2 2/2] staging: iio: ad7192: use iio_device_{claim|release}_direct_mode()

On 12/03/16 11:21, Jonathan Cameron wrote: > On 09/03/16 19:30, Alison Schofield wrote: >> Replace the code that guarantees the device stays in direct mode with >> iio_device_{claim|release}_direct_mode() which does same. >> >> Signed-off-by: Alison Schofield > A small improvement inline - don't e

Re: [RFC PATCH v2 2/2] staging: iio: ad7192: use iio_device_{claim|release}_direct_mode()

On 09/03/16 19:30, Alison Schofield wrote: > Replace the code that guarantees the device stays in direct mode with > iio_device_{claim|release}_direct_mode() which does same. > > Signed-off-by: Alison Schofield A small improvement inline - don't eat the errors within the driver. Jonathan > ---

Re: [RFC PATCH v2 1/2] iio: core: implement iio_device_{claim|release}_direct_mode()

On 09/03/16 19:30, Alison Schofield wrote: > It is often the case that the driver wants to be sure a device stays > in direct mode while it is executing a task or series of tasks. To > accomplish this today, the driver performs this sequence: 1) take the > device state lock, 2) verify it is not in

Re: [RFC PATCH v2 0/2] iio: introduce iio_device_{claim|release}_direct_mode()

On 09/03/16 19:25, Alison Schofield wrote: > This patchset introduces two helper functions to simplify driver code > requiring the device to be locked in direct mode during execution of a > code path. The staging driver ad7192 is updated to demonstrate usage. > > This could be applied to approxima

[PATCH] staging: xgifb: Fix comment style

Fix comments to use * on subsequent lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539bc6faf..c7f02c7db4a2 100644 --- a/driv

[PATCH] Staging: rtl8188eu: removes an unnecessary cast on a void pointer.

Patch to rtl8188e_rxdesc.c to remove an unnecessary cast on a void pointer. Signed-off-by: Ben Marsh --- drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188e

[PATCH] Staging: most: Remove volatile usage

From: PrasannaKumar Muralidharan Remove unnecessary use of volatile for 'request_counter' and 'service_counter' members. Signed-off-by: PrasannaKumar Muralidharan --- drivers/staging/most/hdm-dim2/dim2_hal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH] staging: xgifb: Fix comment style

Fix comments to use trailing */ on separste lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c|3 ++- drivers/staging/xgifb/vb_setmode.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c

[PATCH] Staging: most: Remove atomic_counter_t typedef

From: PrasannaKumar Muralidharan Remove atomic_counter_t typedef, use int instead. Signed-off-by: PrasannaKumar Muralidharan --- drivers/staging/most/hdm-dim2/dim2_hal.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.h b/driver

[PATCH] Staging: most: Remove __cplusplus check in heade files

From: PrasannaKumar Muralidharan Remove unnecessary __cplusplus check in header files as it is not required. Signed-off-by: PrasannaKumar Muralidharan --- drivers/staging/most/hdm-dim2/dim2_errors.h | 8 drivers/staging/most/hdm-dim2/dim2_hal.h| 8 drivers/staging/most/hd